Re: [PATCH v3 0/3] nvram: at24c: fix problems related to "rom-size"

2018-04-08 Thread Wolfram Sang
On Tue, Mar 20, 2018 at 05:18:47PM +0100, Wolfram Sang wrote: > I used this driver as a template for a custom one. While hacking on my own, I > noticed some problems in this driver, too. This series fixes the first set of > them, related to the "rom-size" parameter. It fixes a segfault. > > I

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-08 Thread Wolfram Sang
Eugeniu, > So, the idea is that the startup improvement of rcar_i2c_driver_init() > comes at the cost of a slower cs2000_driver_init(). In the end, > there is no benefit Thank you for the measurements and heads up on this! Much appreciated. The results match my expectations. > If evidence in

[PATCH V5] PCI: rcar: Use runtime PM to control controller clock

2018-04-08 Thread Marek Vasut
From: Dien Pham The controller clock can be switched off during suspend/resume, let runtime PM take care of that. Signed-off-by: Dien Pham Signed-off-by: Hien Dang Signed-off-by: Marek Vasut

[PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Marek Vasut
This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, no functional change. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Phil Edworthy Cc: Simon Horman Cc:

Re: [PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Randy Dunlap
On 04/08/2018 06:09 AM, Marek Vasut wrote: > This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, > no functional change. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Phil Edworthy

[PATCH v2 0/5] Add R8A77980 PCIe support & some driver cleanups

2018-04-08 Thread Sergei Shtylyov
Hello! Here's a set of 5 patches against the 'pci/rcar' branch of Lorenzo Pieralisi's 'pci.git' repo. These are the changes needed for better R-Car gen3 support (namely for R8A77980 support) plus some PCIe driver re-factoring done in the process... [1/5] pcie-rcar: poll PHYRDY in

Re: [PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Randy Dunlap
On 04/08/2018 09:34 AM, Marek Vasut wrote: > On 04/08/2018 05:27 PM, Randy Dunlap wrote: >> On 04/08/2018 06:09 AM, Marek Vasut wrote: >>> This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, >>> no functional change. >>> >>> Signed-off-by: Marek Vasut

Re: [PATCH V3] PCI: rcar: Clean up the macros

2018-04-08 Thread Randy Dunlap
On 04/08/2018 11:04 AM, Marek Vasut wrote: > This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, > no functional change. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven > Cc: Phil Edworthy

Re: [PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Marek Vasut
On 04/08/2018 06:51 PM, Randy Dunlap wrote: > On 04/08/2018 09:34 AM, Marek Vasut wrote: >> On 04/08/2018 05:27 PM, Randy Dunlap wrote: >>> On 04/08/2018 06:09 AM, Marek Vasut wrote: This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, no functional change.

[PATCH v2 2/5] pcie-rcar: remove PHYRDY polling from rcar_pcie_hw_init_h1()

2018-04-08 Thread Sergei Shtylyov
Now that we've added PCIEPHYSR.PHYRDY polling to rcar_pcie_hw_init(), there is no need anymore for polling the PHY specific register in rcar_pcie_hw_init_h1() -- remove it. Signed-off-by: Sergei Shtylyov --- drivers/pci/host/pcie-rcar.c | 12 +---

[PATCH v2 4/5] pcie-rcar: factor out rcar_pcie_hw_init() call

2018-04-08 Thread Sergei Shtylyov
We now have rcar_pcie_hw_init_{h1|gen2|gen3}() differing only in the PCIe PHY init code and all ending with a call to rcar_pcie_hw_init(), thus it makes sense to move that call into the driver's probe() method and then rename those functions to rcar_pcie_phy_init_{h1|gen2|gen3}() -- doing this

Re: [PATCH v5 1/3] ARM: dts: r8a7790: Convert to new LVDS DT bindings

2018-04-08 Thread Niklas Söderlund
Hi Laurent, Thanks for your patch. On 2018-04-06 22:14:36 +0300, Laurent Pinchart wrote: > The internal LVDS encoder now has DT bindings separate from the DU. Port > the device tree over to the new model. > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge > driver") >

[PATCH] media: entity: fix spelling for media_entity_get_fwnode_pad()

2018-04-08 Thread Niklas Söderlund
From: Niklas Söderlund s/dose/does/ Fixes: d295c6a460cd2ac6 ("[media] media: entity: Add media_entity_get_fwnode_pad() function") Signed-off-by: Niklas Söderlund --- include/media/media-entity.h | 2 +- 1 file

Re: [PATCH v5 3/3] ARM: dts: r8a7793: Convert to new LVDS DT bindings

2018-04-08 Thread Niklas Söderlund
Hi Laurent, Thanks for your work. On 2018-04-06 22:14:38 +0300, Laurent Pinchart wrote: > The internal LVDS encoder now has DT bindings separate from the DU. Port > the device tree over to the new model. > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge > driver") >

Re: [PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Marek Vasut
On 04/08/2018 05:27 PM, Randy Dunlap wrote: > On 04/08/2018 06:09 AM, Marek Vasut wrote: >> This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, >> no functional change. >> >> Signed-off-by: Marek Vasut >> Cc: Geert Uytterhoeven

Re: [PATCH v5 2/3] ARM: dts: r8a7791: Convert to new LVDS DT bindings

2018-04-08 Thread Niklas Söderlund
Hi Laurent, Thanks for your patch. On 2018-04-06 22:14:37 +0300, Laurent Pinchart wrote: > The internal LVDS encoder now has DT bindings separate from the DU. Port > the device tree over to the new model. > > Fixes: c6a27fa41fab ("drm: rcar-du: Convert LVDS encoder code to bridge > driver") >

Re: [PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Niklas Söderlund
Hi Marek, Thanks for your work. On 2018-04-08 15:09:42 +0200, Marek Vasut wrote: > This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, > no functional change. > > Signed-off-by: Marek Vasut > Cc: Geert Uytterhoeven >

[PATCH v2 1/5] pcie-rcar: poll PHYRDY in rcar_pcie_hw_init()

2018-04-08 Thread Sergei Shtylyov
In all the R-Car gen1/2/3 manuals, we are instructed to poll PCIEPHYSR for PHYRDY=1 at an early stage of the PCIEC initialization -- while the driver only does this on R-Car H1 (polling a PHY specific register). Add the PHYRDY polling to rcar_pcie_hw_init(). Note that without the special PHY

Re: [PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Randy Dunlap
On 04/08/2018 09:53 AM, Marek Vasut wrote: > On 04/08/2018 06:51 PM, Randy Dunlap wrote: >> On 04/08/2018 09:34 AM, Marek Vasut wrote: >>> On 04/08/2018 05:27 PM, Randy Dunlap wrote: On 04/08/2018 06:09 AM, Marek Vasut wrote: > This patch replaces the (1 << n) with BIT(n) and cleans up

[PATCH V3] PCI: rcar: Clean up the macros

2018-04-08 Thread Marek Vasut
This patch replaces the (1 << n) with BIT(n) and cleans up whitespace, no functional change. Signed-off-by: Marek Vasut Cc: Geert Uytterhoeven Cc: Phil Edworthy Cc: Simon Horman Cc:

[PATCH v2 3/5] pcie-rcar: add R-Car gen3 PHY support

2018-04-08 Thread Sergei Shtylyov
On R-Car gen3 SoCs the PCIe PHY has its own register region -- and I have written a generic PHY driver for it, thus we need to add the corresponding code in rcar_pcie_hw_init_gen3() and call devm_phy_optional_get() at the driver's probing time, so that the existing R-Car gen3 device trees (not

[PATCH v2 5/5] DT: pci: rcar-pci: document R8A77980 bindings

2018-04-08 Thread Sergei Shtylyov
Document the R-Car V3H (R8A77980) SoC in the R-Car PCIe bindings. Signed-off-by: Sergei Shtylyov --- Changes in version 2: - new patch. Documentation/devicetree/bindings/pci/rcar-pci.txt |1 + 1 file changed, 1 insertion(+) Index:

Re: [PATCH V2] PCI: rcar: Clean up the macros

2018-04-08 Thread Marek Vasut
On 04/08/2018 08:03 PM, Randy Dunlap wrote: > On 04/08/2018 09:53 AM, Marek Vasut wrote: >> On 04/08/2018 06:51 PM, Randy Dunlap wrote: >>> On 04/08/2018 09:34 AM, Marek Vasut wrote: On 04/08/2018 05:27 PM, Randy Dunlap wrote: > On 04/08/2018 06:09 AM, Marek Vasut wrote: >> This patch