[git pull] pinctrl: sh-pfc: Updates for v5.4

2019-08-09 Thread Geert Uytterhoeven
Hi Linus, The following changes since commit 5f9e832c137075045d15cd6899ab0505cfb2ca4b: Linus 5.3-rc1 (2019-07-21 14:05:38 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git tags/sh-pfc-for-v5.4-tag1 for you to fet

Re: [PATCH v2] pwm: rcar: remove a redundant condition in rcar_pwm_apply()

2019-08-09 Thread Uwe Kleine-König
On Thu, Aug 08, 2019 at 12:55:40PM +0300, Sergei Shtylyov wrote: > Hello! > > On 08.08.2019 9:38, Yoshihiro Shimoda wrote: > > > Since the rcar_pwm_apply() has already check whehter state->enabled > >Checked? and "whether" Best regards Uwe -- Pengutronix e.K. |

Re: [PATCH] i2c: rcar: avoid race when unregistering slave client

2019-08-09 Thread Adamski, Krzysztof (Nokia - PL/Wroclaw)
On Thu, Aug 08, 2019 at 09:39:10PM +0200, Wolfram Sang wrote: >After we disabled interrupts, there might still be an active one >running. Sync before clearing the pointer to the slave device. > >Reported-by: Krzysztof Adamski >Signed-off-by: Wolfram Sang >--- > >Tested with a Lager board (Renesas

Re: [PATCH RFT] i2c: emev2: avoid race when unregistering slave client

2019-08-09 Thread Adamski, Krzysztof (Nokia - PL/Wroclaw)
On Thu, Aug 08, 2019 at 09:54:17PM +0200, Wolfram Sang wrote: >After we disabled interrupts, there might still be an active one >running. Sync before clearing the pointer to the slave device. > >Fixes: c31d0a00021d ("i2c: emev2: add slave support") >Reported-by: Krzysztof Adamski >Signed-off-by: W

Re: [PATCH RFT] i2c: emev2: avoid race when unregistering slave client

2019-08-09 Thread Wolfram Sang
> I don't see how this could influence the standard I2C communication at > all. If change in em_i2c_unreg_slave() is excluded, all that was changed > is moving irq number from local variable to the em_i2c_device struct > which is also not used outside of the em_i2c_unreg_slave() appart from > logg

[PATCH] of: Fix of_empty_ranges_quirk()

2019-08-09 Thread marek . vasut
From: Marek Vasut The of_empty_ranges_quirk() returns a mix of boolean and signed integer types, which cannot work well. Replace that with boolean only and fix usage logic in of_translate_one() -- the check should trigger when the ranges are NULL and the quirk is applicable on the hardware. Sign

[PATCH 2/2] PCI/of fix of_dma_get_range; get PCI specific dma-ranges

2019-08-09 Thread marek . vasut
From: Oza Pawandeep current device framework and OF framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no imple

[PATCH 1/2] OF/PCI: Export inbound memory interface to PCI RC drivers.

2019-08-09 Thread marek . vasut
From: Oza Pawandeep The patch exports interface to PCIe RC drivers so that, Drivers can get their inbound memory configuration. It provides basis for IOVA reservations for inbound memory holes, if RC is not capable of addressing all the host memory, Specifically when IOMMU is enabled and on ARMv

[PATCH V2 1/3] PCI: rcar: Move the inbound index check

2019-08-09 Thread marek . vasut
From: Marek Vasut Since the $idx variable value is stored across multiple calls to rcar_pcie_inbound_ranges() function, and the $idx value is used to index registers which are written, subsequent calls might cause the $idx value to be high enough to trigger writes into nonexistent registers. Fix

[PATCH V2 2/3] PCI: rcar: Do not abort on too many inbound dma-ranges

2019-08-09 Thread marek . vasut
From: Marek Vasut In case the "dma-ranges" DT property contains either too many ranges or the range start address is unaligned in such a way that populating the range into the controller requires multiple entries, a situation may occur where all ranges cannot be loaded into the controller. Curre

[PATCH V2 3/3] PCI: rcar: Recalculate inbound range alignment for each controller entry

2019-08-09 Thread marek . vasut
From: Marek Vasut Due to hardware constraints, the size of each inbound range entry populated into the controller cannot be larger than the alignment of the entry's start address. Currently, the alignment for each "dma-ranges" inbound range is calculated only once for each range and the increment

Re: [PATCH V2 1/3] PCI: rcar: Move the inbound index check

2019-08-09 Thread Geert Uytterhoeven
Hi Marek, On Fri, Aug 9, 2019 at 7:48 PM wrote: > From: Marek Vasut > > Since the $idx variable value is stored across multiple calls to > rcar_pcie_inbound_ranges() function, and the $idx value is used to > index registers which are written, subsequent calls might cause > the $idx value to be h

[PATCH V3 1/3] PCI: rcar: Move the inbound index check

2019-08-09 Thread marek . vasut
From: Marek Vasut Since the $idx variable value is stored across multiple calls to rcar_pcie_inbound_ranges() function, and the $idx value is used to index registers which are written, subsequent calls might cause the $idx value to be high enough to trigger writes into nonexistent registers. Fix

[PATCH V3 3/3] PCI: rcar: Recalculate inbound range alignment for each controller entry

2019-08-09 Thread marek . vasut
From: Marek Vasut Due to hardware constraints, the size of each inbound range entry populated into the controller cannot be larger than the alignment of the entry's start address. Currently, the alignment for each "dma-ranges" inbound range is calculated only once for each range and the increment

[PATCH V3 2/3] PCI: rcar: Do not abort on too many inbound dma-ranges

2019-08-09 Thread marek . vasut
From: Marek Vasut In case the "dma-ranges" DT property contains either too many ranges or the range start address is unaligned in such a way that populating the range into the controller requires multiple entries, a situation may occur where all ranges cannot be loaded into the controller. Curre

Re: [PATCH v2 2/3] pinctrl: sh-pfc: remove incomplete flag "cfg->type"

2019-08-09 Thread Simon Horman
On Thu, Aug 08, 2019 at 03:19:02PM +0900, Yoshihiro Shimoda wrote: > The old commit c58d9c1b26e3 ("sh-pfc: Implement generic pinconf > support") broke the cfg->type flag to PINMUX_TYPE_FUNCTION because > sh_pfc_pinconf_set() didn't call sh_pfc_reconfig_pin(). > Now if we fix the cfg->type condition

Re: [PATCH v2 1/3] pinctrl: sh-pfc: add new flags into struct sh_pfc_pin_config

2019-08-09 Thread Simon Horman
On Thu, Aug 08, 2019 at 03:19:01PM +0900, Yoshihiro Shimoda wrote: > To clean/modify the code up later, this patch just adds new flags > "mux_set" and "gpio_enabled" into the struct sh_pfc_pin_config. > > Signed-off-by: Yoshihiro Shimoda > Reviewed-by: Geert Uytterhoeven Reviewed-by: Simon Horm

Re: [PATCH v2 3/3] pinctrl: sh-pfc: Rollback to mux if requires when the gpio is freed

2019-08-09 Thread Simon Horman
On Thu, Aug 08, 2019 at 03:19:03PM +0900, Yoshihiro Shimoda wrote: > R-Car PWM controller requires the gpio to output zero duty, > this patch allows to roll it back from gpio to mux when the gpio > is freed. > > Signed-off-by: Yoshihiro Shimoda Reviewed-by: Simon Horman

Re: [PATCH] arm64: dts: renesas: r8a77995: draak: Fix backlight regulator name

2019-08-09 Thread Simon Horman
On Wed, Jul 31, 2019 at 09:37:44AM +0200, Geert Uytterhoeven wrote: > Currently there are two nodes named "regulator1" in the Draak DTS: a > 3.3V regulator for the eMMC and the LVDS decoder, and a 12V regulator > for the backlight. This causes the former to be overwritten by the > latter. > > Fix

Re: [PATCH] of: Fix of_empty_ranges_quirk()

2019-08-09 Thread Simon Horman
On Fri, Aug 09, 2019 at 07:33:21PM +0200, marek.va...@gmail.com wrote: > From: Marek Vasut > > The of_empty_ranges_quirk() returns a mix of boolean and signed integer > types, which cannot work well. Replace that with boolean only and fix > usage logic in of_translate_one() -- the check should tr

Re: [PATCH 1/2] OF/PCI: Export inbound memory interface to PCI RC drivers.

2019-08-09 Thread Simon Horman
On Fri, Aug 09, 2019 at 07:34:48PM +0200, marek.va...@gmail.com wrote: > From: Oza Pawandeep > > The patch exports interface to PCIe RC drivers so that, > Drivers can get their inbound memory configuration. > > It provides basis for IOVA reservations for inbound memory > holes, if RC is not capa

Re: [PATCH 2/2] PCI/of fix of_dma_get_range; get PCI specific dma-ranges

2019-08-09 Thread Simon Horman
On Fri, Aug 09, 2019 at 07:34:49PM +0200, marek.va...@gmail.com wrote: > From: Oza Pawandeep > > current device framework and OF framework integration assumes > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). > > of_dma_

Re: [PATCH 1/2] OF/PCI: Export inbound memory interface to PCI RC drivers.

2019-08-09 Thread Marek Vasut
On 8/9/19 10:56 PM, Simon Horman wrote: > On Fri, Aug 09, 2019 at 07:34:48PM +0200, marek.va...@gmail.com wrote: >> From: Oza Pawandeep >> >> The patch exports interface to PCIe RC drivers so that, >> Drivers can get their inbound memory configuration. >> >> It provides basis for IOVA reservations

[PATCH v2 3/4] dt-bindings: i2c: riic: Rename bindings documentation file

2019-08-09 Thread Simon Horman
Rename the bindings documentation file for RIIC controller from i2c-riic.txt to renesas,riic.txt. This is part of an ongoing effort to name bindings documentation files for Renesas IP blocks consistently, in line with the compat strings they document. Cc: Chris Brandt Signed-off-by: Simon Horman

[PATCH v2 2/4] dt-bindings: i2c: rcar: Rename bindings documentation file

2019-08-09 Thread Simon Horman
Rename the bindings documentation file for R-Car I2C controller from i2c-rcar.txt to renesas,i2c.txt. This is part of an ongoing effort to name bindings documentation files for Renesas IP blocks consistently, in line with the compat strings they document. Signed-off-by: Simon Horman Reviewed-by:

[PATCH v2 4/4] dt-bindings: i2c: i2c-emev2: Rename bindings documentation file

2019-08-09 Thread Simon Horman
Rename the bindings documentation file for Renesas EMEV2 IIC controller from i2c-emev2.txt to renesas,iic-emev2.txt. This is part of an ongoing effort to name bindings documentation files for Renesas IP blocks consistently, in line with the compat strings they document. Signed-off-by: Simon Horma

[PATCH v2 0/4] dt-bindings: i2c: renesas: Rename bindings documentation files

2019-08-09 Thread Simon Horman
Rename the bindings documentation file for Renesas I2C controllers. This is part of an ongoing effort to name bindings documentation files for Renesas IP blocks consistently, in line with the compat strings they document. Based on v5.3-rc1 Changes since v1 * Accumulate review tags * Correct chan

[PATCH v2 1/4] dt-bindings: i2c: sh_mobile: Rename bindings documentation file

2019-08-09 Thread Simon Horman
Rename the bindings documentation file for sh_mobile I2C controller from i2c-sh_mobile.txt to renesas,iic.txt. This is part of an ongoing effort to name bindings documentation files for Renesas IP blocks consistently, in line with the compat strings they document. Signed-off-by: Simon Horman Rev

[PATCH] dt-bindings: ata: sata_rcar: Rename bindings documentation file

2019-08-09 Thread Simon Horman
Rename the bindings documentation file for Renesas SATA controller from sata_rcar.txt to renesas,rcar-sata.txt This is part of an ongoing effort to name bindings documentation files for Renesas IP blocks consistently, in line with the compat strings they document. Signed-off-by: Simon Horman ---

Re: [PATCH] of: Fix of_empty_ranges_quirk()

2019-08-09 Thread Rob Herring
On Fri, Aug 9, 2019 at 11:33 AM wrote: > > From: Marek Vasut > > The of_empty_ranges_quirk() returns a mix of boolean and signed integer > types, which cannot work well. It never returns a negative. The negative is used as an uninitialized flag. Note quirk_state is static. > Replace that with b