Re: [PATCH] pinctrl: sh-pfc: Print correct pinmux info name

2017-03-19 Thread Eugeniu Rosca
On Sun, Mar 19, 2017 at 03:02:48PM +0100, Geert Uytterhoeven wrote: Hi Geert, > Thanks for your patch! > But next time, please send it inline, for easier commenting. Thanks! Will do that next time. > From a code maintenance point of view, I think it's safer to update the info > pointer itself,

Re: [v3,15/20] drm: bridge: dw-hdmi: Handle overflow workaround based on device version

2017-08-20 Thread Eugeniu Rosca
Hello Laurent, Jose, As you might know, Renesas uses the same Synopsis Designware HDMI transmitter IP in the Rcar Gen3 SoCs. There are v4.9+ patches present in [1] to enable support for this. Why I reply in this specific thread is because I am having a trial attempt to rebase the RCAR-specific

Re: [PATCH] ravb: Fix use-after-free on `ifconfig eth0 down`

2017-06-06 Thread Eugeniu Rosca
On Tue, Jun 06, 2017 at 12:35:30PM +0300, Sergei Shtylyov wrote: > Hello! > > On 6/6/2017 1:08 AM, Eugeniu Rosca wrote: > > >Commit a47b70ea86bd ("ravb: unmap descriptors when freeing rings") has > >introduced the issue seen in [1] reproduced on H3ULCB board. &g

[PATCH] ravb: Fix use-after-free on `ifconfig eth0 down`

2017-06-05 Thread Eugeniu Rosca
f ff ff ff ff == Disabling lock debugging due to kernel taint root@salvator-x:~# Fixes: a47b70ea86bd ("ravb: unmap descriptors when freeing rings") Signed-off-by: Eugeniu Rosca <ero...@de.adit-jv.com> --- drivers/net/ethernet/renesas/ravb_main.c | 24 ---

[PATCH] v4l: vsp1: Fix function declaration/definition mismatch

2017-08-20 Thread Eugeniu Rosca
From: Eugeniu Rosca <ero...@de.adit-jv.com> Cppcheck v1.81 complains that the parameter names of certain vsp1 functions don't match between declaration and definition. Fix this. No functional change is confirmed by the empty delta between the disassembled object files before and after the

Re: [PATCH] v4l: vsp1: Fix function declaration/definition mismatch

2017-12-04 Thread Eugeniu Rosca
Hello Laurent, Kieran, On Mon, Dec 04, 2017 at 12:52:17PM +0200, Laurent Pinchart wrote: > Hello, > > On Friday, 24 November 2017 20:40:57 EET Kieran Bingham wrote: > > Hi Eugeniu, > > > > Thankyou for the patch, > > > > Laurent - Any comments on this? Otherwise I'll bundle this in with my > >

[PATCH 04/14] arm64: dts: renesas: r8a7795-es1: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,h3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795-es1-ulcb-kf.dts | 2 +- 1 file

[PATCH 05/14] arm64: dts: renesas: r8a7795: ulcb: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,h3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795-ulcb.dts | 2 +- 1 file change

[PATCH 03/14] arm64: dts: renesas: r8a7795-es1: ulcb: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,h3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795-es1-ulcb.dts | 2 +- 1 file change

[PATCH 06/14] arm64: dts: renesas: r8a7795: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,h3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7795-ulcb-kf.dts | 2 +- 1 file change

[PATCH 00/14] Add minimal DTS support for M3-N Starter Kit

2018-08-04 Thread Eugeniu Rosca
uot;-ulcb*.dts" - to "-ulcb*.dts" These patches have been tested on M3-N ULCB using v4.18-rc7 kernel. Any comments would be greatly appreciated. Best regards, Eugeniu. Eugeniu Rosca (14): arm64: dts: renesas: Cut redundant in *-ulcb*.dts dt-bindings: arm: don't embed SoC

[PATCH 08/14] arm64: dts: renesas: r8a7796: ulcb-kf: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,m3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7796-ulcb-kf.dts | 2 +- 1 file change

[PATCH 12/14] arm64: dts: renesas: r8a77965: add CAN support

2018-08-04 Thread Eugeniu Rosca
48e810f ("arm64: dts: r8a7796: Add reset control properties") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 32 1 file changed, 32 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/d

[PATCH 07/14] arm64: dts: renesas: r8a7796: ulcb: Use "renesas,ulcb" compatible

2018-08-04 Thread Eugeniu Rosca
Following the recent change in dt-bindings [1], switch from "renesas,m3ulcb" to "renesas,ulcb" compatible string. [1] Documentation/devicetree/bindings/arm/shmobile.txt Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a7796-ulcb.dts | 2 +- 1 file change

[PATCH 10/14] arm64: dts: renesas: r8a77965: ulcb: Initial device tree

2018-08-04 Thread Eugeniu Rosca
Allow the bare M3-N-based ULCB board to boot. Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/Makefile | 1 + arch/arm64/boot/dts/renesas/r8a77965-ulcb.dts | 37 + 2 files changed, 38 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH 13/14] arm64: dts: renesas: r8a77965: Add HSCIF0 device node

2018-08-04 Thread Eugeniu Rosca
quot;arm64: dts: r8a7796: Enable HSCIF DMA") - commit bec0948e810f ("arm64: dts: r8a7796: Add reset control properties") Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/r8a77965.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boo

[PATCH 14/14] arm64: dts: renesas: r8a77965: ulcb-kf: Initial device tree

2018-08-04 Thread Eugeniu Rosca
Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/Makefile | 1 + arch/arm64/boot/dts/renesas/r8a77965-ulcb-kf.dts | 20 2 files changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile index

[PATCH 11/14] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-04 Thread Eugeniu Rosca
After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, checkpatch complained that the new compatible string "renesas,can-r8a77965" is not documented. Fix the warning. Signed-off-by: Eugeniu Rosca --- Documentation/devicetree/bindings/net/can/rcar_can.txt | 10 +++-

[PATCH 01/14] arm64: dts: renesas: Cut redundant in *-ulcb*.dts

2018-08-04 Thread Eugeniu Rosca
796_ulcb_defconfig DTB md5 sums match with and w/o the patch (hence no functional change). Signed-off-by: Eugeniu Rosca --- arch/arm64/boot/dts/renesas/Makefile | 12 ++-- arch/arm64/boot/dts/renesas/{r8a7795-es1-h3ulcb-kf.dts => r8a

[PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-04 Thread Eugeniu Rosca
renesas,r8a7796" and "renesas,r8a77965" compatibles. Prior to adding M3-N Starter Kit to the list, rename: - "renesas,h3ulcb" => "renesas,ulcb" - "renesas,m3ulcb" => "renesas,ulcb" Relevant DTS changes come in separate per-DTS commits. Signed-of

[PATCH 09/14] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

2018-08-04 Thread Eugeniu Rosca
-* CPU: Renesas Electronics R8A77965 rev 1.1 ---8< DRAM: 1.9 GiB Bank #0: 0x04800 - 0x0bfff, 1.9 GiB ---8< Signed-off-by: Eugeniu Rosca --- Documentation/devicetree/bindings/arm/shmobile.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documen

Re: [PATCH 09/14] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

2018-08-05 Thread Eugeniu Rosca
Hi Jacopo, Thanks for your comments. Please, find my replies below. On Sun, Aug 05, 2018 at 10:15:43AM +0200, jacopo mondi wrote: > Helle Eugeniu, > > On Sun, Aug 05, 2018 at 01:11:09AM +0200, Eugeniu Rosca wrote: > > In harmony with ATF and U-Boot outputs [1] and [2]

Re: [PATCH 14/14] arm64: dts: renesas: r8a77965: ulcb-kf: Initial device tree

2018-08-05 Thread Eugeniu Rosca
Hi Jacopo, On Sun, Aug 05, 2018 at 11:01:36AM +0200, jacopo mondi wrote: > Hi Eugeniu, > > On Sun, Aug 05, 2018 at 01:11:14AM +0200, Eugeniu Rosca wrote: > > Signed-off-by: Eugeniu Rosca > > --- > > arch/arm64/boot/dts/renesas/Makefile | 1 + >

Re: [PATCH 13/14] arm64: dts: renesas: r8a77965: Add HSCIF0 device node

2018-08-05 Thread Eugeniu Rosca
Hello Simon, Geert, Takeshi, On Sun, Aug 05, 2018 at 01:11:13AM +0200, Eugeniu Rosca wrote: > Add hscif0 node to avoid below r8a77965-ulcb-kf.dtb build failure: > Error: arch/arm64/boot/dts/renesas/ulcb-kf.dtsi:36.1-8 Label or path hscif0 > not found > > Inspired from v4

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-08 Thread Eugeniu Rosca
Hello Geert, Laurent, Morimoto-san, On Tue, Aug 07, 2018 at 10:30:14AM +0200, Geert Uytterhoeven wrote: > Hi Laurent, > > On Tue, Aug 7, 2018 at 10:21 AM Laurent Pinchart > wrote: > > On Tuesday, 7 August 2018 11:18:11 EEST Kuninori Morimoto wrote: > > > > Yeah, it is true "so far". I think

Re: [PATCH 11/14] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-06 Thread Eugeniu Rosca
Hi Kieran, On Mon, Aug 06, 2018 at 11:56:56AM +0100, Kieran Bingham wrote: > Hi Eugeniu > > On 05/08/18 00:11, Eugeniu Rosca wrote: > > After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, > > checkpatch complained that the new compatible string >

Re: [PATCH 12/14] arm64: dts: renesas: r8a77965: add CAN support

2018-08-06 Thread Eugeniu Rosca
Hi Geert, On Mon, Aug 06, 2018 at 05:15:37PM +0200, Geert Uytterhoeven wrote: > Hi Eugeniu, > > On Sun, Aug 5, 2018 at 1:14 AM Eugeniu Rosca wrote: > > According to R-Car Gen3 HW manual rev0.55E, R-Car M3-N has two CAN > > interfaces, similar to H3, M3-W and other SoCs

Re: [PATCH 12/14] arm64: dts: renesas: r8a77965: add CAN support

2018-08-06 Thread Eugeniu Rosca
Hi Kieran, On Mon, Aug 06, 2018 at 12:11:22PM +0100, Kieran Bingham wrote: > Hi Eugeniu, > > On 05/08/18 00:11, Eugeniu Rosca wrote: > > According to R-Car Gen3 HW manual rev0.55E, R-Car M3-N has two CAN > > rev 0.55E sounds like rather an old version of this document.

Re: [PATCH 11/14] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-06 Thread Eugeniu Rosca
Hi Sergei, On Mon, Aug 06, 2018 at 06:21:09PM +0300, Sergei Shtylyov wrote: > Hello! > > On 08/05/2018 02:11 AM, Eugeniu Rosca wrote: > > > After adding CAN support to arch/arm64/boot/dts/renesas/r8a77965.dtsi, > > checkpatch complained that the new compatible string &

Re: [PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-17 Thread Eugeniu Rosca
Hi Simon, On Fri, Aug 17, 2018 at 11:04:03AM +0200, Simon Horman wrote: > On Sun, Aug 12, 2018 at 03:31:44PM +0200, Eugeniu Rosca wrote: > > Document the support for rcar_can on R8A77965 SoC devices. > > Add R8A77965 to the list of SoCs which require the "assigned-clocks"

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-06 Thread Eugeniu Rosca
Hi Morimoto-san, Thank you for your comments. On Mon, Aug 06, 2018 at 12:33:34AM +, Kuninori Morimoto wrote: > Hi Eugeniu > > > In the context of M3N-ULCB (RTP0RC77965SKBX010SA00) board bring-up, it's > > rather pointless to add a new "renesas,m3nulcb" compatible string. Any > > SoC-level

Re: [PATCH 02/14] dt-bindings: arm: don't embed SoC name into the ULCB boards' compatible

2018-08-07 Thread Eugeniu Rosca
On Sun, Aug 05, 2018 at 01:11:02AM +0200, Eugeniu Rosca wrote: > diff --git a/Documentation/devicetree/bindings/arm/shmobile.txt > b/Documentation/devicetree/bindings/arm/shmobile.txt > index d8cf740132c6..f391dba10574 100644 > --- a/Documentation/devicetree/bindings/arm/shmobile

[PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-12 Thread Eugeniu Rosca
9c16252415 ("arm64: dts: r8a7796: Add CAN support") - v4.12 commit bec0948e810f ("arm64: dts: r8a7796: Add reset control properties") Signed-off-by: Eugeniu Rosca --- Changes in v2: - [Kieran Bingham] Improved commit description: - Referenced the newer HW manual rev1.00

[PATCH v2 4/7] arm64: dts: renesas: r8a77965: m3nulcb: Initial device tree

2018-08-12 Thread Eugeniu Rosca
Allow the bare M3-N-based ULCB board to boot. Signed-off-by: Eugeniu Rosca Reviewed-by: Jacopo Mondi --- Changes in v2: - [Jacopo Mondi] Removed redundant license text. Added Reviewed-by. - [Simon Horman] - Renamed DTS 's/r8a77965-ulcb.dts/r8a77965-m3nulcb.dts/' - Renamed board name 's

[PATCH v2 3/7] pinctrl: sh-pfc: r8a77965: Add HSCIF0 pins, groups, and functions

2018-08-12 Thread Eugeniu Rosca
rict` throws several "CHECK: Please use a blank line after function/struct/union/enum declarations", which are ignored for the sake of staying in sync with the aforementioned commits. Signed-off-by: Eugeniu Rosca --- Changes in v2: - Newly added. - IMHO mirroring the mentioned H3 and

[PATCH v2 1/7] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

2018-08-12 Thread Eugeniu Rosca
1.1 ---8< DRAM: 1.9 GiB Bank #0: 0x04800 - 0x0bfff, 1.9 GiB ---8< [3] https://patchwork.kernel.org/patch/10555957/#22169325 Signed-off-by: Eugeniu Rosca --- Changes in v2: - [Jacopo Mondi] Emphasized the fact the amount of RAM is encoded in the board

[PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-12 Thread Eugeniu Rosca
Document the support for rcar_can on R8A77965 SoC devices. Add R8A77965 to the list of SoCs which require the "assigned-clocks" and "assigned-clock-rates" properties (thanks, Sergei). Rewrap text. Signed-off-by: Eugeniu Rosca --- Changes in v2: - [Kieran Bingham] Simplifie

[PATCH v2 7/7] arm64: dts: renesas: r8a77965: m3nulcb-kf: Initial device tree

2018-08-12 Thread Eugeniu Rosca
This is based on the existing KF device tree sources: $ ls -1 arch/arm64/boot/dts/renesas/*-kf.dts arch/arm64/boot/dts/renesas/r8a7795-es1-h3ulcb-kf.dts arch/arm64/boot/dts/renesas/r8a7795-h3ulcb-kf.dts arch/arm64/boot/dts/renesas/r8a7796-m3ulcb-kf.dts Signed-off-by: Eugeniu Rosca --- Changes

[PATCH v2 6/7] arm64: dts: renesas: r8a77965: Add HSCIF0 device node

2018-08-12 Thread Eugeniu Rosca
HSCIF nodes") - commit 6d50bb893504 ("arm64: dts: r8a7796: Enable HSCIF DMA") - commit bec0948e810f ("arm64: dts: r8a7796: Add reset control properties") Signed-off-by: Eugeniu Rosca --- Changes in v2: - Slightly improved the commit description. - Note that this commit

Re: [PATCH 01/14] arm64: dts: renesas: Cut redundant in *-ulcb*.dts

2018-08-10 Thread Eugeniu Rosca
Hi Simon, Laurent, On Fri, Aug 10, 2018 at 01:22:49PM +0200, Simon Horman wrote: > On Mon, Aug 06, 2018 at 01:35:08PM +0300, Laurent Pinchart wrote: [snip] > > The naming convention is roughly -.dts. For instance, in > > r8a7795- > > h3ulcb.dts, the SoC is R8A7795 and the board "H3 ULCB". With

Re: [PATCH 09/14] dt-bindings: arm: Document Renesas R-Car M3-N-based ULCB board

2018-08-10 Thread Eugeniu Rosca
Hi again Jacopo, On Mon, Aug 06, 2018 at 12:40:02AM +0200, Eugeniu Rosca wrote: > Hi Jacopo, > > Thanks for your comments. Please, find my replies below. > > On Sun, Aug 05, 2018 at 10:15:43AM +0200, jacopo mondi wrote: > > Helle Eugeniu, > > > > On Sun,

Re: [PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-17 Thread Eugeniu Rosca
Hello Kieran, On Fri, Aug 17, 2018 at 02:44:25PM +0100, Kieran Bingham wrote: > Hi Eugeniu > > Thank you for the patch. > > On 12/08/18 14:31, Eugeniu Rosca wrote: > > Document the support for rcar_can on R8A77965 SoC devices. > > Add R8A77965 to the list of SoCs

Re: [PATCH v2 2/7] dt-bindings: can: rcar_can: document r8a77965 can support

2018-08-17 Thread Eugeniu Rosca
Hi Kieran, On Fri, Aug 17, 2018 at 05:10:06PM +0100, Kieran Bingham wrote: > Hi Eugeniu, > > On 17/08/18 16:56, Eugeniu Rosca wrote: > > Hello Kieran, > > > > On Fri, Aug 17, 2018 at 02:44:25PM +0100, Kieran Bingham wrote: > >> Hi Eugeniu > >> > &

Re: [PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-23 Thread Eugeniu Rosca
ts. > > >>> Fix them beforehand. > > >>> > > >>> CAN support is inspired from below commits: > > >>> - v4.7 commit 308b7e4ba62e ("arm64: dts: r8a7795: Add CAN support") > > >>> - v4.11 commit 909c16252415 ("arm64: dts:

Re: [PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-27 Thread Eugeniu Rosca
Hi Simon, hi Geert, On Mon, Aug 27, 2018 at 02:44:47PM +0200, Simon Horman wrote: > On Thu, Aug 23, 2018 at 10:52:09AM +0200, Geert Uytterhoeven wrote: > > On Fri, Aug 17, 2018 at 3:53 PM Kieran Bingham > > wrote: > > > On 12/08/18 14:31, Eugeniu Rosca wrote: > >

Re: [PATCH v2 5/7] arm64: dts: renesas: r8a77965: Add CAN{0,1} placeholder nodes

2018-08-27 Thread Eugeniu Rosca
Hi Kieran, I appreciate the detailed reply zooming in into many aspects (both technical and related to process/workflow) of contributing/reviewing patches. I take it as is. I could elaborate on specific parts of it, like applying the "undefined behavior" term (which comes from the world of

Re: [PATCH v2 6/7] arm64: dts: renesas: r8a77965: Add HSCIF0 device node

2018-08-27 Thread Eugeniu Rosca
Hi Simon, On Wed, Aug 22, 2018 at 01:12:47PM +0200, Simon Horman wrote: > On Sun, Aug 12, 2018 at 03:31:48PM +0200, Eugeniu Rosca wrote: > > Fix below DTC error: > > Error: arch/arm64/boot/dts/renesas/ulcb-kf.dtsi:36.1-8 Label or path hscif0 > > not found > > >

Re: [PATCH v2 3/7] pinctrl: sh-pfc: r8a77965: Add HSCIF0 pins, groups, and functions

2018-08-27 Thread Eugeniu Rosca
Hi Geert, On Mon, Aug 27, 2018 at 05:07:39PM +0200, Geert Uytterhoeven wrote: > Hi Eugeniu, > > On Sun, Aug 12, 2018 at 3:33 PM Eugeniu Rosca wrote: > > According to R-Car Gen3 HW manual Rev.1.00 Apr 2018, M3-N SoC implements > > five (0..4) HSCIF channels, simil

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-04 Thread Eugeniu Rosca
Hello Wolfram, Vladimir, Thanks for your precious inputs. I think you outlined two topics in your comments (based on the description submitted with the patch). One (primary?) is related to async probing and one (secondary, but still interesting) is related to the minor (~7ms -> ~1ms) startup

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-04 Thread Eugeniu Rosca
[re-sending due to lost To: field] Hello Wolfram, Vladimir, Thanks for your precious inputs. I think you outlined two topics in your comments (based on the description submitted with the patch). One (primary?) is related to async probing and one (secondary, but still interesting) is related to

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-03-28 Thread Eugeniu Rosca
reviewing and submitting the patch. Best regards, Eugeniu. On Fri, Mar 16, 2018 at 12:58:52PM +0200, Vladimir Zapolskiy wrote: > From: Eugeniu Rosca <ero...@de.adit-jv.com> > > The purpose of this patch looks pretty similar to: > 104522806a7d ("i2c: designware: dw_i2c_init_driver as

Re: [PATCH 1/2] i2c: rcar: refactor private flags

2018-10-08 Thread Eugeniu Rosca
Hi Wolfram, On Fri, Oct 05, 2018 at 06:27:28PM +0200, Wolfram Sang wrote: > > > May I ask how exactly you spotted the "shift-31-problem" in > > drivers/i2c/busses/i2c-rcar.c: > > - visual code review? > > - static analysis, special compiler flags? > > This one. I run a set of static code

Re: [PATCH 1/2] i2c: rcar: refactor private flags

2018-10-04 Thread Eugeniu Rosca
Hi Wolfram, > On August 8, 2018 at 9:59 AM Wolfram Sang > wrote: > > Use BIT macro to avoid shift-31-problem, May I ask how exactly you spotted the "shift-31-problem" in drivers/i2c/busses/i2c-rcar.c: - visual code review? - static analysis, special compiler flags? - run-time testing with