Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-19 Thread Frank Rowand
On 07/19/17 09:02, Rob Herring wrote: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: >> On 07/18/2017 11:43 PM, Rob Herring wrote: >>> Now that we have a custom printf format specifier, convert users of >>> full_name to use %pOF instead. This is preparation

Re: [PATCH 0/2] of: overlay: Crash fix and improvement

2017-12-08 Thread Frank Rowand
to Rob's for-next > branch only. Overlay FDT files should not have invalid contents. But they inevitably will, so the code has to handle those cases. Thanks for finding this problem and making the code better! For the full series: Reviewed-by: Frank Rowand <frank.row...@sony.com> &

Re: [PATCH 0/2] of: overlay: Crash fix and improvement

2017-12-11 Thread Frank Rowand
On 12/09/17 01:04, Geert Uytterhoeven wrote: > Hi Frank, > > On Sat, Dec 9, 2017 at 7:01 AM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 12/08/17 05:13, Geert Uytterhoeven wrote: >>> This patch series fixes memory corruption when applying overlays. >&

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Frank Rowand
On 01/15/18 09:09, Rob Herring wrote: > +Frank > > On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart > wrote: >> The internal LVDS encoders now have their own DT bindings. Before >> switching the driver infrastructure to those new bindings, implement >>

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Frank Rowand
On 01/15/18 11:22, Laurent Pinchart wrote: > Hi Frank, > > On Monday, 15 January 2018 21:12:44 EET Frank Rowand wrote: >> On 01/15/18 09:09, Rob Herring wrote: >>> +Frank >>> >>> On Fri, Jan 12, 2018 at 5:14 PM, Laurent Pinchart wrote: >>>

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Frank Rowand
On 01/15/18 12:29, Laurent Pinchart wrote: > Hi Frank, > > On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: >> On 01/15/18 11:22, Laurent Pinchart wrote: >>> On Monday, 15 January 2018 21:12:44 EET Frank Rowand wrote: >>>> On 01/15/18 09

Re: [PATCH v2 03/12] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-01-15 Thread Frank Rowand
On 01/15/18 15:46, Frank Rowand wrote: > On 01/15/18 12:29, Laurent Pinchart wrote: >> Hi Frank, >> >> On Monday, 15 January 2018 22:12:33 EET Frank Rowand wrote: >>> On 01/15/18 11:22, Laurent Pinchart wrote: >>>> On Monday, 15 January 2018 21:12:44 EET F

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-22 Thread Frank Rowand
On 01/21/18 06:31, Wolfram Sang wrote: > I got a bug report for a DT node refcounting problem in the I2C subsystem. > This > patch was a huge help in validating the bug report and the proposed solution. > So, I thought I bring it to attention again. Thanks Tyrel, for the initial > work! > > Note

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

2018-01-25 Thread Frank Rowand
On 01/21/18 06:31, Wolfram Sang wrote: > From: Tyrel Datwyler > > This patch introduces event tracepoints for tracking a device_nodes > reference cycle as well as reconfig notifications generated in response > to node/property manipulations. > > With the recent

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-24 Thread Frank Rowand
On 01/21/18 06:31, Wolfram Sang wrote: > I got a bug report for a DT node refcounting problem in the I2C subsystem. > This > patch was a huge help in validating the bug report and the proposed solution. > So, I thought I bring it to attention again. Thanks Tyrel, for the initial > work! > > Note

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

2018-01-24 Thread Frank Rowand
On 01/21/18 06:31, Wolfram Sang wrote: > From: Tyrel Datwyler > > This patch introduces event tracepoints for tracking a device_nodes > reference cycle as well as reconfig notifications generated in response > to node/property manipulations. > > With the recent

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

2018-01-24 Thread Frank Rowand
On 01/24/18 22:48, Frank Rowand wrote: > On 01/21/18 06:31, Wolfram Sang wrote: >> From: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> >> >> This patch introduces event tracepoints for tracking a device_nodes >> reference cycle as well as reconfig notifications

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

2018-01-25 Thread Frank Rowand
On 01/25/18 00:01, Geert Uytterhoeven wrote: > Hi Frank, > > On Thu, Jan 25, 2018 at 7:48 AM, Frank Rowand <frowand.l...@gmail.com> wrote: >>> create mode 100644 include/trace/events/of.h >> >> mode looks incorrect. Existing files in include/trace/events/ are

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-24 Thread Frank Rowand
Hi Steve, On 01/21/18 06:31, Wolfram Sang wrote: > I got a bug report for a DT node refcounting problem in the I2C subsystem. > This > patch was a huge help in validating the bug report and the proposed solution. > So, I thought I bring it to attention again. Thanks Tyrel, for the initial >

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-25 Thread Frank Rowand
Hi Wolfram, On 01/25/18 03:03, Steven Rostedt wrote: > On Wed, 24 Jan 2018 22:55:13 -0800 > Frank Rowand <frowand.l...@gmail.com> wrote: > >> Hi Steve, > >> >> Off the top of your head, can you tell me know early in the boot >> process a trace_ev

Re: [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle

2018-01-25 Thread Frank Rowand
On 01/25/18 14:40, Tyrel Datwyler wrote: > On 01/24/2018 10:48 PM, Frank Rowand wrote: >> On 01/21/18 06:31, Wolfram Sang wrote: >>> From: Tyrel Datwyler <tyr...@linux.vnet.ibm.com> >>> >>> This patch introduces event tracepoints for tracking a device_nod

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-25 Thread Frank Rowand
On 01/25/18 15:12, Wolfram Sang wrote: > Frank, > > here seems to be a misunderstanding going on. I don't want to push this > patch upstream against all odds. I merely wanted to find out what the > status of this patch is. Because one possibility was that it had just > been forgotten... > >>>

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-25 Thread Frank Rowand
On 01/25/18 15:14, Wolfram Sang wrote: > >> This means that ftrace can not be used for the of_node_get(), >> of_node_put(), and of_node_release() debug info, because >> these functions are called before early_initcall(). > > For the record: You can still unbind/bind devices. This is how I >

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-25 Thread Frank Rowand
On 01/25/18 15:53, Tyrel Datwyler wrote: > On 01/25/2018 01:49 PM, Frank Rowand wrote: >> Hi Wolfram, >> >> On 01/25/18 03:03, Steven Rostedt wrote: >>> On Wed, 24 Jan 2018 22:55:13 -0800 >>> Frank Rowand <frowand.l...@gmail.com> wrote: >>>

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-02-21 Thread Frank Rowand
On 02/20/18 15:10, Laurent Pinchart wrote: > Hello, > > This patch series addresses a design mistake that dates back from the initial > DU support. Support for the LVDS encoders, which are IP cores separate from > the DU, was bundled in the DU driver. Worse, both the DU and LVDS were > described

Re: [PATCH v6 0/4] R-Car DU: Convert LVDS code to bridge driver

2018-02-22 Thread Frank Rowand
On 02/22/18 05:13, Laurent Pinchart wrote: > Hello, > > This patch series addresses a design mistake that dates back from the initial > DU support. Support for the LVDS encoders, which are IP cores separate from > the DU, was bundled in the DU driver. Worse, both the DU and LVDS were > described

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-24 Thread Frank Rowand
On 02/23/18 11:56, Laurent Pinchart wrote: > Hi Frank, > > On Friday, 23 February 2018 21:43:17 EET Frank Rowand wrote: >> On 02/23/18 01:00, Laurent Pinchart wrote: >>> On Friday, 23 February 2018 04:38:06 EET Frank Rowand wrote: >>>> On 02/22/18 14:10, Frank

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-24 Thread Frank Rowand
On 02/22/18 14:10, Frank Rowand wrote: > Hi Laurent, Rob, > > Thanks for the prompt spin to address my concerns. There are some small > technical issues. > > I did not read the v3 patch until today. v3 through v6 are still using the > old overlay apply method which uses an

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-22 Thread Frank Rowand
Hi Laurent, Rob, Thanks for the prompt spin to address my concerns. There are some small technical issues. I did not read the v3 patch until today. v3 through v6 are still using the old overlay apply method which uses an expanded device tree as input. Rob, I don't see my overlay patches in

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-22 Thread Frank Rowand
On 02/22/18 14:10, Frank Rowand wrote: > Hi Laurent, Rob, > > Thanks for the prompt spin to address my concerns. There are some small > technical issues. > > I did not read the v3 patch until today. v3 through v6 are still using the > old overlay apply method which uses an

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-02-22 Thread Frank Rowand
Hi Laurent, On 02/22/18 02:25, Laurent Pinchart wrote: > Hi Frank, > > On Thursday, 22 February 2018 08:07:14 EET Frank Rowand wrote: >> On 02/20/18 15:10, Laurent Pinchart wrote: >>> Hello, >>> >>> This patch series addresses a design mistake that

Re: [PATCH v4 00/16] R-Car DU: Convert LVDS code to bridge driver

2018-02-23 Thread Frank Rowand
On 02/23/18 01:25, Laurent Pinchart wrote: > Hi Frank, > > On Friday, 23 February 2018 05:20:43 EET Frank Rowand wrote: >> On 02/22/18 02:25, Laurent Pinchart wrote: >>> On Thursday, 22 February 2018 08:07:14 EET Frank Rowand wrote: >>>> On 02/20/18 15:10,

Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-02-23 Thread Frank Rowand
On 02/23/18 01:00, Laurent Pinchart wrote: > Hi Frank, > > On Friday, 23 February 2018 04:38:06 EET Frank Rowand wrote: >> On 02/22/18 14:10, Frank Rowand wrote: >>> Hi Laurent, Rob, >>> >>> Thanks for the prompt spin to address my concerns. There are

Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues

2018-01-23 Thread Frank Rowand
On 01/23/18 04:11, Michael Ellerman wrote: > Wolfram Sang writes: > >> Hi Frank, >> >>> Please go back and read the thread for version 1. Simply resubmitting a >>> forward port is ignoring that whole conversation. >>> >>> There is a lot of good info in that thread. I

Re: Overlay sugar syntax (was: Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes)

2018-03-06 Thread Frank Rowand
On 03/06/18 04:30, Geert Uytterhoeven wrote: > Hi David, > > On Tue, Mar 6, 2018 at 4:54 AM, David Gibson > <da...@gibson.dropbear.id.au> wrote: >> On Fri, Feb 23, 2018 at 09:05:24AM +0100, Geert Uytterhoeven wrote: >>> On Fri, Feb 23, 2018 at 3:38 AM, Fra

Re: Overlay sugar syntax (was: Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes)

2018-03-06 Thread Frank Rowand
On 03/06/18 11:51, Frank Rowand wrote: > On 03/06/18 04:30, Geert Uytterhoeven wrote: >> Hi David, >> >> On Tue, Mar 6, 2018 at 4:54 AM, David Gibson >> <da...@gibson.dropbear.id.au> wrote: >>> On Fri, Feb 23, 2018 at 09:05:24AM +0100, Geert Uytterhoeven w

Re: Overlay sugar syntax (was: Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes)

2018-03-06 Thread Frank Rowand
On 03/06/18 18:30, David Gibson wrote: > On Tue, Mar 06, 2018 at 01:40:20PM -0800, Frank Rowand wrote: >> On 03/06/18 11:51, Frank Rowand wrote: >>> On 03/06/18 04:30, Geert Uytterhoeven wrote: < snip > >>> And the patched dtc works for a dts file that I was t

Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build

2018-03-23 Thread Frank Rowand
Hi Geert, On 03/22/18 07:26, Geert Uytterhoeven wrote: > Hi Frank, > > On Fri, Mar 16, 2018 at 2:39 AM, wrote: >> On Thursday, March 15, 2018 8:37 AM, Arnd Bergmann [mailto:a...@arndb.de] >> wrote: >>> >>> The *.dtb and *.dtb.S files get removed by 'make' during the

Re: [PATCH v7 3/4 - variant 2] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-03-01 Thread Frank Rowand
s_id; > + > + for (i = 0; dtbs[i].compatible; ++i) { > + if (!strcmp(dtbs[i].compatible, compatible)) { > + dtb = [i]; > + break; > + } > + } > + > + if (!dtb) > + return -ENODEV; > + > + ovcs_id = 0; > + return of_overlay_fdt_apply(dtb->begin, _id); return of_overlay_fdt_apply(dtb->begin, dtb->end - dtb->begin, _id); For version 5 of my patch series I added an FDT size argument, as you suggested. Reviewed-by: Frank Rowand <frank.row...@sony.com>

Re: [PATCH v7 3/4 - variant 1] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes

2018-03-01 Thread Frank Rowand
ng with support for the new > DT bindings in the DU driver. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > --- Reviewed-by: Frank Rowand <frank.row...@sony.com>