[PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

2016-06-09 Thread Kieran Bingham
The power domain must be specified to bring the device out of module standby. Document this in the example provided, so that new additions are not missed. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + 1 file chan

[PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

2016-06-09 Thread Kieran Bingham
The FCP driver, can also support the FCPF variant for FDP1 compatible processing. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devi

[PATCHv2] clk: renesas: r8a7795: Provide FDP1 clocks

2016-06-09 Thread Kieran Bingham
Now that the clock parents have been confirmed, and the clock names adjusted the FDP1 clocks can be added to the cpg-mssr Kieran Bingham (1): clk: renesas: r8a7795: Provide FDP1 clocks drivers/clk/renesas/r8a7795-cpg-mssr.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4

[PATCH] clk: renesas: r8a7795: Provide FDP1 clocks

2016-06-09 Thread Kieran Bingham
Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/d

Re: [PATCH RFC 1/2] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-10 Thread Kieran Bingham
Today I learned about make C=1 So ... reviewing my own patch, consider the following sparse warnings 'fixed up' I'll run make C=1 before any future submissions from now on. On 09/06/16 18:37, Kieran Bingham wrote: > The FDP1 driver performs advanced de-interlacing on a memory 2 memory >

[PATCH RFC 1/2] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-09 Thread Kieran Bingham
The FDP1 driver performs advanced de-interlacing on a memory 2 memory based video stream, and supports conversion from YCbCr/YUV to RGB pixel formats Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/Kconfig | 13 + drivers/media/platform/Makefile

[PATCH RFC 0/2] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-09 Thread Kieran Bingham
driver this seemed like an apt point to start the review process. Kieran Bingham (2): v4l: platform: Add Renesas R-Car FDP1 Driver MAINTAINERS: Add support for FDP driver MAINTAINERS|9 + drivers/media/platform/Kconfig | 13 + drivers/media/platform/Makefile

[PATCH 1/2] arm64: dts: r8a7795: add FCPF device nodes

2016-06-09 Thread Kieran Bingham
Provide nodes for the FCP devices dedicated to the FDP device channels. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi

[PATCH RFC 2/2] MAINTAINERS: Add support for FDP driver

2016-06-09 Thread Kieran Bingham
Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 66de4da2d244..bc083b58e478 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7312,6 +7312,15 @@ S: Supported F: Documen

[PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

2016-06-09 Thread Kieran Bingham
The FDP1 is a de-interlacing module which converts interlaced video to progressive video. It is also capable of performing pixel format conversion between YCbCr/YUV formats and RGB formats. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- .../devicetree/bindings/media/renesas,fd

[PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

2016-06-09 Thread Kieran Bingham
Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi index e63e5f29cceb..0c0aa1

[PATCH 1/2] arm64: dts: r8a7795: add FCPF device nodes

2016-06-09 Thread Kieran Bingham
Provide nodes for the FCP devices dedicated to the FDP device channels. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi

[PATCH] v4l: Extend FCP compatible list to support the FDP

2016-06-09 Thread Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1 does not make use of the FCNL features. Extend the compatible list to allow us to use the power domain and runtime-pm support. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/rcar-fcp.c |

[PATCH] v4l: Extend FCP compatible list to support the FDP

2016-06-09 Thread Kieran Bingham
.html Kieran Bingham (1): v4l: Extend FCP compatible list to support the FDP drivers/media/platform/rcar-fcp.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

2016-06-13 Thread Kieran Bingham
On 10/06/16 18:37, Rob Herring wrote: > On Thu, Jun 09, 2016 at 02:41:32PM +0100, Kieran Bingham wrote: >> The FCP driver, can also support the FCPF variant for FDP1 compatible > > Drop the comma. Ok >> processing. >> >> Signed-off-by: K

Re: R8A7795 FDP1 clock parentage

2016-05-30 Thread Kieran Bingham
ot;parent clock" settings itself is not super critical >> # (= it works anyway with wrong settings) >> # it seems other issues ? You were right :) - It was the power-domain. It's resolved now and working. Thank you for your help. > I got information from HW team. > About H3 ES1 FDP1 parent clock is "S2D1" Perfect, thanks for confirming this. Now the patch is unblocked from submission. -- Regards Kieran Bingham

Re: [PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding

2016-05-30 Thread Kieran Bingham
Hi Geert! On 28/05/16 20:06, Geert Uytterhoeven wrote: > Hi Kieran, > > On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kie...@ksquared.org.uk> > wrote: >> The FCP driver, can also support the FCPF variant for FDP1 compatible >> processing. >> &

Re: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage

2016-05-30 Thread Kieran Bingham
Hi Geert, On 28/05/16 20:03, Geert Uytterhoeven wrote: > Hi Kieran, > > On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kie...@ksquared.org.uk> > wrote: >> The example misses the power-domains usage, and documentation that the >> property is used by the nod

[PATCH 0/4] RCar r8a7795 FCPF support

2016-05-27 Thread Kieran Bingham
/devicetree/bindings/media/renesas,fcp.txt These patches are based on Geert's renesas-drivers tree, and are pushed to a branch at g...@github.com:kbingham/linux.git renesas/fcpf for convenience. Kieran Bingham (4): v4l: Extend FCP compatible list to support the FDP dt-bindings: Update Renesas R-Car FCP

[PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage

2016-05-27 Thread Kieran Bingham
The example misses the power-domains usage, and documentation that the property is used by the node. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devi

[PATCH 4/4] arm64: dts: r8a7795: add FCPF device nodes

2016-05-27 Thread Kieran Bingham
Provide nodes for the FCP devices dedicated to the FDP device channels. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi

[PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding

2016-05-27 Thread Kieran Bingham
The FCP driver, can also support the FCPF variant for FDP1 compatible processing. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Cc: devicet...@vger.kernel.org diff

[PATCH 1/4] fcp: Extend FCP compatible list to support the FDP

2016-05-27 Thread Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1 does not make use of the FCNL features. Extend the compatible list to allow us to use the power domain and runtime-pm support. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/rcar-fcp.c |

[PATCH 1/4] v4l: Extend FCP compatible list to support the FDP

2016-05-27 Thread Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1 does not make use of the FCNL features. Extend the compatible list to allow us to use the power domain and runtime-pm support. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/rcar-fcp.c |

Re: [PATCH 1/4] fcp: Extend FCP compatible list to support the FDP

2016-05-27 Thread Kieran Bingham
My apologies - I had a stale file in my patches folder :( This one had the wrong commit-shortlog, please ignore. -- Kieran On 27/05/16 18:19, Kieran Bingham wrote: > The FCP must be powered up for the FDP1 to function, even when the FDP1 > does not make use of the FCNL features.

[PATCH] clk: renesas: Provide r8a7795 FDP1 clocks

2016-05-17 Thread Kieran Bingham
Add the clocks with a parent of S2D1 for now, until the correct parentage is identified --- drivers/clk/renesas/r8a7795-cpg-mssr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/clk/renesas/r8a7795-cpg-mssr.c b/drivers/clk/renesas/r8a7795-cpg-mssr.c index

[PATCH] Provide r8a7795 FDP1 clocks

2016-05-17 Thread Kieran Bingham
the correct parent please? Kieran Bingham (1): clk: renesas: Provide r8a7795 FDP1 clocks drivers/clk/renesas/r8a7795-cpg-mssr.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.5.0

Re: [PATCH] clk: renesas: Provide r8a7795 FDP1 clocks

2016-05-17 Thread Kieran Bingham
Thanks Geert, On 17/05/16 11:25, Geert Uytterhoeven wrote: > Hi Kieran, > > On Tue, May 17, 2016 at 12:03 PM, Kieran Bingham <kie...@ksquared.org.uk> > wrote: >> Add the clocks with a parent of S2D1 for now, until the correct >> parentage is identif

R8A7795 FDP1 clock parentage

2016-05-25 Thread Kieran Bingham
Hi Morimoto-san, I have added an initial patch to support the FDP1 in the clock framework, but I have not been able to correctly identify the actual clock parent. For now I have assumed that it is R8A7795_CLK_S2D1. Could you please confirm this selection, or help identify the true parent

Re: R8A7795 FDP1 clock parentage

2016-05-25 Thread Kieran Bingham
are currently listed as R8A7795_CLK_S2D1, however now that I am trying to enable the FCPF and read registers from it - the VCR is returning as 0x00 (I expect 0x0101) and then I'm getting "Bad mode in Error handler detected, code 0xbf02 -- SError" My suspicion is that my clock has not

Re: [PATCH] [media] fdp1: vb2_queue dev conversion

2016-07-19 Thread Kieran Bingham
> > /* M2M registration */ > @@ -2327,9 +2317,6 @@ release_m2m: > unreg_dev: > v4l2_device_unregister(>v4l2_dev); > > -vb2_allocator_rollback: > - vb2_dma_contig_cleanup_ctx(fdp1->alloc_ctx); > - > return ret; > } > > @@ -2340,7 +2327,6 @@ static int fdp1_remove(struct platform_device *pdev) > v4l2_m2m_release(fdp1->m2m_dev); > video_unregister_device(>vfd); > v4l2_device_unregister(>v4l2_dev); > - vb2_dma_contig_cleanup_ctx(fdp1->alloc_ctx); > pm_runtime_disable(>dev); > > return 0; > -- Regards Kieran Bingham

[PATCH] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-30 Thread Kieran Bingham
The FDP1 driver performs advanced de-interlacing on a memory 2 memory based video stream, and supports conversion from YCbCr/YUV to RGB pixel formats Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- MAINTAINERS|9 + drivers/media/platform/Kconfig

[PATCH v2] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-30 Thread Kieran Bingham
at the same time as converting interlaced content to progressive. Kieran Bingham (1): v4l: platform: Add Renesas R-Car FDP1 Driver MAINTAINERS|9 + drivers/media/platform/Kconfig | 13 + drivers/media/platform/Makefile|1 + drivers/media/platform

[PATCH v2 0/2] arm64: dts: r8a7795: FCPF and FDP1 device nodes

2016-06-30 Thread Kieran Bingham
. Your assumption was correct, and they could be applied without breakage. RobH has acked the binding for the RCar FCPF, but I have not seen an ack for the FDP1 binding yet. I'll follow that up, and ping you on the fdp1 dts patch when it resolved. Regards Kieran -- Kieran Bingham (2): arm64:

[PATCH 1/2] arm64: dts: r8a7795: add FCPF device nodes

2016-06-30 Thread Kieran Bingham
Provide nodes for the FCP devices dedicated to the FDP device channels. Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 21 + 1 file changed, 21 inserti

[PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

2016-06-30 Thread Kieran Bingham
Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kieran Bingham <kie...@bingham.xyz> -- changes for v2 - channel labels dropped arch/arm64/boot/dts/renesas/r8a7795.dtsi | 27

[GIT PULL FOR renesas-drivers] FDP1 Fine Display Processor support

2016-06-30 Thread Kieran Bingham
to 06f3e8e204a41e68ab649a26c557e7bc4c01c0f0: Merge branches 'renesas/fdp1-dt' and 'renesas/fdp1-driver' into renesas/fdp1 (2016-06-30 10:13:43 +0100) Kieran Bingham (9): dt-bindings: Update Renesas R-Car FCP DT binding

[PATCH v2 0/3] dt-bindings: RCar FCP and FDP1 bindings

2016-06-30 Thread Kieran Bingham
compatibles as we have a HW version register available to us in the hardware so we can detect at run-time what device version we are running on. Kieran Bingham (3): dt-bindings: Update Renesas R-Car FCP DT binding dt-bindings: Document Renesas R-Car FCP power-domains usage dt-bindings: Add Renesas R

[PATCH v2 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

2016-06-30 Thread Kieran Bingham
The FCP driver can also support the FCPF variant for FDP1 compatible processing. Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bind

[PATCH v2 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

2016-06-30 Thread Kieran Bingham
The FDP1 is a de-interlacing module which converts interlaced video to progressive video. It is also capable of performing pixel format conversion between YCbCr/YUV formats and RGB formats. Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kieran Bingha

[PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

2016-06-30 Thread Kieran Bingham
The power domain must be specified to bring the device out of module standby. Document this in the bindings provided, so that new additions are not missed. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 5 + 1 file chan

Re: [PATCH 2/2] arm64: dts: r8a7795: add FDP1 device nodes

2016-07-01 Thread Kieran Bingham
Hi Simon, The bindings for this have now been acked by RobH. -- Cheers Kieran On 30/06/16 14:32, Kieran Bingham wrote: > Reviewed-by: Geert Uytterhoeven <geert+rene...@glider.be> > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by

[PATCH 2/5] vsp-lib: Filter non-filesystem regular characters

2017-02-08 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Parameters can contain characters not suited to use in filenames. Add '=','(', and ')' to the filtering, and replace with '_' Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- scripts/vsp-lib.sh | 3 +++ 1 fil

[PATCH 3/5] gen-image: Implement option to parse an input crop

2017-02-08 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Allow the user to specify an input crop in the form (X,Y)/WxH Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- src/gen-image.c | 106 +- 1 file changed, 10

[PATCH 1/5] vsp-lib: sort output frames correctly

2017-02-08 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> In the event of failed frames, or VSP_KEEP_FRAMES being set, the output file names do not sort such that the reference frame is next to the failed frame. This can make comparing reference frames and the relevant output frames t

[PATCH 4/5] vsp-lib: Support RPF frame cropping

2017-02-08 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Pass the optional '--crop (X,Y)/WxH' parameter through reference_frame allowing the input to be cropped for comparison Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- scripts/vsp

[PATCH 5/5] tests: Add RPF cropping test

2017-02-08 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Test both the input cropping size and position Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- tests/vsp-unit-test-0021.sh | 39 ++- 1 file changed, 39 insertions(+)

[PATCH 0/5] vsp-tests: Implement RPF cropping tests

2017-02-08 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Update the gen-image utility such that it can crop the image at input, and provide tests to ensure that the output of the RPF is as we expect. The first patch in the series, reformats the output filenames such that frames, and the c

Re: [PATCH] vsp-lib: Fix reference frame generation for HSV input formats

2017-02-20 Thread Kieran Bingham
esac > + > # Start with the input format to compute the alpha value being used by > # the RPF after unpacking. Keep in sync with generate_input_frame. > case $in_format in With that, Reviewed-by: Kieran Bingham <kieran.bing...@ideasonboard.com>

Re: [PATCHv2 2/5] scripts: Provide bin2png.sh helper

2017-02-21 Thread Kieran Bingham
Hi Geert, On 20/02/17 20:45, Geert Uytterhoeven wrote: > Hi Kieran, > > On Mon, Feb 20, 2017 at 6:47 PM, Kieran Bingham > <kieran.bing...@ideasonboard.com> wrote: >> This change breaks POSIX SH compliance, as reported by shellcheck: >> >> In scripts/bin2png.sh

[PATCH 1/1] scripts: bin2png.sh: Fix POSIX shell compliance

2017-02-22 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> The string manipulations of the form ${VAR/search/replace} are not posix compliant. Use string deletion, and append instead. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- scripts/bin2png.sh | 4 ++-- 1 fil

[PATCH 5/8] v4l: vsp1: Operate on partition struct data directly

2017-02-10 Thread Kieran Bingham
When generating the partition windows, operate directly on the partition struct rather than copying and duplicating the processed data Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 43 -

[PATCH 7/8] v4l: vsp1: Calculate UDS phase for partitions

2017-02-10 Thread Kieran Bingham
To improve image quality when scaling using the UDS we need to correctly determine the start phase value for each partition window. Provide helper functions for calculating the phase, and write this value to the registers when used. Signed-off-by: Kieran Bingham <kieran.bingham+r

[PATCH 8/8] v4l: vsp1: Implement left edge partition algorithm overlap

2017-02-10 Thread Kieran Bingham
Increase the overlap on the left edge to allow a margin to provide better image scaling Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_rpf.c | 7 +- drivers/media/platform/vsp1/vsp1_uds.c | 39 --- 2

[PATCH 6/8] v4l: vsp1: Allow entities to participate in the partition algorithm

2017-02-10 Thread Kieran Bingham
to it's predecessor in the pipeline. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_entity.h | 8 - drivers/media/platform/vsp1/vsp1_pipe.c | 22 - drivers/media/platform/vsp1/vsp1_pipe.h

[GIT PULL] v4l: vsp1: Partition phase developments

2017-02-10 Thread Kieran Bingham
. Kieran Bingham (8): v4l: vsp1: Provide UDS register updates v4l: vsp1: Track the SRU entity in the pipeline v4l: vsp1: Correct image partition parameters v4l: vsp1: Move partition rectangles to struct v4l: vsp1: Operate

Re: [PATCH 2/5] vsp-lib: Filter non-filesystem regular characters

2017-02-10 Thread Kieran Bingham
Hi Laurent, Thanks for the review! On 10/02/17 07:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Wednesday 08 Feb 2017 14:03:57 Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bing...@ideasonboard.com> >> >> Param

Re: [PATCH 3/5] gen-image: Implement option to parse an input crop

2017-02-10 Thread Kieran Bingham
Hi Laurent, Thanks for the review, On 10/02/17 08:19, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Wednesday 08 Feb 2017 14:03:58 Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bing...@ideasonboard.com> >> >>

[PATCH v2 3/4] vsp-lib: Support RPF frame cropping

2017-02-10 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Pass the optional '--crop (X,Y)/WxH' parameter through reference_frame allowing the input to be cropped for comparison Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- scripts/vsp

[PATCH v2 4/4] tests: Add RPF cropping test

2017-02-10 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Test both the input cropping size and position Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- tests/vsp-unit

[PATCH v2 1/4] vsp-lib: Filter non-filesystem regular characters

2017-02-10 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Parameters can contain characters not suited to use in filenames. Add '=','(', and ')' to the filtering, and replace with '_' This reduces extra escaping, and quoting when working with the output filenames of failed

[PATCH v2 0/4] vsp-tests: Implement RPF cropping tests

2017-02-10 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Update the gen-image utility such that it can crop the image at input, and provide tests to ensure that the output of the RPF is as we expect. v2: - rebased on master branch - review comments fixed - vsp-unit-test-0021.sh descr

[PATCH v2 2/4] gen-image: Implement option to parse an input crop

2017-02-10 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Allow the user to specify an input crop in the form (X,Y)/WxH Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- src/gen-image.c | 132 +- 1 file changed, 13

[PATCH 0/2] vsp-tests: Provide stress testing

2017-02-11 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Add two extra tests utilising the 'stress' command utilty. These tests wrap existing test functionality whilst holding the system under arbitrary heavy load Kieran Bingham (2): tests: Add basic stress testing tests: Add extended

[PATCH 1/2] tests: Add basic stress testing

2017-02-11 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Duplicate the functionality of vsp-unit-test-0001, to provide a set of work for the hardware to run, whilst we load the system using the 'stress' utility. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- te

[PATCH 2/2] tests: Add extended stress testing

2017-02-11 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Duplicate the functionality of vsp-unit-test-0020, to provide a longer duration task for the hardware to run, whilst we load the system using the 'stress' utility. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com>

Re: [PATCH 4/5] vsp-lib: Support RPF frame cropping

2017-02-10 Thread Kieran Bingham
Ooops, I left this on my screen, and have already sent the V2 anyway. Hitting send for posterity. -- Kieran On 10/02/17 09:20, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Wednesday 08 Feb 2017 14:03:59 Kieran Bingham wrote: >> From: Kieran

[RFC PATCH 2/3] v4l: vsp1: extend VSP1 module API to allow DRM callback registration

2017-03-01 Thread Kieran Bingham
, the event can be returned back to the originator through the registered callback. We must not have bidirectional dependencies on the two components to maintain support for loadable modules, thus we extend the API to allow a callback to be registered within the VSP DRM interface. Signed-off-by: Kieran

[RFC PATCH 0/3] RCAR-DU, VSP1: Prevent pre-emptive frame flips on VSP1-DRM pipelines

2017-03-01 Thread Kieran Bingham
believe this is due to the one frame latency imposed by the VSPD and will need further investigation. Kieran Bingham (3): v4l: vsp1: Register pipe with output WPF v4l: vsp1: extend VSP1 module API to allow DRM callback registration drm: rcar-du: Register a completion callback with VSP1 drivers

[RFC PATCH 1/3] v4l: vsp1: Register pipe with output WPF

2017-03-01 Thread Kieran Bingham
as the output. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/vsp1/vsp1_drm.c b/drivers/media/platform/vsp1/vsp1_drm.c index cd209dccff1b..8e2aa3

Re: [PATCH] v4l: vsp1: Disable HSV formats on Gen3 hardware

2017-03-02 Thread Kieran Bingham
off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_pipe.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/dr

Re: [PATCH v3 00/10] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-09-08 Thread Kieran Bingham
experimental > and doesn't fix any known bug. I've included the patch in the series to get > feedback on whether this is a good idea. > > Kieran, I noticed that your patches are authored by > > Kieran Bingham <kie...@ksquared.org.uk> > > Is that correct o

Re: [PATCH v3 02/10] v4l: ctrls: Add deinterlacing mode control

2016-09-08 Thread Kieran Bingham
inchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kie...@bingham.xyz> > --- > Documentation/media/uapi/v4l/extended-controls.rst | 4 > drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ > include/uapi/linux/v4l2-controls.h | 1 +

Re: [PATCH v3 05/10] v4l: fdp1: vb2_queue dev conversion

2016-09-08 Thread Kieran Bingham
p1_queue_setup(), > - Convert the FDP1 driver to use the new vb2_queue dev field, cfr. > commit 53ddcc683faef8c7 ("[media] media/platform: convert drivers to > use the new vb2_queue dev field"). > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>

Re: [PATCH v3 09/10] v4l: fdp1: Fix field validation when preparing buffer

2016-09-11 Thread Kieran Bingham
tainly isn't a bad thing to verify they are what we were told they would be :D -- Reviewed-by: Kieran Bingham <kie...@bingham.xyz> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > --- > drivers/media/platform/rcar_fdp1.c | 40 > +

Re: [PATCH v3 10/10] v4l: fdp1: Store buffer information in vb2 buffer

2016-09-11 Thread Kieran Bingham
, and preparing the buffers early is clearly more elegant and less prone to failure. Thanks Kieran ... Obligatory over tagging Acked-by: Kieran Bingham <kie...@bingham.xyz> Reviewed-by: Kieran Bingham <kie...@bingham.xyz> On 07/09/16 23:25, Laurent Pinchart wrote: > The struct fdp1_b

Re: [PATCH v3 06/10] v4l: fdp1: Incorporate miscellaneous review comments

2016-09-11 Thread Kieran Bingham
LORSPACE_REC709 for ycbcr_enc > - Fix handling of V4L2_FIELD_INTERLACED > - Use the standard V4L2_CID_DEINTERLACER_MODE control > - Add missing white space > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kie...@bingha

[PULL REQUEST] VSP1 Image Partitioning algorithm

2016-09-14 Thread Kieran Bingham
) Kieran Bingham (6): v4l: vsp1: Ensure pipeline locking in resume path v4l: vsp1: Repair race between frame end and qbuf handler v4l: vsp1: Use DFE instead of FRE for frame end v4l: vsp1: Support chained display lists v4l: vsp1: Determine partition

Re: [PATCH v3 07/10] v4l: fdp1: Remove unused struct fdp1_v4l2_buffer

2016-09-09 Thread Kieran Bingham
On 07/09/16 23:25, Laurent Pinchart wrote: > The structure is not used, remove it. Ahh yes, looks like a left over from my first attempt at serialising input fields. Reviewed-by: Kieran Bingham <kie...@bingham.xyz> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@i

Re: [PATCH 04/13] v4l: vsp1: Repair race between frame end and qbuf handler

2016-09-14 Thread Kieran Bingham
On 14/09/16 00:16, Laurent Pinchart wrote: > From: Kieran Bingham <kieran+rene...@bingham.xyz> > > The frame-end function releases and completes the buffers on the input > and output entities of the pipe before marking the pipe->state as > 'STOPPED'. This introduces a ra

Re: [PULL REQUEST] VSP1 Image Partitioning algorithm

2016-09-19 Thread Kieran Bingham
On 19/09/16 16:57, Geert Uytterhoeven wrote: > Hi Kieran, > > On Wed, Sep 14, 2016 at 6:45 PM, Kieran Bingham <kie...@ksquared.org.uk> > wrote: >> Please consider integrating the latest VSP1 next branch to provide the >> image partitioning algorithm into

Re: Kernal version Issue

2016-10-03 Thread Kieran Bingham
ally, or a specialist consultant to support you. > Best Regards Jithin T Raj -- Regards Kieran Bingham

[PATCH] v4l: vsp1: Prevent commencing pipelines before they are setup

2016-11-11 Thread Kieran Bingham
ned-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- I considered a few options to fix this issue. If anyone disagrees with my reasoning, and believes one of the below approaches should be used, let me know and I'll rework the patch. A) Moving the vsp1_video_pipeline_r

Re: [PATCH v4 3/4] v4l: Add Renesas R-Car FDP1 Driver

2016-10-24 Thread Kieran Bingham
respin. -- Regards Kieran On 24/10/16 10:03, Laurent Pinchart wrote: > From: Kieran Bingham <kieran+rene...@bingham.xyz> > > The FDP1 driver performs advanced de-interlacing on a memory 2 memory > based video stream, and supports conversion from YCbCr/YUV > to RGB pixel fo

[PATCH 4/5] tests: Test suspend/resume on idle pipelines

2016-11-25 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Provide a test to verify the hardware is functional both before and after entering a suspend / resume cycle. Make use of the /sys/power/pm_test functionality provided by CONFIG_PM_DEBUG to perform the testing Signed-off-by: Kieran B

[PATCH 2/5] scripts: Provide bin2png.sh helper

2016-11-25 Thread Kieran Bingham
From: Kieran Bingham <kie...@bingham.xyz> Identify the size and format from the test output filename, and pass to raw2rgbpnm for conversion to a PNM file. >From there we can convert easily to a PNG output file. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- scripts/

Re: [PATCH 2/5] scripts: Provide bin2png.sh helper

2016-11-25 Thread Kieran Bingham
Hi Laurent, Thanks for the review :D On 25/11/16 17:55, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 25 Nov 2016 13:59:13 Kieran Bingham wrote: >> From: Kieran Bingham <kie...@bingham.xyz> >> >> Identify the size a

[PATCH 1/5] scripts: Test suite runner

2016-11-25 Thread Kieran Bingham
From: Kieran Bingham <kie...@bingham.xyz> Provide a utility script to execute all vsp unit tests, as well as the option to execute multiple iterations of the suite. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- scripts/vsp-tests.sh | 46 +

[PATCH 5/5] tests: Test suspend/resume on active pipelines

2016-11-25 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Provide a test to verify the hardware completes a functional test whilst performing a suspend resume cycle in parallel. Make use of the /sys/power/pm_test functionality provided by CONFIG_PM_DEBUG to perform the testing Signed-off-by:

[PATCH 3/5] logger: Log to the FTrace buffer if tracing is enabled

2016-11-25 Thread Kieran Bingham
From: Kieran Bingham <kie...@bingham.xyz> Extend the logger such that it will detect the tracing system, and also append print statement to this ring buffer. This provides the relevant logging output interspersed in the ftrace logs for an effective solution to identifying the actions that

Re: [PATCH 4/5] tests: Test suspend/resume on idle pipelines

2016-11-25 Thread Kieran Bingham
On 25/11/16 17:13, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 25 Nov 2016 13:59:15 Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bing...@ideasonboard.com> >> >> Provide a test to verify the hardware is funct

Re: [PATCH 3/5] logger: Log to the FTrace buffer if tracing is enabled

2016-11-25 Thread Kieran Bingham
Hi Laurent, On 25/11/16 17:40, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 25 Nov 2016 13:59:14 Kieran Bingham wrote: >> From: Kieran Bingham <kie...@bingham.xyz> >> >> Extend the logger such that it will detect the t

Re: [PATCH 5/5] tests: Test suspend/resume on active pipelines

2016-11-25 Thread Kieran Bingham
Hi Laurent, On 25/11/16 17:10, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 25 Nov 2016 13:59:16 Kieran Bingham wrote: >> From: Kieran Bingham <kieran.bing...@ideasonboard.com> >> >> Provide a test to verify the hard

Re: [PATCH 1/5] scripts: Test suite runner

2016-11-25 Thread Kieran Bingham
On 25/11/16 18:21, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Friday 25 Nov 2016 13:59:12 Kieran Bingham wrote: >> From: Kieran Bingham <kie...@bingham.xyz> >> >> Provide a utility script to execute all vsp unit tests, as we

Re: [PATCH] v4l: vsp1: Prevent commencing pipelines before they are setup

2016-11-23 Thread Kieran Bingham
the issue repaired here. -- Regards Kieran On 11/11/16 10:31, Kieran Bingham wrote: > With multiple inputs through the BRU it is feasible for the streams to > race each other at stream-on. In the case of the video pipelines, this > can present two serious issues. > > 1) A null-derefere

[PATCH 0/5] VSP-Tests: Add suspend resume tests and helpers

2016-11-25 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Provide two tests for suspend/resume cycles. One will verify the VSP1 is functional with a test before and after a suspend cycle. The other will maintain an active pipeline which must succeed despite a suspend resume cycle oc

[GIT PULL FOR renesas-drivers] VSP Writeback prototype

2016-11-14 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Hi Geert, The following changes since commit 8bc55e5947b58dee3c8b126d7c303991ae0db130: tty: serial_core: Fix serial console crash on port shutdown (2016-10-25 13:53:49 +0200) are available in the git repository at:

[GIT PULL FOR renesas-drivers] VSP Partition algorithm improvements

2016-11-14 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> Hi Geert, The following changes since commit 8bc55e5947b58dee3c8b126d7c303991ae0db130: tty: serial_core: Fix serial console crash on port shutdown (2016-10-25 13:53:49 +0200) are available in the git repository at:

Re: [RFC 3/3] v4l: vsp1: Provide a writeback video device

2016-11-01 Thread Kieran Bingham
Looks like I forgot to run checkpatch here, and it picked up a few things. Please disregard them in your review, and they will be fixed for next version. On 27/10/16 15:01, Kieran Bingham wrote: > When the VSP1 is used in an active display pipeline, the output of the > WPF can supply t

[PATCHv2] v4l: vsp1: Provide a writeback video device

2016-11-03 Thread Kieran Bingham
. The source will be able to perform pixel format conversion, but not rescaling, and as such the output from the memory node will always be of the same dimensions as the display output. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- With the patch "[media

  1   2   3   4   5   6   7   8   9   >