Re: [PATCH 16/20] drm: omap: Rely on the default ->best_encoder() behavior

2016-06-02 Thread Laurent Pinchart
is assigned but not used anymore, you can remove it. With that fixed, Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > -} > - > static const struct drm_connector_funcs omap_connector_funcs = { > .dpms = drm_atomic_helper_connector_dpms, > .re

Re: [PATCH/RFC v3 15/22] clk: renesas: r8a7796: Obtain mode pin values from R-Car RST driver

2016-06-02 Thread Laurent Pinchart
ne...@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > v3: > - New. > --- > drivers/clk/renesas/r8a7796-cpg-mssr.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/renesas/r8a779

Re: [PATCH/RFC v3 16/22] clk: renesas: rcar-gen3-cpg: Remove obsolete rcar_gen3_read_mode_pins()

2016-06-02 Thread Laurent Pinchart
Hi Geert, Thank you for the patch. On Wednesday 01 Jun 2016 21:21:14 Geert Uytterhoeven wrote: > All R-Car Gen3 clock drivers now obtain the values of the mode pins from > the R-Car RST driver. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by

Re: [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver

2016-06-02 Thread Laurent Pinchart
ll ? > +int __init rcar_rst_read_mode_pins(u32 *mode) > +{ > + int error; > + > + if (!rcar_rst_base) { > + error = rcar_rst_init(); > + if (error) > + return error; > + } > + > + *mode = saved_mode; > + return 0; > +} > diff --git a/include/linux/soc/renesas/rcar-rst.h > b/include/linux/soc/renesas/rcar-rst.h new file mode 100644 > index ..a18e0783946b66ec > --- /dev/null > +++ b/include/linux/soc/renesas/rcar-rst.h > @@ -0,0 +1,6 @@ > +#ifndef __LINUX_SOC_RENESAS_RCAR_RST_H__ > +#define __LINUX_SOC_RENESAS_RCAR_RST_H__ > + > +int rcar_rst_read_mode_pins(u32 *mode); > + > +#endif /* __LINUX_SOC_RENESAS_RCAR_RST_H__ */ -- Regards, Laurent Pinchart

Re: [PATCH/RFC v3 14/22] clk: renesas: r8a7795: Obtain mode pin values from R-Car RST driver

2016-06-02 Thread Laurent Pinchart
ne...@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > v3: > - New. > --- > drivers/clk/renesas/r8a7795-cpg-mssr.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/renesas/r8a779

Re: [PATCH 01/20] drm/atomic: Fix remaining places where !funcs->best_encoder is valid

2016-06-02 Thread Laurent Pinchart
->best_encoder() is > + * NULL we fallback to the default drm_atomic_helper_best_encoder() > + * helper. > + */ > + if (fb_helper->dev->mode_config.funcs->atomic_commit && > + !connector_funcs->best_encoder) > + encoder = drm

Re: [PATCH/RFC 0/1] soc: renesas: Add DT fixup code for backwards compatibility

2016-06-02 Thread Laurent Pinchart
fline into a new > dtb or compile dts files and overlays to a dtb. We need to keep the use case in mind. The main (and possibly only) reason why we want to patch DT this way is to support systems whose DTB can't be updated (otherwise we could just update the DTB) and isn't fully known in advance to the kernel (otherwise we would just bundle an updated full DTB with the kernel). We thus need a heuristic-based approach at runtime to identify missing or outdated DT pieces and patch them, with some level of fuzziness. I'm not sure we could handle this with overlays. > > Should this be handled at another level? E.g. operate on the FDT? > > We should try to avoid doing things with the FDT if possible. -- Regards, Laurent Pinchart

Re: [PATCH 09/20] drm: rcar-du: Rely on the default ->best_encoder() behavior

2016-06-02 Thread Laurent Pinchart
emove rcon->encoder = renc; from rcar_du_vga_connector_init(), it's not needed anymore. The same code in rcar_du_hdmi_connector_init() has to stay for now though, as it's used to locate the slave encoder in the HDMI support code. That should change when the driver will be converted to use drm_bridge. I can also fix this during the conversion to drm_bridge if you don't want to resubmit. In any case, Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> -- Regards, Laurent Pinchart

Re: R-Car3: PFC: Where to do the pinmux/drvctrl?

2016-06-09 Thread Laurent Pinchart
andled (e.g. DRVCTRL2). > > So your proposal would be to fix/correct/extend Linux kernel's > pfc-r8a7795 to correctly support the drive strength needed for the RAVB > on the Salvator-X? If the R8A7795 supports configuring the drive strength of RAVB pins, and that feature is needed by systems using that SoC, then the pfc-r8a7795 driver should implement it, yes. That's no different that any other hardware feature. -- Regards, Laurent Pinchart

[PATCH 3/5] v4l: vsp1: lut: Initialize the mutex

2016-06-08 Thread Laurent Pinchart
The LUT mutex isn't initialized when creating the LUT, fix it. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_lut.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/vsp1/vsp1_lut.c b/drivers

[PATCH 2/5] v4l: vsp1: dl: Don't free fragments with interrupts disabled

2016-06-08 Thread Laurent Pinchart
the garbage collection. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 72 --- 1 file changed, 58 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/d

[PATCH 4/5] v4l: vsp1: lut: Expose configuration through a control

2016-06-08 Thread Laurent Pinchart
Replace the custom ioctl with a V4L2 control in order to standardize the API. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_lut.c | 74 ++ drivers/media/platform/vsp1/vsp1_lut.h | 6 +-- i

[PATCH 5/5] v4l: vsp1: Add Cubic Look Up Table (CLU) support

2016-06-08 Thread Laurent Pinchart
The CLU processing block is a 2D/3D lookup table that converts the input three color component data into desired three color components using a lookup table. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/Makefile

[PATCH 1/5] v4l: vsp1: pipe: Fix typo in comment

2016-06-08 Thread Laurent Pinchart
The vsp1_pipeline wq field is a wait queue, not a work queue. Fix the comment accordingly. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_pipe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code

2016-06-08 Thread Laurent Pinchart
Hi Geert, On Wednesday 08 Jun 2016 09:04:17 Geert Uytterhoeven wrote: > On Wed, Jun 8, 2016 at 2:18 AM, Laurent Pinchart wrote: > >> --- 0031/drivers/iommu/ipmmu-vmsa.c > >> +++ work/drivers/iommu/ipmmu-vmsa.c 2016-06-06 11:19:40.210607110 +0900 > >> @@ -1074,7

Re: [PATCH 2/3] iommu/ipmmu-vmsa: Increase maximum micro-TLBS to 48

2016-06-07 Thread Laurent Pinchart
with the largest utlb number in the R- Car Gen3 datasheet uses a 0-38 utlb range. > spin_lock_init(>lock); > bitmap_zero(mmu->ctx, IPMMU_CTX_MAX); > mmu->features = match->data; -- Regards, Laurent Pinchart

Re: [PATCH 3/3] iommu/ipmmu-vmsa: Hook up r8a7796 DT matching code

2016-06-07 Thread Laurent Pinchart
f, "renesas,ipmmu-r8a7796", > + ipmmu_vmsa_iommu_of_setup); How about a Gen3 generic compatible string in addition to the SoC-specific ones ? > #endif > > MODULE_DESCRIPTION("IOMMU API for Renesas VMSA-compatible IPMMU"); -- Regards, Laurent Pinchart

Re: [PATCH 1/3] iommu/ipmmu-vmsa: Add r8a7796 DT binding

2016-06-07 Thread Laurent Pinchart
: Magnus Damm <damm+rene...@opensource.se> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > > Documentation/devicetree/bindings/iommu/renesas,ipmmu-vmsa.txt |1 + > 1 file changed, 1 insertion(+) > > --- 0001/Documentation/devicetree/bindings/iommu/renesa

Re: [PATCH v2 06/11] iommu/ipmmu-vmsa: Teach xlate() to skip disabled iommus

2016-06-07 Thread Laurent Pinchart
sabled in DT then return error > + * to make sure the of_iommu code does not install ops > + * even though the iommu device is disabled > + */ > + if (!of_device_is_available(spec->np)) > + return -ENODEV; > + > return 0; > } -- Regards, Laurent Pinchart

Re: [PATCH 14/14] drm/shmobile: use drm_crtc_vblank_{get,put}()

2016-06-06 Thread Laurent Pinchart
.pado...@collabora.co.uk> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c > b/driv

Re: [PATCH/RFC v3 02/22] soc: renesas: Add R-Car RST driver

2016-06-10 Thread Laurent Pinchart
it's "pins" that bothers Dirk, how about rcar_rst_read_boot_mode() ? Or maybe rcar_rst_boot_mode(), given that the function caches the value, it doesn't read it every time. -- Regards, Laurent Pinchart

Re: [PATCH 2/3] pinctrl: sh-pfc: Improve core and user API separation

2016-06-10 Thread Laurent Pinchart
> > -struct sh_pfc; > +struct sh_pfc_window { > + phys_addr_t phys; > + void __iomem *virt; > + unsigned long size; > +}; > + > +struct sh_pfc_pin_range; > + > +struct sh_pfc { > + struct device *dev; > + const struct sh_pfc_soc_info *info; > + spinlock_t lock; > + > + unsigned int num_windows; > + struct sh_pfc_window *windows; > + unsigned int num_irqs; > + unsigned int *irqs; > + > + struct sh_pfc_pin_range *ranges; > + unsigned int nr_ranges; > + > + unsigned int nr_gpio_pins; > + > + struct sh_pfc_chip *gpio; > +#ifdef CONFIG_SUPERH > + struct sh_pfc_chip *func; > +#endif > +}; > > struct sh_pfc_soc_operations { > int (*init)(struct sh_pfc *pfc); -- Regards, Laurent Pinchart

Re: [PATCH] clk: renesas: r8a7795: Correct lvds clock parent

2016-06-10 Thread Laurent Pinchart
he > rcar-du LVDS encoder driver doesn't use the parent clock's rate. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > Will queue in clk-renesas-for-v4.8. > > drivers/cl

Re: [PATCH] pinctrl: sh-pfc: sh7757: Fix duplicate initializer in GPIO pinmux data

2016-06-10 Thread Laurent Pinchart
Remove the duplicate initializer to fix this. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > Based on the comment near the definition of A16_MARK, which states A16 > belongs to the &quo

Re: [PATCH 0/2 v2] drm: rcar-du: EPROBE_DEFER case doesn't need error message

2016-06-10 Thread Laurent Pinchart
Hi Morimoto-san, On Wednesday 25 May 2016 00:38:48 Kuninori Morimoto wrote: > Hi David, Laurent > > These removes unneeded error message from Renesas DU driver. > Current this unneeded error message makes user confuse. Thank you for the patches. For both of them, Reviewed-by: Laur

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

2016-06-13 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Thursday 09 Jun 2016 14:41:32 Kieran Bingham wrote: > The FCP driver, can also support the FCPF variant for FDP1 compatible > processing. With the comma dropped, Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed

Re: [PATCH 4/4] rcar-du: add R8A7794 TCON support

2016-05-27 Thread Laurent Pinchart
e datasheet TCON can be connected to both DU0 and DU1. > + .encoder_type = DRM_MODE_ENCODER_TCON, > + .port = 2, > + }, > }, > .num_lvds = 0, > + .num_tcon = 1, > }; > > static const struct rcar_du_device_info rcar_du_r8a7795_info = { -- Regards, Laurent Pinchart

Re: [PATCH/RFC v2 1/4] v4l: Add metadata buffer type and format

2016-06-22 Thread Laurent Pinchart
g the image media bus format affects the metadata media > bus format. I guess that could be mentioned albeit it's hardware specific, > on some sensors metadata width is independent of the image width. Even then > this is not where I'd put it. I'd get back to the topic when documenting > how the API for multiple streams over a single link works. -- Regards, Laurent Pinchart

Re: [PATCH 1/2] [media] v4l: vsp1: Split pad operations between rpf and wpf

2016-06-22 Thread Laurent Pinchart
_ops once s_stream is > moved. > > Suggested-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> > --- > drivers/media/platform/vsp1/vsp1_rpf.c | 12 +- > dr

Re: [PATCH 7/7] drm/rcar-du: Remove redundant calls to drm_connector_register_all()

2016-06-21 Thread Laurent Pinchart
an > move drm_connector_register_all() to drm_dev_register() and not suffer > from any backwards compatibility issues with drivers not following the > more rigorous init ordering. > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vet

Re: [PATCH/RFC v2 1/4] v4l: Add metadata buffer type and format

2016-06-22 Thread Laurent Pinchart
Hi Hans, Thank you for the review. On Monday 23 May 2016 12:09:16 Hans Verkuil wrote: > On 05/12/2016 02:18 AM, Laurent Pinchart wrote: > > The metadata buffer type is used to transfer metadata between userspace > > and kernelspace through a V4L2 buffers queue. It comes with a n

[PATCH 22/24 v1.1] v4l: vsp1: wpf: Add flipping support

2016-06-21 Thread Laurent Pinchart
Vertical flipping is available on both Gen2 and Gen3, while horizontal flipping is only available on Gen3. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- Changes since v1: - Initialize the wpf.flip.lock spinlock Geert, I've updated the for/renesas-drivers

[PATCH 00/24] R-Car VSP1: Histogram, look-up table and flip support

2016-06-20 Thread Laurent Pinchart
l flipping (20/24 to 22/24) and doesn't attempt to access freed buffers anymore (24/24). I plan to send a pull request for v4.8 as soon as the previous pull request gets merged. Laurent Pinchart (24): v4l: Add metadata buffer type and format v4l: Define a pixel format for the R-Car VSP1 1-D

[PATCH 01/24] v4l: Add metadata buffer type and format

2016-06-20 Thread Laurent Pinchart
The metadata buffer type is used to transfer metadata between userspace and kernelspace through a V4L2 buffers queue. It comes with a new metadata capture capability and format description. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- Documentation/D

[PATCH 10/24] v4l: vsp1: Set entities functions

2016-06-20 Thread Laurent Pinchart
Initialize the function field of all subdev entities instantiated by the driver. This gets rids of multiple warnings printed by the media controller core. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_bru.c| 3 ++- d

[PATCH 12/24] v4l: vsp1: dl: Don't free fragments with interrupts disabled

2016-06-20 Thread Laurent Pinchart
the garbage collection. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 72 --- 1 file changed, 58 insertions(+), 14 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_dl.c b/d

[PATCH 04/24] v4l: vsp1: Don't create HGO entity when the userspace API is disabled

2016-06-20 Thread Laurent Pinchart
The HGO is never used in the DRM pipeline, there is thus no need to create an HGO entity when the userspace API is disabled. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 de

[PATCH 09/24] v4l: vsp1: Don't create LIF entity when the userspace API is enabled

2016-06-20 Thread Laurent Pinchart
-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_drv.c b/drivers/media/platform/vsp1/vsp1_drv.c index cd56ca

[PATCH 03/24] v4l: vsp1: Add HGO support

2016-06-20 Thread Laurent Pinchart
The HGO is a Histogram Generator One-Dimension. It computes per-channel histograms over a configurable region of the image with optional subsampling. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/Kconfig| 1 + drivers

[PATCH 02/24] v4l: Define a pixel format for the R-Car VSP1 1-D histogram engine

2016-06-20 Thread Laurent Pinchart
The format is used on the R-Car VSP1 video queues that carry 1-D histogram statistics data. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Acked-by: Sakari Ailus <sakari.ai...@linux.intel.com> --- .../DocBook/media/v4l/pixfmt-meta-vsp1-hgo.x

[PATCH 14/24] v4l: vsp1: lut: Expose configuration through a control

2016-06-20 Thread Laurent Pinchart
Replace the custom ioctl with a V4L2 control in order to standardize the API. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_lut.c | 76 +++--- drivers/media/platform/vsp1/vsp1_lut.h | 6 +-- i

[PATCH 16/24] v4l: vsp1: sru: Fix intensity control ID

2016-06-20 Thread Laurent Pinchart
The intensity control reused the V4L2_CID_CONTRAST control ID by mistake. Fix it by using an ID from the device-specific IDs range. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_sru.c | 2 +- 1 file changed, 1 insertion

[PATCH 08/24] v4l: vsp1: Don't register media device when userspace API is disabled

2016-06-20 Thread Laurent Pinchart
The media device doesn't need to be exposed to userspace when the VSP is fully controlled by the DU driver. Don't register it in that case. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 16 +--- 1 file c

[PATCH 15/24] v4l: vsp1: Add Cubic Look Up Table (CLU) support

2016-06-20 Thread Laurent Pinchart
The CLU processing block is a 2D/3D lookup table that converts the input three color component data into desired three color components using a lookup table. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/Makefile

[PATCH 23/24] v4l: vsp1: Constify operation structures

2016-06-20 Thread Laurent Pinchart
The structures are never modified, make them const. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_bru.c | 4 ++-- drivers/media/platform/vsp1/vsp1_clu.c | 4 ++-- drivers/media/platform/vsp1/vsp1_hgo.c | 4 ++-- d

[PATCH 24/24] v4l: vsp1: Stop the pipeline upon the first STREAMOFF

2016-06-20 Thread Laurent Pinchart
that don't exist anymore. Fix this by stopping the pipeline upon the first STREAMOFF call, not the last. Reported-by: Kuninori Morimoto <kuninori.morimoto...@renesas.com> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video

Re: [PATCH 2/8] media: rcar_vin: Use correct pad number in try_fmt

2016-06-16 Thread Laurent Pinchart
fill_pix_format(pix, ); > > @@ -121,6 +127,8 @@ static int __rvin_try_format_source(struct rvin_dev > *vin, vin_dbg(vin, "Source resolution: %ux%u\n", source->width, > source->height); > > +cleanup: Nitpicking, I'd name the label "done". > + v4l2_subdev_free_pad_config(pad_cfg); > return 0; > } -- Regards, Laurent Pinchart

Re: [PATCH 1/8] media: rcar-vin: pad-aware driver initialisation

2016-06-16 Thread Laurent Pinchart
@ctrl_handler:V4L2 control handler > * @notifier:V4L2 asynchronous subdevs notifier > * @entity: entity in the DT for subdevice > @@ -117,6 +118,7 @@ struct rvin_dev { > > struct video_device vdev; > struct v4l2_device v4l2_dev; > + int src_pad_idx; > struct v4l2_ctrl_handler ctrl_handler; > struct v4l2_async_notifier notifier; > struct rvin_graph_entity entity; -- Regards, Laurent Pinchart

Re: [PATCH 3/4] dma: rcar-dma: Fixed active descriptor initializing

2016-06-15 Thread Laurent Pinchart
tart new transfers > > Signed-off-by: Muhammad Hamza Farooq <mfar...@visteon.com> > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Acked-by: Laurent Pinchart <laurent.pinch...@ideason

Re: [PATCH 4/4] dmaengine: rcar-dmac: Fix residue reporting for pending descriptors

2016-06-15 Thread Laurent Pinchart
Hi Niklas, Thank you for the patch. On Wednesday 15 Jun 2016 13:13:08 Niklas Söderlund wrote: > From: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > > Cookies corresponding to pending transfers have a residue value equal to > the full size of the corres

Re: [PATCH 2/4] dmaengine: rcar-dmac: warn if transfer cannot start as TE = 1

2016-06-15 Thread Laurent Pinchart
sed on previous work from Muhammad Hamza Farooq. > > Suggested-by: Muhammad Hamza Farooq <mfar...@visteon.com> > Signed-off-by: Niklas Söderlund <niklas.soderlund+rene...@ragnatech.se> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > driver

Re: [PATCH 5/8] [media] rcar-vin: add Gen3 HW registers

2016-06-16 Thread Laurent Pinchart
> + max_width = RVIN_MAX_WIDTH_GEN3; > + max_height = RVIN_MAX_HEIGHT_GEN3; > + } else { > + max_width = RVIN_MAX_WIDTH; > + max_height = RVIN_MAX_HEIGHT; > + } This is one example where I think a device info structure would help. You could store there the maximum width and height, and remove the condition here. Again, no need to change this now as long as we don't have too many such checks. > + v4l_bound_align_image(>width, 2, max_width, walign, > + >height, 4, max_height, 2, 0); > > switch (pix->field) { > case V4L2_FIELD_NONE: > diff --git a/drivers/media/platform/rcar-vin/rcar-vin.h > b/drivers/media/platform/rcar-vin/rcar-vin.h index 81780f1..b97fa43 100644 > --- a/drivers/media/platform/rcar-vin/rcar-vin.h > +++ b/drivers/media/platform/rcar-vin/rcar-vin.h > @@ -32,6 +32,7 @@ > #define HW_BUFFER_MASK 0x7f > > enum chip_id { > + RCAR_GEN3, > RCAR_GEN2, > RCAR_H1, > RCAR_M1, Nitpicking, it looks weird to me to list them in reverse chronological order, I'd order them as RCAR_H1 RCAR_M1 RCAR_GEN2 RCAR_GEN3 Another node -- Regards, Laurent Pinchart

Re: [PATCH/RFC v2 4/4] v4l: vsp1: Add HGO support

2016-06-24 Thread Laurent Pinchart
Hi Guennadi, On Monday 13 Jun 2016 17:33:01 Guennadi Liakhovetski wrote: > On Thu, 12 May 2016, Laurent Pinchart wrote: > > The HGO is a Histogram Generator One-Dimension. It computes per-channel > > histograms over a configurable region of the image with optional > > subsamp

[PATCH v3 00/35] VSP: Add R-Car Gen3 support

2016-02-08 Thread Laurent Pinchart
is the usage of the IP version register instead of DT properties to configure device parameters such as the number of BRU inputs or the availability of the BRU. Laurent Pinchart (34): v4l: Add YUV 4:2:2 and YUV 4:4:4 tri-planar non-contiguous formats v4l: vsp1: Add tri-planar memory formats

[PATCH v3 20/35] v4l: vsp1: Fix typo in VI6_DISP_IRQ_STA_DST register bit name

2016-02-08 Thread Laurent Pinchart
Rename the VI6_DISP_IRQ_STA_DSE register bit to VI6_DISP_IRQ_STA_DST to fix a typo and match the datasheet. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH v3 18/35] v4l: vsp1: Extract link creation to separate function

2016-02-08 Thread Laurent Pinchart
Link creation will be handled differently for the DU pipeline. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 95 -- 1 file changed, 56 insertions(+), 39 deletions(-) diff --git a/d

[PATCH v3 23/35] v4l: vsp1: Move entity route setup function to vsp1_entity.c

2016-02-08 Thread Laurent Pinchart
The function will be used by the DU code, move it out of vsp1_video.c. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_entity.c | 12 drivers/media/platform/vsp1/vsp1_entity.h | 2 ++ drivers/media/platfor

[PATCH v3 07/35] v4l: vsp1: Rename vsp1_video_buffer to vsp1_vb2_buffer

2016-02-08 Thread Laurent Pinchart
The structure represent a vsp1 videobuf2 buffer, name it accordingly. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_rpf.c | 2 +- drivers/media/platform/vsp1/vsp1_rwpf.h | 4 ++-- drivers/media/platform/vsp1/vsp1_v

[PATCH v3 13/35] v4l: vsp1: Decouple pipeline end of frame processing from vsp1_video

2016-02-08 Thread Laurent Pinchart
To make the pipeline structure and operations usable without video devices the frame end processing must be decoupled from struct vsp1_video. Implement this by calling the video frame end function indirectly through a function pointer in struct vsp1_pipeline. Signed-off-by: Laurent Pinchart

[PATCH v3 12/35] v4l: vsp1: Remove struct vsp1_pipeline num_video field

2016-02-08 Thread Laurent Pinchart
The field is always equal to the num_inputs field plus one, remove the duplicate. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 7 ++- drivers/media/platform/vsp1/vsp1_video.h | 1 - 2 files changed, 2 inse

[PATCH v3 04/35] v4l: vsp1: Change the type of the rwpf field in struct vsp1_video

2016-02-08 Thread Laurent Pinchart
The rwpf field contains a pointer to the rpf or wpf associated with the video node. Instead of storing it as a vsp1_entity, store the corresponding vsp1_rwpf pointer to allow accessing the vsp1_rwpf fields directly. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.

[PATCH v3 03/35] v4l: vsp1: Group all link creation code in a single file

2016-02-08 Thread Laurent Pinchart
There's no need to spread the code across multiple source files. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 50 +++-- drivers/media/platform/vsp1/vsp1_rpf.c | 20 - d

[PATCH v3 35/35] v4l: vsp1: Add display list support

2016-02-08 Thread Laurent Pinchart
queued to the hardware without waiting for the end of the current frame. Display list support is currently limited to the DRM pipeline. Signed-off-by: Koji Matsuoka <koji.matsuoka...@renesas.com> Signed-off-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> --- Changes since v2

[PATCH v3 05/35] v4l: vsp1: Store the memory format in struct vsp1_rwpf

2016-02-08 Thread Laurent Pinchart
Move the format from struct vsp1_video to struct vsp1_rwpf to prepare for VSPD KMS support that will not instantiate V4L2 video device nodes. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_bru.c | 4 ++-- drivers/media/pl

[PATCH v3 33/35] v4l: vsp1: Implement atomic update for the DRM driver

2016-02-08 Thread Laurent Pinchart
restarting the video stream. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 70 +- drivers/media/platform/vsp1/vsp1_drm.h | 7 include/media/vsp1.h | 9 +++-- 3

[PATCH v3 32/35] v4l: vsp1: Disconnect unused RPFs from the DRM pipeline

2016-02-08 Thread Laurent Pinchart
Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_drm.c b/drivers/media/platform/vsp1/vsp1_drm.c index ac81ff

[PATCH v3 25/35] v4l: vsp1: Make the BRU optional

2016-02-08 Thread Laurent Pinchart
Not all VSP instances have a BRU on R-Car Gen3, make it optional. Set the feature unconditionally for now, this will be fixed when adding Gen3 support. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1.h | 1 + drivers

[PATCH v3 29/35] v4l: vsp1: Set the alpha value manually in RPF and WPF s_stream handlers

2016-02-08 Thread Laurent Pinchart
-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_rpf.c | 16 ++-- drivers/media/platform/vsp1/vsp1_rwpf.h | 2 ++ drivers/media/platform/vsp1/vsp1_wpf.c | 7 --- 3 files changed, 20 insertions(+), 5 deletions(-) diff --git a/d

[PATCH v3 34/35] v4l: vsp1: Add support for the R-Car Gen3 VSP2

2016-02-08 Thread Laurent Pinchart
Add DT compatible strings for the VSP2 instances found in the R-Car Gen3 SoCs and support them in the vsp1 driver. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- .../devicetree/bindings/media/renesas,vsp1.txt | 20 --- drivers/media/platfor

[PATCH v3 15/35] v4l: vsp1: Rename video pipeline functions to use vsp1_video prefix

2016-02-08 Thread Laurent Pinchart
Those functions are specific to video nodes, rename them for consistency. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff

[PATCH v3 28/35] v4l: vsp1: Make pipeline inputs array index by RPF index

2016-02-08 Thread Laurent Pinchart
+DU support. Make the array indexed by RPF index instead and skip NULL elements when iterating over RPFs. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_pipe.c | 6 +- drivers/media/platform/vsp1/vsp1_pipe.h | 2 +- d

[PATCH v3 10/35] v4l: vsp1: Support VSP1 instances without any UDS

2016-02-08 Thread Laurent Pinchart
Not all VSP1 instances include a UDS. Make the renesas,#uds DT property optional and accept a number of UDS equal to 0 as valid. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- Documentation/devicetree/bindings/media/renesas,vsp1.txt | 3 ++- drivers

[PATCH v3 02/35] v4l: vsp1: Add tri-planar memory formats support

2016-02-08 Thread Laurent Pinchart
Tri-planar memory formats store the Y, U and V components in separate planes. The VSP hardware supports them, the driver now does too. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 20

[PATCH v3 24/35] v4l: vsp1: Make number of BRU inputs configurable

2016-02-08 Thread Laurent Pinchart
The R-Car Gen3 family has 5-inputs BRUs, support them by making the number of BRU inputs configurable. As the driver assumes that the number of BRU inputs is equal to the number of RPFs, replace the BRU_MAX_INPUTS macro with VSP1_MAX_RPF to make the assumption apparent. Signed-off-by: Laurent

[PATCH v3 16/35] v4l: vsp1: Extract pipeline initialization code into a function

2016-02-08 Thread Laurent Pinchart
The code will be reused outside of vsp1_video.c. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_pipe.c | 10 ++ drivers/media/platform/vsp1/vsp1_pipe.h | 1 + drivers/media/platform/vsp1/vsp1_video.c | 6 +--

[PATCH v3 08/35] v4l: vsp1: Move video device out of struct vsp1_rwpf

2016-02-08 Thread Laurent Pinchart
To make the video device nodes optional we need to decouple the [rw]pf instances from the video devices. Move video devices out of struct vsp1_rwpf and instantiate them dynamically in the core driver code. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- d

[PATCH v3 14/35] v4l: vsp1: Split pipeline management code from vsp1_video.c

2016-02-08 Thread Laurent Pinchart
The code will be used to control the vsp1 driver from the DU driver without using video nodes. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/Makefile | 3 +- drivers/media/platform/vsp1/vsp1_pipe.c

[PATCH v3 17/35] v4l: vsp1: Reuse local variable instead of recomputing it

2016-02-08 Thread Laurent Pinchart
No need to waste CPU cycles when the value we need is already available. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platfor

[PATCH v3 09/35] v4l: vsp1: Make rwpf operations independent of video device

2016-02-08 Thread Laurent Pinchart
The rwpf queue operation doesn't queue a buffer but sets the memory address for the next run. Rename it to set_memory and pass it a new structure independent of the video buffer than only contains memory information. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.

Re: [PATCH v3 7/8] ARM: dts: r8a7790: add iommus to dmac0 and dmac1

2016-02-10 Thread Laurent Pinchart
las Söderlund <niklas.soderlund+rene...@ragnatech.se> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Same comment and ack for patch 8/8. Note that we should still try to find a way to selectively enable the IOMMU in a per-device fashion, as system integra

Re: [PATCH v3 6/8] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-02-10 Thread Laurent Pinchart
>src_addr_width); > + if (ret) > + return ret; > + > + ret = rcar_dmac_set_slave_addr(chan, >dst, cfg->dst_addr, > + cfg->dst_addr_width); You could align cfg with chan on the previous line (twice). With this fixed and the attributes removed as explained by Robin, Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > + return ret; > } > > static int rcar_dmac_chan_terminate_all(struct dma_chan *chan) -- Regards, Laurent Pinchart

Re: [PATCH v4] adv7604: add direct interrupt handling

2016-02-09 Thread Laurent Pinchart
Hi Ulrich, Thank you for the patch. On Tuesday 09 February 2016 17:40:19 Ulrich Hecht wrote: > When probed from device tree, the i2c client driver can handle the > interrupt on its own. > > Signed-off-by: Ulrich Hecht <ulrich.hecht+rene...@gmail.com> > Reviewed

[PATCH/RFC 2/9] clk: shmobile: r8a7795: Add LVDS module clock

2016-02-11 Thread Laurent Pinchart
The parent clock hasn't been validated yet. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/clk/shmobile/r8a7795-cpg-mssr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/shmobile/r8a7795-cpg-mssr.c b/drivers/clk/shmobile/r8a77

[PATCH/RFC 7/9] ARM64: renesas: r8a7795: Add VSP instances

2016-02-11 Thread Laurent Pinchart
[5.315395] x5 : x4 : [5.318044] x3 : x2 : [5.320694] x1 : x0 : Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- arch/arm64/boot/dts/re

[PATCH/RFC 6/9] ARM64: renesas: r8a7795: Add FCPV nodes

2016-02-11 Thread Laurent Pinchart
The FCPs handle the interface between various IP cores and memory. Add the instances related to the VSP2s. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 63 1 file changed, 63 inse

[PATCH/RFC 4/9] v4l: vsp1: VSPD instances have no LUT on Gen3

2016-02-11 Thread Laurent Pinchart
Remove the HAS_LUT flag in the corresponding device information entry. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vsp1/vsp1

[PATCH/RFC 9/9] ARM64: renesas: salvator-x: Enable DU

2016-02-11 Thread Laurent Pinchart
Only the VGA output is supported for now. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 44 ++ 1 file changed, 44 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795-sa

[PATCH/RFC 8/9] ARM64: renesas: r8a7795: Add DU device to DT

2016-02-11 Thread Laurent Pinchart
Add the DU device to r8a7795.dtsi in a disabled state. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 46 1 file changed, 46 insertions(+) diff --git a/arch/arm64/boot/dts/r

[PATCH/RFC 5/9] v4l: vsp1: Add FCP support

2016-02-11 Thread Laurent Pinchart
On some platforms the VSP performs memory accesses through an FCP. When that's the case get a reference to the FCP from the VSP DT node and enable/disable it at runtime as needed. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- .../devicetree/bindings

[PATCH 0/2] Renesas VSP1: Fix DRM API header

2016-02-24 Thread Laurent Pinchart
ies on top of the vsp1 branch, but doesn't have to be merged into it as it's not a dependency for the DRM pull request I've sent. I'll thus send you a normal pull request for this once the patches will be reviewed. Laurent Pinchart (2): v4l: vsp1: Fix vsp1_du_atomic_(begin|flush) declarations v4l:

[PATCH 1/2] v4l: vsp1: Fix vsp1_du_atomic_(begin|flush) declarations

2016-02-24 Thread Laurent Pinchart
The functions are void, make the declaration match the definition. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- include/media/vsp1.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/media/vsp1.h b/include/media/vsp1.h

[PATCH 2/2] v4l: vsp1: drm: Include correct header file

2016-02-24 Thread Laurent Pinchart
The VSP1 DRM API is declared in , not . Fix it. This also reverts commit 18922936dc28 ("[media] vsp1_drm.h: add missing prototypes") that added the same declarations in a different header file. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- driver

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

2016-02-22 Thread Laurent Pinchart
Hi Simon, On Tuesday 23 February 2016 09:11:03 Simon Horman wrote: > On Mon, Feb 22, 2016 at 03:05:58PM +0200, Laurent Pinchart wrote: > > On Monday 22 February 2016 13:39:37 Geert Uytterhoeven wrote: > >> On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart wrote: > >>&

Re: [PATCH] fbdev: sh_mobile_lcdc: Use ARCH_RENESAS

2016-02-22 Thread Laurent Pinchart
Hi Geert, On Monday 22 February 2016 13:39:37 Geert Uytterhoeven wrote: > On Mon, Feb 22, 2016 at 1:24 PM, Laurent Pinchart wrote: > > On Monday 22 February 2016 10:59:51 Simon Horman wrote: > >> Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > >> > >>

Re: [PATCH] media: platform: rcar_jpu, sh_vou, vsp1: Use ARCH_RENESAS

2016-02-23 Thread Laurent Pinchart
ENESAS seems to be a more > appropriate name than SHMOBILE for the majority of Renesas ARM based SoCs. > > Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > --- > drivers/media/platform/Kconfig | 6 +++--

Re: [PATCH] v4l2: remove MIPI CSI-2 driver for SH-Mobile platforms

2016-02-23 Thread Laurent Pinchart
the master branch of media_tree -- Regards, Laurent Pinchart

Re: [PATCH/RFC v2 00/11] ARM/arm64: renesas: Add SYSC PM Domain DT Support

2016-02-28 Thread Laurent Pinchart
Hi Geert, On Sunday 28 February 2016 09:55:32 Geert Uytterhoeven wrote: > On Sat, Feb 27, 2016 at 2:53 AM, Laurent Pinchart wrote: > > After rebasing this series on top of Simon's latest devel branch, I'm > > experiencing hard system freezes when using the VSP. > > Is thi

[PATCH] arm64: dts: r8a7795: Remove the A3SH power domain

2016-02-28 Thread Laurent Pinchart
The power domain is not documented in the latest version of the datasheet, and turning it off causes the whole system to freeze the next time a power domain is turned on. Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7795.dt

Re: [PATCH/RFC v2 00/11] ARM/arm64: renesas: Add SYSC PM Domain DT Support

2016-02-28 Thread Laurent Pinchart
Hi Geert, Here's an update. On Sunday 28 February 2016 17:04:47 Laurent Pinchart wrote: > On Sunday 28 February 2016 09:55:32 Geert Uytterhoeven wrote: > > On Sat, Feb 27, 2016 at 2:53 AM, Laurent Pinchart wrote: > >> After rebasing this series on top of Simon's latest

Re: [PATCH/RFC 1/9] clk: shmobile: r8a7795: Add FCP clocks

2016-02-26 Thread Laurent Pinchart
Hi Morimoto-san, On Friday 12 February 2016 04:00:42 Laurent Pinchart wrote: > The parent clock isn't documented in the datasheet, use S2D1 as a best > guess for now. Would you be able to find out what the parent clock is for the FCP and LVDS (patch 2/9) clocks ? Feel free t

  1   2   3   4   5   6   7   8   9   10   >