Re: [PATCH] dmaengine: rcar-dmac: Make DMAC reinit during system resume explicit

2018-01-17 Thread Vinod Koul
ansson > Signed-off-by: Geert Uytterhoeven > --- > This is a dependency for "[PATCH 1/2] PM / genpd: Stop/start devices > without pm_runtime_force_suspend/resume()" > (https://www.spinics.net/lists/kernel/msg2696802.html), so perhaps it > makes most sense if Rafael takes it thro

Re: [PATCH] DT: dma: renesas,rcar-dmac: document R8A77980 support

2018-02-04 Thread Vinod Koul
On Thu, Feb 01, 2018 at 10:09:25PM +0300, Sergei Shtylyov wrote: > Renesas R-Car V3H SoC has the R-Car gen3 compatible DMA controllers. > Document R-Car V3H (also known as R8A77980) SoC bindings. Applied, thanks -- ~Vinod

Re: [PATCH v2] dmaengine: rcar-dmac: Widen DMA mask to 40 bits

2017-02-13 Thread Vinod Koul
On Mon, Feb 13, 2017 at 12:00:26PM +0100, Geert Uytterhoeven wrote: > By default, the DMA mask covers only the low 32-bit address space, which > causes SWIOTLB on arm64 to fall back to a bounce buffer for DMA > transfers involving memory outside the 32-bit address space. > > The R-Car DMA controll

Re: [PATCH v3] dmaengine: rcar-dmac: enable descriptor mode on 40bit

2017-03-26 Thread Vinod Koul
On Wed, Mar 22, 2017 at 04:22:36AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > SYS-DMAC can use 40bit address transfer, and it supports Descriptor > Mode too. Current SYS-DMAC driver disables Descriptor Mode if it was > 40bit address today. But it can use Descriptor Mode with

Re: [PATCH 3/3] dmaengine: rcar-dmac: wait for ISR to finish before freeing resources

2017-04-04 Thread Vinod Koul
On Thu, Mar 30, 2017 at 09:38:39AM +0200, Niklas Söderlund wrote: > Hi Geert, > > On 2017-03-29 15:30:42 +0200, Niklas Söderlund wrote: > > Hi Geert, > > > > On 2017-03-29 14:31:33 +0200, Geert Uytterhoeven wrote: > > > Hi Niklas, > > > > > > On Wed, Mar 29, 2017 at 12:40 AM, Niklas Söderlund >

Re: [PATCH 3/3] dmaengine: rcar-dmac: wait for ISR to finish before freeing resources

2017-05-14 Thread Vinod Koul
> > > > On 2017-04-05 08:55:31 +0530, Vinod Koul wrote: > > > >> On Thu, Mar 30, 2017 at 09:38:39AM +0200, Niklas Söderlund wrote: > > > >>> On 2017-03-29 15:30:42 +0200, Niklas Söderlund wrote: > > > >>>> On 2017-03-29 14:31:33 +0200

Re: [PATCH] dmaengine: usb-dmac: Fix DMAOR AE bit definition

2017-05-15 Thread Vinod Koul
On Mon, May 15, 2017 at 05:49:52PM +0900, Yoshihiro Shimoda wrote: > From: Hiroyuki Yokoyama > > This patch fixes the register definition of AE (Address Error flag) bit. Applied, thanks -- ~Vinod

Re: [PATCH v2 1/3] dmaengine: rcar-dmac: store channel IRQ in struct rcar_dmac_chan

2017-05-18 Thread Vinod Koul
On Tue, May 16, 2017 at 01:09:15AM +0200, Niklas Söderlund wrote: > The IRQ number is needed after probe to be able to add synchronisation > points in other places in the driver when freeing resources and to > implement a device_synchronize() callback. Store the IRQ number in the > struct rcar_dmac

Re: [PATCH v2 1/3] dmaengine: rcar-dmac: store channel IRQ in struct rcar_dmac_chan

2017-05-19 Thread Vinod Koul
On Fri, May 19, 2017 at 08:59:03AM +0200, Geert Uytterhoeven wrote: > Hi Vinod, > > On Fri, May 19, 2017 at 5:51 AM, Vinod Koul wrote: > > On Tue, May 16, 2017 at 01:09:15AM +0200, Niklas Söderlund wrote: > >> The IRQ number is needed after probe to be able to add synchr

Re: [PATCH v2 0/3] dmaengine: rcar-dmac: fix resource freeing synchronization

2017-05-19 Thread Vinod Koul
On Tue, May 16, 2017 at 01:09:14AM +0200, Niklas Söderlund wrote: > Hi, > > This series fix resource freeing synchronization by: > > 1. Patch 1/3 >Store the IRQ number in the global struct so it can be used later >together with synchronize_irq(). > > 2. Patch 2/3 >Adding support for

Re: [PATCH] dt-bindings: rcar-dmac: Document missing error interrupt

2017-05-19 Thread Vinod Koul
On Fri, May 19, 2017 at 09:27:47AM +0200, Geert Uytterhoeven wrote: > The documentation for the "interrupt-names" property only mentions the > per-channel interrupts, while the error interrupt has always been > mandatory, too. Applied, thanks -- ~Vinod

Re: [PATCH 1/7] dmaengine: use proper name for the R-Car SoC

2017-06-01 Thread Vinod Koul
On Sun, May 28, 2017 at 11:30:44AM +0200, Wolfram Sang wrote: > It is 'R-Car', not 'r-car'. No code or binding changes, only descriptive text. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: rcar-dmac: fix max_chunk_size for R-Car Gen3

2018-02-27 Thread Vinod Koul
On Wed, Feb 14, 2018 at 06:40:12PM +0900, Yoshihiro Shimoda wrote: > According to R-Car Gen3 Rev.0.80 manual, the DMATCR can be set to > 16,777,215 as maximum. So, this patch fixes the max_chunk_size for > safety on all of SoCs. Otherwise, a system may hang if the DMATCR > is set to 0 on R-Car Gen3

Re: [PATCH] dmaengine: usb-dmac: add binding for r8a77965

2018-03-04 Thread Vinod Koul
On Tue, Feb 27, 2018 at 02:54:56PM +0900, Yoshihiro Shimoda wrote: > This patch adds binding for r8a77965 (R-Car M3-N). Applied, thanks > > Signed-off-by: Yoshihiro Shimoda > --- > Documentation/devicetree/bindings/dma/renesas,usb-dmac.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --gi

Re: [PATCH] dmaengine: rcar-dmac: Check the done lists in rcar_dmac_chan_get_residue()

2018-03-05 Thread Vinod Koul
On Fri, Feb 02, 2018 at 07:05:15PM +0900, Yoshihiro Shimoda wrote: > This patch fixes an issue that a race condition happens between a client > driver and the rcar-dmac driver: > > - The rcar_dmac_isr_transfer_end() is called. > - The done list appears, and desc.running is the next active list. >

Re: [PATCH] dmaengine: rcar-dmac: Fix too early/late system suspend/resume callbacks

2018-04-03 Thread Vinod Koul
On Thu, Mar 29, 2018 at 06:53:32PM +0200, Geert Uytterhoeven wrote: > If serial console wake-up is enabled ("echo enabled > > /sys/.../ttySC0/power/wakeup"), and any serial input is received while > the system is suspended, serial port input no longer works after system > resume. > > Note that: >

Re: [PATCH] dt-bindings: rcar-dmac: Document r8a77470 support

2018-04-03 Thread Vinod Koul
On Thu, Mar 29, 2018 at 11:11:06AM +0100, Biju Das wrote: > Renesas RZ/G SoC also have the R-Car gen2/3 compatible DMA controllers. > Document RZ/G1C (also known as R8A77470) SoC bindings. Applied, thanks -- ~Vinod

Re: [PATCH 07/61] dma: simplify getting .drvdata

2018-04-21 Thread Vinod Koul
On Thu, Apr 19, 2018 at 04:05:37PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. Do you mind splitting this per driver please, that makes it easy to manage for me :) -- ~Vinod

Re: [PATCH 08/61] dmaengine: dw: simplify getting .drvdata

2018-04-21 Thread Vinod Koul
On Thu, Apr 19, 2018 at 04:05:38PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. Applied, thanks -- ~Vinod

Re: [PATCH 09/61] dmaengine: qcom: simplify getting .drvdata

2018-04-21 Thread Vinod Koul
On Thu, Apr 19, 2018 at 04:05:39PM +0200, Wolfram Sang wrote: > We should get drvdata from struct device directly. Going via > platform_device is an unneeded step back and forth. Applied, thanks -- ~Vinod

Re: [PATCH 2/8] dmaengine: shdmac: Change platform check to CONFIG_ARCH_RENESAS

2018-04-25 Thread Vinod Koul
On Fri, Apr 20, 2018 at 03:28:28PM +0200, Geert Uytterhoeven wrote: > Since commit 9b5ba0df4ea4f940 ("ARM: shmobile: Introduce ARCH_RENESAS") > is CONFIG_ARCH_RENESAS a more appropriate platform check than the legacy > CONFIG_ARCH_SHMOBILE, hence use the former. > > Renesas SuperH SH-Mobile SoCs a

Re: [PATCH v4] dmaengine: rcar-dmac: Document R-Car D3 bindings

2018-04-27 Thread Vinod Koul
On Tue, Apr 24, 2018 at 10:51:06AM +0200, Simon Horman wrote: > From: Ulrich Hecht > > R8A77995's SYS-DMAC is R-Car Gen3-compatible. Applied, thanks -- ~Vinod

Re: [PATCH 1/2] dmaengine: usb-dmac: Document R8A7799{0,5} bindings

2018-05-17 Thread Vinod Koul
On 16-05-18, 15:06, Ulrich Hecht wrote: > From: Hiroyuki Yokoyama > > Renesas R-Car D3 (R8A77995) and E3 (R8A77990) SoCs also have the R-Car > gen2/3 compatible DMA controllers, so document the SoC specific binding. Applied, thanks -- ~Vinod

Re: [PATCH 2/2] dmaengine: rcar-dmac: Document R8A77990 bindings

2018-05-17 Thread Vinod Koul
On 16-05-18, 15:06, Ulrich Hecht wrote: > From: Hiroyuki Yokoyama > > Renesas R-Car E3 (R8A77990) SoC also has the R-Car gen2/3 compatible DMA > controllers, so document the SoC specific binding. This fails to apply for me, please rebase and send -- ~Vinod

Re: [PATCH] dmaengine: rcar-dmac: Document R8A774A1 bindings

2018-11-11 Thread Vinod Koul
On 08-11-18, 13:59, Fabrizio Castro wrote: > Thank you Simon for getting back to me. > > Vinod, does this patch look ok to you? This does not appear in my queue, please resend and collect the acks received if any as well Thanks -- ~Vinod

Re: [PATCH 4/6] dt-bindings: dmaengine: usb-dmac: Add binding for r8a774a1

2018-11-11 Thread Vinod Koul
On 08-11-18, 14:21, Simon Horman wrote: > On Thu, Nov 08, 2018 at 12:48:46PM +, Fabrizio Castro wrote: > > Dear All, > > > > Who is the best person to take this patch? > > I believe this one is for Vinod. Please resend it, it is not in my queue -- ~Vinod

Re: [PATCH v2] dmaengine: sh: Remove R-Mobile APE6 support

2018-11-29 Thread Vinod Koul
On 29-11-18, 12:18, Geert Uytterhoeven wrote: > Renesas R-Mobile APE6 support is currently unused: > - DMA slaves were never enabled in r8a73a4.dtsi, > - The driver relies on legacy filter matching and describing all > slaves and MID/RIDs in a table, unlike modern DMA engine drivers for >

Re: [PATCH v3] dmaengine: sh: Remove R-Mobile APE6 support

2018-12-04 Thread Vinod Koul
On 03-12-18, 15:18, Geert Uytterhoeven wrote: > Renesas R-Mobile APE6 support is currently unused: > - DMA slaves were never enabled in r8a73a4.dtsi, > - The driver relies on legacy filter matching and describing all > slaves and MID/RIDs in a table, unlike modern DMA engine drivers for >

Re: [PATCH] dmaengine: rcar-dmac: Document R8A774C0 bindings

2018-12-16 Thread Vinod Koul
On 13-12-18, 20:17, Fabrizio Castro wrote: > Renesas' RZ/G2E (R8A774C0) SoC has DMA controllers compatible > with this driver, therefore document RZ/G2E specific bindings. Applied, thanks -- ~Vinod

Re: [PATCH] dt-bindings: dmaengine: usb-dmac: Add binding for r8a774c0

2018-12-16 Thread Vinod Koul
On 13-12-18, 20:21, Fabrizio Castro wrote: > This patch adds bindings for the r8a774c0 (RZ/G2E). Applied, thanks -- ~Vinod

Re: [PATCH v2] dmaengine: usb-dmac: Make DMAC system sleep callbacks explicit

2019-01-20 Thread Vinod Koul
On 17-01-19, 17:44, Yoshihiro Shimoda wrote: > From: Phuong Nguyen > > This commit fixes the issue that USB-DMAC hangs silently after system > resumes on R-Car Gen3 hence renesas_usbhs will not work correctly > when using USB-DMAC for bulk transfer e.g. ethernet or serial > gadgets. > > The issu

Re: [PATCH v3 1/2] dmaengine: sh: rcar-dmac: With cyclic DMA residue 0 is valid

2019-04-22 Thread Vinod Koul
On 12-04-19, 07:29, Dirk Behme wrote: > Having a cyclic DMA, a residue 0 is not an indication of a completed > DMA. In case of cyclic DMA make sure that dma_set_residue() is called > and with this a residue of 0 is forwarded correctly to the caller. Applied both, thanks -- ~Vinod

Re: [PATCH] dmaengine: rcar-dmac: Update copyright information

2019-04-26 Thread Vinod Koul
On 25-04-19, 03:52, Yoshihiro Shimoda wrote: > Hi Geert-san, > > > From: Geert Uytterhoeven, Sent: Wednesday, April 24, 2019 9:22 PM > > > > Hi Niklas, Shimoda-san, > > > > On Thu, Apr 11, 2019 at 5:18 PM Niklas Söderlund > > wrote: > > > On 2019-04-11 10:49:37 +0200, Simon Horman wrote: > > >

Re: [PATCH] dmaengine: rcar-dmac: Update copyright information

2019-04-26 Thread Vinod Koul
On 10-04-19, 20:26, Niklas Söderlund wrote: > From: Hiroyuki Yokoyama > > Update copyright and string for Gen3. Applied, thanks -- ~Vinod

Re: [PATCH v2] dmaengine: sudmac: remove unused driver

2019-05-20 Thread Vinod Koul
On 13-05-19, 13:39, Simon Horman wrote: > SUDMAC driver was introduced in v3.10 but was never integrated for use > by any platform. As it is unused remove it. Applied, thanks -- ~Vinod

Re: [PATCHv9 0/6] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-09-15 Thread Vinod Koul
On Wed, Aug 10, 2016 at 11:07:10PM +0530, Vinod Koul wrote: > On Wed, Aug 10, 2016 at 01:22:13PM +0200, Niklas Söderlund wrote: > > Hi, > > > > This series tries to solve the problem with DMA with device registers > > (MMIO registers) that are behind an IOMMU

Re: [PATCHv9 0/6] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-09-26 Thread Vinod Koul
On Wed, Aug 10, 2016 at 01:22:13PM +0200, Niklas Söderlund wrote: > Hi, > > This series tries to solve the problem with DMA with device registers > (MMIO registers) that are behind an IOMMU for the rcar-dmac driver. A > recent patch '9575632 (dmaengine: make slave address physical)' > clarifies th

Re: [PATCH 0/2] dma-mapping: fix ia64 and m32r build error and warnings

2016-09-29 Thread Vinod Koul
On Thu, Sep 29, 2016 at 12:02:38PM +0200, Niklas Söderlund wrote: > From: Niklas Söderlund > > Hi Vindo, :( > > This small series fixes the build error and warnings for ia64 and m32r > which kbuild test robot found and where introduced in the series > '[PATCHv9 0/6] dmaengine: rcar-dmac: add

Re: [PATCH] dma-debug: fix ia64 build, use PHYS_PFN

2016-09-30 Thread Vinod Koul
On Thu, Sep 29, 2016 at 09:59:15PM +0200, Niklas Söderlund wrote: > kbuild test robot reports: > >lib/dma-debug.c: In function 'debug_dma_map_resource': > >> lib/dma-debug.c:1541:16: error: implicit declaration of function > >> '__phys_to_pfn' [-Werror=implicit-function-declaration] > en

Re: [PATCH] DT: dma: rcar-dmac: document R8A7743/5 support

2016-09-30 Thread Vinod Koul
On Thu, Sep 29, 2016 at 01:25:48AM +0300, Sergei Shtylyov wrote: > Renesas RZ/G SoC also have the R-Car gen2/3 compatible DMA controllers. > Document RZ/G1[ME] (also known as R8A774[35]) SoC bindings. Applied, thanks -- ~Vinod

Re: [PATCH dmaengine/next] dmaengine: rcar-dmac: Document R-Car M3-W bindings

2016-11-24 Thread Vinod Koul
On Thu, Nov 24, 2016 at 03:23:06PM +0100, Simon Horman wrote: > From: Ulrich Hecht Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: rcar-dmac: unmap slave resource when channel is freed

2017-01-13 Thread Vinod Koul
On Wed, Jan 11, 2017 at 03:39:31PM +0100, Niklas Söderlund wrote: > The slave mapping should be removed together with other channel > resources when the channel is freed. If it's not unmapped it will hang > around forever after the channel is freed. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: use phys_addr_t for slave configuration

2016-02-15 Thread Vinod Koul
On Tue, Feb 09, 2016 at 11:57:24PM +0100, Wolfram Sang wrote: > > > This is a dependency for adding iommu support to the rcar-dmac driver, cfr. > > "[PATCH v2 0/5] dmaengine: rcar-dmac: add iommu support for slave > > transfers". > > http://www.spinics.net/lists/linux-renesas-soc/msg00066.html >

[PATCH][CFT]: dmaengine: make slave address physical

2016-02-21 Thread Vinod Koul
, we know the dmaengine and always use a specific one. Further the IOMMU cases can lead to failure of this notion, so make this as physical address and now dmaengine driver will do the required mapping. Original-patch-by: Linus Walleij Signed-off-by: Vinod Koul --- include/linux/dmaengine.h | 4

Re: [PATCH][CFT]: dmaengine: make slave address physical

2016-02-22 Thread Vinod Koul
On Mon, Feb 22, 2016 at 05:02:07PM +0200, Laurent Pinchart wrote: > Hi Vinod, > > On Sunday 21 February 2016 20:50:46 Vinod Koul wrote: > > The slave dmaengine semantics required the client to map dma > > addresses and pass DMA address to dmaengine drivers. While this &

Re: [PATCH][CFT]: dmaengine: make slave address physical

2016-02-22 Thread Vinod Koul
On Mon, Feb 22, 2016 at 10:49:08AM +0100, Niklas Söderlund wrote: > Hi Vinod, > > On 2016-02-21 20:50:46 +0530, Vinod Koul wrote: > > The slave dmaengine semantics required the client to map dma > > addresses and pass DMA address to dmaengine drivers. While this > > was

Re: [PATCH][CFT]: dmaengine: make slave address physical

2016-02-22 Thread Vinod Koul
On Mon, Feb 22, 2016 at 01:31:04PM +0100, Wolfram Sang wrote: > On Mon, Feb 22, 2016 at 09:37:10AM +0100, Geert Uytterhoeven wrote: > > Hi Vinod, > > > > On Sun, Feb 21, 2016 at 4:20 PM, Vinod Koul wrote: > > > The slave dmaengine semantics required the client to ma

Re: [PATCH][CFT]: dmaengine: make slave address physical

2016-02-22 Thread Vinod Koul
On Mon, Feb 22, 2016 at 09:37:10AM +0100, Geert Uytterhoeven wrote: > Hi Vinod, > > On Sun, Feb 21, 2016 at 4:20 PM, Vinod Koul wrote: > > The slave dmaengine semantics required the client to map dma > > addresses and pass DMA address to dmaengine drivers. While this > &

Re: [PATCH] dmaengine: sh: shdmac: don't open code of_device_get_match_data()

2016-03-03 Thread Vinod Koul
On Tue, Mar 01, 2016 at 05:37:07PM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > This change will also make Coverity happy by avoiding a theoretical NULL > pointer dereference; yet another reason is to use the above helper function > to tighten the code and make it more readable. Applied,

Re: [PATCH v2] dma: rcar-dmac: clear pertinence number of channels

2016-03-03 Thread Vinod Koul
On Thu, Mar 03, 2016 at 05:25:53PM +0900, Kuninori Morimoto wrote: > From: Kuninori Morimoto > > DMACHCLR clears each channels, but its channel number is based on > its SoC or IP. Current driver is using fixed 0x7fff (= for 15ch), > it is not good match for Gen3 or Gen2 Audio DMAC. This patch fix

Re: [PATCH v4 6/8] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-03-06 Thread Vinod Koul
On Tue, Feb 16, 2016 at 09:39:42PM +0100, Niklas Söderlund wrote: > Enable slave transfers to devices behind IPMMU:s by mapping the slave IPMMU:s ? > addresses using the dma-mapping API. > > Signed-off-by: Niklas Söderlund > Reviewed-by: Laurent Pinchart > --- > drivers/dma/sh/rcar-dmac.c | 5

Re: [PATCH v5 3/9] dma-mapping: add dma_{map,unmap}_resource

2016-03-10 Thread Vinod Koul
On Thu, Mar 10, 2016 at 05:05:23PM +0100, Niklas S??derlund wrote: > Hi Christoph, > > On 2016-03-07 23:38:47 -0800, Christoph Hellwig wrote: > > Please add some documentation on where/how this should be used. It's > > not a very obvious interface. > > Good idea, I have added the following to Do

Re: [PATCH] dmaengine: usb-dmac: Add soctype for R-Car M3-W

2017-08-24 Thread Vinod Koul
On Fri, Aug 25, 2017 at 05:47:22AM +, Yoshihiro Shimoda wrote: > Hi Rob, > > > From: Rob Herring > > Sent: Friday, August 11, 2017 1:26 AM > > > > On Wed, Aug 02, 2017 at 08:33:34PM +0900, Yoshihiro Shimoda wrote: > > > This patch adds R-Car M3-W device tree bindings for usb-dmac driver. > >

Re: [PATCH v2] rcar-dmac: initialize all data before registering IRQ handler

2017-08-24 Thread Vinod Koul
On Mon, Aug 21, 2017 at 06:31:57AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > Anton Volkov noticed that engine->dev is NULL before > of_dma_controller_register() in probe. > Thus there might be a NULL pointer dereference in > rcar_dmac_chan_start_xfer while accessing chan->c

Re: [PATCH v2] dmaengine: rcar-dmac: document R8A77970 bindings

2017-09-04 Thread Vinod Koul
On Thu, Aug 31, 2017 at 11:59:24PM +0300, Sergei Shtylyov wrote: > Renesas R-Car V3M (R8A77970) SoC also has the R-Car gen2/3 compatible DMA > controllers, so document the SoC specific binding. Applied, thanks -- ~Vinod

Re: [PATCH v2] dmaengine: usb-dmac: Add compatible string for r8a7743/5

2017-10-08 Thread Vinod Koul
On Fri, Oct 06, 2017 at 06:15:17PM +0100, Biju Das wrote: > This patch adds support for r8a7743/5 SoCs. The Renesas RZ/G1[ME] > (R8A7743/5) usbdmac engine is identical to the R-Car Gen2 family. > > No driver change is needed due to the fallback compatible value > "renesas,r8a7743-usb-dmac". > Addi

Re: [PATCH] dmaengine: nbpfaxi: Use of_device_get_match_data() helper

2017-10-12 Thread Vinod Koul
On Wed, Oct 04, 2017 at 02:15:23PM +0200, Geert Uytterhoeven wrote: > Use the of_device_get_match_data() helper instead of open coding. > Note that when used with DT, there's always a valid match. Applied, thanks -- ~Vinod

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-10-31 Thread Vinod Koul
On Tue, Oct 31, 2017 at 11:46:36AM +0100, Geert Uytterhoeven wrote: > CC linux-renesas-soc > > On Tue, Oct 31, 2017 at 11:45 AM, Geert Uytterhoeven > wrote: > > Hi Vinod, Morimoto-san, Yokoyama-san, > > > > On Fri, Oct 20, 2017 at 8:15 AM, Vinod Koul wrote: >

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-11-07 Thread Vinod Koul
On Tue, Oct 31, 2017 at 05:11:13PM +0530, Vinod Koul wrote: > On Tue, Oct 31, 2017 at 11:46:36AM +0100, Geert Uytterhoeven wrote: > > > > > > This is now commit 847449f23dcbff68 ("dmaengine: rcar-dmac: use TCRB > > > instead of TCR for residue") in s

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-11-08 Thread Vinod Koul
On Wed, Nov 08, 2017 at 06:33:33AM +, Kuninori Morimoto wrote: > > Hi Vinod > > > > > > This is now commit 847449f23dcbff68 ("dmaengine: rcar-dmac: use TCRB > > > > > instead of TCR for residue") in slave-dma/next, and breaks serial > > > > > console > > > > > input on koelsch (shmobile_defc

Re: [PATCH 1/2] dt-bindings: dmaengine: usb-dmac: Add binding for r8a77470

2018-11-11 Thread Vinod Koul
On 25-10-18, 15:53, Biju Das wrote: > This patch adds usb high-speed dmac binding for r8a77470 (RZ/G1C) SoC. Applied, thanks -- ~Vinod

Re: [PATCH resend] dt-bindings: dmaengine: usb-dmac: Add binding for r8a774a1

2018-11-24 Thread Vinod Koul
On 15-11-18, 11:59, Fabrizio Castro wrote: > From: Biju Das > > This patch adds binding for r8a774a1 (RZ/G2M). > > Signed-off-by: Biju Das Applied, thanks -- ~Vinod

Re: [PATCH resend] dmaengine: rcar-dmac: Document R8A774A1 bindings

2018-11-24 Thread Vinod Koul
On 15-11-18, 11:58, Fabrizio Castro wrote: > Renesas' RZ/G2M (R8A774A1) SoC has DMA controllers compatible > with this driver, therefore document RZ/G2M specific bindings. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: of_dma: approximate an average distribution

2016-05-14 Thread Vinod Koul
On Wed, May 11, 2016 at 03:15:11PM +0200, Niklas Söderlund wrote: > Currently the following DT description would result in dmac0 always > being tried first and dmac1 second if dmac0 was unavailable. This > results in heavier use of dmac0 then of dmac1. This patch adds an > approximate average distr

Re: [PATCHv7 0/6] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-06-01 Thread Vinod Koul
On Wed, Jun 01, 2016 at 05:22:23PM +0200, Niklas Söderlund wrote: > Hi, > > [In this v7 series I have tried to address the questions raised by Christoph > Hellwig and I hope it can awnser your concernes regarding dma-debug.] > > This series tries to solve the problem with DMA with device registe

Re: [PATCHv7 0/6] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-06-02 Thread Vinod Koul
On Thu, Jun 02, 2016 at 02:58:07PM +0200, Niklas Söderlund wrote: > Hi Vinod, > > On 2016-06-01 23:36:11 +0530, Vinod Koul wrote: > > On Wed, Jun 01, 2016 at 05:22:23PM +0200, Niklas Söderlund wrote: > > > Hi, > > > > > > [In this v7 series I hav

Re: [PATCH 0/4] Residue patches for rcar-dmac from renesas-drivers

2016-06-28 Thread Vinod Koul
On Wed, Jun 15, 2016 at 01:13:04PM +0200, Niklas Söderlund wrote: > Hi all, > > Laurent Pinchart (1): > dmaengine: rcar-dmac: Fix residue reporting for pending descriptors > > Muhammad Hamza Farooq (2): > dma: rcar-dma: use result of updated get_residue in tx_status > dma: rcar-dma: Fixed a

Re: [PATCHv2 0/4] Residue patches for rcar-dmac from renesas-drivers

2016-07-07 Thread Vinod Koul
On Thu, Jun 30, 2016 at 05:15:14PM +0200, Niklas Söderlund wrote: > Hi all, > > I have looked over the DMA residue branches in renesas-drivers tree > (topic/rcar-dmac-hamza-v3 and topic/rcar-dmac-residue-v1) hoping to > bring them to upstream. The original author for the bulk of the patches > Hamz

Re: [alsa-devel] Question about struct snd_soc_dai() :: cpu_dai->codec

2016-07-26 Thread Vinod Koul
On Tue, Jul 26, 2016 at 05:41:56AM +, Kuninori Morimoto wrote: > > Hi ALSA SoC > > My current headache is ALSA SoC's each modules (= Card/Codec/CPU/Platform) > doesn't care about "unbind/rmmod". > For example, if someone unbinded/rmmoded "Codec", Card or other modules > doesn't know about it.

Re: [alsa-devel] Question about struct snd_soc_dai() :: cpu_dai->codec

2016-07-27 Thread Vinod Koul
On Wed, Jul 27, 2016 at 07:57:05AM +0200, Takashi Iwai wrote: > On Wed, 27 Jul 2016 05:21:11 +0200, > Vinod Koul wrote: > > > > On Tue, Jul 26, 2016 at 05:41:56AM +, Kuninori Morimoto wrote: > > > > > > Hi ALSA SoC > > > > > > My current

Re: [alsa-devel] Question about struct snd_soc_dai() :: cpu_dai->codec

2016-07-27 Thread Vinod Koul
On Wed, Jul 27, 2016 at 10:22:41PM +0200, Takashi Iwai wrote: > On Wed, 27 Jul 2016 20:22:33 +0200, > Mark Brown wrote: > > > > On Wed, Jul 27, 2016 at 08:11:49PM +0200, Takashi Iwai wrote: > > > > > I'm wondering whether it's a better option to block the unbind > > > behavior, either in driver b

Re: Question about struct snd_soc_dai() :: cpu_dai->codec

2016-07-29 Thread Vinod Koul
On Fri, Jul 29, 2016 at 11:07:49AM +0200, Lars-Peter Clausen wrote: > On 07/29/2016 02:30 AM, Takashi Sakamoto wrote: > > Lars, > > > > On Jul 29 2016 05:33, Lars-Peter Clausen wrote: > >> Hotplug is something that always pops up sooner or later. E.g. if someone > >> puts a ASoC supported CODEC on

Re: [PATCH] dmaengine: usb-dmac: check CHCR.DE bit in usb_dmac_isr_channel()

2016-08-08 Thread Vinod Koul
On Thu, Aug 04, 2016 at 07:59:41PM +0900, Yoshihiro Shimoda wrote: > The USB-DMAC's interruption happens even if the CHCR.DE is not set to 1 > because CHCR.NULLE is set to 1. So, this driver should call > usb_dmac_isr_transfer_end() if the DE bit is set to 1 only. Otherwise, > the desc is possible

Re: [PATCHv9 0/6] dmaengine: rcar-dmac: add iommu support for slave transfers

2016-08-10 Thread Vinod Koul
On Wed, Aug 10, 2016 at 01:22:13PM +0200, Niklas Söderlund wrote: > Hi, > > This series tries to solve the problem with DMA with device registers > (MMIO registers) that are behind an IOMMU for the rcar-dmac driver. A > recent patch '9575632 (dmaengine: make slave address physical)' > clarifies th

Re: [PATCH] dmaengine: sh: usb-dmac: Use [] to denote a flexible array member

2019-06-24 Thread Vinod Koul
On 19-06-19, 14:45, Geert Uytterhoeven wrote: > Flexible array members should be denoted using [] instead of [0], else > gcc will not warn when they are no longer at the end of the structure. Applied, thanks -- ~Vinod

Re: [PATCH] dmaengine: rcar-dmac: Reject zero-length slave DMA requests

2019-06-24 Thread Vinod Koul
On 24-06-19, 14:38, Geert Uytterhoeven wrote: > While the .device_prep_slave_sg() callback rejects empty scatterlists, > it still accepts single-entry scatterlists with a zero-length segment. > These may happen if a driver calls dmaengine_prep_slave_single() with a > zero len parameter. The corres

Re: [PATCH] dmaengine: rcar-dmac: Reject zero-length slave DMA requests

2019-06-24 Thread Vinod Koul
On 24-06-19, 14:38, Geert Uytterhoeven wrote: > While the .device_prep_slave_sg() callback rejects empty scatterlists, > it still accepts single-entry scatterlists with a zero-length segment. > These may happen if a driver calls dmaengine_prep_slave_single() with a > zero len parameter. The corres

Re: [PATCH] dt-bindings: shdma: Rename bindings documentation file

2019-07-28 Thread Vinod Koul
On 24-07-19, 13:49, Simon Horman wrote: > Rename the bindings documentation file for shdma > from shdma.txt to renesas,shdma.txt. > > This is part of an ongoing effort to name bindings documentation files for > Renesas IP blocks consistently, in line with the compat strings they > document. Appli

Re: [PATCH] dt-bindings: dmaengine: nbpfaxi: Rename bindings documentation file

2019-08-20 Thread Vinod Koul
On 19-08-19, 15:52, Simon Horman wrote: > Rename the device tree bindings for renesas "Type-AXI" NBPFAXI* DMA > controllers from nbpfaxi.txt to renesas,nbpfaxi.txt. > > This is part of an ongoing effort to name bindings documentation files for > Renesas IP blocks consistently, in line with the com

Re: [PATCH v2] dmaengine: rcar-dmac: Fix DMACHCLR handling if iommu is mapped

2019-09-03 Thread Vinod Koul
On 02-09-19, 20:44, Yoshihiro Shimoda wrote: > The commit 20c169aceb45 ("dmaengine: rcar-dmac: clear pertinence > number of channels") forgets to clear the last channel by > DMACHCLR in rcar_dmac_init() (and doesn't need to clear the first > channel) if iommu is mapped to the device. So, this patch

Re: [PATCH 0/2] dmaengine: rcar-dmac: minor modifications

2019-09-03 Thread Vinod Koul
On 27-08-19, 20:10, Yoshihiro Shimoda wrote: > This patch series is based on renesas-drivers.git / > renesas-drivers-2019-08-13-v5.3-rc4 tag. This is minor modifications > to add support for changed registers memory mapping hardware support > easily in the future. This fails to apply for me, pleas

Re: [PATCH 0/2] dmaengine: rcar-dmac: minor modifications

2019-09-04 Thread Vinod Koul
On 04-09-19, 06:14, Yoshihiro Shimoda wrote: > Hi Vinod, > > > From: Vinod Koul, Sent: Wednesday, September 4, 2019 3:10 PM > > > > On 27-08-19, 20:10, Yoshihiro Shimoda wrote: > > > This patch series is based on renesas-drivers.git / > > > renesas-driv

Re: [PATCH v2 0/3] dmaengine: rcar-dmac: use of_data and add dma-channel-mask support

2019-09-04 Thread Vinod Koul
On 04-09-19, 17:24, Yoshihiro Shimoda wrote: > This patch series is based on the latest slave-dma.git / next branch and > merge the latest slave-dma.git / fixes branch. This is because this patch > series depends on the following commit: Well it should not depend on fix which is going for 5.3 and

Re: [PATCH v3 0/4] dmaengine: rcar-dmac: use of_data and add dma-channel-mask support

2019-10-13 Thread Vinod Koul
On 09-09-19, 15:34, Yoshihiro Shimoda wrote: > This patch series is based on the latest slave-dma.git / next branch. > > Changes from v2: > - Rebase the latest slave-dma.git / next branch (In other words, >this patch series doesn't depend any other branches. > - Cherry-picked a patch which i

Re: [PATCH v2] dt-bindings: dmaengine: rcar-dmac: Document R8A774B1 bindings

2019-10-15 Thread Vinod Koul
On 27-09-19, 11:37, Biju Das wrote: > Renesas RZ/G2N (R8A774B1) SoC also has the R-Car gen2/3 compatible > DMA controllers, therefore document RZ/G2N specific bindings. Applied, thanks -- ~Vinod