Re: [PATCH 1/7] watchdog: add watchdog pretimeout framework

2016-06-05 Thread Wolfram Sang
On Thu, May 26, 2016 at 03:37:17PM -0700, Guenter Roeck wrote: > On Thu, May 26, 2016 at 06:41:36PM +0200, Wolfram Sang wrote: > [ ... ] > > > > No doubt about that. I had some ideas and thought it is easier to talk > > over code. If you want to rebase it, too, I'd be

Re: [RFC 2/3] pinctrl: sh-pfc: r8a7795: add support for voltage switching

2016-06-06 Thread Wolfram Sang
On Mon, Jun 06, 2016 at 09:23:35AM +0200, Geert Uytterhoeven wrote: > Hi Wolfram, > > On Mon, Jun 6, 2016 at 8:50 AM, Wolfram Sang <w...@the-dreams.de> wrote: > > From: Wolfram Sang <wsa+rene...@sang-engineering.com> > > > > Signed-off-by: Wolfram

Re: [PATCH v2 4/4] ARM: dts: r8a7790: lager: use demuxer for IIC3/I2C3

2016-06-08 Thread Wolfram Sang
On Wed, Jun 08, 2016 at 04:14:26PM +0900, Simon Horman wrote: > Create a separate bus for dla98063 PMIC and da9210 regulator > related I2C slaves. > > Based on similar work for HDMI by Wolfram Sang. > > Cc: Wolfram Sang <wsa+rene...@sang-engineering.com> > Signed-off-b

Re: [PATCH v2 1/4] ARM: dts: r8a7790: lager: rename i2cexio as i2cexio0

2016-06-08 Thread Wolfram Sang
On Wed, Jun 08, 2016 at 04:14:23PM +0900, Simon Horman wrote: > This is in preparation for adding i2cexio1 which will use the > dmuxer for IIC1/I2C0. I2C1 signature.asc Description: PGP signature

[PATCH 1/3] pinctrl: sh-pfc: refactor voltage setting

2016-06-06 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> All known hardware being able to switch voltages has the same POCCTRL register. So, factor out the common code to the core and keep only the pin-to-bit mapping SoC specific. Convert the only user, r8a7790. In case POCCTRL should ever ge

[PATCH 0/3] pinctrl: sh-pfc: add r8a7795 support for voltage switching

2016-06-06 Thread Wolfram Sang
: * be precise in encoding which pins can do voltage switching on bank3 * addded Geert's reviewed tag (thanks!) Please apply, Wolfram Wolfram Sang (3): pinctrl: sh-pfc: refactor voltage setting pinctrl: sh-pfc: r8a7795: add support for voltage switching arm64: dts: r8a7795: salvator

Re: [PATCH 0/3] pinctrl: sh-pfc: add r8a7795 support for voltage switching

2016-06-10 Thread Wolfram Sang
> BTW, are these a hard dependency for patch 3, or will the missing power > source control just be ignored? Long answer short: It is a hard dependency. It shouldn't be, but fixing this might need patches to pfc, mmc-core, and sdhi driver. Need to think about it. (and even then, patch 3 will be

Re: [PATCH] i2c: mux: refer to i2c-mux.txt

2016-06-09 Thread Wolfram Sang
On Wed, Jun 08, 2016 at 03:21:39PM +0900, Simon Horman wrote: > Correct references to i2c-mux.txt which was previously mux.txt. > > Also correct the spelling of relevant. > > Signed-off-by: Simon Horman Applied to for-current, thanks! signature.asc Description:

[PATCH 4/7] watchdog: documentation: squash paragraphs about 'no set_timeout'

2016-05-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Those paragraphs deal with the same topic, so tie them together for easier reading. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Documentation/watchdog/watchdog-kernel-api.txt | 4 ++-- 1 file changed,

[PATCH 5/7] watchdog: softdog: sort includes to avoid duplicates

2016-05-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/watchdog/softdog.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/sof

[PATCH 3/7] watchdog: softdog: consistently use softdog_ prefix

2016-05-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> And move module_init/exit to the proper place while here. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/watchdog/softdog.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-)

[PATCH 6/7] watchdog: softdog: drop superfluous set_timeout callback

2016-05-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> If we leave set_timeout empty, the core will do exactly what is implemented here anyway. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/watchdog/softdog.c | 7 --- 1 file changed, 7 deletions(-)

[PATCH 0/7] watchdog: softdog: cleanups

2016-05-25 Thread Wolfram Sang
/linux.git renesas/softdog_cleanup Please review, comment, apply... Thanks, Wolfram Wolfram Sang (7): watchdog: softdog: remove obsolete comments watchdog: softdog: use watchdog core to init timeout value watchdog: softdog: consistently use softdog_ prefix watchdog: softdog: remove

[PATCH 2/7] watchdog: softdog: use watchdog core to init timeout value

2016-05-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Error string and comment say we fall back to a default, but in reality we bailed out. Refactor the code to use the core helper which then matches the described behaviour. While updating the init message anyhow, shorten it while we ar

[PATCH 1/7] watchdog: softdog: remove obsolete comments

2016-05-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> The history is obsolete, especially since we switched to watchdog framework. The section markers also don't make sense anymore given the small size of the driver. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>

[PATCH 7/7] watchdog: softdog: improve coding style

2016-05-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/watchdog/softdog.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/sof

[PATCH 4/7] watchdog: softdog: remove forward declaration

2016-05-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/watchdog/softdog.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/sof

[PATCH] pinctrl: sh-pfc: fix property name in bindings doc

2016-06-10 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> It must be "drive-strength", with a hyphen. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Documentation/devicetree/bindings/pinctrl/renesas,pfc-pinctrl.txt | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH v2 4/4] ARM: dts: r8a7790: lager: use demuxer for IIC3/I2C3

2016-06-13 Thread Wolfram Sang
> i2c9 = "i2cexio1"; > i2c10 = "i2chdmi"; > i2c11 = "gpioi2c"; > + i2c12 = "i2cpwr"; To make it easier for users, we should maybe group them? i2c8+9: additional gpio busses i2c10-13: i2cexioX ? signature.asc Description: PGP signature

Re: [PATCH v2 2/4] ARM: dts: r8a7790: lager: use demuxer for IIC1/I2C1

2016-06-13 Thread Wolfram Sang
On Wed, Jun 08, 2016 at 04:14:24PM +0900, Simon Horman wrote: > Make it possible to select which I2C1 IP core you want to run on the > EXIO-A connector. > > This is based on reference work for the I2C0 core of the lager by Wolfram > Sang. > > Cc: Wolfram Sang <wsa+rene

Re: [PATCH v2 0/4] ARM: dts: r8a7790: lager: use demuxer for I2C

2016-06-13 Thread Wolfram Sang
># ./exercise-i2c-demux.sh >I2C Demux: i2c-8 > Master: 1:/i2c@e650800 >[ 97.694487] i2c-rcar e6508000.i2c: probed 0 (1) > Master: 0:/i2c@e65 >[ 102.706365] i2c-demux-pinctrl i2c-8: failed to setup demux-adapter 0 > (-19) 0 (0) Confirmed :( Got today only this

[RFC 2/3] pinctrl: sh-pfc: r8a7795: add support for voltage switching

2016-06-06 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/pinctrl/sh-pfc/pfc-r8a7795.c | 24 ++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/sh-pfc/pfc-

[RFC 1/3] pinctrl: sh-pfc: refactor voltage setting

2016-06-06 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> All known hardware being able to switch voltages has the same POCCTRL register. So, factor out the common code to the core and keep only the pin-to-bit mapping SoC specific. Convert the only user, r8a7790. In case POCCTRL should ever ge

[RFC 3/3] arm64: dts: r8a7795: salvator: enable UHS for SDHI 0 & 3

2016-06-06 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot

Re: [PATCH 1/7] watchdog: add watchdog pretimeout framework

2016-05-26 Thread Wolfram Sang
Hi Vladimir, great to see you still have capacity for this series :) > The thing is that I'm particularly interested in > > 1) sleeping governors, > 2) userspace notification of any appropriate kind, but preferably not by >adding a clumsy .poll callback, uevent is the best IMHO. I am

Re: [PATCH v3 2/4] mmc: tmio: Add tuning support

2016-05-27 Thread Wolfram Sang
> +static int tmio_mmc_execute_tuning(struct mmc_host *mmc, u32 opcode) > +{ > + struct tmio_mmc_host *host = mmc_priv(mmc); > + unsigned int num = 0; > + int i, ret = 0; > + bool *tap; > + > + if (host->init_tuning) > + num = host->init_tuning(host); > + if

Re: [PATCH v3 0/4] UHS-I SDR-104 support for sh_mobile_sdhi

2016-05-27 Thread Wolfram Sang
. Tested-by: Wolfram Sang <wsa+rene...@sang-engineering.com> signature.asc Description: PGP signature

Re: [PATCH v3 1/4] mmc: tmio: enhance illegal sequence handling

2016-05-27 Thread Wolfram Sang
Signed-off-by: Ai Kyuse <ai.kyuse...@renesas.com> > [simon: broken out of a larger patch] > Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Breaking out this one really helps the understanding and the review of the series. Thanks for doing it! Reviewed-by: Wolfram Sang &l

Re: [PATCH v3 3/4] mmc: sh_mobile_sdhi: Add tuning support

2016-05-27 Thread Wolfram Sang
On Tue, May 24, 2016 at 11:43:16AM +0900, Simon Horman wrote: > From: Ai Kyuse I wonder if you shouldn't take over ownership of this and the previous patch? You changed quite a lot. > +static inline u32 sd_scc_read32(struct tmio_mmc_host *host, int addr) > +{ > +

[PATCH] mmc: tmio: make a cast explicit

2016-05-27 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Sparse complains about the implicit cast. Making it explicit is indeed better coding style. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/mmc/host/tmio_mmc.h | 2 +- 1 file changed, 1 insertion(+)

Re: [PATCH] i2c: I2C_RCAR should depend on HAS_DMA

2016-05-26 Thread Wolfram Sang
On Sun, May 22, 2016 at 09:38:35AM +0200, Geert Uytterhoeven wrote: > If NO_DMA=y: > > drivers/built-in.o: In function `rcar_i2c_dma_unmap': > i2c-rcar.c:(.text+0x6f06c6): undefined reference to `bad_dma_ops' > drivers/built-in.o: In function `rcar_i2c_dma': >

[PATCH V2 06/31] staging: ks7010: avoid workqueue races

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> My Spectec SDW823 card oopsed when it was already inserted during boot. When debugging this, I noticed that the card init was done in a seperate workqueue which was only activated once in probe. After removing the workqueue and c

[PATCH V2 24/31] staging: ks7010: indent michael_mic.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/michael_mic.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/ks7010/michael_mic.

[PATCH V2 25/31] staging: ks7010: indent ks7010_sdio.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Unlike the previous patches which are plain indent outcomes, this has some manual fixups to be not overly strict with the 80 char limit. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/k

[PATCH V2 05/31] staging: ks7010: remove code for old kernel versions

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> No need to be backwards compatible. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.c | 9 - drivers/staging/ks7010/ks_wlan.h | 28 +

[PATCH V2 27/31] staging: ks7010: fix module annotations

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> List all authors, beautify description, match license to what is stated in file headers, add firmware information. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_sdio.c | 10 +

[PATCH V2 26/31] staging: ks7010: remove supported card table with one element

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> There is only this card supported, no need to iterate over the table. The resulting firmware filename wasn't used anyway, but came from the config file or hardcoded default. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engine

[PATCH V2 10/31] staging: ks7010: really iterate over multicast addresses

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> The loop variable was defined but not really used. Fix this. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --g

[PATCH V2 15/31] staging: ks7010: indent eap_packet.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/eap_packet.h | 49 ++--- 1 file changed, 24 insertions(+), 25 deletions(-) diff --git a/drivers/st

[PATCH V2 07/31] staging: ks7010: use long preamble as default

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> I had a problem connecting to a network with a short preamble, so let's make the safer option the default. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 4 ++-- 1 fil

[PATCH V2 17/31] staging: ks7010: indent ks7010_sdio.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_sdio.h | 64 +--- 1 file changed, 30 insertions(+), 34 deletions(-) diff --git a/drivers/st

[PATCH V2 20/31] staging: ks7010: indent ks_wlan.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_wlan.h | 246 +++ 1 file changed, 121 insertions(+), 125 deletions(-) diff --git a/drivers/st

[PATCH V2 30/31] staging: ks7010: drop counting sd errors

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> They were counted but never really used anywhere. Also change the printk to a debug print, since it mostly shows on the expected -ENOMEDIUM on card removal. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- dri

[PATCH V2 09/31] staging: ks7010: delete seperate debug header

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Move the one debug macro to the generic wlan header. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 1 - drivers/staging/ks7010/ks7010_sdio.c | 1 - drivers/st

[PATCH V2 11/31] staging: ks7010: make loading config file optional

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> We have sane defaults, so we don't need to bail out if there is no config file. Note that the config file should go away completely in favour of configuration mechanisms already upstream. Signed-off-by: Wolfram Sang <wsa+ren

[PATCH V2 04/31] staging: ks7010: remove checks for WIRELESS_EXT version

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> We are by far newer than that anyhow. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.c | 23 --- drivers/staging/ks7010/ks_wlan_net.c | 14 ---

[PATCH V2 28/31] staging: ks7010: adapt to new trans_start handling

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> trans_start is gone from netdevice, so use the new helper function to set the mark. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_wlan_net.c | 2 +- 1 file changed, 1 insertion(+)

[PATCH V2 13/31] staging: ks7010: add example cfg file as a reference

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> We want to remove it, but to do so properly, it is good to have a working example. Needs to be copied to /lib/firmware in order to be used. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks701

[PATCH V2 03/31] staging: ks7010: remove custom firmware loader

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> FW_LOADER works fine, no need for a open coded fallback. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/Kconfig | 1 + drivers/staging/ks7010/ks7010_c

[PATCH V2 14/31] staging: ks7010: remove unecessary typedef

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Let's simply specify the struct to keep in sync with kernel coding style. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 4 +- drivers/staging/ks7010/ks7010_sd

[PATCH V2 19/31] staging: ks7010: indent ks_hostif.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_hostif.h | 525 ++--- 1 file changed, 262 insertions(+), 263 deletions(-) diff --git a/drivers/st

[PATCH V2 12/31] staging: ks7010: fix printk format warnings

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Use proper type for size_t. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 2 files changed, 2 insertions(+),

[PATCH V2 31/31] staging: ks7010: cleanup file headers

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Remove svn-ids and fix typos in the licence declaration. Add my copyright to the sdio code which I worked on mainly. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/eap_pac

[PATCH V2 21/31] staging: ks7010: indent ks_wlan_ioctl.h

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks_wlan_ioctl.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/ks7010/ks_wlan_ioctl.

[PATCH V2 29/31] staging: ks7010: simplify module_init/exit

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> The printouts are not needed, the driver core has enough debug output for this if wanted. So, use a helper to save boilerplate code. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010

[PATCH V2 16/31] staging: ks7010: indent ks7010_config.c

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/ks7010_config.c | 353 + 1 file changed, 184 insertions(+), 169 deletions(-) diff --git a/drivers/st

[PATCH V2 08/31] staging: ks7010: use kernel helper to print buffer

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> No need for an open coded one. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/Makefile | 2 +- drivers/staging/ks7010/ks7010_sdio.c | 9 + drivers/staging/ks7010/ks_deb

[PATCH V2 02/31] staging: ks7010: remove non-SDIO code and #ifdefs

2016-05-31 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> I couldn't find any trace of code or even products using ks7010 with something else than SDIO. So, remove the conditionals. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/staging/ks7010/Makefile

[PULL REQUEST] renesas/topic/pretimeout for renesas drivers

2016-05-29 Thread Wolfram Sang
Zapolskiy (3): watchdog: pretimeout: add panic pretimeout governor watchdog: pretimeout: add noop pretimeout governor watchdog: pretimeout: add userspace notifier pretimeout governor Wolfram Sang (13): watchdog: softdog: remove obsolete comments watchdog: softdog: use

Re: [PATCH/RFC 1/4] mmc: renesas_sdhi: rename sh_mobile_sdhi as renesas_sdhi

2016-06-22 Thread Wolfram Sang
On Wed, Jun 15, 2016 at 01:01:54PM +0900, Simon Horman wrote: > The SDHI driver is applicable to a wider range of SoCs than SH-Mobile, > Renesas seems to be a more appropriate name. > > Signed-off-by: Simon Horman It feels strange to rename the file and leaving all

Re: [PATCH/RFC 3/4] mmc: renesas_sdhi: rename DMA source file as renesas_sdhi_dma.c

2016-06-22 Thread Wolfram Sang
On Wed, Jun 15, 2016 at 01:01:56PM +0900, Simon Horman wrote: > Rename the source file for DMA for Renesas SDHI as a follow-up to attaching > DMA code to the renesas_sdhi driver rather than the tmio_core driver. > > Signed-off-by: Simon Horman > --- >

Re: [PATCH/RFC 2/4] mmc: renesas_sdhi, tmio: make dma more modular

2016-06-22 Thread Wolfram Sang
> +#if IS_ENABLED(CONFIG_MMC_SDHI_DMA) > +int tmio_mmc_init_dma(void); > +#else > +static int tmio_mmc_init_dma(void) > +{ > + return -EINVAL; > +} > +#endif Can't we make this another tmio_mmc_dma_ops to save the ifdeffery? signature.asc Description: PGP signature

Re: [PATCH v2 0/4] ARM: dts: r8a7790: lager: use demuxer for I2C

2016-06-14 Thread Wolfram Sang
> Confirmed :( Got today only this far that the ENODEV comes from the PFC > driver. CONFIG_DEBUG_PINCTRL is a good idea for further debugging > probably. Correction, it seems the pinctrl handle gets mixed up, so the devm_pinctrl_get_select() fails. Does that match your findings? Pity I can't

Re: [RFC] pinctrl: sh-pfc: propagate errors on group config

2016-06-21 Thread Wolfram Sang
> > On group configuration, bail out if setting one of the individual pins > > fails. We don't need to roll-back, the pinctrl core will do this for us. > > > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> > > --- > > > > Tested o

[RFC] pinctrl: sh-pfc: propagate errors on group config

2016-06-20 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> On group configuration, bail out if setting one of the individual pins fails. We don't need to roll-back, the pinctrl core will do this for us. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- Tested on a Lager

Re: [PATCH] MAINTAINERS: Update mailing list for Renesas SoC Development

2016-01-18 Thread Wolfram Sang
n <geert+rene...@glider.be> > Cc: Magnus Damm <magnus.d...@gmail.com> > Signed-off-by: Simon Horman <horms+rene...@verge.net.au> Acked-by: Wolfram Sang <wsa+rene...@sang-engineering.com> signature.asc Description: Digital signature

Re: [PATCH 2/3] arm64: dts: r8a7796: Add RWDT node

2016-06-27 Thread Wolfram Sang
On Mon, Jun 27, 2016 at 07:50:46PM +0200, Geert Uytterhoeven wrote: > Add a device node for the Watchdog Timer (WDT) controller on the Renesas > R-Car M3-W (r8a7796) SoC. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Wolfram Sang <wsa+rene...

Re: [PATCH 1/3] watchdog: renesas-wdt: Add support for the r8a7796 wdt

2016-06-27 Thread Wolfram Sang
On Mon, Jun 27, 2016 at 07:50:45PM +0200, Geert Uytterhoeven wrote: > Document support for the Watchdog Timer (WDT) Controller in the Renesas > R-Car M3-W (r8a7796) SoC. > > No driver update is needed. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Ack

Re: [PATCH 3/3] arm64: dts: r8a7796/salvator-x: Enable watchdog timer

2016-06-27 Thread Wolfram Sang
On Mon, Jun 27, 2016 at 07:50:47PM +0200, Geert Uytterhoeven wrote: > Enable the Watchdog Timer (WDT) controller on the Renesas Salvator-X > board equipped with an R-Car M3-W (r8a7796) SoC. > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be> Acked-by: Wolfram Sang

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-02-10 Thread Wolfram Sang
^ > I think you should try without MMC_CAP_WAIT_WHILE_BUSY, and then check > that a following CMD13 command always states that the card isn't busy. > I think the best path to try this is when sending a big write data > request, as in that case you can be quite certain that the card gets > busy

Re: Salvator-X ravb failure with v4.5-rc3 due to irqchip power down

2016-02-08 Thread Wolfram Sang
> The real problem is that the PHY interrupt is wired to an on-chip GPIO > controller, which is disabled by PM Runtime if no GPIOs are in use, and > interrupts are not taken into account (the irqchip subsystem is not (yet) PM > Runtime aware) for GPIO use. > > Adding a call to > >

Re: [PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-02-11 Thread Wolfram Sang
On Thu, Feb 11, 2016 at 10:00:50AM +0100, Ulf Hansson wrote: > On 11 February 2016 at 01:07, Wolfram Sang <w...@the-dreams.de> wrote: > >> I suspect you are using a delayed work in this driver to deal with > >> request timeouts. > >> > >> The value for

[PATCH] mmc: sdhi: Add r8a7795 support

2016-02-11 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Registers are 64bit apart, so we refactor bus_shift handling a little and set it based on the DT compatible. Also, EXT_ACC is different. Signed-off-by: Ai Kyuse <ai.kyuse...@renesas.com> Signed-off-by: Wolfram Sang <w

[PATCH] mmc: sanitize 'bus width' in debug output

2016-01-29 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> The bus width is sometimes the actual bus width, and sometimes indices to different arrays encoding the bus width. In my debugging case "2" could mean 8-bit as well as 4-bit, which was extremly confusing. Let's use the human

[RFC 2/2] mmc: sdhi: on RCar, make use of CBSY bit

2016-01-26 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Most registers need to wait until the command is completed, not necessarily until the bus is free. RCar SoCs can signal that via the CBSY bit, so let's use it instead of SCLKDIVEN to save a few ns of delay. Signed-off-by: Wolfram San

[RFC 0/2] mmc: sdhi: make use of CBSY

2016-01-26 Thread Wolfram Sang
have something to play with, here is an RFC. Let me know what you think. Wolfram Sang (2): mmc: tmio/sdhi: introduce flag for RCar specific features mmc: sdhi: on RCar, make use of CBSY bit drivers/mmc/host/sh_mobile_sdhi.c | 19 +-- drivers/mmc/host/tmio_mmc_pio.c | 6

Re: [PATCH 0/9] mmc: sdhi: some refactoring and adding basic r8a7795 support

2016-02-02 Thread Wolfram Sang
> Do note that I am re-basing my next branch from time to time, so I > assume the branch you shared with me isn't an immutable branch!? No prob, it was just for you :) signature.asc Description: PGP signature

Re: [PATCH 0/2] ARM: shmobile: use Lager as reference for I2C slave and core switch

2016-02-23 Thread Wolfram Sang
> > To be honest, I forgot my reasoning for not doing it :) It was surely > > not bloat of multi_v7. If I can't remember it tomorrow, I'll just send a > > patch. > > Great, thanks. While trying to make the patch, I remembered why I was reluctant - multi_v7_defconfig is such a moving target. A

Re: [PATCH][CFT]: dmaengine: make slave address physical

2016-02-22 Thread Wolfram Sang
the patch is still the same. And while the new commit message is a lot more precise, it is also in the same spirit as the old one. That being said: Acked-by: Wolfram Sang <wsa+rene...@sang-engineering.com> Tested-by: Wolfram Sang <wsa+rene...@sang-engineering.com> I tested it on my

[RFC] Revert "ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE"

2016-02-22 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> This reverts commit 406663ed61c8ad2b792824af1c1bc0e4faa711c6. With BPREDICT enabled, my Lager board can't boot anymore and gets stuck early in the boot process (mostly without any printout, sometimes with a little printout) Sign

Re: [RFC 1/7] pinctrl: sh-pfc: r8a7790: Implement voltage switching for SDHI

2016-02-29 Thread Wolfram Sang
> Shouldn't the "From" line have Ben's authorship, too? I considered the changes to this patch significant enough to take over ownership. Even more so with the changes you suggested. > > @Uli, Geert: Since bias support is probably similar, what do you think? Does > > it make sense to add

Re: [RFC] Revert "ARM: shmobile: defconfig: Do not enable CONFIG_CPU_BPREDICT_DISABLE"

2016-02-22 Thread Wolfram Sang
hout printing anything special? Yes. The only notable difference I recognized in the output was the set bit for branch prediction in the cr register output. That's why I assumed this commit to be guilty... > > > Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> >

Re: [PATCH][CFT]: dmaengine: make slave address physical

2016-02-22 Thread Wolfram Sang
> > But in case of slave, we know the dmaengine and always use a > > specific one. Further the IOMMU cases can lead to failure of this > > notion, so make this as physical address and now dmaengine driver > > will do the required mapping. > > You could also add "This finally bring the code in

Re: [PATCH 0/2] ARM: shmobile: use Lager as reference for I2C slave and core switch

2016-02-22 Thread Wolfram Sang
> My feeling is yes for consistency. Yes, valid point. > Are you concerned about bloat in multiv7_defconfig? To be honest, I forgot my reasoning for not doing it :) It was surely not bloat of multi_v7. If I can't remember it tomorrow, I'll just send a patch. > Sure, I have tentatively queued

[PATCH] ARM: multi_v7_defconfig: enable I2C demultiplexer and slave eeprom

2016-02-24 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> The Renesas Lager board shall be a reference platform for the runtime I2C IP core switcher and for I2C slave support. Enable the needed drivers for this. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- arch

Re: [PATCH] i2c: riic, sh_mobile, rcar: Use ARCH_RENESAS

2016-02-24 Thread Wolfram Sang
On Mon, Feb 22, 2016 at 10:15:19AM +0900, Simon Horman wrote: > Make use of ARCH_RENESAS in place of ARCH_SHMOBILE. > > This is part of an ongoing process to migrate from ARCH_SHMOBILE to > ARCH_RENESAS the motivation for which being that RENESAS seems to be a more > appropriate name than

[PATCH 0/9] mmc: sdhi: some refactoring and adding basic r8a7795 support

2016-01-25 Thread Wolfram Sang
commit message rewording Please test, comment, apply... Thanks, Wolfram Shinobu Uehara (1): mmc: sdhi: Add EXT_ACC register busy check Wolfram Sang (8): mmc: tmio_dma: remove debug messages with little information mmc: sdhi: error message on ENOMEM is superfluous mmc: tmio: add

[PATCH 8/9] mmc: tmio: disable clock before changing it

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Rcar2 & 3 docs state that for going to and coming from the 0xff setting, the clock must first be disabled before the DIV bits are changed. Instead of tracking this, let's just do this unconditionally. Signed-off-by: Wolfram Sang

[PATCH 5/9] mmc: tmio: remove stale comments

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> These don't make sense anymore. Since commit 5d60e500541ed1 ("mmc: tmio: add new TMIO_MMC_HAVE_HIGH_REG flags"), we don't deal with a resource here. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com>

[PATCH 4/9] mmc: tmio: add flag to reduce delay after changing clock status

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> The docs for RCar Gen2 & 3 I have access to, mention delays of 5ms after stop and 1ms after start. Make it possible to apply these values. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/mmc/host/tm

[PATCH 2/9] mmc: sdhi: Add EXT_ACC register busy check

2016-01-25 Thread Wolfram Sang
From: Shinobu Uehara <shinobu.uehara...@renesas.com> All the docs I have access to say that this register needs the bus busy check. Signed-off-by: Shinobu Uehara <shinobu.uehara...@renesas.com> Signed-off-by: Ai Kyuse <ai.kyuse...@renesas.com> Signed-off-by: Wolfram Sang

[PATCH 6/9] mmc: sdhi: use faster clock handling on RCar Gen2

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/mmc/host/sh_mobile_sdhi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_m

[PATCH 7/9] mmc: tmio: refactor set_clock a little

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Some of the indentation made the code awful to read. Fix that. Also, introduce defines instead of magic hex values. Note that this includes one change: We mask out know 0xff instead of 0x1ff. But 0x100 has always been the clock enab

[PATCH 9/9] mmc: sdhi: Add r8a7795 support

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Registers are 64bit apart, so we refactor bus_shift handling a little and set it based on the DT compatible. Also, EXT_ACC is different. Signed-off-by: Ai Kyuse <ai.kyuse...@renesas.com> Signed-off-by: Wolfram Sang <w

[PATCH 1/9] mmc: tmio_dma: remove debug messages with little information

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> When compiling the driver with CONFIG_MMC_DEBUG set, I get: === drivers/mmc/host/tmio_mmc_dma.c: In function 'tmio_mmc_start_dma': include/linux/device.h:1186:2: warning: 'cookie' may be used uninitialized in this function [-

Re: [RFC 0/6] mmc: sdhi: add basic r8a7795 support

2016-01-25 Thread Wolfram Sang
> I've been thinking about implementing a "delay callback", which waits for > bit 13 on previous SoCs and for bit 14 for r8a7795. Does it make a difference for you? I thought it didn't? signature.asc Description: Digital signature

[PATCH] mmc: make MAN_BKOPS_EN message a debug

2016-01-25 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> IMO this info is only useful for developers. Most users won't need this information, since there is not much they can do about it. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/mmc/core/mmc.c |

[RFC 5/6] mmc: sdhi: use faster clock handling on RCar Gen2

2016-01-19 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/mmc/host/sh_mobile_sdhi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_m

[RFC 2/6] mmc: sdhi: error message on ENOMEM is superfluous

2016-01-19 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> We will get a full dump anyhow. Signed-off-by: Wolfram Sang <wsa+rene...@sang-engineering.com> --- drivers/mmc/host/sh_mobile_sdhi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/mmc/host/sh_mobi

[RFC 6/6] mmc: sdhi: Add r8a7795 support

2016-01-19 Thread Wolfram Sang
From: Wolfram Sang <wsa+rene...@sang-engineering.com> Registers are 64bit apart, so we refactor bus_shift handling a little and set it based on the DT compatible. Also, EXT_ACC is different. Signed-off-by: Ai Kyuse <ai.kyuse...@renesas.com> Signed-off-by: Wolfram Sang <w

  1   2   3   4   5   6   7   8   9   10   >