Re: [PATCH] pinctrl: sh-pfc: r8a7791: Add ADI pinconf support

2016-12-01 Thread jac...@jmondi.org
Hi Laurent, Geert, thanks for review On 29/11/2016 22:39, Geert Uytterhoeven wrote: Hi Laurent, On Tue, Nov 29, 2016 at 8:30 PM, Laurent Pinchart wrote: On Tuesday 29 Nov 2016 10:11:56 Jacopo Mondi wrote: Add pin configuration support for Gyro-ADC, named ADI on r8a7791 SoC. The Gyro-ADC

Re: [RFC 1/3] gpio-rz: Port to v3.18

2016-12-02 Thread jac...@jmondi.org
Hi Chris, On 02/12/2016 17:23, Chris Brandt wrote: On 12/2/2016, Jacopo Mondi wrote: Fix invalid return value in gpio remove function Signed-off-by: Jacopo Mondi --- drivers/gpio/gpio-rz.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-rz.c b/drivers/

Re: [RFC 3/3] spidev: Add back "linux,spidev" as compatible

2016-12-05 Thread jac...@jmondi.org
Hi Geert, On 03/12/2016 11:30, Geert Uytterhoeven wrote: Hi Jacopo, On Fri, Dec 2, 2016 at 4:43 PM, Jacopo Mondi wrote: spidev is not meant to be configured directly from DTS anymore. Since we're prototyping, add the "linux,spidev" compatibility string back I guess you needed this because y

Re: [RFC] dts: arm: renesas: koelsh: Add MAX11100 device

2016-12-07 Thread jac...@jmondi.org
Hi Geert, thanks for review On 07/12/2016 09:40, Geert Uytterhoeven wrote: Hi Jacopo, On Tue, Dec 6, 2016 at 5:34 PM, Jacopo Mondi wrote: Add node to test MAX11100 ADC with LED28 connected to the chip input line. What does the name "LED28" refer to? It's simply gpio #28 on port gpio5.

Re: [PATCH] iio: Add Maxim MAX11100 driver

2016-12-07 Thread jac...@jmondi.org
Hi Peter, thanks for review On 06/12/2016 22:00, Peter Meerwald-Stadler wrote: On Tue, 6 Dec 2016, Jacopo Mondi wrote: Add IIO driver for Maxim MAX11100 single-channel ADC. Support raw_read mode only. comments below; very minimal driver, but several easy issues... the read_raw() is suppo

Re: [PATCH] iio: Add Maxim MAX11100 driver

2016-12-12 Thread jac...@jmondi.org
Hi Jonathan, On 10/12/2016 19:04, Jonathan Cameron wrote: On 07/12/16 08:29, jac...@jmondi.org wrote: [snip] This driver is so minimal, I wonder if there are not drivers for similar devices to which I can add support for MAX11100 instead of writing a new one from scratch. Anyone with

Re: [PATCHv2] iio: adc: Add Maxim MAX11100 driver

2016-12-14 Thread jac...@jmondi.org
Hello Peter, thanks for review On 13/12/2016 21:33, Peter Meerwald-Stadler wrote: Add IIO driver for Maxim MAX11100 single-channel ADC. Add DT bindings documentation. some more comments Signed-off-by: Jacopo Mondi --- v1 -> v2: - incorporated pmeerw's review comments - retriev

Re: [PATCHv2] iio: adc: Add Maxim MAX11100 driver

2016-12-14 Thread jac...@jmondi.org
Hi Geert, On 13/12/2016 14:21, Geert Uytterhoeven wrote: Hi Jacopo, On Tue, Dec 13, 2016 at 1:37 PM, Jacopo Mondi wrote: Add IIO driver for Maxim MAX11100 single-channel ADC. Add DT bindings documentation. Signed-off-by: Jacopo Mondi --- a/drivers/iio/adc/Makefile +++ b/drivers/iio/adc/M