Re: [PATCH 10/15] ARM64: dts: r8a77965: Add SCIF device nodes

[Geert Uytterhoeven]

On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi
 wrote:
> Add SCIF[0-5] device nodes for M3-N (r8a77965) SoC.
>
> Signed-off-by: Jacopo Mondi 

> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi

> scif3: serial@e6c5 {
> -   /* placeholder */
> +   compatible = "renesas,scif-r8a7796",

renesas,scif-r8a77965

> +"renesas,rcar-gen3-scif", "renesas,scif";
> +   reg = <0 0xe6c5 0 64>;
> +   interrupts = ;
> +   clocks = < CPG_MOD 204>,
> +< CPG_CORE R8A77965_CLK_S3D1>,
> +<_clk>;
> +   clock-names = "fck", "brg_int", "scif_clk";
> +   dmas = < 0x57>, < 0x56>;
> +   dma-names = "tx", "rx";
> +   power-domains = < R8A77965_PD_ALWAYS_ON>;
> +   resets = < 204>;
> +   status = "disabled";
> };
>
> scif4: serial@e6c4 {
> -   /* placeholder */
> +   compatible = "renesas,scif-r8a7796",

renesas,scif-r8a77965

> +"renesas,rcar-gen3-scif", "renesas,scif";
> +   reg = <0 0xe6c4 0 64>;
> +   interrupts = ;
> +   clocks = < CPG_MOD 203>,
> +< CPG_CORE R8A77965_CLK_S3D1>,
> +<_clk>;
> +   clock-names = "fck", "brg_int", "scif_clk";
> +   dmas = < 0x59>, < 0x58>;
> +   dma-names = "tx", "rx";
> +   power-domains = < R8A77965_PD_ALWAYS_ON>;
> +   resets = < 203>;
> +   status = "disabled";
> };
>
> scif5: serial@e6f3 {
> -   /* placeholder */
> +   compatible = "renesas,scif-r8a7796",

renesas,scif-r8a77965

> +"renesas,rcar-gen3-scif", "renesas,scif";
> +   reg = <0 0xe6f3 0 64>;
> +   interrupts = ;
> +   clocks = < CPG_MOD 202>,
> +< CPG_CORE R8A77965_CLK_S3D1>,
> +<_clk>;
> +   clock-names = "fck", "brg_int", "scif_clk";
> +   dmas = < 0x5b>, < 0x5a>,
> +  < 0x5b>, < 0x5a>;
> +   dma-names = "tx", "rx", "tx", "rx";
> +   power-domains = < R8A77965_PD_ALWAYS_ON>;
> +   resets = < 202>;
> +   status = "disabled";

With the above fixed:
Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

[PATCH 10/15] ARM64: dts: r8a77965: Add SCIF device nodes

[Jacopo Mondi]

Add SCIF[0-5] device nodes for M3-N (r8a77965) SoC.

Signed-off-by: Jacopo Mondi 
---
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 85 ---
 1 file changed, 79 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi 
b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 9e57a08..236592b 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -340,27 +340,100 @@
};
 
scif0: serial@e6e6 {
-   /* placeholder */
+   compatible = "renesas,scif-r8a77965",
+"renesas,rcar-gen3-scif", "renesas,scif";
+   reg = <0 0xe6e6 0 64>;
+   interrupts = ;
+   clocks = < CPG_MOD 207>,
+< CPG_CORE R8A77965_CLK_S3D1>,
+<_clk>;
+   clock-names = "fck", "brg_int", "scif_clk";
+   dmas = < 0x51>, < 0x50>,
+  < 0x51>, < 0x50>;
+   dma-names = "tx", "rx", "tx", "rx";
+   power-domains = < R8A77965_PD_ALWAYS_ON>;
+   resets = < 207>;
+   status = "disabled";
};
 
scif1: serial@e6e68000 {
-   /* placeholder */
+   compatible = "renesas,scif-r8a77965",
+"renesas,rcar-gen3-scif", "renesas,scif";
+   reg = <0 0xe6e68000 0 64>;
+   interrupts = ;
+   clocks = < CPG_MOD 206>,
+< CPG_CORE R8A77965_CLK_S3D1>,
+<_clk>;
+   clock-names = "fck", "brg_int", "scif_clk";
+   dmas = < 0x53>, < 0x52>,
+  < 0x53>, < 0x52>;
+   dma-names = "tx", "rx", "tx", "rx";
+   power-domains = < R8A77965_PD_ALWAYS_ON>;
+   resets = < 206>;
+   status = "disabled";
};
 
scif2: serial@e6e88000 {
-   /* placeholder */
+   compatible = "renesas,scif-r8a77965",
+"renesas,rcar-gen3-scif", "renesas,scif";
+   reg = <0 0xe6e88000 0 64>;
+   interrupts = ;
+   clocks = < CPG_MOD 310>,
+< CPG_CORE R8A77965_CLK_S3D1>,
+<_clk>;
+   clock-names = "fck", "brg_int", "scif_clk";
+   power-domains = < R8A77965_PD_ALWAYS_ON>;
+   resets = < 310>;
+   status = "disabled";
};
 
scif3: serial@e6c5 {
-   /* placeholder */
+   compatible = "renesas,scif-r8a7796",
+"renesas,rcar-gen3-scif", "renesas,scif";
+   reg = <0 0xe6c5 0 64>;
+   interrupts = ;
+   clocks = < CPG_MOD 204>,
+< CPG_CORE R8A77965_CLK_S3D1>,
+<_clk>;
+   clock-names = "fck", "brg_int", "scif_clk";
+   dmas = < 0x57>, < 0x56>;
+   dma-names = "tx", "rx";
+   power-domains = < R8A77965_PD_ALWAYS_ON>;
+   resets = < 204>;
+   status = "disabled";
};
 
scif4: serial@e6c4 {
-   /* placeholder */
+   compatible = "renesas,scif-r8a7796",
+"renesas,rcar-gen3-scif", "renesas,scif";
+   reg = <0 0xe6c4 0 64>;
+   interrupts = ;
+   clocks = < CPG_MOD 203>,
+< CPG_CORE R8A77965_CLK_S3D1>,
+<_clk>;
+   clock-names = "fck", "brg_int", "scif_clk";
+   dmas = < 0x59>, < 0x58>;
+   dma-names = "tx", "rx";
+   power-domains = < R8A77965_PD_ALWAYS_ON>;
+   resets = < 203>;
+   status = "disabled";
};
 
scif5: serial@e6f3 {
-   /* placeholder */
+   compatible = "renesas,scif-r8a7796",
+"renesas,rcar-gen3-scif", "renesas,scif";
+   reg = <0 0xe6f3 0 64>;
+   interrupts = ;
+   clocks = < CPG_MOD 202>,
+< CPG_CORE R8A77965_CLK_S3D1>,
+