Re: [PATCH 20/20] arm64: dts: renesas: salvator: use VC1 for CVBS
On Wed, Aug 30, 2017 at 10:08:24AM +0200, Niklas Söderlund wrote:
> Hi Simon,
>
> On 2017-08-30 09:36:37 +0200, Simon Horman wrote:
> > On Fri, Aug 11, 2017 at 11:57:03AM +0200, Niklas Söderlund wrote:
> > > In order to test Virtual Channels use VC1 for CVBS input from the
> > > adv748x.
> > >
> > > Signed-off-by: Niklas Söderlund
> > > ---
> > > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > index 7b67efcb1d22090a..8047fe1df065d63b 100644
> > > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > > @@ -41,7 +41,7 @@
> > > };
> > >
> > > chosen {
> > > - bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
> > > + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp
> > > adv748x.txbvc=1";
> > > stdout-path = "serial0:115200n8";
> > > };
> >
> > Hi Niklas,
> >
> > I'm somewhat surprised to see what appears to be a new module parameter.
> > I'm not going to reject this but did you give consideration to doing this
> > another way?
>
> This is my fault when sending this series out it should be marked as RFC
> as it's stated in the cover-letter. This new module parameter is not
> intended to be unstreamed, not even the driver parts. It's only usage is
> to be able to easy test the multiplexed media pad using the onboard
> Salvator-X components.
>
> >
> > In any case I have marked this as "Deferred" pending acceptance of the
> > driver change. If you think it can go in now then I'm open to discussion.
>
> You can mark it as rejected and forget about it :-)
Thanks for the clarification, I marked it as RFC :)
Re: [PATCH 20/20] arm64: dts: renesas: salvator: use VC1 for CVBS
Hi Simon,
On 2017-08-30 09:36:37 +0200, Simon Horman wrote:
> On Fri, Aug 11, 2017 at 11:57:03AM +0200, Niklas Söderlund wrote:
> > In order to test Virtual Channels use VC1 for CVBS input from the
> > adv748x.
> >
> > Signed-off-by: Niklas Söderlund
> > ---
> > arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > index 7b67efcb1d22090a..8047fe1df065d63b 100644
> > --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> > @@ -41,7 +41,7 @@
> > };
> >
> > chosen {
> > - bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
> > + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp
> > adv748x.txbvc=1";
> > stdout-path = "serial0:115200n8";
> > };
>
> Hi Niklas,
>
> I'm somewhat surprised to see what appears to be a new module parameter.
> I'm not going to reject this but did you give consideration to doing this
> another way?
This is my fault when sending this series out it should be marked as RFC
as it's stated in the cover-letter. This new module parameter is not
intended to be unstreamed, not even the driver parts. It's only usage is
to be able to easy test the multiplexed media pad using the onboard
Salvator-X components.
>
> In any case I have marked this as "Deferred" pending acceptance of the
> driver change. If you think it can go in now then I'm open to discussion.
You can mark it as rejected and forget about it :-)
--
Regards,
Niklas Söderlund
Re: [PATCH 20/20] arm64: dts: renesas: salvator: use VC1 for CVBS
On Fri, Aug 11, 2017 at 11:57:03AM +0200, Niklas Söderlund wrote:
> In order to test Virtual Channels use VC1 for CVBS input from the
> adv748x.
>
> Signed-off-by: Niklas Söderlund
> ---
> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> index 7b67efcb1d22090a..8047fe1df065d63b 100644
> --- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
> @@ -41,7 +41,7 @@
> };
>
> chosen {
> - bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
> + bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp
> adv748x.txbvc=1";
> stdout-path = "serial0:115200n8";
> };
Hi Niklas,
I'm somewhat surprised to see what appears to be a new module parameter.
I'm not going to reject this but did you give consideration to doing this
another way?
In any case I have marked this as "Deferred" pending acceptance of the
driver change. If you think it can go in now then I'm open to discussion.
[PATCH 20/20] arm64: dts: renesas: salvator: use VC1 for CVBS
In order to test Virtual Channels use VC1 for CVBS input from the
adv748x.
Signed-off-by: Niklas Söderlund
---
arch/arm64/boot/dts/renesas/salvator-common.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
index 7b67efcb1d22090a..8047fe1df065d63b 100644
--- a/arch/arm64/boot/dts/renesas/salvator-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/salvator-common.dtsi
@@ -41,7 +41,7 @@
};
chosen {
- bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp";
+ bootargs = "ignore_loglevel rw root=/dev/nfs ip=dhcp
adv748x.txbvc=1";
stdout-path = "serial0:115200n8";
};
--
2.13.3
