Re: [PATCH v2 0/5] PCI: rcar: Cleanups

2016-10-12 Thread Bjorn Helgaas 
On Wed, Oct 12, 2016 at 07:58:35AM -0500, Bjorn Helgaas wrote:
>   - Add local "dev" pointers to reduce repetition of things like
> "&pdev->dev".
> 
>   - Remove platform drvdata because it appears unused (we called
> platform_set_drvdata() but not platform_get_drvdata()).
> 
>   - Remove unused arguments and #defines.
> 
> Nothing here should change the behavior of the driver.
> 
> Changes from v1:
>   I dropped the following patches because they were a lot of churn for
>   questionable benefit:
> PCI: rcar: Rename accessors
> PCI: rcar: Name private struct pointer "rcar" consistently
> PCI: rcar: Swap order of rcar_writel() reg/val arguments
> PCI: rcar-gen2: Name private struct pointer "rcar" consistently
> PCI: rcar-gen2: Add register accessors
> 
> ---
> 
> Bjorn Helgaas (5):
>   PCI: rcar: Add local struct device pointers
>   PCI: rcar: Remove unused platform data
>   PCI: rcar: Remove unused rcar_pcie_get_resources() platform_device arg
>   PCI: rcar: Remove DRV_NAME macro
>   PCI: rcar-gen2: Add local struct device pointers

I applied these to pci/host-rcar for v4.9.  I hope to ask Linus to
pull them tomorrow, so if you see any issues, let me know soon.

[PATCH v2 0/5] PCI: rcar: Cleanups

2016-10-12 Thread Bjorn Helgaas 
  - Add local "dev" pointers to reduce repetition of things like
"&pdev->dev".

  - Remove platform drvdata because it appears unused (we called
platform_set_drvdata() but not platform_get_drvdata()).

  - Remove unused arguments and #defines.

Nothing here should change the behavior of the driver.

Changes from v1:
  I dropped the following patches because they were a lot of churn for
  questionable benefit:
PCI: rcar: Rename accessors
PCI: rcar: Name private struct pointer "rcar" consistently
PCI: rcar: Swap order of rcar_writel() reg/val arguments
PCI: rcar-gen2: Name private struct pointer "rcar" consistently
PCI: rcar-gen2: Add register accessors

---

Bjorn Helgaas (5):
  PCI: rcar: Add local struct device pointers
  PCI: rcar: Remove unused platform data
  PCI: rcar: Remove unused rcar_pcie_get_resources() platform_device arg
  PCI: rcar: Remove DRV_NAME macro
  PCI: rcar-gen2: Add local struct device pointers


 drivers/pci/host/pci-rcar-gen2.c |   46 ++
 drivers/pci/host/pcie-rcar.c |   98 +++---
 2 files changed, 75 insertions(+), 69 deletions(-)