Re: [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ

2018-02-15 Thread Simon Horman
On Tue, Feb 13, 2018 at 02:24:14PM +0300, Sergei Shtylyov wrote:
> Specify  EtherAVB PHY IRQ  in the Eagle board's device tree, now that we
> have the GPIO support (previously phylib had to resort to polling).
> 
> Signed-off-by: Sergei Shtylyov 

Thanks, applied with Geert's tag.

> ---
>  arch/arm64/boot/dts/renesas/r8a77970-eagle.dts |2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> ===
> --- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> +++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
> @@ -44,6 +44,8 @@
>   phy0: ethernet-phy@0 {
>   rxc-skew-ps = <1500>;
>   reg = <0>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <17 IRQ_TYPE_LEVEL_LOW>;

Could you consider following-up with a patch to add:

reset-gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;

>   };
>  };
>  
> 


Re: [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ

2018-02-15 Thread Sergei Shtylyov

Hello!

On 2/14/2018 1:02 PM, Geert Uytterhoeven wrote:


Specify  EtherAVB PHY IRQ  in the Eagle board's device tree, now that we
have the GPIO support (previously phylib had to resort to polling).

Signed-off-by: Sergei Shtylyov 


You've dropped my:
Reviewed-by: Geert Uytterhoeven 


   Sorry, I was too hasty to resubmit. :-/


Gr{oetje,eeting}s,

 Geert


MBR, Sergei


Re: [PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ

2018-02-14 Thread Geert Uytterhoeven
On Tue, Feb 13, 2018 at 12:24 PM, Sergei Shtylyov
 wrote:
> Specify  EtherAVB PHY IRQ  in the Eagle board's device tree, now that we
> have the GPIO support (previously phylib had to resort to polling).
>
> Signed-off-by: Sergei Shtylyov 

You've dropped my:
Reviewed-by: Geert Uytterhoeven 

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


[PATCH v2 2/2] arm64: dts: renesas: eagle: specify EtherAVB PHY IRQ

2018-02-13 Thread Sergei Shtylyov
Specify  EtherAVB PHY IRQ  in the Eagle board's device tree, now that we
have the GPIO support (previously phylib had to resort to polling).

Signed-off-by: Sergei Shtylyov 

---
 arch/arm64/boot/dts/renesas/r8a77970-eagle.dts |2 ++
 1 file changed, 2 insertions(+)

Index: renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
===
--- renesas.orig/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
+++ renesas/arch/arm64/boot/dts/renesas/r8a77970-eagle.dts
@@ -44,6 +44,8 @@
phy0: ethernet-phy@0 {
rxc-skew-ps = <1500>;
reg = <0>;
+   interrupt-parent = <&gpio1>;
+   interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
};
 };