Re: [PATCH v2 4/5] arm64: dts: renesas: r8a77970: add the LVDS instance

2018-02-19 Thread Simon Horman
On Thu, Feb 08, 2018 at 07:05:53PM +0300, Sergei Shtylyov wrote:
> Hello!
> 
> On 02/08/2018 06:47 PM, Niklas Söderlund wrote:
> 
> > Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
> > the it to the LVDS output of the DU. While at it align the endpoint name
> > of the du to du_out_lvds0 which is used in other Renesas DTS files to
> > describe this link.
> > 
> > Signed-off-by: Niklas Söderlund 
> > ---
> >  arch/arm64/boot/dts/renesas/r8a77970.dtsi | 29 
> > -
> >  1 file changed, 28 insertions(+), 1 deletion(-)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi 
> > b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > index c6056635bd372ce3..9c65884cc384952d 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> > @@ -653,7 +653,34 @@
> >  
> > port@1 {
> > reg = <1>;
> > -   du_out_lvds: endpoint {
> > +   du_out_lvds0: endpoint {
> > +   remote-endpoint = <_in>;
> > +   };
> > +   };
> > +   };
> > +   };
> > +
> > +   lvds0: lvds@feb9 {
> > +   compatible = "renesas,r8a77970-lvds";
> > +   reg = <0 0xfeb9 0 0x14>;
> > +   clocks = < CPG_MOD 727>;
> > +   power-domains = < R8A77970_PD_ALWAYS_ON>;
> > +   resets = < 727>;
> > +   status = "disabled";
> > +
> > +   ports {
> > +   #address-cells = <1>;
> > +   #size-cells = <0>;
> > +
> > +   port@0 {
> > +   reg = <0>;
> > +   lvds0_in: endpoint {
> > +   remote-endpoint = 
> > <_out_lvds0>;
> > +   };
> > +   };
> > +   port@1 {
> > +   reg = <1>;
> > +   lvds0_out: endpoint {
> > };
> > };
> > };
> 
> 
>That's basically my patch modulo the added "power-domains" and "resets" 
> props, and the node/endpoint rename (of a dubious value, if you ask me ;-)).

Hi Sergei,

after speaking with yourself and Niklas - who I think also spoke with you -
I'd be most grateful if you could repost this series at your convenience,
with the author and other outstanding review addressed.

Thanks.


Re: [PATCH v2 4/5] arm64: dts: renesas: r8a77970: add the LVDS instance

2018-02-08 Thread Sergei Shtylyov
Hello!

On 02/08/2018 06:47 PM, Niklas Söderlund wrote:

> Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
> the it to the LVDS output of the DU. While at it align the endpoint name
> of the du to du_out_lvds0 which is used in other Renesas DTS files to
> describe this link.
> 
> Signed-off-by: Niklas Söderlund 
> ---
>  arch/arm64/boot/dts/renesas/r8a77970.dtsi | 29 -
>  1 file changed, 28 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> index c6056635bd372ce3..9c65884cc384952d 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
> @@ -653,7 +653,34 @@
>  
>   port@1 {
>   reg = <1>;
> - du_out_lvds: endpoint {
> + du_out_lvds0: endpoint {
> + remote-endpoint = <_in>;
> + };
> + };
> + };
> + };
> +
> + lvds0: lvds@feb9 {
> + compatible = "renesas,r8a77970-lvds";
> + reg = <0 0xfeb9 0 0x14>;
> + clocks = < CPG_MOD 727>;
> + power-domains = < R8A77970_PD_ALWAYS_ON>;
> + resets = < 727>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + lvds0_in: endpoint {
> + remote-endpoint = 
> <_out_lvds0>;
> + };
> + };
> + port@1 {
> + reg = <1>;
> + lvds0_out: endpoint {
>   };
>   };
>   };


   That's basically my patch modulo the added "power-domains" and "resets" 
props, and the node/endpoint rename (of a dubious value, if you ask me ;-)).

MBSR, Sergei


[PATCH v2 4/5] arm64: dts: renesas: r8a77970: add the LVDS instance

2018-02-08 Thread Niklas Söderlund
Add the LVDS device to r8a77970.dtsi in a disabled state. Also connect
the it to the LVDS output of the DU. While at it align the endpoint name
of the du to du_out_lvds0 which is used in other Renesas DTS files to
describe this link.

Signed-off-by: Niklas Söderlund 
---
 arch/arm64/boot/dts/renesas/r8a77970.dtsi | 29 -
 1 file changed, 28 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi 
b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
index c6056635bd372ce3..9c65884cc384952d 100644
--- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi
@@ -653,7 +653,34 @@
 
port@1 {
reg = <1>;
-   du_out_lvds: endpoint {
+   du_out_lvds0: endpoint {
+   remote-endpoint = <_in>;
+   };
+   };
+   };
+   };
+
+   lvds0: lvds@feb9 {
+   compatible = "renesas,r8a77970-lvds";
+   reg = <0 0xfeb9 0 0x14>;
+   clocks = < CPG_MOD 727>;
+   power-domains = < R8A77970_PD_ALWAYS_ON>;
+   resets = < 727>;
+   status = "disabled";
+
+   ports {
+   #address-cells = <1>;
+   #size-cells = <0>;
+
+   port@0 {
+   reg = <0>;
+   lvds0_in: endpoint {
+   remote-endpoint = 
<_out_lvds0>;
+   };
+   };
+   port@1 {
+   reg = <1>;
+   lvds0_out: endpoint {
};
};
};
-- 
2.16.1