Re: [PATCH v2 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-13 Thread Kieran Bingham
Hi Dan Thank you for the review, On 13/02/18 07:23, Dan Carpenter wrote: > On Mon, Feb 12, 2018 at 06:11:57PM +, Kieran Bingham wrote: >> +adv7511->i2c_packet = i2c_new_secondary_device(i2c, "packet", >> +ADV7511_PACKET_I2C_ADDR_DEFAULT); >> +if

Re: [PATCH v2 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-12 Thread Dan Carpenter
On Mon, Feb 12, 2018 at 06:11:57PM +, Kieran Bingham wrote: > + adv7511->i2c_packet = i2c_new_secondary_device(i2c, "packet", > + ADV7511_PACKET_I2C_ADDR_DEFAULT); > + if (!adv7511->i2c_packet) { > + ret = -EINVAL; > + goto

[PATCH v2 5/5] drm: adv7511: Add support for i2c_new_secondary_device

2018-02-12 Thread Kieran Bingham
From: Kieran Bingham The ADV7511 has four 256-byte maps that can be accessed via the main I²C ports. Each map has it own I²C address and acts as a standard slave device on the I²C bus. Allow a device tree node to override the default addresses so that