Re: [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB

[Simon Horman]

On Mon, Oct 02, 2017 at 09:16:56AM +, Yoshihiro Shimoda wrote:
> Hi Simon-san,
> 
> > -Original Message-
> > From: Simon Horman
> > Sent: Monday, October 2, 2017 4:15 PM
> > 
> > On Mon, Oct 02, 2017 at 01:18:49AM +, Yoshihiro Shimoda wrote:
> > > Hello,
> > >
> > > > -Original Message-
> > > > From: Sergei Shtylyov
> > > > Sent: Saturday, September 30, 2017 7:24 PM
> > > >
> > > > Hello!
> > > >
> > > > On 9/29/2017 2:52 PM, Simon Horman wrote:
> > > >
> > > > > From: Yoshihiro Shimoda 
> > > > >
> > > > > This patch enables EthernetAVB for R-Car D3 draak board.
> > > > >
> > > > > Signed-off-by: Yoshihiro Shimoda 
> > > > > Reviewed-by: Geert Uytterhoeven 
> > > > > Signed-off-by: Simon Horman 
> > > > > ---
> > > > >   arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 
> > > > > +
> > > > >   1 file changed, 25 insertions(+)
> > > > >
> > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts 
> > > > > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > > index 7b776cb7e928..96b7ff5cc321 100644
> > > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > [...]
> > > > > @@ -37,6 +39,14 @@
> > > > >   };
> > > > >
> > > > >{
> > > > > + avb0_pins: avb {
> > > > > + mux {
> > > > > + groups = "avb0_link", "avb0_phy_int", 
> > > > > "avb0_mdc",
> > > >^^
> > > > Hum, I don't think it's compatible with routing the PHY interrupt 
> > > > via
> > > > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT 
> > > > anyway.
> > >
> > > Oops! You're correct. I should drop "avb0_phy_int".
> > >
> > > Simon-san, may I send a follow-up patch to fix this?
> > 
> > Thanks Sergei, thanks Shimoda-san,
> > 
> > yes, please provide a follow-up patch.
> > 
> > At this stage I don't think we need to re-spin this pull-request
> > to fix this, rather a follow-up patch can be included
> > in a follow-up pull request.
> 
> I got it. I will send it. Also, should I send salvator-common and ulcb patches
> about Geert-san's comment (These dtsi files also enable "avb_phy_int" for 
> now)?

Hi Shimoda-san,

yes, I think that would be best.

Please include Fixes tags.

RE: [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB

[Yoshihiro Shimoda]

Hi Simon-san,

> -Original Message-
> From: Simon Horman
> Sent: Monday, October 2, 2017 4:15 PM
> 
> On Mon, Oct 02, 2017 at 01:18:49AM +, Yoshihiro Shimoda wrote:
> > Hello,
> >
> > > -Original Message-
> > > From: Sergei Shtylyov
> > > Sent: Saturday, September 30, 2017 7:24 PM
> > >
> > > Hello!
> > >
> > > On 9/29/2017 2:52 PM, Simon Horman wrote:
> > >
> > > > From: Yoshihiro Shimoda 
> > > >
> > > > This patch enables EthernetAVB for R-Car D3 draak board.
> > > >
> > > > Signed-off-by: Yoshihiro Shimoda 
> > > > Reviewed-by: Geert Uytterhoeven 
> > > > Signed-off-by: Simon Horman 
> > > > ---
> > > >   arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 
> > > > +
> > > >   1 file changed, 25 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts 
> > > > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > index 7b776cb7e928..96b7ff5cc321 100644
> > > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > [...]
> > > > @@ -37,6 +39,14 @@
> > > >   };
> > > >
> > > >{
> > > > +   avb0_pins: avb {
> > > > +   mux {
> > > > +   groups = "avb0_link", "avb0_phy_int", 
> > > > "avb0_mdc",
> > >^^
> > > Hum, I don't think it's compatible with routing the PHY interrupt via
> > > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT 
> > > anyway.
> >
> > Oops! You're correct. I should drop "avb0_phy_int".
> >
> > Simon-san, may I send a follow-up patch to fix this?
> 
> Thanks Sergei, thanks Shimoda-san,
> 
> yes, please provide a follow-up patch.
> 
> At this stage I don't think we need to re-spin this pull-request
> to fix this, rather a follow-up patch can be included
> in a follow-up pull request.

I got it. I will send it. Also, should I send salvator-common and ulcb patches
about Geert-san's comment (These dtsi files also enable "avb_phy_int" for now)?

Best regards,
Yoshihiro Shimoda

> >
> > Best regards,
> > Yoshihiro Shimoda
> >
> > > > +"avb0_mii";
> > > > +   function = "avb0";
> > > > +   };
> > > > +   };
> > > > +
> > > > scif2_pins: scif2 {
> > > > groups = "scif2_data";
> > > > function = "scif2";
> > > > @@ -56,6 +66,21 @@
> > > > status = "okay";
> > > >   };
> > > >
> > > > + {
> > > > +   pinctrl-0 = <_pins>;
> > > > +   pinctrl-names = "default";
> > > > +   renesas,no-ether-link;
> > > > +   phy-handle = <>;
> > > > +   status = "okay";
> > > > +
> > > > +   phy0: ethernet-phy@0 {
> > > > +   rxc-skew-ps = <1500>;
> > > > +   reg = <0>;
> > > > +   interrupt-parent = <>;
> > > > +   interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
> > > > +   };
> > > > +};
> > > > +
> > > >{
> > > > pinctrl-0 = <_pins>;
> > > > pinctrl-names = "default";
> > >
> > > MBR, Sergei

Re: [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB

[Geert Uytterhoeven]

Hi Sergei,

On Sat, Sep 30, 2017 at 12:24 PM, Sergei Shtylyov
 wrote:
> On 9/29/2017 2:52 PM, Simon Horman wrote:
>> From: Yoshihiro Shimoda 
>>
>> This patch enables EthernetAVB for R-Car D3 draak board.
>>
>> Signed-off-by: Yoshihiro Shimoda 
>> Reviewed-by: Geert Uytterhoeven 
>> Signed-off-by: Simon Horman 

>> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
>
> [...]
>>
>> @@ -37,6 +39,14 @@
>>   };
>>  {
>> +   avb0_pins: avb {
>> +   mux {
>> +   groups = "avb0_link", "avb0_phy_int", "avb0_mdc",
>
>   ^^
>Hum, I don't think it's compatible with routing the PHY interrupt via
> GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT
> anyway.

Seems we have the same issue in arch/arm64/boot/dts/renesas/ulcb.dtsi and
arch/arm64/boot/dts/renesas/salvator-common.dtsi?

>>   + {

>> +   phy0: ethernet-phy@0 {
>> +   rxc-skew-ps = <1500>;
>> +   reg = <0>;
>> +   interrupt-parent = <>;
>> +   interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
>> +   };
>> +};

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

Re: [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB

[Simon Horman]

On Mon, Oct 02, 2017 at 01:18:49AM +, Yoshihiro Shimoda wrote:
> Hello,
> 
> > -Original Message-
> > From: Sergei Shtylyov
> > Sent: Saturday, September 30, 2017 7:24 PM
> > 
> > Hello!
> > 
> > On 9/29/2017 2:52 PM, Simon Horman wrote:
> > 
> > > From: Yoshihiro Shimoda 
> > >
> > > This patch enables EthernetAVB for R-Car D3 draak board.
> > >
> > > Signed-off-by: Yoshihiro Shimoda 
> > > Reviewed-by: Geert Uytterhoeven 
> > > Signed-off-by: Simon Horman 
> > > ---
> > >   arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 
> > > +
> > >   1 file changed, 25 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts 
> > > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > index 7b776cb7e928..96b7ff5cc321 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > [...]
> > > @@ -37,6 +39,14 @@
> > >   };
> > >
> > >{
> > > + avb0_pins: avb {
> > > + mux {
> > > + groups = "avb0_link", "avb0_phy_int", "avb0_mdc",
> >^^
> > Hum, I don't think it's compatible with routing the PHY interrupt via
> > GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT 
> > anyway.
> 
> Oops! You're correct. I should drop "avb0_phy_int".
> 
> Simon-san, may I send a follow-up patch to fix this?

Thanks Sergei, thanks Shimoda-san,

yes, please provide a follow-up patch.

At this stage I don't think we need to re-spin this pull-request
to fix this, rather a follow-up patch can be included
in a follow-up pull request.

> 
> Best regards,
> Yoshihiro Shimoda
> 
> > > +  "avb0_mii";
> > > + function = "avb0";
> > > + };
> > > + };
> > > +
> > >   scif2_pins: scif2 {
> > >   groups = "scif2_data";
> > >   function = "scif2";
> > > @@ -56,6 +66,21 @@
> > >   status = "okay";
> > >   };
> > >
> > > + {
> > > + pinctrl-0 = <_pins>;
> > > + pinctrl-names = "default";
> > > + renesas,no-ether-link;
> > > + phy-handle = <>;
> > > + status = "okay";
> > > +
> > > + phy0: ethernet-phy@0 {
> > > + rxc-skew-ps = <1500>;
> > > + reg = <0>;
> > > + interrupt-parent = <>;
> > > + interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
> > > + };
> > > +};
> > > +
> > >{
> > >   pinctrl-0 = <_pins>;
> > >   pinctrl-names = "default";
> > 
> > MBR, Sergei

RE: [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB

[Yoshihiro Shimoda]

Hello,

> -Original Message-
> From: Sergei Shtylyov
> Sent: Saturday, September 30, 2017 7:24 PM
> 
> Hello!
> 
> On 9/29/2017 2:52 PM, Simon Horman wrote:
> 
> > From: Yoshihiro Shimoda 
> >
> > This patch enables EthernetAVB for R-Car D3 draak board.
> >
> > Signed-off-by: Yoshihiro Shimoda 
> > Reviewed-by: Geert Uytterhoeven 
> > Signed-off-by: Simon Horman 
> > ---
> >   arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 
> > +
> >   1 file changed, 25 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts 
> > b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > index 7b776cb7e928..96b7ff5cc321 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> [...]
> > @@ -37,6 +39,14 @@
> >   };
> >
> >{
> > +   avb0_pins: avb {
> > +   mux {
> > +   groups = "avb0_link", "avb0_phy_int", "avb0_mdc",
>^^
> Hum, I don't think it's compatible with routing the PHY interrupt via
> GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway.

Oops! You're correct. I should drop "avb0_phy_int".

Simon-san, may I send a follow-up patch to fix this?

Best regards,
Yoshihiro Shimoda

> > +"avb0_mii";
> > +   function = "avb0";
> > +   };
> > +   };
> > +
> > scif2_pins: scif2 {
> > groups = "scif2_data";
> > function = "scif2";
> > @@ -56,6 +66,21 @@
> > status = "okay";
> >   };
> >
> > + {
> > +   pinctrl-0 = <_pins>;
> > +   pinctrl-names = "default";
> > +   renesas,no-ether-link;
> > +   phy-handle = <>;
> > +   status = "okay";
> > +
> > +   phy0: ethernet-phy@0 {
> > +   rxc-skew-ps = <1500>;
> > +   reg = <0>;
> > +   interrupt-parent = <>;
> > +   interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
> > +   };
> > +};
> > +
> >{
> > pinctrl-0 = <_pins>;
> > pinctrl-names = "default";
> 
> MBR, Sergei

Re: [PATCH 20/22] arm64: dts: renesas: r8a77995: draak: enable EthernetAVB

[Sergei Shtylyov]

Hello!

On 9/29/2017 2:52 PM, Simon Horman wrote:


From: Yoshihiro Shimoda 

This patch enables EthernetAVB for R-Car D3 draak board.

Signed-off-by: Yoshihiro Shimoda 
Reviewed-by: Geert Uytterhoeven 
Signed-off-by: Simon Horman 
---
  arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 25 +
  1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts 
b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index 7b776cb7e928..96b7ff5cc321 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts

[...]

@@ -37,6 +39,14 @@
  };
  
   {

+   avb0_pins: avb {
+   mux {
+   groups = "avb0_link", "avb0_phy_int", "avb0_mdc",

  ^^
   Hum, I don't think it's compatible with routing the PHY interrupt via 
GPIO5_19 below. The driver doesn't support signalling via AVB_PHY_INT anyway.



+"avb0_mii";
+   function = "avb0";
+   };
+   };
+
scif2_pins: scif2 {
groups = "scif2_data";
function = "scif2";
@@ -56,6 +66,21 @@
status = "okay";
  };
  
+ {

+   pinctrl-0 = <_pins>;
+   pinctrl-names = "default";
+   renesas,no-ether-link;
+   phy-handle = <>;
+   status = "okay";
+
+   phy0: ethernet-phy@0 {
+   rxc-skew-ps = <1500>;
+   reg = <0>;
+   interrupt-parent = <>;
+   interrupts = <19 IRQ_TYPE_LEVEL_LOW>;
+   };
+};
+
   {
pinctrl-0 = <_pins>;
pinctrl-names = "default";


MBR, Sergei