RE: what happened to /proc/vmallocinfo as of v4.15?

2019-02-15 Thread Chris Brandt
Thank you Geert!!!

I didn't even think about looking at the printk code!

Cheers
Chris


> -Original Message-
> From: Geert Uytterhoeven 
> Sent: Friday, February 15, 2019 1:02 PM
> To: Chris Brandt 
> Cc: linux-renesas-soc@vger.kernel.org
> Subject: Re: what happened to /proc/vmallocinfo as of v4.15?
> 
> Hi Chris,
> 
> On Fri, Feb 15, 2019 at 5:14 PM Chris Brandt 
> wrote:
> > I just noticed this yesterday and I can't seem to figure it out.
> >
> > In linux-4.14, vmallocinfo looked like this:
> >
> > $ cat /proc/vmallocinfo
> > 0xc280-0xc28020008192 of_iomap+0x19/0x22 phys=0xe8201000 ioremap
> > 0xc2802000-0xc28040008192 of_iomap+0x19/0x22 phys=0xe8202000 ioremap
> > 0xc2804000-0xc28060008192 l2x0_of_init+0x3f/0x174 phys=0x3000
> ioremap
> > 0xc2806000-0xc28080008192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> > 0xc2808000-0xc280a0008192 unpurged vm_area
> > 0xc280a000-0xc280c0008192 unpurged vm_area
> > 0xc280c000-0xc280e0008192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> > 0xc280e000-0xc2818192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> > 0xc281-0xc28120008192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> >
> >
> > However as of linux-4.15, it now looks like this:
> >
> > $ cat /proc/vmallocinfo
> > 0x2423e1ec-0x1d3488578192 of_iomap+0x19/0x22 phys=0xe8201000 ioremap
> > 0x1d348857-0x52c378408192 of_iomap+0x19/0x22 phys=0xe8202000 ioremap
> > 0x52c37840-0x402f3b088192 l2x0_of_init+0x3f/0x174 phys=0x3000
> ioremap
> > 0x402f3b08-0x06d553ef8192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> > 0x06d553ef-0xf6dfcceb8192 unpurged vm_area
> > 0xf6dfcceb-0xd99b65708192 unpurged vm_area
> > 0xd99b6570-0xa32d8fae8192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> > 0xa32d8fae-0xffd158558192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> > 0xffd15855-0x9d2cc6ea8192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> >
> >
> > The virtual addresses are all wrong!
> >
> > I can't seem to find any patches or code changes that would explain this.
> >
> > Does anyone have an idea why it now looks like this?
> 
> Please see commit ad67b74d2469d9b8 ("printk: hash addresses printed
> with %p").
> 
> Gr{oetje,eeting}s,
> 
> Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
> -- Linus Torvalds


Re: what happened to /proc/vmallocinfo as of v4.15?

2019-02-15 Thread Geert Uytterhoeven
Hi Chris,

On Fri, Feb 15, 2019 at 5:14 PM Chris Brandt  wrote:
> I just noticed this yesterday and I can't seem to figure it out.
>
> In linux-4.14, vmallocinfo looked like this:
>
> $ cat /proc/vmallocinfo
> 0xc280-0xc28020008192 of_iomap+0x19/0x22 phys=0xe8201000 ioremap
> 0xc2802000-0xc28040008192 of_iomap+0x19/0x22 phys=0xe8202000 ioremap
> 0xc2804000-0xc28060008192 l2x0_of_init+0x3f/0x174 phys=0x3000 ioremap
> 0xc2806000-0xc28080008192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> 0xc2808000-0xc280a0008192 unpurged vm_area
> 0xc280a000-0xc280c0008192 unpurged vm_area
> 0xc280c000-0xc280e0008192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> 0xc280e000-0xc2818192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> 0xc281-0xc28120008192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
>
>
> However as of linux-4.15, it now looks like this:
>
> $ cat /proc/vmallocinfo
> 0x2423e1ec-0x1d3488578192 of_iomap+0x19/0x22 phys=0xe8201000 ioremap
> 0x1d348857-0x52c378408192 of_iomap+0x19/0x22 phys=0xe8202000 ioremap
> 0x52c37840-0x402f3b088192 l2x0_of_init+0x3f/0x174 phys=0x3000 ioremap
> 0x402f3b08-0x06d553ef8192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> 0x06d553ef-0xf6dfcceb8192 unpurged vm_area
> 0xf6dfcceb-0xd99b65708192 unpurged vm_area
> 0xd99b6570-0xa32d8fae8192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> 0xa32d8fae-0xffd158558192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
> 0xffd15855-0x9d2cc6ea8192 of_iomap+0x19/0x22 phys=0xfcfe ioremap
>
>
> The virtual addresses are all wrong!
>
> I can't seem to find any patches or code changes that would explain this.
>
> Does anyone have an idea why it now looks like this?

Please see commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p").

Gr{oetje,eeting}s,

Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds