Re: [PATCH] dma: sh: convert to SPDX identifiers
On 12-09-18, 14:05, Geert Uytterhoeven wrote: > Hi Vinod, > > On Wed, Sep 12, 2018 at 11:43 AM Vinod wrote: > > Btw I have sent the series for dma_slave_config direction removal, sh/ > > drivers turned to be bit more, can you guys take care of it please? > > I'm sorry, I can't seem to find that. I though I had Cced renesas folks including you, but looks like I missed you, apologies > Can you please provide a link to the patch series? https://www.spinics.net/lists/dmaengine/msg16551.html Thanks -- ~Vinod
Re: [PATCH] dma: sh: convert to SPDX identifiers
Hi Vinod,
On Wed, Sep 12, 2018 at 11:43 AM Vinod wrote:
> Btw I have sent the series for dma_slave_config direction removal, sh/
> drivers turned to be bit more, can you guys take care of it please?
I'm sorry, I can't seem to find that.
Can you please provide a link to the patch series?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] dma: sh: convert to SPDX identifiers
On 11-09-18, 10:17, Geert Uytterhoeven wrote: > Hi Vinod, > > On Tue, Sep 11, 2018 at 9:48 AM Vinod wrote: > > On 07-09-18, 01:58, Kuninori Morimoto wrote: > > > From: Kuninori Morimoto > > > > > > This patch updates license to use SPDX-License-Identifier > > > instead of verbose license text. > > > > Thanks but the style is not consistent in files :( > > > > Can we use one only? > > Please read > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst#n69 > > 2. Style: > >The SPDX license identifier is added in form of a comment. The comment >style depends on the file type:: > > C source: // SPDX-License-Identifier: > C header: /* SPDX-License-Identifier: */ Right and I missed patch is doing for both c & h files, my bad Applying this now. Btw I have sent the series for dma_slave_config direction removal, sh/ drivers turned to be bit more, can you guys take care of it please? -- ~Vinod
Re: [PATCH] dma: sh: convert to SPDX identifiers
Hi Vinod
> > > From: Kuninori Morimoto
> > >
> > > This patch updates license to use SPDX-License-Identifier
> > > instead of verbose license text.
> >
> > Thanks but the style is not consistent in files :(
> >
> > Can we use one only?
>
> Please read
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst#n69
>
> 2. Style:
>
>The SPDX license identifier is added in form of a comment. The comment
>style depends on the file type::
>
> C source: // SPDX-License-Identifier:
> C header: /* SPDX-License-Identifier: */
>
> Gr{oetje,eeting}s,
And this, too
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst#n15
GPL-1.0+ : GNU General Public License v1.0 or later
GPL-2.0+ : GNU General Public License v2.0 or later
LGPL-2.0 : GNU Library General Public License v2 only
LGPL-2.0+ : GNU Library General Public License v2 or later
LGPL-2.1 : GNU Lesser General Public License v2.1 only
LGPL-2.1+ : GNU Lesser General Public License v2.1 or later
Best regards
---
Kuninori Morimoto
Re: [PATCH] dma: sh: convert to SPDX identifiers
Hi Vinod,
On Tue, Sep 11, 2018 at 9:48 AM Vinod wrote:
> On 07-09-18, 01:58, Kuninori Morimoto wrote:
> > From: Kuninori Morimoto
> >
> > This patch updates license to use SPDX-License-Identifier
> > instead of verbose license text.
>
> Thanks but the style is not consistent in files :(
>
> Can we use one only?
Please read
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst#n69
2. Style:
The SPDX license identifier is added in form of a comment. The comment
style depends on the file type::
C source: // SPDX-License-Identifier:
C header: /* SPDX-License-Identifier: */
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] dma: sh: convert to SPDX identifiers
On 07-09-18, 01:58, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. Thanks but the style is not consistent in files :( Can we use one only? > diff --git a/drivers/dma/sh/shdma-arm.h b/drivers/dma/sh/shdma-arm.h > index a1b0ef4..30bcfe3 100644 > --- a/drivers/dma/sh/shdma-arm.h > +++ b/drivers/dma/sh/shdma-arm.h > @@ -1,11 +1,8 @@ > -/* > +/* SPDX-License-Identifier: GPL-2.0 this is one > #ifndef SHDMA_ARM_H > diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c > index 6b5626e..c51de49 100644 > --- a/drivers/dma/sh/shdma-base.c > +++ b/drivers/dma/sh/shdma-base.c > @@ -1,3 +1,4 @@ > +// SPDX-License-Identifier: GPL-2.0 different > diff --git a/drivers/dma/sh/shdma.h b/drivers/dma/sh/shdma.h > index 2c0a969..73aec72 100644 > --- a/drivers/dma/sh/shdma.h > +++ b/drivers/dma/sh/shdma.h > @@ -1,14 +1,9 @@ > -/* > +/* SPDX-License-Identifier: GPL-2.0+ this and so on.. -- ~Vinod
Re: [PATCH] dma: sh: convert to SPDX identifiers
On Fri, Sep 07, 2018 at 01:58:59AM +, Kuninori Morimoto wrote: > > From: Kuninori Morimoto > > This patch updates license to use SPDX-License-Identifier > instead of verbose license text. > > Signed-off-by: Kuninori Morimoto Reviewed-by: Simon Horman
