Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-08 Thread Wolfram Sang
Eugeniu, > So, the idea is that the startup improvement of rcar_i2c_driver_init() > comes at the cost of a slower cs2000_driver_init(). In the end, > there is no benefit Thank you for the measurements and heads up on this! Much appreciated. The results match my expectations. > If evidence in

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-04 Thread Eugeniu Rosca
[re-sending due to lost To: field] Hello Wolfram, Vladimir, Thanks for your precious inputs. I think you outlined two topics in your comments (based on the description submitted with the patch). One (primary?) is related to async probing and one (secondary, but still interesting) is related to

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-04 Thread Eugeniu Rosca
Hello Wolfram, Vladimir, Thanks for your precious inputs. I think you outlined two topics in your comments (based on the description submitted with the patch). One (primary?) is related to async probing and one (secondary, but still interesting) is related to the minor (~7ms -> ~1ms) startup

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-03 Thread Wolfram Sang
> Thus putting an I2C master controller device driver to the same late > init level means that due to the concurrency there will be lots of > probe defers of endpoint device drivers, and making "heavy" device > drivers like rcar-vin to be run in asyncronous probe increases boot > time dispersion

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-03 Thread Vladimir Zapolskiy
Hi Wolfram, On 04/03/2018 06:55 PM, Wolfram Sang wrote: > Hi Vladimir and Eugeniu, > >> The purpose of this patch looks pretty similar to: >> 104522806a7d ("i2c: designware: dw_i2c_init_driver as subsys initcall") >> 74f56c4ad4e4 ("i2c-bfin-twi: move setup to the earlier subsys initcall") >>

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-04-03 Thread Wolfram Sang
Hi Vladimir and Eugeniu, > The purpose of this patch looks pretty similar to: > 104522806a7d ("i2c: designware: dw_i2c_init_driver as subsys initcall") > 74f56c4ad4e4 ("i2c-bfin-twi: move setup to the earlier subsys initcall") > b8680784875b ("i2c-gpio: Move initialization code to

Re: [PATCH] i2c: rcar: initialize earlier using subsys_initcall()

2018-03-28 Thread Eugeniu Rosca
Hello Wolfram and i2c/Renesas contributors, To give you some background behind this change, it is done in the context of rcar3 boot optimization, while trying to put our past experience in practice for reaching the "rvc-in-less-than-2s" requirement for our customers. The current commit