Re: [PATCH] watchdog: renesas-wdt: Add support for WDIOF_CARDRESET
> Reviewed-by: Guenetr Roeck Guenter, how about a keyboard macro to avoid such typos? ;) Fixed it in v2. signature.asc Description: PGP signature
Re: [PATCH] watchdog: renesas-wdt: Add support for WDIOF_CARDRESET
On Tue, Mar 20, 2018 at 10:36 PM, Wolfram Sang
wrote:
> From: Veeraiyan Chidambaram
>
> This patch adds the WDIOF_CARDRESET support for the Renessas platform
> watchdog, to know if the board reboot is due to a watchdog reset.
>
> This is done via the WOVF bit (bit 4) of the RWTCSRA register, which
> indicates if RWTCNT overflowed, triggering the reset in last boot.
>
> Signed-off-by: Veeraiyan Chidambaram
> [takeshi.kihara.df: changed to read the RWTCSRA register while clock is
> enabled]
> Signed-off-by: Takeshi Kihara
> Signed-off-by: Wolfram Sang
Reviewed-by: Geert Uytterhoeven
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Re: [PATCH] watchdog: renesas-wdt: Add support for WDIOF_CARDRESET
On Wed, Mar 21, 2018 at 01:40:55AM +0200, Vladimir Zapolskiy wrote: > Hi Wolfram, > > On 03/20/2018 11:36 PM, Wolfram Sang wrote: > > From: Veeraiyan Chidambaram > > > > This patch adds the WDIOF_CARDRESET support for the Renessas platform > > typo, s/Renessas/Renesas/ Ooops, thanks! signature.asc Description: PGP signature
Re: [PATCH] watchdog: renesas-wdt: Add support for WDIOF_CARDRESET
Hi Wolfram, On 03/20/2018 11:36 PM, Wolfram Sang wrote: > From: Veeraiyan Chidambaram > > This patch adds the WDIOF_CARDRESET support for the Renessas platform typo, s/Renessas/Renesas/ > watchdog, to know if the board reboot is due to a watchdog reset. > > This is done via the WOVF bit (bit 4) of the RWTCSRA register, which > indicates if RWTCNT overflowed, triggering the reset in last boot. > > Signed-off-by: Veeraiyan Chidambaram > [takeshi.kihara.df: changed to read the RWTCSRA register while clock is > enabled] > Signed-off-by: Takeshi Kihara > Signed-off-by: Wolfram Sang Reviewed-by: Vladimir Zapolskiy -- With best wishes, Vladimir
Re: [PATCH] watchdog: renesas-wdt: Add support for WDIOF_CARDRESET
On Tue, Mar 20, 2018 at 10:36:26PM +0100, Wolfram Sang wrote:
> From: Veeraiyan Chidambaram
>
> This patch adds the WDIOF_CARDRESET support for the Renessas platform
> watchdog, to know if the board reboot is due to a watchdog reset.
>
> This is done via the WOVF bit (bit 4) of the RWTCSRA register, which
> indicates if RWTCNT overflowed, triggering the reset in last boot.
>
> Signed-off-by: Veeraiyan Chidambaram
> [takeshi.kihara.df: changed to read the RWTCSRA register while clock is
> enabled]
> Signed-off-by: Takeshi Kihara
> Signed-off-by: Wolfram Sang
Reviewed-by: Guenetr Roeck
> ---
> drivers/watchdog/renesas_wdt.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/renesas_wdt.c b/drivers/watchdog/renesas_wdt.c
> index 6b8c6ddfe30b31..514db5cc159511 100644
> --- a/drivers/watchdog/renesas_wdt.c
> +++ b/drivers/watchdog/renesas_wdt.c
> @@ -121,7 +121,8 @@ static int rwdt_restart(struct watchdog_device *wdev,
> unsigned long action,
> }
>
> static const struct watchdog_info rwdt_ident = {
> - .options = WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT,
> + .options = WDIOF_MAGICCLOSE | WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT |
> + WDIOF_CARDRESET,
> .identity = "Renesas WDT Watchdog",
> };
>
> @@ -197,9 +198,10 @@ static int rwdt_probe(struct platform_device *pdev)
> return PTR_ERR(clk);
>
> pm_runtime_enable(&pdev->dev);
> -
> pm_runtime_get_sync(&pdev->dev);
> priv->clk_rate = clk_get_rate(clk);
> + priv->wdev.bootstatus = (readb_relaxed(priv->base + RWTCSRA) &
> + RWTCSRA_WOVF) ? WDIOF_CARDRESET : 0;
> pm_runtime_put(&pdev->dev);
>
> if (!priv->clk_rate) {
> --
> 2.11.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
