Re: [PATCH 0/3] Add SMP support
On Fri, Aug 11, 2017 at 09:37:45AM +, Biju Das wrote: > Hello, > > > > -Original Message- > > From: Biju Das > > Sent: 10 August 2017 12:19 > > To: 'Simon Horman' <ho...@verge.net.au> > > Cc: 'Rob Herring' <robh...@kernel.org>; 'Mark Rutland' > > <mark.rutl...@arm.com>; 'Magnus Damm' <magnus.d...@gmail.com>; > > 'Russell King' <li...@armlinux.org.uk>; Chris Paterson > > <chris.paters...@renesas.com>; 'devicet...@vger.kernel.org' > > <devicet...@vger.kernel.org>; 'linux-renesas-soc@vger.kernel.org' > renesas-...@vger.kernel.org>; 'linux-arm-ker...@lists.infradead.org' > arm-ker...@lists.infradead.org> > > Subject: RE: [PATCH 0/3] Add SMP support > > > > > > > > > -Original Message- > > > From: Biju Das > > > Sent: 10 August 2017 10:17 > > > To: 'Simon Horman' <ho...@verge.net.au> > > > Cc: Rob Herring <robh...@kernel.org>; Mark Rutland > > > <mark.rutl...@arm.com>; Magnus Damm <magnus.d...@gmail.com>; > > Russell > > > King <li...@armlinux.org.uk>; Chris Paterson > > > <chris.paters...@renesas.com>; devicet...@vger.kernel.org; > > > linux-renesas- s...@vger.kernel.org; > > > linux-arm-ker...@lists.infradead.org > > > Subject: RE: [PATCH 0/3] Add SMP support > > > > > > > > > > -Original Message- > > > > From: Simon Horman [mailto:ho...@verge.net.au] > > > > Sent: 09 August 2017 09:36 > > > > To: Biju Das <biju@bp.renesas.com> > > > > Cc: Rob Herring <robh...@kernel.org>; Mark Rutland > > > > <mark.rutl...@arm.com>; Magnus Damm <magnus.d...@gmail.com>; > > > Russell > > > > King <li...@armlinux.org.uk>; Chris Paterson > > > > <chris.paters...@renesas.com>; devicet...@vger.kernel.org; > > > > linux-renesas- s...@vger.kernel.org; > > > > linux-arm-ker...@lists.infradead.org > > > > Subject: Re: [PATCH 0/3] Add SMP support > > > > > > > > On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote: > > > > > This series aims to add SMP support for r8a7743 SoC. > > > > > > > > > > This series has been tested against Linux-next tag 20170727 and > > > > > renesas-dev branch. > > > > > > > > It seems that these patches are targeted at the renesas tree. > > > > The best practice in that case is to base patches on the latest devel > > > > branch. > > > > Please consider doing so in future. > > > > > > > > The patches themselves seem good to me, however, I would like to > > > > enquire about testing. In particular, have you tested CPU hotplug > > > > and suspend to RAM with these patches (and without in the case of the > > latter)? > > > > > > I have tested CPU hotplug with this patch and it works ok. > > > > > > Currently iWave platform doesn't support STR I guess. But we should > > > check the changes on other M2 platforms to prove that things don't break. > > I have tested STR on iWave RZ-G1M platform as well. I used ttySC0 as wake up > Source(echo enabled > /sys/class/tty/ttySC0/power/wakeup) > > It works fine with and without the patch . > > It is tested against renesas-developer branch tag 20170809-v4.13-rc4. > > > I have tested STR on RZ-G1M SK(r8a7743) platform using gpio-key as wake up > > source. > > It works fine with and without the patch . It is tested against > > renesas-developer > > branch. > > > > Also I have tested STR on R-Car M2 board.it works fine with gpio-key as wake > > up source. > > > > > [>] > > > > I am cautious about any regressions that may creep in when going > > > > from UP to SMP. Thanks for testing, I have applied this series.
RE: [PATCH 0/3] Add SMP support
Hello, > -Original Message- > From: Biju Das > Sent: 10 August 2017 12:19 > To: 'Simon Horman' <ho...@verge.net.au> > Cc: 'Rob Herring' <robh...@kernel.org>; 'Mark Rutland' > <mark.rutl...@arm.com>; 'Magnus Damm' <magnus.d...@gmail.com>; > 'Russell King' <li...@armlinux.org.uk>; Chris Paterson > <chris.paters...@renesas.com>; 'devicet...@vger.kernel.org' > <devicet...@vger.kernel.org>; 'linux-renesas-soc@vger.kernel.org' renesas-...@vger.kernel.org>; 'linux-arm-ker...@lists.infradead.org' arm-ker...@lists.infradead.org> > Subject: RE: [PATCH 0/3] Add SMP support > > > > > -Original Message- > > From: Biju Das > > Sent: 10 August 2017 10:17 > > To: 'Simon Horman' <ho...@verge.net.au> > > Cc: Rob Herring <robh...@kernel.org>; Mark Rutland > > <mark.rutl...@arm.com>; Magnus Damm <magnus.d...@gmail.com>; > Russell > > King <li...@armlinux.org.uk>; Chris Paterson > > <chris.paters...@renesas.com>; devicet...@vger.kernel.org; > > linux-renesas- s...@vger.kernel.org; > > linux-arm-ker...@lists.infradead.org > > Subject: RE: [PATCH 0/3] Add SMP support > > > > > > > -Original Message- > > > From: Simon Horman [mailto:ho...@verge.net.au] > > > Sent: 09 August 2017 09:36 > > > To: Biju Das <biju@bp.renesas.com> > > > Cc: Rob Herring <robh...@kernel.org>; Mark Rutland > > > <mark.rutl...@arm.com>; Magnus Damm <magnus.d...@gmail.com>; > > Russell > > > King <li...@armlinux.org.uk>; Chris Paterson > > > <chris.paters...@renesas.com>; devicet...@vger.kernel.org; > > > linux-renesas- s...@vger.kernel.org; > > > linux-arm-ker...@lists.infradead.org > > > Subject: Re: [PATCH 0/3] Add SMP support > > > > > > On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote: > > > > This series aims to add SMP support for r8a7743 SoC. > > > > > > > > This series has been tested against Linux-next tag 20170727 and > > > > renesas-dev branch. > > > > > > It seems that these patches are targeted at the renesas tree. > > > The best practice in that case is to base patches on the latest devel > > > branch. > > > Please consider doing so in future. > > > > > > The patches themselves seem good to me, however, I would like to > > > enquire about testing. In particular, have you tested CPU hotplug > > > and suspend to RAM with these patches (and without in the case of the > latter)? > > > > I have tested CPU hotplug with this patch and it works ok. > > > > Currently iWave platform doesn't support STR I guess. But we should > > check the changes on other M2 platforms to prove that things don't break. I have tested STR on iWave RZ-G1M platform as well. I used ttySC0 as wake up Source(echo enabled > /sys/class/tty/ttySC0/power/wakeup) It works fine with and without the patch . It is tested against renesas-developer branch tag 20170809-v4.13-rc4. > I have tested STR on RZ-G1M SK(r8a7743) platform using gpio-key as wake up > source. > It works fine with and without the patch . It is tested against > renesas-developer > branch. > > Also I have tested STR on R-Car M2 board.it works fine with gpio-key as wake > up source. > > > [>] > > > I am cautious about any regressions that may creep in when going > > > from UP to SMP. > > > > > > > > > > Biju Das (3): > > > > dt-bindings: apmu: Document r8a7743 support > > > > ARM: dts: r8a7743: Add APMU node and second CPU core > > > > ARM: dts: r8a7743: Add OPP table for frequency scaling > > > > > > > > .../devicetree/bindings/power/renesas,apmu.txt | 3 ++- > > > > arch/arm/boot/dts/r8a7743.dtsi | 25 > > ++ > > > > 2 files changed, 27 insertions(+), 1 deletion(-) > > > > > > > > -- > > > > 1.9.1 > > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
RE: [PATCH 0/3] Add SMP support
> -Original Message- > From: Biju Das > Sent: 10 August 2017 10:17 > To: 'Simon Horman' <ho...@verge.net.au> > Cc: Rob Herring <robh...@kernel.org>; Mark Rutland > <mark.rutl...@arm.com>; Magnus Damm <magnus.d...@gmail.com>; > Russell King <li...@armlinux.org.uk>; Chris Paterson > <chris.paters...@renesas.com>; devicet...@vger.kernel.org; linux-renesas- > s...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: RE: [PATCH 0/3] Add SMP support > > > > -Original Message- > > From: Simon Horman [mailto:ho...@verge.net.au] > > Sent: 09 August 2017 09:36 > > To: Biju Das <biju@bp.renesas.com> > > Cc: Rob Herring <robh...@kernel.org>; Mark Rutland > > <mark.rutl...@arm.com>; Magnus Damm <magnus.d...@gmail.com>; > Russell > > King <li...@armlinux.org.uk>; Chris Paterson > > <chris.paters...@renesas.com>; devicet...@vger.kernel.org; > > linux-renesas- s...@vger.kernel.org; > > linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH 0/3] Add SMP support > > > > On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote: > > > This series aims to add SMP support for r8a7743 SoC. > > > > > > This series has been tested against Linux-next tag 20170727 and > > > renesas-dev branch. > > > > It seems that these patches are targeted at the renesas tree. > > The best practice in that case is to base patches on the latest devel > > branch. > > Please consider doing so in future. > > > > The patches themselves seem good to me, however, I would like to > > enquire about testing. In particular, have you tested CPU hotplug and > > suspend to RAM with these patches (and without in the case of the latter)? > > I have tested CPU hotplug with this patch and it works ok. > > Currently iWave platform doesn't support STR I guess. But we should check the > changes on other M2 platforms to prove that things don't break. I have tested STR on RZ-G1M SK(r8a7743) platform using gpio-key as wake up source. It works fine with and without the patch . It is tested against renesas-developer branch. Also I have tested STR on R-Car M2 board.it works fine with gpio-key as wake up source. > [>] > > I am cautious about any regressions that may creep in when going from > > UP to SMP. > > > > > > > Biju Das (3): > > > dt-bindings: apmu: Document r8a7743 support > > > ARM: dts: r8a7743: Add APMU node and second CPU core > > > ARM: dts: r8a7743: Add OPP table for frequency scaling > > > > > > .../devicetree/bindings/power/renesas,apmu.txt | 3 ++- > > > arch/arm/boot/dts/r8a7743.dtsi | 25 > ++ > > > 2 files changed, 27 insertions(+), 1 deletion(-) > > > > > > -- > > > 1.9.1 > > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
RE: [PATCH 0/3] Add SMP support
> -Original Message- > From: Simon Horman [mailto:ho...@verge.net.au] > Sent: 09 August 2017 09:36 > To: Biju Das <biju@bp.renesas.com> > Cc: Rob Herring <robh...@kernel.org>; Mark Rutland > <mark.rutl...@arm.com>; Magnus Damm <magnus.d...@gmail.com>; > Russell King <li...@armlinux.org.uk>; Chris Paterson > <chris.paters...@renesas.com>; devicet...@vger.kernel.org; linux-renesas- > s...@vger.kernel.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH 0/3] Add SMP support > > On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote: > > This series aims to add SMP support for r8a7743 SoC. > > > > This series has been tested against Linux-next tag 20170727 and > > renesas-dev branch. > > It seems that these patches are targeted at the renesas tree. > The best practice in that case is to base patches on the latest devel branch. > Please consider doing so in future. > > The patches themselves seem good to me, however, I would like to enquire > about testing. In particular, have you tested CPU hotplug and suspend to RAM > with these patches (and without in the case of the latter)? I have tested CPU hotplug with this patch and it works ok. Currently iWave platform doesn't support STR I guess. But we should check the changes on other M2 platforms to prove that things don't break. [>] > I am cautious about any regressions that may creep in when going from UP to > SMP. > > > > Biju Das (3): > > dt-bindings: apmu: Document r8a7743 support > > ARM: dts: r8a7743: Add APMU node and second CPU core > > ARM: dts: r8a7743: Add OPP table for frequency scaling > > > > .../devicetree/bindings/power/renesas,apmu.txt | 3 ++- > > arch/arm/boot/dts/r8a7743.dtsi | 25 > > ++ > > 2 files changed, 27 insertions(+), 1 deletion(-) > > > > -- > > 1.9.1 > > Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
Re: [PATCH 0/3] Add SMP support
On Tue, Aug 08, 2017 at 11:56:30AM +0100, Biju Das wrote: > This series aims to add SMP support for r8a7743 SoC. > > This series has been tested against Linux-next tag 20170727 > and renesas-dev branch. It seems that these patches are targeted at the renesas tree. The best practice in that case is to base patches on the latest devel branch. Please consider doing so in future. The patches themselves seem good to me, however, I would like to enquire about testing. In particular, have you tested CPU hotplug and suspend to RAM with these patches (and without in the case of the latter)? I am cautious about any regressions that may creep in when going from UP to SMP. > > Biju Das (3): > dt-bindings: apmu: Document r8a7743 support > ARM: dts: r8a7743: Add APMU node and second CPU core > ARM: dts: r8a7743: Add OPP table for frequency scaling > > .../devicetree/bindings/power/renesas,apmu.txt | 3 ++- > arch/arm/boot/dts/r8a7743.dtsi | 25 > ++ > 2 files changed, 27 insertions(+), 1 deletion(-) > > -- > 1.9.1 >
