Re: [PATCH 1/5] scripts: Test suite runner

[Kieran Bingham]

On 25/11/16 18:21, Laurent Pinchart wrote:
> Hi Kieran,
> 
> Thank you for the patch.
> 
> On Friday 25 Nov 2016 13:59:12 Kieran Bingham wrote:
>> From: Kieran Bingham 
>>
>> Provide a utility script to execute all vsp unit tests, as well
>> as the option to execute multiple iterations of the suite.
>>
>> Signed-off-by: Kieran Bingham 
>> ---
>>  scripts/vsp-tests.sh | 46 ++
>>  1 file changed, 46 insertions(+)
>>  create mode 100755 scripts/vsp-tests.sh
>>
>> diff --git a/scripts/vsp-tests.sh b/scripts/vsp-tests.sh
>> new file mode 100755
>> index ..e5ffa0ec4236
>> --- /dev/null
>> +++ b/scripts/vsp-tests.sh
>> @@ -0,0 +1,46 @@
>> +#!/bin/sh
>> +
>> +##
>> +## VSP Tests runner
>> +##
>> +## Automatically execute all vsp-unit tests
>> +## Move test failure results to a specific folder for
>> +## the running kernel version
>> +##
>> +## An argument can be provided to specify the number of
>> +## iterations to perform
>> +##
>> +## usage:
>> +##  ./vsp-tests.sh 
>> +##
>> +##   n: Number of iterations to execute test suite
>> +##
>> +
>> +KERNEL_VERSION=`uname -r`
>> +
>> +run_test() {
>> +echo $1
>> +./$1
>> +
>> +if [ $(ls *.bin 2>/dev/null | wc -l) != 0 ];
>> +then
>> +RESULTS_DIR=$KERNEL_VERSION/test-$1/$2/
>> +
>> +echo "Moving *.bin to test-$1/$2/";
> 
> You can remove the ; at the end of the lines.
> 
>> +mkdir -p $RESULTS_DIR;
>> +echo "mv *.bin $RESULTS_DIR";
> 
> Do we really need this message ?

We certainly don't need two :D.

I'll combine the best bits of them both :D
echo "Moving test failures to $RESULTS_DIR";

And in fact, now that bin2png.sh works on the target - this could also
generate the PNG files immediately which would be useful.

>> +mv *.bin $RESULTS_DIR;
>> +fi;
>> +}
>> +
>> +run_suite() {
>> +echo "Test loop $1"
>> +
>> +for test in vsp-unit-test*.sh; do
>> +run_test $test $1;
>> +done;
>> +}
>> +
>> +for loop in `seq 1 1 $1`; do
>> +run_suite $loop
>> +done;
> 

-- 
Regards

Kieran Bingham

Re: [PATCH 1/5] scripts: Test suite runner

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Friday 25 Nov 2016 13:59:12 Kieran Bingham wrote:
> From: Kieran Bingham 
> 
> Provide a utility script to execute all vsp unit tests, as well
> as the option to execute multiple iterations of the suite.
> 
> Signed-off-by: Kieran Bingham 
> ---
>  scripts/vsp-tests.sh | 46 ++
>  1 file changed, 46 insertions(+)
>  create mode 100755 scripts/vsp-tests.sh
> 
> diff --git a/scripts/vsp-tests.sh b/scripts/vsp-tests.sh
> new file mode 100755
> index ..e5ffa0ec4236
> --- /dev/null
> +++ b/scripts/vsp-tests.sh
> @@ -0,0 +1,46 @@
> +#!/bin/sh
> +
> +##
> +## VSP Tests runner
> +##
> +## Automatically execute all vsp-unit tests
> +## Move test failure results to a specific folder for
> +## the running kernel version
> +##
> +## An argument can be provided to specify the number of
> +## iterations to perform
> +##
> +## usage:
> +##  ./vsp-tests.sh 
> +##
> +##   n: Number of iterations to execute test suite
> +##
> +
> +KERNEL_VERSION=`uname -r`
> +
> +run_test() {
> + echo $1
> + ./$1
> +
> + if [ $(ls *.bin 2>/dev/null | wc -l) != 0 ];
> + then
> + RESULTS_DIR=$KERNEL_VERSION/test-$1/$2/
> +
> + echo "Moving *.bin to test-$1/$2/";

You can remove the ; at the end of the lines.

> + mkdir -p $RESULTS_DIR;
> + echo "mv *.bin $RESULTS_DIR";

Do we really need this message ?

> + mv *.bin $RESULTS_DIR;
> + fi;
> +}
> +
> +run_suite() {
> + echo "Test loop $1"
> +
> + for test in vsp-unit-test*.sh; do
> + run_test $test $1;
> + done;
> +}
> +
> +for loop in `seq 1 1 $1`; do
> + run_suite $loop
> +done;

-- 
Regards,

Laurent Pinchart