Re: [PATCH 2/3] dt-bindings: thermal: rcar-thermal: add R8A77995 support

[Yoshihiro Kaneko]

Hi Geert-san,

Thank you for your review!

2018-03-12 19:13 GMT+09:00 Geert Uytterhoeven :
> Hi Kaneko-san,
>
> On Sun, Mar 11, 2018 at 9:26 PM, Yoshihiro Kaneko  
> wrote:
>> Signed-off-by: Yoshihiro Kaneko 
>
> Thanks for your patch!
>
>> --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
>> +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
>> @@ -12,6 +12,7 @@ Required properties:
>> - "renesas,thermal-r8a7791" (R-Car M2-W)
>> - "renesas,thermal-r8a7792" (R-Car V2H)
>> - "renesas,thermal-r8a7793" (R-Car M2-N)
>> +   - "renesas,thermal-r8a77995" (R-Car D3)
>
> OK for this change.
>
> I think the paragraph above needs some clarification, too:
>
> Required properties:
> - compatible: "renesas,thermal-",
>"renesas,rcar-gen2-thermal" (with
> thermal-zone) or
>"renesas,rcar-thermal" (without
> thermal-zone) as fallback.
>
> Your DT update for D3 contains the thermal-zone, but it is not R-Car Gen2,
> while you declare it compatible with "renesas,rcar-thermal".
>
> Probably we can just drop the fallback for D3 (and V3M later)?

It sounds good.
I will update DT to drop the fallback for D3.

>
> And the paragraph about interrupts need an update, too, as D3 has more
> than one interrupt:
>
> Option properties:
> - interrupts: use interrupt

I will update this paragraph.


Thanks,
Kaneko

>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- 
> ge...@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like 
> that.
> -- Linus Torvalds

Re: [PATCH 2/3] dt-bindings: thermal: rcar-thermal: add R8A77995 support

[Geert Uytterhoeven]

Hi Kaneko-san,

On Sun, Mar 11, 2018 at 9:26 PM, Yoshihiro Kaneko  wrote:
> Signed-off-by: Yoshihiro Kaneko 

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> @@ -12,6 +12,7 @@ Required properties:
> - "renesas,thermal-r8a7791" (R-Car M2-W)
> - "renesas,thermal-r8a7792" (R-Car V2H)
> - "renesas,thermal-r8a7793" (R-Car M2-N)
> +   - "renesas,thermal-r8a77995" (R-Car D3)

OK for this change.

I think the paragraph above needs some clarification, too:

Required properties:
- compatible: "renesas,thermal-",
   "renesas,rcar-gen2-thermal" (with
thermal-zone) or
   "renesas,rcar-thermal" (without
thermal-zone) as fallback.

Your DT update for D3 contains the thermal-zone, but it is not R-Car Gen2,
while you declare it compatible with "renesas,rcar-thermal".

Probably we can just drop the fallback for D3 (and V3M later)?

And the paragraph about interrupts need an update, too, as D3 has more
than one interrupt:

Option properties:
- interrupts: use interrupt

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds