Re: [PATCH 2/4] arm64: dts: renesas: r8a77990: Add GPIO device nodes

2018-05-16 Thread Simon Horman 
On Sun, May 13, 2018 at 11:02:05AM +0200, Simon Horman wrote:
> On Fri, May 11, 2018 at 01:31:19PM +0900, Yoshihiro Shimoda wrote:
> > This patch adds GPIO nodes for r8a77990 (R-Car E3).
> > 
> > Based on a patch from Takeshi Kihara 
> > 
> > Signed-off-by: Yoshihiro Shimoda 
> > ---
> >  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 112 
> > ++
> >  1 file changed, 112 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi 
> > b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > index efc3c0b..d94e047 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> > @@ -60,6 +60,118 @@
> > #size-cells = <2>;
> > ranges;
> >  
> > +   gpio0: gpio@e605 {
> > +   compatible = "renesas,gpio-r8a77990",
> > +"renesas,rcar-gen3-gpio",
> > +"renesas,gpio-rcar";
> 
> "renesas,gpio-rcar" is deprecated and thus should not be added to DT any
> more. I will see about removing it from r8a77995.dtsi which seems to be the
> only place that it used in mainline.
> 
> Otherwise this patch looks good to me.

I have applied this patch after removing "renesas,gpio-rcar".

The result is as follows.


From: Yoshihiro Shimoda 
Subject: [PATCH] arm64: dts: renesas: r8a77990: Add GPIO device nodes

This patch adds GPIO nodes for r8a77990 (R-Car E3).

Based on a patch from Takeshi Kihara 

Signed-off-by: Yoshihiro Shimoda 
[simon: dropped use of deprecated "renesas,gpio-rcar"]
Signed-off-by: Simon Horman 
---
 arch/arm64/boot/dts/renesas/r8a77990.dtsi | 105 ++
 1 file changed, 105 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi 
b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index efc3c0ba36c2..bbc3db50bc01 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -60,6 +60,111 @@
#size-cells = <2>;
ranges;
 
+   gpio0: gpio@e605 {
+   compatible = "renesas,gpio-r8a77990",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe605 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = < 0 0 18>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = < CPG_MOD 912>;
+   power-domains = < 32>;
+   resets = < 912>;
+   };
+
+   gpio1: gpio@e6051000 {
+   compatible = "renesas,gpio-r8a77990",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe6051000 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = < 0 32 23>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = < CPG_MOD 911>;
+   power-domains = < 32>;
+   resets = < 911>;
+   };
+
+   gpio2: gpio@e6052000 {
+   compatible = "renesas,gpio-r8a77990",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe6052000 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = < 0 64 26>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = < CPG_MOD 910>;
+   power-domains = < 32>;
+   resets = < 910>;
+   };
+
+   gpio3: gpio@e6053000 {
+   compatible = "renesas,gpio-r8a77990",
+"renesas,rcar-gen3-gpio";
+   reg = <0 0xe6053000 0 0x50>;
+   interrupts = ;
+   #gpio-cells = <2>;
+   gpio-controller;
+   gpio-ranges = < 0 96 16>;
+   #interrupt-cells = <2>;
+   interrupt-controller;
+   clocks = < CPG_MOD 909>;
+   power-domains = < 32>;
+   resets = < 909>;
+   };
+
+   gpio4: gpio@e6054000 {
+   compatible = "renesas,gpio-r8a77990",
+"renesas,rcar-gen3-gpio";
+

Re: [PATCH 2/4] arm64: dts: renesas: r8a77990: Add GPIO device nodes

2018-05-13 Thread Simon Horman 
On Fri, May 11, 2018 at 01:31:19PM +0900, Yoshihiro Shimoda wrote:
> This patch adds GPIO nodes for r8a77990 (R-Car E3).
> 
> Based on a patch from Takeshi Kihara 
> 
> Signed-off-by: Yoshihiro Shimoda 
> ---
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 112 
> ++
>  1 file changed, 112 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi 
> b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index efc3c0b..d94e047 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -60,6 +60,118 @@
>   #size-cells = <2>;
>   ranges;
>  
> + gpio0: gpio@e605 {
> + compatible = "renesas,gpio-r8a77990",
> +  "renesas,rcar-gen3-gpio",
> +  "renesas,gpio-rcar";

"renesas,gpio-rcar" is deprecated and thus should not be added to DT any
more. I will see about removing it from r8a77995.dtsi which seems to be the
only place that it used in mainline.

Otherwise this patch looks good to me.

> + reg = <0 0xe605 0 0x50>;
> + interrupts = ;
> + #gpio-cells = <2>;
> + gpio-controller;
> + gpio-ranges = < 0 0 18>;
> + #interrupt-cells = <2>;
> + interrupt-controller;
> + clocks = < CPG_MOD 912>;
> + power-domains = < 32>;
> + resets = < 912>;
> + };

...