Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes
On Thu, Feb 15, 2018 at 04:20:42PM +, Kieran Bingham wrote: > Hi Simon, > > On 15/02/18 16:14, Simon Horman wrote: > > On Tue, Feb 13, 2018 at 02:32:22PM +0200, Laurent Pinchart wrote: > >> Hi Kieran, > >> > >> Thank you for the patch. > >> > >> On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote: > >>> From: Kieran Bingham > >>> > >>> The FCPVD handles the interface between the VSPD and memory. > >>> > >>> Signed-off-by: Kieran Bingham > >> > >> Reviewed-by: Laurent Pinchart > >> > >> I would however squash this with patch 1/4 from the same series. > > > > Thanks, I've taken the liberty of doing so when applying this patch. > > The result is as follows: > > That's probably fine, but there was a follow up series which already handles > this. Thanks, I've dropped this and will use the follow-up series instead.
Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes
Hi Simon, On 15/02/18 16:14, Simon Horman wrote: > On Tue, Feb 13, 2018 at 02:32:22PM +0200, Laurent Pinchart wrote: >> Hi Kieran, >> >> Thank you for the patch. >> >> On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote: >>> From: Kieran Bingham >>> >>> The FCPVD handles the interface between the VSPD and memory. >>> >>> Signed-off-by: Kieran Bingham >> >> Reviewed-by: Laurent Pinchart >> >> I would however squash this with patch 1/4 from the same series. > > Thanks, I've taken the liberty of doing so when applying this patch. > The result is as follows: That's probably fine, but there was a follow up series which already handles this. -- Kieran > From: Kieran Bingham > Subject: [PATCH] arm64: dts: renesas: r8a77995: add FCPV[BD] node > > The FCPVB handles the interface between the VSPB and memory. > The FCPVD handles the interface between the VSPD and memory. > > Signed-off-by: Kieran Bingham > Reviewed-by: Laurent Pinchart > [simon: squahsed FCPVB and FCPVD patches] > Signed-off-by: Simon Horman > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > index cd3c6a30fc47..196a917afea6 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -691,6 +691,33 @@ > #phy-cells = <0>; > status = "disabled"; > }; > + > + fcpvb0: fcp@fe96f000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfe96f000 0 0x200>; > + clocks = <&cpg CPG_MOD 607>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 607>; > + iommus = <&ipmmu_vp0 5>; > + }; > + > + fcpvd0: fcp@fea27000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfea27000 0 0x200>; > + clocks = <&cpg CPG_MOD 603>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 603>; > + iommus = <&ipmmu_vi0 8>; > + }; > + > + fcpvd1: fcp@fea2f000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfea2f000 0 0x200>; > + clocks = <&cpg CPG_MOD 602>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 602>; > + iommus = <&ipmmu_vi0 9>; > + }; > }; > > timer { >
Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes
On Tue, Feb 13, 2018 at 02:32:22PM +0200, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote: > > From: Kieran Bingham > > > > The FCPVD handles the interface between the VSPD and memory. > > > > Signed-off-by: Kieran Bingham > > Reviewed-by: Laurent Pinchart > > I would however squash this with patch 1/4 from the same series. Thanks, I've taken the liberty of doing so when applying this patch. The result is as follows: From: Kieran Bingham Subject: [PATCH] arm64: dts: renesas: r8a77995: add FCPV[BD] node The FCPVB handles the interface between the VSPB and memory. The FCPVD handles the interface between the VSPD and memory. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart [simon: squahsed FCPVB and FCPVD patches] Signed-off-by: Simon Horman --- arch/arm64/boot/dts/renesas/r8a77995.dtsi | 27 +++ 1 file changed, 27 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index cd3c6a30fc47..196a917afea6 100644 --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi @@ -691,6 +691,33 @@ #phy-cells = <0>; status = "disabled"; }; + + fcpvb0: fcp@fe96f000 { + compatible = "renesas,fcpv"; + reg = <0 0xfe96f000 0 0x200>; + clocks = <&cpg CPG_MOD 607>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 607>; + iommus = <&ipmmu_vp0 5>; + }; + + fcpvd0: fcp@fea27000 { + compatible = "renesas,fcpv"; + reg = <0 0xfea27000 0 0x200>; + clocks = <&cpg CPG_MOD 603>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 603>; + iommus = <&ipmmu_vi0 8>; + }; + + fcpvd1: fcp@fea2f000 { + compatible = "renesas,fcpv"; + reg = <0 0xfea2f000 0 0x200>; + clocks = <&cpg CPG_MOD 602>; + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; + resets = <&cpg 602>; + iommus = <&ipmmu_vi0 9>; + }; }; timer { -- 2.11.0
Re: [PATCH 2/4] arm64: dts: renesas: r8a77995: add FCPVD nodes
Hi Kieran, Thank you for the patch. On Tuesday, 13 February 2018 00:25:27 EET Kieran Bingham wrote: > From: Kieran Bingham > > The FCPVD handles the interface between the VSPD and memory. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart I would however squash this with patch 1/4 from the same series. > --- > arch/arm64/boot/dts/renesas/r8a77995.dtsi | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > b/arch/arm64/boot/dts/renesas/r8a77995.dtsi index > 6cf935d307d9..196a917afea6 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77995.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77995.dtsi > @@ -700,6 +700,24 @@ > resets = <&cpg 607>; > iommus = <&ipmmu_vp0 5>; > }; > + > + fcpvd0: fcp@fea27000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfea27000 0 0x200>; > + clocks = <&cpg CPG_MOD 603>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 603>; > + iommus = <&ipmmu_vi0 8>; > + }; > + > + fcpvd1: fcp@fea2f000 { > + compatible = "renesas,fcpv"; > + reg = <0 0xfea2f000 0 0x200>; > + clocks = <&cpg CPG_MOD 602>; > + power-domains = <&sysc R8A77995_PD_ALWAYS_ON>; > + resets = <&cpg 602>; > + iommus = <&ipmmu_vi0 9>; > + }; > }; > > timer { -- Regards, Laurent Pinchart