RE: [PATCH 3/3] ARM: dts: rskrza1: add ostm DT support
Hi Geert and Sergei, On Friday, January 13, 2017, Geert Uytterhoeven wrote: > On Thu, Jan 12, 2017 at 8:01 PM, Chris Brandt > wrote: > > --- a/arch/arm/boot/dts/r7s72100.dtsi > > +++ b/arch/arm/boot/dts/r7s72100.dtsi > > @@ -513,7 +513,8 @@ > > interrupts = > GIC_SPI 103 IRQ_TYPE_EDGE_RISING>; > > > > - clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, <&mstp5_clks > R7S72100_CLK_OSTM1>; > > + clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, > > +<&mstp5_clks R7S72100_CLK_OSTM1>; > > I think this change should be folded into "[PATCH 2/3] ARM: dts: r7s72100: > add ostm to device tree" ;-) Oops, I think I got things a little screwed up when git rebasing and reordering and such. Thanks for the review! Chris
Re: [PATCH 3/3] ARM: dts: rskrza1: add ostm DT support
Hello! On 1/12/2017 10:01 PM, Chris Brandt wrote: Signed-off-by: Chris Brandt [...] diff --git a/arch/arm/boot/dts/r7s72100.dtsi b/arch/arm/boot/dts/r7s72100.dtsi index 247bbe0..974c084 100644 --- a/arch/arm/boot/dts/r7s72100.dtsi +++ b/arch/arm/boot/dts/r7s72100.dtsi @@ -513,7 +513,8 @@ interrupts = ; - clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, <&mstp5_clks R7S72100_CLK_OSTM1>; + clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, +<&mstp5_clks R7S72100_CLK_OSTM1>; Unintended change? status = "disabled"; }; }; MBR, Sergei
Re: [PATCH 3/3] ARM: dts: rskrza1: add ostm DT support
Hi Chris, On Thu, Jan 12, 2017 at 8:01 PM, Chris Brandt wrote: > --- a/arch/arm/boot/dts/r7s72100.dtsi > +++ b/arch/arm/boot/dts/r7s72100.dtsi > @@ -513,7 +513,8 @@ > interrupts =GIC_SPI 103 IRQ_TYPE_EDGE_RISING>; > > - clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, <&mstp5_clks > R7S72100_CLK_OSTM1>; > + clocks = <&mstp5_clks R7S72100_CLK_OSTM0>, > +<&mstp5_clks R7S72100_CLK_OSTM1>; I think this change should be folded into "[PATCH 2/3] ARM: dts: r7s72100: add ostm to device tree" ;-) > status = "disabled"; > }; > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds