Re: [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support

2018-02-13 Thread Wolfram Sang
On Tue, Feb 13, 2018 at 12:33:53PM +0100, Simon Horman wrote: > On Wed, Feb 07, 2018 at 11:20:12PM +0100, Wolfram Sang wrote: > > > > Hi Simon, > > > > > + void (*disable_scc)(struct mmc_host *mmc); > > > > Do we really need this callback? I'd think it can be folded into > > reset_hs400_mode()

Re: [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support

2018-02-13 Thread Simon Horman
On Wed, Feb 07, 2018 at 11:20:12PM +0100, Wolfram Sang wrote: > > Hi Simon, > > > + void (*disable_scc)(struct mmc_host *mmc); > > Do we really need this callback? I'd think it can be folded into > reset_hs400_mode() because it is called only once? > > > + void

Re: [PATCH v2 2/3] mmc: tmio: add eMMC HS400 mode support

2018-02-07 Thread Wolfram Sang
Hi Simon, > + void (*disable_scc)(struct mmc_host *mmc); Do we really need this callback? I'd think it can be folded into reset_hs400_mode() because it is called only once? > + void (*prepare_hs400_tuning)(struct mmc_host *mmc, struct mmc_ios *ios); Can't we use the