Re: [PATCH v2 3/3] drm: rcar-du: lvds: Refactor LVDS startup

[Laurent Pinchart]

Hi Sergei,

On Wednesday, 14 February 2018 20:39:59 EET Sergei Shtylyov wrote:
> On 02/14/2018 09:13 PM, Laurent Pinchart wrote:
> > From: Sergei Shtylyov 
> > 
> > After the recent corrections to the R-Car gen2/3 LVDS startup code,
> > already similar enough at their ends rcar_lvds_enable_gen{2|3}() started
> > asking for a merge and it's becoming actually necessary with the addition
> > of the R-Car V3M (R8A77970) support -- this gen3 SoC has gen2-like
> > LVDPLLCR layout.
> > 
> > Signed-off-by: Sergei Shtylyov 
> > Reviewed-by: Laurent Pinchart 
> > Tested-by: Laurent Pinchart 
> 
> Well, your role wasn't limited to reviewning/testing, you'd clearly did
> some editing too... thus I was expecting to see some changelog.

My bad, it was an oversight. I'll add the following.

[Set the LVDS mode and input before turning channels on]
[Rebased, coding style changes]

> > Signed-off-by: Laurent Pinchart
> > 
> 
> Your variant of my patch looks good otherwise. :-)

Thank you :-) I've queued it in my tree.

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 3/3] drm: rcar-du: lvds: Refactor LVDS startup

[Sergei Shtylyov]

On 02/14/2018 09:13 PM, Laurent Pinchart wrote:

> From: Sergei Shtylyov 
> 
> After the recent corrections to the R-Car gen2/3 LVDS startup code, already
> similar enough at their ends rcar_lvds_enable_gen{2|3}() started asking for
> a merge and it's becoming actually necessary with the addition of the R-Car
> V3M (R8A77970) support -- this gen3 SoC has gen2-like LVDPLLCR layout.
> 
> Signed-off-by: Sergei Shtylyov 
> Reviewed-by: Laurent Pinchart 
> Tested-by: Laurent Pinchart 

   Well, your role wasn't limited to reviewning/testing, you'd clearly did some 
editing too... thus I was expecting to see some changelog.

> Signed-off-by: Laurent Pinchart 

   Your variant of my patch looks good otherwise. :-)

[...]

MBR, Sergei