Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-10-20 Thread Wolfram Sang
On Mon, Sep 12, 2016 at 10:15:05AM -0400, Chris Brandt wrote: > In moving platforms from board files to DT, there still needs to be a way > to set the ocr_mask setting for the tmio driver during probe. Without this > setting, the probe will fail because the supported voltages are not known. > >

RE: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-09-17 Thread Chris Brandt
On 9/17/2016, Ulf Hansson wrote: > > I'm assuming I'll have to do the same for MMC (sh_mmcif.c) once I get to > that driver (I need to find my MMC PLUS card first for testing). > > Okay! > > Kind regards > Uffe Just FYI, For the eMMC case, I decided not to modify sh_mmcif.c to add the OCR and

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-09-17 Thread Ulf Hansson
On 13 September 2016 at 17:59, Chris Brandt wrote: > Hello Uffe > > Thank you for your reply. > > On 9/13/2016, Ulf Hansson wrote: >> Because, if you have an external regulator feeding the mmc with power you >> should set it up and use it. > > But in many board designs,

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-09-13 Thread Ulf Hansson
On 13 September 2016 at 15:50, Chris Brandt wrote: > Here's a question: > > The DT regulator method is good if you want to be able to control the > regulator at run-time by the system. > > But for MMC and SDHI, why isn't there a way to just set the OCR voltage in > the

RE: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-09-13 Thread Chris Brandt
Here's a question: The DT regulator method is good if you want to be able to control the regulator at run-time by the system. But for MMC and SDHI, why isn't there a way to just set the OCR voltage in the board's DT if it's fixed (other than making a fixed regulator node)? Why isn't there a

RE: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-09-13 Thread Chris Brandt
On 9/13/2016, Ulf Hansson wrote: > Regarding the ocr_mask; How do these SoCs provides the power to the mmc/sd > card? > > Do note, I am *not* talking about the I/O voltage but the core power to > the card. The SoC does not *provide* power to the card. It's not that fancy. How the 3.3v is

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-09-13 Thread Geert Uytterhoeven
Hi Ulf, On Tue, Sep 13, 2016 at 2:57 PM, Ulf Hansson wrote: > On 12 September 2016 at 16:15, Chris Brandt wrote: >> In moving platforms from board files to DT, there still needs to be a way >> to set the ocr_mask setting for the tmio driver

Re: [PATCH v3 1/3] mmc: sh_mobile_sdhi: add ocr_mask option

2016-09-13 Thread Ulf Hansson
On 12 September 2016 at 16:15, Chris Brandt wrote: > In moving platforms from board files to DT, there still needs to be a way > to set the ocr_mask setting for the tmio driver during probe. Without this > setting, the probe will fail because the supported voltages are