Re: [PATCH v4 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO

2018-11-19 Thread Geert Uytterhoeven
Hi Linus, On Mon, Nov 19, 2018 at 2:22 PM Linus Walleij wrote: > On Tue, Nov 13, 2018 at 6:28 PM Geert Uytterhoeven > wrote: > > Anyway, we're getting closer to bikeshedding, so with the real issues fixed: > > Reviewed-by: Geert Uytterhoeven > > I assume you are queueing the RZ/A2 stuff as

RE: [PATCH v4 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO

2018-11-13 Thread Chris Brandt
On Tuesday, November 13, 2018, jacopo mondi wrote: > Just two minor things, so please add my > Reviewed-by: Jacopo Mondi Thanks Jacopo! Chris

Re: [PATCH v4 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO

2018-11-13 Thread jacopo mondi
Hi Chris, thanks for the patch Just two minor things, so please add my Reviewed-by: Jacopo Mondi On Wed, Nov 07, 2018 at 01:27:33PM -0500, Chris Brandt wrote: > Add device tree binding documentation and header file for Renesas R7S9210 > (RZ/A2) SoCs. > > Signed-off-by: Chris Brandt >

RE: [PATCH v4 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO

2018-11-13 Thread Chris Brandt
Hi Geert, On Tuesday, November 13, 2018 1, Geert Uytterhoeven wrote: > Perhaps adding a convenience definition > > #define JP PM > > may be a good idea? Or just a comment? > > #define PM 21/* JP */ Either one is OK I guess. I'll see which one makes more sense as I reworked

Re: [PATCH v4 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO

2018-11-13 Thread Geert Uytterhoeven
Hi Chris, On Tue, Nov 13, 2018 at 5:38 PM Chris Brandt wrote: > On Monday, November 12, 2018 1, Geert Uytterhoeven wrote: > > > +Required properties: > > > + - compatible: should be: > > > +- "renesas,r7s9210-pinctrl": for RZ/A2M > > > > On RZ/A1, the datasheet called this "Ports", and the

RE: [PATCH v4 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO

2018-11-13 Thread Chris Brandt
Hi Geert, On Monday, November 12, 2018 1, Geert Uytterhoeven wrote: > > +Required properties: > > + - compatible: should be: > > +- "renesas,r7s9210-pinctrl": for RZ/A2M > > On RZ/A1, the datasheet called this "Ports", and the corresponding > compatible > value is "renesas,r7s72100-ports".

Re: [PATCH v4 2/2] dt-bindings: pinctrl: Add RZ/A2 pinctrl and GPIO

2018-11-12 Thread Geert Uytterhoeven
Hi Chris, On Wed, Nov 7, 2018 at 7:27 PM Chris Brandt wrote: > Add device tree binding documentation and header file for Renesas R7S9210 > (RZ/A2) SoCs. > > Signed-off-by: Chris Brandt > Reviewed-by: Rob Herring Thanks for your patch! > new file mode 100644 > index ..622d37a7225b