Hi Jacopo,
Thank you for the patch.
On Wed, May 08, 2019 at 07:34:28PM +0200, Jacopo Mondi wrote:
> Add CMM units to Renesas R-Car M3-W device tree and reference them from
> the Display Unit they are connected to.
>
> Signed-off-by: Jacopo Mondi <jacopo+rene...@jmondi.org>
> ---
> arch/arm64/boot/dts/renesas/r8a7796.dtsi | 25 ++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> index cdf784899cf8..b81c4711dce3 100644
> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -2503,6 +2503,30 @@
> renesas,fcp = <&fcpf0>;
> };
>
> + cmm0: cmm@fea40000 {
> + compatible = "renesas,cmm";
> + reg = <0 0xfea40000 0 0x1000>;
> + clocks = <&cpg CPG_MOD 711>;
> + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> + resets = <&cpg 711>;
> + };
> +
> + cmm1: cmm@fea50000 {
> + compatible = "renesas,cmm";
> + reg = <0 0xfea50000 0 0x1000>;
> + clocks = <&cpg CPG_MOD 710>;
> + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> + resets = <&cpg 710>;
> + };
> +
> + cmm2: cmm@fea60000 {
> + compatible = "renesas,cmm";
> + reg = <0 0xfea60000 0 0x1000>;
> + clocks = <&cpg CPG_MOD 709>;
> + power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
> + resets = <&cpg 709>;
> + };
> +
This looks good to me.
> fcpf0: fcp@fe950000 {
> compatible = "renesas,fcpf";
> reg = <0 0xfe950000 0 0x200>;
> @@ -2763,6 +2787,7 @@
> status = "disabled";
>
> vsps = <&vspd0 &vspd1 &vspd2>;
> + cmms = <&cmm0 0 &cmm1 1 &cmm2 2>;
Apart from the indices that I don't think are needed this looks good to
me too,
Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
>
> ports {
> #address-cells = <1>;
--
Regards,
Laurent Pinchart
