RE: samsung merge window over

2010-05-24 Thread Kukjin Kim
Ben Dooks wrote: > > Thankyou to all who contributed to this round of updates, I am officially > calling the end of any new development work for this merge window. > > Special thanks to all at Samsung for their help. > > I will now be preparing a defconfig, documentation and any other bugfixes >

RE: [PATCH] ARM: S5P: Fix the platform external interrupt issues.

2010-05-24 Thread Marek Szyprowski
Hello, On Monday, May 24, 2010 9:44 AM Kukjin Kim wrote: > From: Pannaga Bhushan > > This patch does the following: > > 1. Corrects the common platform code for external interrupts for using the >VIC mask/unmask bits also. > 2. Moves the common defines related to external interrupt for pla

Re: [PATCH 5/6] USB: s3c-hsotg: Ensure FIFOs are fully flushed after layout

2010-05-24 Thread Maulik Mankad
On Tue, May 25, 2010 at 10:06 AM, Ben Dooks wrote: > According to the design guide, if the FIFO layout is changed, then the > FIFOs must be flushed to ensure all FIFO pointers are correct. > > Signed-off-by: Ben Dooks > --- >  drivers/usb/gadget/s3c-hsotg.c |   26 ++ >  1

Re: [PATCH 3/6] USB: s3c-hsotg: Ensure TX FIFO addresses setup when initialising FIFOs

2010-05-24 Thread Maulik Mankad
On Tue, May 25, 2010 at 10:06 AM, Ben Dooks wrote: > Some versions of the S3C HS OtG block startup with overlapping TX FIFO > information, so change the fifo_init code to ensure that known values > are set into the FIFO registers at initialisation/reset time. > > This also ensures that the FIFO RA

samsung merge window over

2010-05-24 Thread Ben Dooks
Thankyou to all who contributed to this round of updates, I am officially calling the end of any new development work for this merge window. Special thanks to all at Samsung for their help. I will now be preparing a defconfig, documentation and any other bugfixes tree to send to Linus as soon as

[PATCH 3/6] USB: s3c-hsotg: Ensure TX FIFO addresses setup when initialising FIFOs

2010-05-24 Thread Ben Dooks
Some versions of the S3C HS OtG block startup with overlapping TX FIFO information, so change the fifo_init code to ensure that known values are set into the FIFO registers at initialisation/reset time. This also ensures that the FIFO RAM pointers are in a known state before use. Signed-off-by: B

[PATCH 1/6] USB: s3c_hsotg: Add support for external USB clock

2010-05-24 Thread Ben Dooks
From: Maurus Cuelenaere The PLL that drives the USB clock supports 3 input clocks: 12, 24 and 48Mhz. This patch adds support to the USB driver for setting the correct register bit according to the given clock. This depends on the following patch: [PATCH] ARM: S3C64XX: Add USB external clock defi

[PATCH 5/6] USB: s3c-hsotg: Ensure FIFOs are fully flushed after layout

2010-05-24 Thread Ben Dooks
According to the design guide, if the FIFO layout is changed, then the FIFOs must be flushed to ensure all FIFO pointers are correct. Signed-off-by: Ben Dooks --- drivers/usb/gadget/s3c-hsotg.c | 26 ++ 1 files changed, 26 insertions(+), 0 deletions(-) diff --git a/dri

[PATCH 4/6] USB: s3c-hsotg: SoftDisconnect minimum 3ms

2010-05-24 Thread Ben Dooks
The shortest period SoftDisconnect can be asserted for is 3 milliseconds according to the V210 datasheet, so ensure that we add an msleep() to the registration code to enforce this. Signed-off-by: Ben Dooks --- drivers/usb/gadget/s3c-hsotg.c |3 +++ 1 files changed, 3 insertions(+), 0 deleti

s3c-hsotg driver updates / fixes

2010-05-24 Thread Ben Dooks
This series includes the usb-xtal rate addition/fix from Marus which has been submitted (so please ignore if merge is already pending) and fixes for some of the problems that have been seen. This is not the full set of fixes, as there are still some more complicated issues to sort out with things

[PATCH 6/6] USB: s3c-hsotg: Enable soft disconnect during initialization

2010-05-24 Thread Ben Dooks
From: Thomas Abraham Enable soft disconnect bit the OTG core during initialization. Without this, the host sees that a gadget is connected and tries to enumerate. The soft disconnect should be enabled until the USB gadget driver is registered with this otg driver. Signed-off-by: Thomas Abraham

[PATCH 2/6] USB: s3c_hsotg: define USB_GADGET_DUALSPEED in Kconfig

2010-05-24 Thread Ben Dooks
From: Maurus Cuelenaere The s3c_hsotg driver sets usb_gadget->is_dualspeed to 1, yet it doesn't define USB_GADGET_DUALSPEED in Kconfig. This triggers a NULL pointer dereference in the composite driver (which is fixed in another patch). Signed-off-by: Maurus Cuelenaere Signed-off-by: Ben Dooks

[PATCH v2] ARM: S5P6440: Add External Interrupt support

2010-05-24 Thread Kukjin Kim
From: Thomas Abraham Add external interrupt support for S5P6440. The external interrupts supported as 0 to 15. Signed-off-by: Thomas Abraham Signed-off-by: Kukjin Kim --- Changes since v1: 1. Removed unused include files. 2. Fix incorrect return values. arch/arm/mach-s5p6440/Makefile |

Re: [PATCH] ARM: S5P6440: Add External Interrupt support

2010-05-24 Thread Russell King - ARM Linux
On Mon, May 24, 2010 at 04:47:00PM +0900, Kukjin Kim wrote: > +#include Doesn't seem to use this header. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [PATCH] ARM: S5P6440: Add External Interrupt support

2010-05-24 Thread Russell King - ARM Linux
On Mon, May 24, 2010 at 04:47:00PM +0900, Kukjin Kim wrote: > + default: > + printk(KERN_ERR "No such irq type %d", type); > + return -1; Do you mean -EPERM? Do you really mean -EPERM? -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in t

[PATCH] ARM: S5P: Fix the platform external interrupt issues.

2010-05-24 Thread Kukjin Kim
From: Pannaga Bhushan This patch does the following: 1. Corrects the common platform code for external interrupts for using the VIC mask/unmask bits also. 2. Moves the common defines related to external interrupt for plat-s5p to common files. 3. Based on the new common defines, correspondi

[PATCH] ARM: S5P6440: Add External Interrupt support

2010-05-24 Thread Kukjin Kim
From: Thomas Abraham Add external interrupt support for S5P6440. The external interrupts supported as 0 to 15. Signed-off-by: Thomas Abraham Signed-off-by: Kukjin Kim --- arch/arm/mach-s5p6440/Makefile |2 +- arch/arm/mach-s5p6440/irq-eint.c | 169 ++

[PATCH] usb: s3c: Enable soft disconnect during initialization

2010-05-24 Thread Kukjin Kim
From: Thomas Abraham Enable soft disconnect bit the OTG core during initialization. Without this, the host sees that a gadget is connected and tries to enumerate. The soft disconnect should be enabled until the USB gadget driver is registered with this otg driver. Signed-off-by: Thomas Abraham