On 22 August 2012 22:39, Mitch Bradley wrote:
> Sorry to interject on a topic that seems to have already been decided,
> but I'm confused by one thing and would like clarification. I
> understand that you need to use a GPIO-style specifier as a surrogate
> for a pinmux specification - that much i
Guenter Roeck wrote:
>
> Suspend and resume functions call spi_master_get() without matching
> spi_master_put(). The extra references are unnecessary and cause
> subsequent
> module unload attempts to fail. Drop the calls.
>
> Signed-off-by: Guenter Roeck
Acked-by: Kukjin Kim
(Cc'ed Mark Brow
Signed-off-by: Chris Ball
---
Documentation/devicetree/bindings/mmc/mmc.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mmc.txt
b/Documentation/devicetree/bindings/mmc/mmc.txt
index 8a6811f..8e2e0ba 100644
--- a/Documentation
Hi Thomas,
On 8/22/2012 2:04 AM, Thomas Abraham wrote:
> On 22 August 2012 16:38, Chris Ball wrote:
>> Hi Thomas,
>>
>> On Wed, Aug 22 2012, Thomas Abraham wrote:
This matches Mitch's last suggestion exactly -- I think we're all agreed
on these properties now. The only remaining questi
On Wed, Aug 22, 2012 at 01:42:47PM +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> Initialize return variable before exiting on an error path.
Applied, thanks.
signature.asc
Description: Digital signature
On 22 August 2012 20:24, Chris Ball wrote:
> Hi Thomas,
>
> On Wed, Aug 22 2012, Thomas Abraham wrote:
>>> none -> currently "samsung,sdhci-cd-internal"
>>> broken-cd -> currently "samsung,sdhci-cd-none"
>>> cd-gpios -> currently "samsung,sdhci-cd-gpios"
>>> non-removable -> curr
Hi Stephen,
On Wed, Aug 22 2012, Stephen Warren wrote:
> On 08/22/2012 04:17 AM, Chris Ball wrote:
>> Hi,
>>
>> On Wed, Aug 22 2012, Shawn Guo wrote:
>>> The following is what I have on my mind.
>>>
>>> broken-cd cd-gpiosimplication
>>> ---
>>> no
On 08/22/2012 04:17 AM, Chris Ball wrote:
> Hi,
>
> On Wed, Aug 22 2012, Shawn Guo wrote:
>> The following is what I have on my mind.
>>
>> broken-cdcd-gpiosimplication
>> ---
>> no no SDHCI CD
>> no yes
Hi Thomas,
On Wed, Aug 22 2012, Thomas Abraham wrote:
>> none -> currently "samsung,sdhci-cd-internal"
>> broken-cd -> currently "samsung,sdhci-cd-none"
>> cd-gpios -> currently "samsung,sdhci-cd-gpios"
>> non-removable -> currently "samsung,sdhci-cd-permanent"
>> cd-gpios + sams
Hi Shawn,
On Wed, Aug 22 2012, Shawn Guo wrote:
> mmc: sdhci: Always pass clock request value zero to set_clock host op
>
> To allow the set_clock host op to disable the SDCLK source when not
> needed, always call the host op when the requested clock speed is
> zero. Do this even
Hi Chris,
On Tue, Aug 21, 2012 at 10:48:43AM -0400, Chris Ball wrote:
> Aside: the bindings do not match the code. The bindings document says
> to use "fsl,cd-internal", and imx51-babbage.dts does so -- but the code
> doesn't check for "fsl,cd-internal", it checks for "fsl,cd-controller":
>
>
On 22 August 2012 16:38, Chris Ball wrote:
> Hi Thomas,
>
> On Wed, Aug 22 2012, Thomas Abraham wrote:
>>> This matches Mitch's last suggestion exactly -- I think we're all agreed
>>> on these properties now. The only remaining question is how to handle
>>> the pinctrl for CD in Thomas's case.
>>
From: Julia Lawall
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
//
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when !=
On Wed, Aug 22, 2012 at 06:38:36PM +0900, Kukjin Kim wrote:
> Julia Lawall wrote:
> > Signed-off-by: Julia Lawall
> Acked-by: Kukjin Kim
> (Cc'ed Mark Brown who is handling spi for a moment)
Please resend the patch to me so I can apply this.
signature.asc
Description: Digital signature
Hi Thomas,
On Wed, Aug 22 2012, Thomas Abraham wrote:
>> This matches Mitch's last suggestion exactly -- I think we're all agreed
>> on these properties now. The only remaining question is how to handle
>> the pinctrl for CD in Thomas's case.
>
> Hi Chris,
>
> For sdhci-s3c driver, the 'broken-cd
On 22 August 2012 15:47, Chris Ball wrote:
> Hi,
>
> On Wed, Aug 22 2012, Shawn Guo wrote:
>> The following is what I have on my mind.
>>
>> broken-cd cd-gpiosimplication
>> ---
>> nono SDHCI CD
>> noyes
Hi,
On Wed, Aug 22 2012, Shawn Guo wrote:
> The following is what I have on my mind.
>
> broken-cd cd-gpiosimplication
> ---
> nono SDHCI CD
> noyes GPIO CD
> yes no NO CD /
Mandeep Singh Baines wrote:
>
> From 0cdf3aff, "ARM: SAMSUNG: use spin_lock_irqsave() in
> clk_{enable,disable}":
>
> The clk_enable()and clk_disable() can be used process and ISR either.
> And actually it is used for real product and other platforms use it
> now. So spin_lock_irqsave() sho
Julia Lawall wrote:
>
> From: Julia Lawall
>
> Initialize return variable before exiting on an error path.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> //
> (
> if@p1 (\(ret < 0\|ret != 0\))
> { ... return ret; }
> |
19 matches
Mail list logo
