Re: [PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-11-06 Thread Mark Brown
On Mon, Nov 05, 2012 at 05:21:03PM +0530, Shubhrajyoti Datta wrote: On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: A small code saving and less error handling to worry about. Looks good. request irq could be devm_* also. Not an objection though.

Re: [PATCH 2/2] i2c-s3c2410: Convert to devm_request_and_ioremap()

2012-11-06 Thread Shubhrajyoti Datta
On Tue, Nov 6, 2012 at 1:40 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: On Mon, Nov 05, 2012 at 05:21:03PM +0530, Shubhrajyoti Datta wrote: On Mon, Nov 5, 2012 at 2:03 PM, Mark Brown broo...@opensource.wolfsonmicro.com wrote: A small code saving and less error handling to worry

RE: [PATCH v2] ARM: S3C64XX: Fix up IRQ mapping for balblair on Cragganmore

2012-11-06 Thread Kukjin Kim
Mark Brown wrote: On Fri, Nov 02, 2012 at 01:04:14PM +, Dimitris Papastamos wrote: We are using S3C_EINT(4) instead of S3C_EINT(5). Reviwed-by: Mark Brown broo...@opensource.wolfsonmicro.com Reviewed-by? Applied with fixing typo :-) Thanks. Best regards, Kgene. -- Kukjin Kim

RE: [PATCH] ARM: dts: exynos4: Add support for Exynos4x12 SoCs

2012-11-06 Thread Kukjin Kim
Tomasz Figa wrote: This patch adds device tree sources for Exynos4x12 SoC series (currently Exynos4212 and Exynos4412) and enables mach-exynos4-dt to support these SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

RE: [PATCH 6/7] pinctrl: exynos5440: add pinctrl driver for Samsung EXYNOS5440 SoC

2012-11-06 Thread Kukjin Kim
Linus Walleij wrote: On Fri, Oct 26, 2012 at 7:55 PM, Kukjin Kim kgene@samsung.com wrote: From: Thomas Abraham thomas.abra...@linaro.org Add a new pinctrl driver for Samsung EXYNOS5440 SoC. The pin controller module in EXYNOS5440 is different from the pin controller found on other

RE: [PATCH] ARM: Fix the WFI instruction opcode definition.

2012-11-06 Thread Kukjin Kim
Dave Martin wrote: [...] - asm(.word 0xe320f003\n + asm(__WFI Wouldn't using the actual wfi instruction fix this. There is a wfi() macro. Or just call cpu_do_idle() which will do any other things needed before wfi like a dsb instruction.

RE: [PATCH] ARM: dts: add board dts file for Exynos4412 based SMDK board

2012-11-06 Thread Kukjin Kim
Thomas Abraham wrote: Add a minimal board dts file for Samsung Exynos4412 based SMDK board. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- This patch depends the on the following patch posted by Tomasz Figa. ARM: dts: exynos4: Add support for Exynos4x12 SoCs

RE: [PATCH] ARM: Exynos: remove unused init_uarts callback for exynos4x12 platforms

2012-11-06 Thread Kukjin Kim
Thomas Abraham wrote: All the Exynos4x12 based platforms use only device tree based boot. So remove the unused 'init_uarts' callback from exynos cpu_ids table. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- arch/arm/mach-exynos/common.c |2 -- 1 files changed, 0

RE: [PATCH] ARM: Exynos: remove unused init_uarts callback for exynos4x12 platforms

2012-11-06 Thread Kukjin Kim
Kukjin Kim wrote: Thomas Abraham wrote: All the Exynos4x12 based platforms use only device tree based boot. So remove the unused 'init_uarts' callback from exynos cpu_ids table. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- arch/arm/mach-exynos/common.c |2 --

RE: [PATCH 1/2] ARM: EXYNOS: reorder inclusions of linux/platform_data/xxx.h

2012-11-06 Thread Kukjin Kim
Jingoo Han wrote: This patch reorders inclusions of linux/platform_data/xxx.h and puts the inclusions with the same kind for readability, according to alphabetical ordering. Signed-off-by: Jingoo Han jg1@samsung.com --- arch/arm/mach-exynos/dev-audio.c |2 +-

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-11-06 Thread Felipe Balbi
Hi, On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: This patchset is based on the work by Praveen Paneri for samsung-usbphy driver: http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653 Changes from v2: - Using EXYNOS5_PHY_ as common prefix along with exact names

Re: [PATCH] ARM: Fix the WFI instruction opcode definition.

2012-11-06 Thread Dave Martin
On Tue, Nov 06, 2012 at 08:24:31PM +0900, Kukjin Kim wrote: Dave Martin wrote: [...] - asm(.word 0xe320f003\n + asm(__WFI Wouldn't using the actual wfi instruction fix this. There is a wfi() macro. Or just call cpu_do_idle() which

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-11-06 Thread Vivek Gautam
Hi Balbi, On Tue, Nov 6, 2012 at 6:44 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: This patchset is based on the work by Praveen Paneri for samsung-usbphy driver: http://comments.gmane.org/gmane.linux.kernel.samsung-soc/12653

[PATCH v4 0/5] Adding usb2.0 host-phy support for exynos5250

2012-11-06 Thread Vivek Gautam
This patchset is based on the work by Praveen Paneri for samsung-usbphy driver: http://www.spinics.net/lists/linux-usb/msg73518.html Changes from v3: - Moved enums S5P_USB_PHY_DEVICE, S5P_USB_PHY_HOST from machine to file include/linux/usb/samsung_usb_phy.h as USB_PHY_TYPE_DEVICE and

[PATCH v4 1/5] ARM: EXYNOS: Update move usb-phy types to generic include layer

2012-11-06 Thread Vivek Gautam
Updating the names of usb-phy types to more generic names: USB_PHY_TYPE_DEIVCE USB_PHY_TYPE_HOST; and further update its dependencies. Signed-off-by: Praveen Paneri p.pan...@samsung.com Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/mach-exynos/setup-usb-phy.c |9

[PATCH 2/5] usb: phy: samsung: Add host phy support to samsung-phy driver

2012-11-06 Thread Vivek Gautam
This patch adds host phy support to samsung-usbphy.c and further adds support for samsung's exynos5250 usb-phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Signed-off-by: Praveen Paneri p.pan...@samsung.com --- arch/arm/mach-exynos/setup-usb-phy.c |2 +-

[PATCH v4 3/5] ARM: Exynos5250: Enabling samsung-usbphy driver

2012-11-06 Thread Vivek Gautam
Adding usbphy node for Exynos5250 along with the platform data Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- .../devicetree/bindings/usb/samsung-usbphy.txt | 12 +- arch/arm/boot/dts/exynos5250.dtsi |5 ++ arch/arm/mach-exynos/Kconfig

[PATCH v4 4/5] USB: ehci-s5p: Add phy driver support

2012-11-06 Thread Vivek Gautam
Adding the phy driver to ehci-s5p. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com --- drivers/usb/host/ehci-s5p.c | 70

[PATCH v4 5/5] USB: ohci-exynos: Add phy driver support

2012-11-06 Thread Vivek Gautam
Adding the phy-driver to ohci-exynos. Keeping the platform data for continuing the smooth operation for boards which still uses it Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com --- drivers/usb/host/ohci-exynos.c | 70

[PATCH] ARM: EXYNOS5250: Add support for USB 3.0 dwc3 controller

2012-11-06 Thread Vivek Gautam
Here we add the required support for device tree and further clocks and device reigster base address. Based on 'for-next' branch of linux-samsung tree. Tested with required driver DT patches for dwc3-exynos: http://www.spinics.net/lists/linux-usb/msg73857.html and USB 3.0 phy support patches:

[PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-06 Thread Vivek Gautam
Adding DWC3 device tree node for Exynos5250 along with the device address and clock support needed for the controller. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi |6 ++ arch/arm/mach-exynos/clock-exynos5.c| 24

[PATCH 0/2] Adding USB 3.0 DRD-phy support for exynos5250

2012-11-06 Thread Vivek Gautam
This patchset is based on the work for USB 2.0 host phy support for exynos5250 https://lists.ozlabs.org/pipermail/devicetree-discuss/2012-November/021915.html Based on 'usb-next' branch. Tested on smdk5250 with following patch-series:

[PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-06 Thread Vivek Gautam
Adding support for USB3.0 phy for dwc3 controller on exynso5250 SOC. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- drivers/usb/phy/samsung-usbphy.c| 337 +++ include/linux/usb/samsung_usb_phy.h |1 + 2 files changed, 338 insertions(+), 0

[PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

2012-11-06 Thread Vivek Gautam
Adding base address information and required platform data support for enabling USB DRD phy on exynos5250 SOC. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi|3 ++- arch/arm/mach-exynos/include/mach/regs-pmu.h |4

Re: [PATCH v3 0/4] Adding usb2.0 host-phy support for exynos5250

2012-11-06 Thread Felipe Balbi
Hi, On Tue, Nov 06, 2012 at 07:23:12PM +0530, Vivek Gautam wrote: Hi Balbi, On Tue, Nov 6, 2012 at 6:44 PM, Felipe Balbi ba...@ti.com wrote: Hi, On Mon, Oct 29, 2012 at 07:12:36PM +0530, Vivek Gautam wrote: This patchset is based on the work by Praveen Paneri for samsung-usbphy

Re: [PATCH] ARM: Exynos5250: Enabling dwc3-exynos driver

2012-11-06 Thread Felipe Balbi
On Tue, Nov 06, 2012 at 08:58:49PM +0530, Vivek Gautam wrote: Adding DWC3 device tree node for Exynos5250 along with the device address and clock support needed for the controller. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi |6

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-06 Thread Andrey Gusakov
Hi. Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? Work! I'm looking at drivers/media/usb/gspca/m5602/m5602_ov9650.h It use significantly different init sequence. Some of settings described in Application note for ov9650, some look like magic. Do you have

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-06 Thread Sylwester Nawrocki
Hi, I have a few comments. Please see below... On 11/06/2012 04:36 PM, Vivek Gautam wrote: Adding support for USB3.0 phy for dwc3 controller on exynso5250 SOC. exynso - exynos Signed-off-by: Vivek Gautamgautam.vi...@samsung.com --- drivers/usb/phy/samsung-usbphy.c| 337

RE: [PATCH] ARM: dts: exynos4: Add support for Exynos4x12 SoCs

2012-11-06 Thread Kukjin Kim
Kukjin Kim wrote: Tomasz Figa wrote: This patch adds device tree sources for Exynos4x12 SoC series (currently Exynos4212 and Exynos4412) and enables mach-exynos4-dt to support these SoCs. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park

RE: [PATCH 2/4] gpio: samsung: Skip registration if pinctrl driver is present on Exynos4x12

2012-11-06 Thread Kukjin Kim
Linus Walleij wrote: On Wed, Oct 24, 2012 at 4:37 PM, Tomasz Figa t.f...@samsung.com wrote: This patch modifies the Samsung GPIO driver to check for pinctrl driver presence earlier and use generic matching instead of a single compatible value. This allows us to fix warning about

[PATCH] spi: s3c64xx: Add fix for crash in spi suspend/resume

2012-11-06 Thread Naveen Krishna Chatradhi
From: Abhilash Kesavan a.kesa...@samsung.com The SPI driver makes a gpio_request during initialization. The requested gpios need to be populated as part of the s3c64xx_spi_driver_data so that they can be released during suspend and requested again during resume. Add the missing code to save the