Re: [PATCH v3 4/6] ARM: EXYNOS: Add support for Exynos secure firmware

2012-11-12 Thread Russell King - ARM Linux
On Thu, Oct 25, 2012 at 05:22:38PM +0200, Tomasz Figa wrote: +static int exynos_do_idle(void) +{ +exynos_smc(SMC_CMD_SLEEP, 0, 0, 0); +return 0; +} This looks fine as an API - it has a defined purpose. + +static int exynos_cpu_boot(int cpu) +{ +

Re: [PATCH v3 6/6] ARM: EXYNOS: Add secure firmware support to secondary CPU bring-up

2012-11-12 Thread Russell King - ARM Linux
On Thu, Oct 25, 2012 at 05:22:40PM +0200, Tomasz Figa wrote: @@ -47,6 +48,8 @@ static inline void __iomem *cpu_boot_reg(int cpu) { void __iomem *boot_reg; + if (!call_firmware_op(cpu_boot_reg, cpu, boot_reg)) + return boot_reg; boot_reg = cpu_boot_reg_base();

Re: [PATCH v3 0/6] ARM: EXYNOS: Add secure firmware support

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 04:39:28PM +0900, Kukjin Kim wrote: (+ Russell King) I think there's still an amount of work to do here; it's not a generic interface at the moment because it makes some assumptions about how things are done (eg, it assumes that there _will_ be a CPU boot register; that

Re: [PATCH v3 4/6] ARM: EXYNOS: Add support for Exynos secure firmware

2012-11-12 Thread Tomasz Figa
Hi Russel, On Monday 12 of November 2012 09:51:14 Russell King - ARM Linux wrote: + +static int exynos_cpu_boot(int cpu) +{ + exynos_smc(SMC_CMD_CPU1BOOT, cpu, 0, 0); + return 0; +} Same for this (though, what _exactly_ is 'cpu', is it the physical CPU number or the logical

Re: [PATCH v3 0/6] ARM: EXYNOS: Add secure firmware support

2012-11-12 Thread Tomasz Figa
On Monday 12 of November 2012 09:55:30 Russell King - ARM Linux wrote: On Mon, Nov 12, 2012 at 04:39:28PM +0900, Kukjin Kim wrote: (+ Russell King) I think there's still an amount of work to do here; it's not a generic interface at the moment because it makes some assumptions about how

RE: Build failure: OMAP4430 failed due to exynos4 pinctrl

2012-11-12 Thread Kukjin Kim
Russell King - ARM Linux wrote: Last night's randconfig for OMAP4430 failed with: drivers/built-in.o:(.rodata+0x1a60): undefined reference to `exynos4210_pin_ctrl' Config and log: http://www.arm.linux.org.uk/developer/build/file.php?type=configidx=2693

[RFC PATCH 0/4] ARM: S3C24XX: irq move to drivers and first steps to dt

2012-11-12 Thread Heiko Stübner
On the way back from Barcelona I've started the move of the common s3c24xx irq-code to drivers/irqchip and also modifications to enable using it in a devicetree context at some point. So, as I'm also missing the now probably famous tail-lights in this, it would be cool to have some feedback if

[RFC PATCH 1/4] ARM: S3C24XX: move s3c24xx-irq to drivers/irqchip

2012-11-12 Thread Heiko Stübner
Removes another part from plat-s3c24xx and also enables further improvements happening in the correct location. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/Kconfig |1 + arch/arm/plat-s3c24xx/Makefile |1 -

[RFC PATCH 2/4] irqchip: s3c24xx: add irq_domains for the interrupt registers

2012-11-12 Thread Heiko Stübner
Add irqdomains for the three register sets in use for base, external and sub-interrupts. This also pouplates the hwirq value for further improvements. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/irqchip/Kconfig |1 + drivers/irqchip/irq-s3c24xx.c | 14 ++ 2

[RFC PATCH 3/4] ARM: S3C24XX: irq_data conversion for s3c_irqsub_* functions

2012-11-12 Thread Heiko Stübner
Don't strip off the rest of the irq_data struct when calling one of the s3c_irqsub_* functions. This enables using its hwirq field later on. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c24xx/irq-s3c2412.c |6 +++--- arch/arm/mach-s3c24xx/irq-s3c2416.c | 24

[RFC PATCH 4/4] ARM: S3C24XX: First part converting irq code to use hwirq

2012-11-12 Thread Heiko Stübner
Use the newly introduced irq_domains to let the basic ack, mask and unmask functions use its hwirq field. This also includes the external irq sources and removes all offset calculations based on the static irq numbers from these parts. Signed-off-by: Heiko Stuebner he...@sntech.de ---

Re: [PATCH] ARM: dts: add board dts file for Exynos4412 based SMDK board

2012-11-12 Thread Tomasz Figa
Hi Thomas, On Saturday 03 of November 2012 20:19:32 Thomas Abraham wrote: Add a minimal board dts file for Samsung Exynos4412 based SMDK board. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- This patch depends the on the following patch posted by Tomasz Figa. ARM: dts:

Re: Build failure: OMAP4430 failed due to exynos4 pinctrl

2012-11-12 Thread Arnd Bergmann
On Monday 12 November 2012, Kukjin Kim wrote: Russell King - ARM Linux wrote: Last night's randconfig for OMAP4430 failed with: drivers/built-in.o:(.rodata+0x1a60): undefined reference to `exynos4210_pin_ctrl' Config and log:

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Maarten Lankhorst
Op 08-11-12 21:23, Sasha Levin schreef: Just use BUG_ON() instead of constructions such as: if (...) BUG() A simplified version of the semantic patch that makes this transformation is as follows: (http://coccinelle.lip6.fr/) // smpl @@ expression e; @@ - if (e)

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Russell King - ARM Linux
On Mon, Nov 12, 2012 at 04:12:29PM +0100, Maarten Lankhorst wrote: Op 08-11-12 21:23, Sasha Levin schreef: @@ -465,10 +465,8 @@ static void __init combiner_cascade_irq(unsigned int combiner_nr, unsigned int i else max_nr = EXYNOS4_MAX_COMBINER_NR; - if

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Sasha Levin
On 11/12/2012 10:12 AM, Maarten Lankhorst wrote: Op 08-11-12 21:23, Sasha Levin schreef: Just use BUG_ON() instead of constructions such as: if (...) BUG() A simplified version of the semantic patch that makes this transformation is as follows:

Re: [PATCH] ARM: EXYNOS: use BUG_ON where possible

2012-11-12 Thread Sasha Levin
On 11/12/2012 10:23 AM, Russell King - ARM Linux wrote: On Mon, Nov 12, 2012 at 04:12:29PM +0100, Maarten Lankhorst wrote: Op 08-11-12 21:23, Sasha Levin schreef: @@ -465,10 +465,8 @@ static void __init combiner_cascade_irq(unsigned int combiner_nr, unsigned int i else

Re: [RFC PATCH 1/4] ARM: S3C24XX: move s3c24xx-irq to drivers/irqchip

2012-11-12 Thread Heiko Stübner
Am Montag, 12. November 2012, 18:05:39 schrieb Stephen Warren: On 11/12/2012 06:47 AM, Heiko Stübner wrote: Removes another part from plat-s3c24xx and also enables further improvements happening in the correct location. Signed-off-by: Heiko Stuebner he...@sntech.de ---

Re: [oselas] Mini2440 boot failure on kernel 3.7-rc1

2012-11-12 Thread Sylwester Nawrocki
Hi Juergen, Brian, On 10/22/2012 09:28 AM, Juergen Beisert wrote: Hi Sylwester, Sylwester Nawrocki wrote: [...] [2.455000] NAND device: Manufacturer ID: 0xec, Chip ID: 0xf1 (Samsung NAND 128MiB 3,3V 8-bit), 8 [2.46] 4 cmdlinepart partitions found on MTD device nand [2.465000]

RE: [PATCH 1/7] ARM: EXYNOS: add support for EXYNOS5440 SoC

2012-11-12 Thread Kukjin Kim
Tomasz Figa wrote: Hi Kgene, Hi, [...] void exynos5_restart(char mode, const char *cmd) { - __raw_writel(0x1, EXYNOS_SWRESET); + u32 val; + void __iomem *addr; + + if (of_machine_is_compatible(samsung,exynos5250)) { + val = 0x1; + addr =

RE: [PATCH] usb: ohci-exynos: use clk_prepare_enable and clk_disable_unprepare

2012-11-12 Thread Kukjin Kim
Thomas Abraham wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org (+ Alan Stern) Acked-by: Kukjin Kim kgene@samsung.com Thanks. Best regards, Kgene. --

RE: [PATCH] usb: ehci-s5p: use clk_prepare_enable and clk_disable_unprepare

2012-11-12 Thread Kukjin Kim
Thomas Abraham wrote: Convert clk_enable/clk_disable to clk_prepare_enable/clk_disable_unprepare calls as required by common clock framework. Signed-off-by: Thomas Abraham thomas.abra...@linaro.org (+ Alan Stern) Acked-by: Kukjin Kim kgene@samsung.com Thanks. Best regards, Kgene. --

RE: Build failure: OMAP4430 failed due to exynos4 pinctrl

2012-11-12 Thread Kukjin Kim
Arnd Bergmann wrote: [...] This won't work. A driver can't select and depend on another symbol at the same time. Ops. You're right. I missed :-( This is what I came up with earlier. Arnd 8 From a15cc6277a3a43c8b5c1dd90ca71732b2ffe2b18 Mon Sep 17 00:00:00