Re: [RFC 01/12] media: s5p-fimc: modify existing mdev to use common pipeline

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, Thanks for the review. Actually I know this is the important patch in this series and I wanted us to have enough time to discuss on this patch. That's why I posted this patch series in hurry. I will remove this patch from the exynos5-mdev series and will send this as a separate

Re: [RFC 02/12] fimc-lite: Adding Exynos5 compatibility to fimc-lite driver

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:06 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the Exynos5 soc compatibility to the fimc-lite driver. It also adds a version checking to deal with the changes between

Re: [RFC 03/12] media: fimc-lite: Adding support for Exynos5

2013-03-11 Thread Shaik Ameer Basha
Hi Sylweter, On Mon, Mar 11, 2013 at 2:09 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds the following functionalities to existing driver 1] FIMC-LITE supports multiple DMA shadow registers from Exynos5 onwards.

RE: [PATCH v2 0/7] Add G2D nodes to Exynos4 machines

2013-03-11 Thread Kukjin Kim
Sachin Kamat wrote: Hi Kukjin, Can you please look into this series as it is pending since quite some time. Applied, I have another opinion about the compatible string though... I think, it can be sorted out next time :-) Thanks. - Kukjin On 18 February 2013 10:32, Sachin Kamat

Re: [RFC 04/12] s5p-csis: Adding Exynos5250 compatibility

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:10 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: Please don't leave the change log empty. I'll apply this patch. I'm just wondering, if there aren't any further changes needed to make the

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, On Mon, Mar 11, 2013 at 2:24 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds necessary source definations needed for mipi-csis driver and adds devicetree node for exynos5250. Signed-off-by: Shaik Ameer

Re: [RFC 05/12] ARM: EXYNOS: Add devicetree node for mipi-csis driver for exynos5

2013-03-11 Thread Shaik Ameer Basha
On Mon, Mar 11, 2013 at 2:27 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: --- a/arch/arm/boot/dts/exynos5250.dtsi +++ b/arch/arm/boot/dts/exynos5250.dtsi @@ -47,6 +47,8 @@ i2c6 =i2c_6; i2c7

Re: [RFC 07/12] media: exynos5-is: Adding media device driver for exynos5

2013-03-11 Thread Shaik Ameer Basha
Hi Sylwester, Thanks for the review. I will address all you comments for this patch in the next version. Thanks, Shaik Ameer Basha On Mon, Mar 11, 2013 at 3:58 AM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 03/06/2013 12:53 PM, Shaik Ameer Basha wrote: This patch adds support

RE: [PATCH v3] arm: plat-samsung: check processor type before cache restoration in resume

2013-03-11 Thread Kukjin Kim
Inderpal Singh wrote: Only cortex-a9 based samsung platforms have l2x0 cache controller. Hence check the same before restoring the cache in resume. This is needed for single kernel image. Signed-off-by: Inderpal Singh inderpal.si...@linaro.org --- changes in v2: - check

RE: [PATCH] ARM: S3C24XX: drop select MACH_NEO1973

2013-03-11 Thread Kukjin Kim
Paul Bolle wrote: The Kconfig entry for the Openmoko GTA02 / Freerunner phone selects MACH_NEO1973. But there is no Kconfig symbol MACH_NEO1973. The select statement for that symbol is a nop. It can safely be dropped. Signed-off-by: Paul Bolle pebo...@tiscali.nl --- 0) Tested with git

[PATCH] watchdog: convert to devm_ioremap_resource()

2013-03-11 Thread Silviu-Mihai Popescu
Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all explicit error messages can be removed from the failure code paths. Signed-off-by:

Re: [PATCH 1/5] ARM: dts: exynos5250-arndale: Add node entry for gpio-buttons

2013-03-11 Thread Tushar Behera
On 03/11/2013 07:35 AM, Kukjin Kim wrote: Tomasz Figa wrote: Hi, I'm wondering why Exynos5250 has not been migrated to use pinctrl yet. Support for it in pinctrl-samsung driver has been already merged, but I don't see any pinctrl nodes in exynos5250.dtsi. This is important because the

Re: [PATCH] watchdog: convert to devm_ioremap_resource()

2013-03-11 Thread Sachin Kamat
Hi, On 11 March 2013 13:08, Silviu-Mihai Popescu silviupopescu1...@gmail.com wrote: Convert all uses of devm_request_and_ioremap() to the newly introduced devm_ioremap_resource() which provides more consistent error handling. devm_ioremap_resource() provides its own error messages so all

[PATCH 1/2] ARM: EXYNOS: enable all secondary cores for exynos5440

2013-03-11 Thread Amit Daniel Kachhap
This patch enables four cores on exynos5440. Also this patch skips the non exynos5440 pmu control changes. Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com --- arch/arm/mach-exynos/platsmp.c | 44

[PATCH 2/2] ARM: EXYNOS: Support CPU hotplug for exynos5440

2013-03-11 Thread Amit Daniel Kachhap
This patch adds support for CPU hotlpug for the 3 secondary cores of the exynos5440 SOC. The command to hotplug out/in is, echo 0 /sys/devices/system/cpu/cpu[1-3]/online echo 1 /sys/devices/system/cpu/cpu[1-3]/online Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap

[PATCH -next] ARM: EXYNOS: remove duplicated include from common.c

2013-03-11 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Remove duplicated include. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- arch/arm/mach-exynos/common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-exynos/common.c b/arch/arm/mach-exynos/common.c index

Re: [PATCH 2/2] ARM: dts: add pin state information in client nodes for Exynos5 platforms

2013-03-11 Thread Doug Anderson
Thomas, Thank you for doing this! :) On Wed, Mar 6, 2013 at 4:36 AM, Thomas Abraham thomas.abra...@linaro.org wrote: diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 17dd951..434e440 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++

Re: [PATCH] spi: s3c64xx: let device core setup the default pin configuration

2013-03-11 Thread Doug Anderson
Thomas, On Wed, Mar 6, 2013 at 3:42 AM, Thomas Abraham thomas.abra...@linaro.org wrote: With device core now able to setup the default pin configuration, the pin configuration code based on the deprecated Samsung specific gpio bindings is removed. Signed-off-by: Thomas Abraham

Re: [PATCH] mmc: dwmmc: let device core setup the default pin configuration

2013-03-11 Thread Doug Anderson
Thomas, On Wed, Mar 6, 2013 at 4:04 AM, Thomas Abraham thomas.abra...@linaro.org wrote: With device core now able to setup the default pin configuration, the pin configuration code based on the deprecated Samsung specific gpio bindings is removed. Signed-off-by: Thomas Abraham

[PATCH RFC 00/11] s5p-fimc: Exynos4x12 FIMC-IS support prerequisite

2013-03-11 Thread Sylwester Nawrocki
This patch series contains couple fixes to the s5p-fimc driver and changes necessary for the Exynos4x12 FIMC-IS support. Andrzej Hajda (1): s5p-fimc: Added error checks for pipeline stream on callbacks Sylwester Nawrocki (10): s5p-fimc: Add parent clock setup s5p-csis: Add parent clock

[PATCH RFC 01/11] s5p-fimc: Added error checks for pipeline stream on callbacks

2013-03-11 Thread Sylwester Nawrocki
From: Andrzej Hajda a.ha...@samsung.com set_stream error for pipelines is logged or reported to user space if possible. Signed-off-by: Andrzej Hajda a.ha...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH RFC 02/11] s5p-fimc: Add parent clock setup

2013-03-11 Thread Sylwester Nawrocki
With this patch the driver will set parent clock as a parent clock of mux clock. When the samsung clocks driver is reworked to use new composite clock type, the mux clock can be removed. parent clock should be set in related dtsi file and can be overwritten in a board dts file. This way it is

[PATCH RFC 03/11] s5p-csis: Add parent clock setup

2013-03-11 Thread Sylwester Nawrocki
With this patch the driver will set parent clock as a parent clock of mux clock. When the samsung clocks driver is reworked to use new composite clock type, the mux clock can be removed. parent clock should be set in relevant dtsi file and can be overwritten in a board dts file. This way it is

[PATCH RFC 04/11] s5p-fimc: Update graph traversal for entities with multiple source pads

2013-03-11 Thread Sylwester Nawrocki
We cannot assume that the passed entity the fimc_pipeline_prepare() function is supposed to start the media graph traversal from will always have its sink pad at pad index 0. Find the starting media entity's sink pad by iterating over its all pads and checking the pad flags. This ensures proper

[PATCH RFC 06/11] s5p-fimc: Add the FIMC ISP writeback input support

2013-03-11 Thread Sylwester Nawrocki
A second sink pad is added to each FIMC.N subdev that will be used to link it to the ISP subdev. Only V4L2_MBUS_FMT_YUV10_1X30 format is supported at the pad FIMC_SD_PAD_SINK_FIFO. TODO: - Implement the FIMC input bus type selection based on state of media link from FIMC-IS-ISP to FIMC.N

[PATCH RFC 07/11] s5p-fimc: Ensure CAMCLK clock can be enabled by FIMC-LITE devices

2013-03-11 Thread Sylwester Nawrocki
In configurations where FIMC-LITE is used to capture image signal from an external sensor only we need to ensure one of FIMC devices is in active power state and the fimc gate clock is enabled. Otherwise the CAMCLK clock output signal will be masked off preventing an external sensor's operation.

[PATCH RFC 09/11] s5p-fimc: Ensure proper s_power() call order in the ISP datapaths

2013-03-11 Thread Sylwester Nawrocki
Since the FIMC-IS firmware communicates with an image sensor directly through the ISP I2C bus controllers the sub-devices power supplies cannot be simply enabled from left to right or disabled from right to left along the processing pipeline. Thus a subdev index to call s_power() on is looked up

[PATCH RFC 10/11] s5p-fimc: Remove dependency on fimc-core.h in fimc-lite driver

2013-03-11 Thread Sylwester Nawrocki
Drop fimc-lite.h header inclusion to make the exynos-fimc-lite module independent on other modules. Move struct fimc_fmt declaration to the driver's private headers as it is used in multiple modules. Reported-by: Shaik Ameer Basha shaik.am...@samsung.com Signed-off-by: Sylwester Nawrocki

[PATCH RFC 11/11] V4L: Add MATRIX option to V4L2_CID_EXPOSURE_METERING control

2013-03-11 Thread Sylwester Nawrocki
This patch adds a menu option to the V4L2_CID_EXPOSURE_METERING control for multi-zone metering. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Documentation/DocBook/media/v4l/controls.xml |9 -

[RFC PATCH 0/8] A V4L2 driver for Exynos4x12 Imaging Subsystem

2013-03-11 Thread Sylwester Nawrocki
This patch series is an initial version of a driver for the camera ISP subsystem (FIMC-IS) embedded in Samsung Exynos4x12 SoCs. The FIMC-IS subsystem is build around a ARM Cortex-A5 CPU that controls its dedicated peripherals, like I2C, SPI, UART, PWM, ADC,... and the ISP chain. There are 3

[RFC PATCH 2/8] s5p-fimc: Add FIMC-IS ISP I2C bus driver

2013-03-11 Thread Sylwester Nawrocki
This patch adds the ISP I2C bus controller driver files. Creating a standard I2C bus adapter, even if the driver doesn't actually communicates with the hardware and it is instead used by the ISP firmware running on the Cortex-A5, allows to use standard hardware description in the device tree. As

[RFC PATCH 3/8] s5p-fimc: Add FIMC-IS parameter region definitions

2013-03-11 Thread Sylwester Nawrocki
This patch adds ISP processing parameters interface files. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-is-param.c | 971 +

[RFC PATCH 4/8] s5p-fimc: Add common FIMC-IS image sensor driver

2013-03-11 Thread Sylwester Nawrocki
This subdev driver currently only handles an image sensor's power supplies and reset signal. There is no any I2C communication here as it is handled by the ISP's firmware. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[RFC PATCH 5/8] s5p-fimc: Add ISP video capture driver stubs

2013-03-11 Thread Sylwester Nawrocki
This patch adds a video capture node for the FIMC-IS ISP IP block and Makefile/Kconfig to actually enable the driver's compilation. The ISP video capture driver is still a work in progress. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

[RFC PATCH 6/8] fimc-is: Add Exynos4x12 FIMC-IS device tree bindings documentation

2013-03-11 Thread Sylwester Nawrocki
Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/exynos4-fimc-is.txt | 41 1 file changed, 41 insertions(+) create mode 100644

[RFC PATCH 7/8] s5p-fimc: Add fimc-is subdevs registration

2013-03-11 Thread Sylwester Nawrocki
This patch allows to register FIMC-IS device represented by FIMC-IS-ISP subdev to the top level media device driver. The use_isp platform data structure field allows to select whether the fimc-is ISP subdev should be tried to be registered or not. Signed-off-by: Sylwester Nawrocki

[RFC PATCH 8/8] s5p-fimc: Create media links for the FIMC-IS entities

2013-03-11 Thread Sylwester Nawrocki
Create disabled links from the FIMC-LITE subdevs to the FIMC-IS-ISP subdev and from FIMC-IS-ISP to all FIMC subdevs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 78

Re: [PATCH 1/2] ARM: exynos: pl330: Add #dma-cells for generic dma binding support

2013-03-11 Thread Arnd Bergmann
On Thursday 07 March 2013, Kukjin Kim wrote: Can you please take this patch in 3.9 rc2 ? Sure, I will. BTW, Arnd, I'm not sure second one(socfpga.dtsi) can be handled in samsung tree. I guess you're right, I've applied the second one to the fixes branch now. Thanks, Arnd -- To

[PATCH 0/4] clk: samsung: small fixes and enhancements

2013-03-11 Thread Heiko Stübner
Small fixes and enhancements that came up when implementing the common clock support for s3c2443, s3c2416 and s3c2450. The 3rd and 4th patch enable the adding of separate aliases to previously defined clocks, as discussed with Sylwester Nawrocki. This is often needed as some clocks need more

[PATCH 1/4] clk: samsung: register clk_div_tables for divider clocks

2013-03-11 Thread Heiko Stübner
On some Samsung platforms divider clocks only use specific divider combinations like the armdiv on s3c2443 and s3c2416. For these usecases the generic divider clock already provides the option of providing a lookup table mapping register values to divider values. Therefore add a new field to

[PATCH 2/4] clk: samsung: remove np check in clock init

2013-03-11 Thread Heiko Stübner
This let to the suspend init never being reached on non-DT platforms. Signed-off-by: Heiko Stueber he...@sntech.de --- drivers/clk/samsung/clk.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk.c b/drivers/clk/samsung/clk.c index d36cdd5..1a5de69

[PATCH 3/4] clk: samsung: always allocate the clk_table

2013-03-11 Thread Heiko Stübner
This is needed to allow looking up previous created clocks when adding separate aliases to them. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/clk/samsung/clk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/clk/samsung/clk.c

[PATCH 4/4] clk: samsung: add infrastructure to add separate aliases

2013-03-11 Thread Heiko Stübner
The current code adds aliases, if necessary, directly when adding the clock, limiting the number of possible aliases to one. Some platforms need more than one alias, like the hsmmc pclocks on s3c2416 which need a hsmmc and mmc_busclk.0 alias for the s3c-sdhci driver. Therefore add the

[PATCH 0/7] ARM: S3C24XX: Convert S3C2416 to common clock framework

2013-03-11 Thread Heiko Stübner
Due to the upcoming change in pwm/samsung-time handling, this series is meant as mere discussion source. Nevertheless applied to the current linux-samsung for-next it sucessfully enables the s3c2416 to use the common clock framework. This series is dependant on the previous samsung-clock fixes

[PATCH 1/7] clk: samsung: add plls used in s3c2416 and s3c2443

2013-03-11 Thread Heiko Stübner
This adds support for pll2126x, pll3000x, pll6552x and pll6553x. Signed-off-by: Heiko Stuebner he...@sntech.de --- drivers/clk/samsung/clk-pll.c | 376 + drivers/clk/samsung/clk-pll.h |8 + 2 files changed, 384 insertions(+), 0 deletions(-) diff

[PATCH 2/7] ARM: S3C24XX: add soc_is_s3c2416 and soc_is_s3c2443

2013-03-11 Thread Heiko Stübner
This is needed to distinguish between them during at least the clock init. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/include/plat/cpu.h | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git

[PATCH 3/7] ARM: S3C24XX: enable legacy clock code only when SAMSUNG_CLOCK selected

2013-03-11 Thread Heiko Stübner
This enables a smooth transition, as not all S3C24XX SoCs need to be converted at the same time and can instead simply exchange their select SAMSUNG_CLOCK with a select COMMON_CLK after the conversion. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/mach-s3c24xx/common-s3c2443.c |

[PATCH 4/7] clk: samsung: add clock-driver for s3c2416, s3c2443 and s3c2450

2013-03-11 Thread Heiko Stübner
The three SoCs share a common clock tree which only differs in the existence of some special clocks. The s3c2450 specific clocks will only be reachable via DT in the near future, as there is no generic way to distinguish between the similar s3c2416 and s3c2450 SoCs. As with all parts common to

[PATCH 5/7] DO_NOT_APPLY: add clock driver for Samsung pwm clocks

2013-03-11 Thread Heiko Stübner
This ports the pwm-clock code from plat-samsung to the common clock framework to make available the pwm clocks used by samsung-time and the samsung pwm driver. This is needed to enable the usage of the samsung-time clocksource when using the common clock framework on s3c arches but the correct

[PATCH 6/7] ARM: SAMSUNG: use clk_prepare_enable in samsung-time

2013-03-11 Thread Heiko Stübner
The common clock framework expects clocks to be prepared before they are enabled. Signed-off-by: Heiko Stuebner he...@sntech.de --- arch/arm/plat-samsung/samsung-time.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/plat-samsung/samsung-time.c

[PATCH 7/7] DO_NOT_APPLY: convert s3c2416 to use the common clock framework

2013-03-11 Thread Heiko Stübner
Switch the s3c2416 and smdk2416 from using the Samsung clocks to the common clock framework. This is not meant to be the final result, as it uses the temporary pwm clocks and the clock init itself also needs changes, especially as the _init_time function stolen from exynos is currently board

[PATCH] i2c: exynos5: add High Speed I2C controller driver

2013-03-11 Thread Naveen Krishna Chatradhi
Adds support for High Speed I2C driver found in Exynos5 and later SoCs from Samsung. This driver currently supports Auto mode. Driver only supports Device Tree method. Note: Added debugfs support for registers view, not tested. Signed-off-by: Taekgyun Ko taeggyun...@samsung.com Signed-off-by: