Re: [PATCH 1/2] ARM: s3c64xx: cpuidle: use init/exit common routine

2013-04-25 Thread Daniel Lezcano
On 04/23/2013 04:41 PM, Daniel Lezcano wrote: Remove the duplicated code and use the cpuidle common code for initialization. Signed-off-by: Daniel Lezcano daniel.lezc...@linaro.org --- Hi Kim and Ben, It is the last patch in the series which was not acked-by. Rafael is willing to take it in

[PATCH v2 0/4] Thermal:exynos: Thermal Measurement Unit fix and Samsung SoCs support

2013-04-25 Thread Lukasz Majewski
This patch series provide various fixes for TMU block. First of all it fixes a problem with get_cpu_frequency() lockup at cpu_cooling.c. Secondly a proper regulator definition (VDD_TS) has been added. Moreover device tree definitions and documentation entry are now in place. Dependencies

[PATCH v2 1/4] ARM: dts: thermal: exynos4: TMU device tree support for Exynos4412 targets

2013-04-25 Thread Lukasz Majewski
Device tree support for TMU at Exynos4x12 targets. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes for v2: - None --- arch/arm/boot/dts/exynos4x12.dtsi | 10 ++ 1 file changed, 10 insertions(+) diff --git

[PATCH v2 3/4] ARM: dts: thermal: exynos4: Add documentation for Exynos SoC thermal bindings

2013-04-25 Thread Lukasz Majewski
Proper description for Exynos4 bindings added to Documentation/devicetree/ bindings Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes for v2: - Documentation extension according to ML feedback ---

[PATCH v2 4/4] ARM:TMU:fix: Avoid lockup when first frequency table entry is CPUFREQ_ENTRY_INVALID

2013-04-25 Thread Lukasz Majewski
With the while loop, when i=0 and first entry in the frequency table is CPUFREQ_ENTRY_INVALID, the code results in an endless loop (since i is not incremented). To fix this problem the for loop has been chosen. Incrementing i in the for end block solves the problem. Signed-off-by: Lukasz

Re: [PATCH v2 2/4] Thermal: exynos: Support for TMU regulator defined at device tree

2013-04-25 Thread amit daniel kachhap
Hi Lukasz Majewski, Sorry for late review but I am currently working on restructuring the whole exynos thermal driver and this support of LDO can be added as feature as not all socs support this. This is also suggested by Eduardo. All your other patches looks fine. Thanks, Amit Daniel On Thu,

Re: [PATCH 2/2] pinctrl: samsung: Fix link error with CONFIG_PINCTRL_EXYNOS disabled

2013-04-25 Thread Linus Walleij
On Wed, Apr 24, 2013 at 4:47 PM, Tomasz Figa t.f...@samsung.com wrote: On Wednesday 24 of April 2013 16:27:09 Linus Walleij wrote: On Tue, Apr 23, 2013 at 2:09 PM, Tomasz Figa t.f...@samsung.com wrote: On Tuesday 23 of April 2013 14:03:12 Linus Walleij wrote: This does not apply to my devel

Re: [PATCH v2 2/4] Thermal: exynos: Support for TMU regulator defined at device tree

2013-04-25 Thread Lukasz Majewski
Hi Amit, Hi Lukasz Majewski, Sorry for late review but I am currently working on restructuring the whole exynos thermal driver and this support of LDO can be added as feature as not all socs support this. This is also suggested by Eduardo. All your other patches looks fine. But this is

Re: [PATCH v3 00/13] ARM: EXYNOS: Fix Universal C210 support

2013-04-25 Thread Arnd Bergmann
On Tuesday 23 April 2013, Tomasz Figa wrote: This series intends to fix support for Universal C210 board in mainline. Main difference from other boards based on Exynos 4210 is that hardware revision of the SoC used on Universal C210 does not support MCT timers and legacy PWM timers must be

Re: [PATCH v2 4/4] ARM:TMU:fix: Avoid lockup when first frequency table entry is CPUFREQ_ENTRY_INVALID

2013-04-25 Thread Eduardo Valentin
Lukasz, On 25-04-2013 08:30, Lukasz Majewski wrote: With the while loop, when i=0 and first entry in the frequency table is CPUFREQ_ENTRY_INVALID, the code results in an endless loop (since i is not incremented). To fix this problem the for loop has been chosen. Incrementing i in the for end

Re: [PATCH v2 4/4] ARM:TMU:fix: Avoid lockup when first frequency table entry is CPUFREQ_ENTRY_INVALID

2013-04-25 Thread Lukasz Majewski
Hi Eduardo, Lukasz, On 25-04-2013 08:30, Lukasz Majewski wrote: With the while loop, when i=0 and first entry in the frequency table is CPUFREQ_ENTRY_INVALID, the code results in an endless loop (since i is not incremented). To fix this problem the for loop has been chosen.

Re: [PATCH 1/2] ARM: s3c64xx: cpuidle: use init/exit common routine

2013-04-25 Thread Kukjin Kim
On 04/25/13 18:35, Daniel Lezcano wrote: On 04/23/2013 04:41 PM, Daniel Lezcano wrote: Remove the duplicated code and use the cpuidle common code for initialization. Signed-off-by: Daniel Lezcanodaniel.lezc...@linaro.org --- Hi Kim and Ben, It is the last patch in the series which was not

Re: Exynos regressions w.r.t. config and debuggability due to multiplatform

2013-04-25 Thread Kukjin Kim
On 04/25/13 00:03, Arnd Bergmann wrote: On Wednesday 24 April 2013, Olof Johansson wrote: I think we should hold off on multiplatform for exynos until it works better, i.e. 3.11. I think, this would be better choice for now if it's not urgent... - Kukjin -- To unsubscribe from this list:

Re: [GIT PULL] Late Exynos stuff for v3.10

2013-04-25 Thread Kukjin Kim
On 04/24/13 09:06, Olof Johansson wrote: Hi, Hi Olof, Can I please ask you to make our life a little easier by telling us what the specific problems these patches solve are? What I am looking for is something along the lines of: -- This branch includes some last-minute enablements of DT

Re: [PATCH v2 4/4] ARM:TMU:fix: Avoid lockup when first frequency table entry is CPUFREQ_ENTRY_INVALID

2013-04-25 Thread Eduardo Valentin
On 25-04-2013 11:22, Lukasz Majewski wrote: Hi Eduardo, Lukasz, On 25-04-2013 08:30, Lukasz Majewski wrote: With the while loop, when i=0 and first entry in the frequency table is CPUFREQ_ENTRY_INVALID, the code results in an endless loop (since i is not incremented). To fix this problem

Re: [PATCH v2 0/4] Thermal:exynos: Thermal Measurement Unit fix and Samsung SoCs support

2013-04-25 Thread Eduardo Valentin
Hello Lukasz, On 25-04-2013 08:30, Lukasz Majewski wrote: This patch series provide various fixes for TMU block. First of all it fixes a problem with get_cpu_frequency() lockup at cpu_cooling.c. Secondly a proper regulator definition (VDD_TS) has been added. Moreover device tree definitions

Re: [PATCH v2 2/4] Thermal: exynos: Support for TMU regulator defined at device tree

2013-04-25 Thread Eduardo Valentin
Amit, Lukasz, On 25-04-2013 09:29, Lukasz Majewski wrote: Hi Amit, Hi Lukasz Majewski, Sorry for late review but I am currently working on restructuring the whole exynos thermal driver and this support of LDO can be added as feature as not all socs support this. This is also suggested by

Re: [PATCH v2 1/4] ARM: dts: thermal: exynos4: TMU device tree support for Exynos4412 targets

2013-04-25 Thread Eduardo Valentin
On 25-04-2013 08:30, Lukasz Majewski wrote: Device tree support for TMU at Exynos4x12 targets. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com This patch looks good to me: Acked-by: Eduardo Valentin eduardo.valen...@ti.com ---

Re: [PATCH v2 3/4] ARM: dts: thermal: exynos4: Add documentation for Exynos SoC thermal bindings

2013-04-25 Thread Eduardo Valentin
On 25-04-2013 08:30, Lukasz Majewski wrote: Proper description for Exynos4 bindings added to Documentation/devicetree/ bindings Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com I am fine with this one too. Reviewed-by: Eduardo

Re: [PATCH v3 00/13] ARM: EXYNOS: Fix Universal C210 support

2013-04-25 Thread Kukjin Kim
On 04/25/13 23:46, Arnd Bergmann wrote: On Universal C210 board, both with and without DT: Tested-by: Tomasz Figat.f...@samsung.com Reviewed-by: Arnd Bergmanna...@arndb.de Olof, Kgene, I think we should have this one in 3.10 since it fixes a regression. It looks bigger than it really is

Re: [PATCH v2 0/4] Thermal:exynos: Thermal Measurement Unit fix and Samsung SoCs support

2013-04-25 Thread Lukasz Majewski
Hi Eduardo, Hello Lukasz, On 25-04-2013 08:30, Lukasz Majewski wrote: This patch series provide various fixes for TMU block. First of all it fixes a problem with get_cpu_frequency() lockup at cpu_cooling.c. Secondly a proper regulator definition (VDD_TS) has been added. Moreover

Re: Exynos regressions w.r.t. config and debuggability due to multiplatform

2013-04-25 Thread Arnd Bergmann
On Thursday 25 April 2013, Kukjin Kim wrote: On 04/25/13 00:03, Arnd Bergmann wrote: On Wednesday 24 April 2013, Olof Johansson wrote: I think we should hold off on multiplatform for exynos until it works better, i.e. 3.11. I think, this would be better choice for now if it's not

Re: [PATCH v2 0/4] Thermal:exynos: Thermal Measurement Unit fix and Samsung SoCs support

2013-04-25 Thread Sachin Kamat
Hi Eduardo, On 25 April 2013 21:58, Lukasz Majewski l.majew...@samsung.com wrote: Hi Eduardo, Hello Lukasz, On 25-04-2013 08:30, Lukasz Majewski wrote: This patch series provide various fixes for TMU block. First of all it fixes a problem with get_cpu_frequency() lockup at