Re: [PATCH] ARM: exynos: Select PINCTRL_EXYNOS for exynos5

2013-05-09 Thread Tomasz Figa
Hi Doug, Olof, On Wednesday 08 of May 2013 12:33:34 Olof Johansson wrote: Hi, On Wed, May 8, 2013 at 11:48 AM, Doug Anderson diand...@chromium.org wrote: Olof, On Wed, May 8, 2013 at 11:19 AM, Olof Johansson o...@lixom.net wrote: Seems like this should be selected by the SoC

Re: [PATCH V3 06/21] thermal: exynos: Add missing definations and code cleanup

2013-05-09 Thread Eduardo Valentin
Amit, On 07-05-2013 09:00, Amit Daniel Kachhap wrote: This patch adds some extra register bitfield definations and cleans up the code to prepare for moving register macros and definations inside the TMU data section. Acked-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel

Re: [PATCH V3 09/21] thermal: exynos: Move register definitions from driver file to data file

2013-05-09 Thread Eduardo Valentin
Hey Amit, On 07-05-2013 09:00, Amit Daniel Kachhap wrote: This patch migrates the TMU register definition/bitfields to data file. This is needed to support SoC's which use the same TMU controller but register validity, offsets or bitfield may slightly vary across SOC's. Acked-by: Kukjin Kim

Re: [PATCH V3 10/21] thermal: exynos: Fix to clear only the generated interrupts

2013-05-09 Thread Eduardo Valentin
On 07-05-2013 09:01, Amit Daniel Kachhap wrote: This patch uses the TMU status register to know the generated interrupts and only clear them in the interrupt handler. Acked-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com ---

Re: [PATCH V3 20/21] thermal: exynos: Support for TMU regulator defined at device tree

2013-05-09 Thread Eduardo Valentin
On 07-05-2013 09:01, Amit Daniel Kachhap wrote: TMU probe function now checks for a device tree defined regulator. For compatibility reasons it is allowed to probe driver even without this regulator defined. Signed-off-by: Lukasz Majewski l.majew...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH V3 15/21] thermal: exynos: Add support to handle many instances of TMU

2013-05-09 Thread Eduardo Valentin
On 07-05-2013 09:01, Amit Daniel Kachhap wrote: This patch adds support to handle multiple instances of the TMU controllers. This is done by removing the static structure to register with the core thermal and creating it dynamically for each instance of the TMU controller. The interrupt is

Re: [PATCH] ARM: exynos: Select PINCTRL_EXYNOS for exynos5

2013-05-09 Thread Doug Anderson
Tomasz / Olof, On Thu, May 9, 2013 at 2:45 AM, Tomasz Figa t.f...@samsung.com wrote: Nothing stops you from doing that on your own. I tend to push back onto the maintainers to get them engaged in their own housekeeping, but anyone is free to :) I will probably leave this to the maintainers at

[PATCH v3] ARM: exynos: Select PINCTRL_EXYNOS for exynos4/5 at chip level

2013-05-09 Thread Doug Anderson
Previously if you had MACH_EXYNOS5_DT but not MACH_EXYNOS4_DT you'd be missing the pincontrol definitions. Move PINCTRL selects to the arch level since we should be enabling the code for all exynos variants. Update the PINCTRL descriptions to indicate that PINCTRL_EXYNOS is not for exynos5440.

RE: [PATCH] ARM: exynos: Select PINCTRL_EXYNOS for exynos5

2013-05-09 Thread Kukjin Kim
Doug Anderson wrote: Tomasz / Olof, Hi Doug, Tomasz and Olof On Thu, May 9, 2013 at 2:45 AM, Tomasz Figa t.f...@samsung.com wrote: Nothing stops you from doing that on your own. I tend to push back onto the maintainers to get them engaged in their own housekeeping, but anyone is free

RE: [PATCH] ARM: EXYNOS5: Fix kernel dump in AFTR idle mode

2013-05-09 Thread Kukjin Kim
Olof Johansson wrote: On Mon, Apr 29, 2013 at 05:01:47PM +0530, Inderpal Singh wrote: The kernel crashes while resuming from AFTR idle mode. It happens because L2 cache was not going into retention state. This patch configures the USE_RETENTION bit of ARM_L2_OPTION register so that it

Re: [GIT PULL] Late Exynos stuff for v3.10

2013-05-09 Thread Olof Johansson
Kukjin, On Thu, Apr 25, 2013 at 8:38 AM, Kukjin Kim kgene@samsung.com wrote: It doesn't have to be something super-elaborate, but I'd like it to be sort of self-documenting in a way that I don't have to look through the series of patches to get an overview of what's in the branch. Of

Re: [PATCH] ARM: EXYNOS5: Fix kernel dump in AFTR idle mode

2013-05-09 Thread Olof Johansson
On Thu, May 9, 2013 at 4:32 PM, Kukjin Kim kgene@samsung.com wrote: Olof Johansson wrote: On Mon, Apr 29, 2013 at 05:01:47PM +0530, Inderpal Singh wrote: The kernel crashes while resuming from AFTR idle mode. It happens because L2 cache was not going into retention state. This patch

Re: [PATCH V2 1/3] clk: samsung: register audio subsystem clocks using common clock framework

2013-05-09 Thread Tomasz Figa
Hi Padmavathi, I managed to review the patch a bit more thoroughly and I had few more comments. You can find them inline. On Tuesday 07 of May 2013 12:13:34 Padmavathi Venna wrote: Audio subsystem is introduced in s5pv210 and exynos platforms. This has seperate clock controller which can

Re: [PATCH V2 0/3] clk: Samsung: audss: Register audio subsytem clocks using common clk framework

2013-05-09 Thread Tomasz Figa
Hi Padmavathi, On Tuesday 07 of May 2013 12:13:33 Padmavathi Venna wrote: Samsung S5PV210 and Exynos SoC has a separate subsystem for audio. This subsystem has a internal clock controller which controls i2s0 and pcm0 clocks. This patch series adds the Samsung audio subsytem clock to the

RE: [PATCH v5] pinctrl: Add pinctrl-s3c24xx driver

2013-05-09 Thread Kukjin Kim
Heiko Stübner wrote: The s3c24xx pins follow a similar pattern as the other Samsung SoCs and can therefore reuse the already introduced infrastructure. The s3c24xx SoCs have one design oddity in that the first 4 external interrupts do not reside in the eint pending register but in the main

Re: [PATCH V3 04/21] thermal: exynos: Move exynos_thermal.h from include/* to driver/* folder

2013-05-09 Thread amit daniel kachhap
Hi, On Thu, May 9, 2013 at 6:58 PM, Eduardo Valentin eduardo.valen...@ti.com wrote: Hello Amit, On 07-05-2013 09:00, Amit Daniel Kachhap wrote: This patch renames and moves include/linux/platform_data/exynos_thermal.h to drivers/thermal/samsung/exynos_tmu.h. This file movement is needed as

Re: [PATCH V3 05/21] thermal: exynos: Bifurcate exynos tmu driver and configuration data

2013-05-09 Thread amit daniel kachhap
Hi Eduardo, On Thu, May 9, 2013 at 7:09 PM, Eduardo Valentin eduardo.valen...@ti.com wrote: Hey Amit, On 07-05-2013 09:00, Amit Daniel Kachhap wrote: This code splits the exynos tmu driver code into SOC specific data parts. This will simplify adding new SOC specific data to the same TMU

Re: [PATCH V3 06/21] thermal: exynos: Add missing definations and code cleanup

2013-05-09 Thread amit daniel kachhap
Hi, On Thu, May 9, 2013 at 7:22 PM, Eduardo Valentin eduardo.valen...@ti.com wrote: Amit, On 07-05-2013 09:00, Amit Daniel Kachhap wrote: This patch adds some extra register bitfield definations and cleans up the code to prepare for moving register macros and definations inside the TMU data

Re: [PATCH V3 09/21] thermal: exynos: Move register definitions from driver file to data file

2013-05-09 Thread amit daniel kachhap
Hi Eduardo, On Thu, May 9, 2013 at 8:02 PM, Eduardo Valentin eduardo.valen...@ti.com wrote: Hey Amit, On 07-05-2013 09:00, Amit Daniel Kachhap wrote: This patch migrates the TMU register definition/bitfields to data file. This is needed to support SoC's which use the same TMU controller but

Re: [PATCH V3 18/21] thermal: exynos: Add support for exynos5440 TMU sensor.

2013-05-09 Thread amit daniel kachhap
Hi Eduardo, On Thu, May 9, 2013 at 8:17 PM, Eduardo Valentin eduardo.valen...@ti.com wrote: Hey Amit, On 07-05-2013 09:01, Amit Daniel Kachhap wrote: This patch modifies TMU controller to add changes needed to work with exynos5440 platform. Also register definitions and required

Re: [PATCH V3 15/21] thermal: exynos: Add support to handle many instances of TMU

2013-05-09 Thread amit daniel kachhap
On Thu, May 9, 2013 at 8:23 PM, Eduardo Valentin eduardo.valen...@ti.com wrote: On 07-05-2013 09:01, Amit Daniel Kachhap wrote: This patch adds support to handle multiple instances of the TMU controllers. This is done by removing the static structure to register with the core thermal and

Re: [PATCH 3/3] ARM: dts: Add display timing node to exynos5250-arndale.dts

2013-05-09 Thread Olof Johansson
On Thu, May 9, 2013 at 7:55 PM, Vikas Sajjan vikas.saj...@linaro.org wrote: Hi Tomasz, On 10 May 2013 05:35, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vikas, On Wednesday 08 of May 2013 11:31:34 Vikas Sajjan wrote: Adds display timing node for a DP panel to Arndale Board DTS file