Re: [PATCH V3] pci: exynos: split into two parts such as Synopsys part and Exynos part

2013-07-23 Thread Kishon Vijay Abraham I
Hi, On Tuesday 23 July 2013 06:44 AM, Jingoo Han wrote: On Tuesday, July 23, 2013 12:04 AM, Kishon Vijay Abraham I wrote: On Thursday 18 July 2013 10:51 AM, Jingoo Han wrote: Exynos PCIe IP consists of Synopsys specific part and Exynos specific part. Only core block is a Synopsys designware

[PATCH] ARM: dts: Add secure-firmware boot support for OrigenQaud board

2013-07-23 Thread Tushar Behera
OrigenQuad board boots with secure firmware support. Enable support for reading smc commands. The binding has been updated as per the documentation provided in Documentation/devicetree/bindings/arm/samsung-boards.txt. Signed-off-by: Tushar Behera tushar.beh...@linaro.org ---

Re: [PATCH V3] pci: exynos: split into two parts such as Synopsys part and Exynos part

2013-07-23 Thread Jingoo Han
On Tuesday, July 23, 2013 3:30 PM, Kishon Vijay Abraham I wrote: On Tuesday 23 July 2013 06:44 AM, Jingoo Han wrote: On Tuesday, July 23, 2013 12:04 AM, Kishon Vijay Abraham I wrote: On Thursday 18 July 2013 10:51 AM, Jingoo Han wrote: Exynos PCIe IP consists of Synopsys specific part and

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
Hi Alan, On Monday 22 of July 2013 10:44:39 Alan Stern wrote: On Mon, 22 Jul 2013, Kishon Vijay Abraham I wrote: The PHY and the controller it is attached to are both physical devices. The connection between them is hardwired by the system manufacturer and cannot be

Re: [PATCH] ARM: EXYNOS: Fix low level debug support

2013-07-23 Thread Yadwinder Singh Brar
On Mon, Jul 22, 2013 at 6:37 PM, Tomasz Figa t.f...@samsung.com wrote: On Monday 22 of July 2013 06:23:06 Thomas Abraham wrote: On 13 July 2013 04:57, Yadwinder Singh Brar yadi.b...@samsung.com wrote: Presently, using exynos_defconfig with CONFIG_DEBUG_LL and CONFIG_EARLY_PRINTK on, kernel

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
[Fixed address of devicetree mailing list and added more people on CC.] For reference, full thread can be found under following link: http://thread.gmane.org/gmane.linux.ports.arm.kernel/252813 Best regards, Tomasz On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, On Monday 22

Re: [PATCH] ARM: S3C24XX: Add missing clkdev entries for s3c2440 UART

2013-07-23 Thread Jürgen Beisert
On Sunday 21 July 2013 21:42:45 Sylwester Nawrocki wrote: This patch restores serial port operation which has been broken since commit 60e93575476f90a72146b51283f514da655410a7 serial: samsung: enable clock before clearing pending interrupts during init That commit only uncovered the real

[PATCH V3] watchdog: s3c2410_wdt: remove the global variables

2013-07-23 Thread Leela Krishna Amudala
This patch removes the global variables in the driver file and group them into a structure. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- Note: This patch is rebased on kgene's for-next branch and tested on SMDK5420. Changes since V2: - Addressed comments given by

Re: [PATCH V2] watchdog: s3c2410_wdt: remove the global variables

2013-07-23 Thread Leela Krishna Amudala
Hello Tomas Figa, Thanks for reviewing the patch. On Mon, Jul 22, 2013 at 11:08 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Leela Krishna, Looks mostly good, but see some comments inline. On Monday 22 of July 2013 11:44:09 Leela Krishna Amudala wrote: This patch removes the global

Re: [PATCH V2] watchdog: s3c2410_wdt: remove the global variables

2013-07-23 Thread Leela Krishna Amudala
Hi Sachin, On Tue, Jul 23, 2013 at 8:28 AM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Leela, On 22 July 2013 11:44, Leela Krishna Amudala l.kris...@samsung.com wrote: This patch removes the global variables in the driver file and group them into a structure. Signed-off-by: Leela

Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file

2013-07-23 Thread Lee Jones
On Mon, 22 Jul 2013, Tomasz Figa wrote: Hi Lee, On Monday 22 of July 2013 11:52:26 Lee Jones wrote: Cc: Kukjin Kim kgene@samsung.com Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org --- arch/arm/boot/dts/exynos4210.dtsi | 2 +- 1 file

Re: [PATCH 07/22] ARM: exynos: Remove '0x's from Exynos4110 DTSI file

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 09:55:52 Lee Jones wrote: On Mon, 22 Jul 2013, Tomasz Figa wrote: Hi Lee, On Monday 22 of July 2013 11:52:26 Lee Jones wrote: Cc: Kukjin Kim kgene@samsung.com Cc: linux-samsung-soc@vger.kernel.org Signed-off-by: Lee Jones lee.jo...@linaro.org ---

Re: [PATCH] ARM: DT: Exynos: fix number of interrupt-cells in mct node

2013-07-23 Thread Chander Kashyap
ping. On 14 June 2013 20:11, Chander Kashyap chander.kash...@linaro.org wrote: Two cells were used to specify interrupts in mct node, while second cell always remains unused. Hence use only one cell. Suggested by Tomasz Figa. Signed-off-by: Chander Kashyap chander.kash...@linaro.org ---

[PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Antonios Motakis
IOMMU groups are expected by certain users of the IOMMU API, e.g. VFIO. Since each device is behind its own System MMU, we can allocate a new IOMMU group for each device. This patch depends on Cho KyongHo's patch series titled [PATCH v7 00/12] iommu/exynos: Fixes and Enhancements of System MMU

Re: [PATCH 2/4] clk: exynos-audss: allow input clocks to be specified in device tree

2013-07-23 Thread Padma Venkat
Hi Tomasz, On Tue, Jul 23, 2013 at 1:12 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On Monday 22 of July 2013 11:15:30 Mike Turquette wrote: Quoting Tomasz Figa (2013-07-22 09:28:47) Hi Padmavathi, Andrew, On Wednesday 10 of July 2013 17:41:51 Padmavathi Venna wrote: From: Andrew

Re: [PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Antonios Motakis
On Tue, Jul 23, 2013 at 12:31 PM, Inki Dae inki@samsung.com wrote: -Original Message- From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung-soc- ow...@vger.kernel.org] On Behalf Of Antonios Motakis Sent: Tuesday, July 23, 2013 7:02 PM To:

Re: [PATCH V3] watchdog: s3c2410_wdt: remove the global variables

2013-07-23 Thread Tomasz Figa
Hi, On Tuesday 23 of July 2013 14:29:45 Leela Krishna Amudala wrote: This patch removes the global variables in the driver file and group them into a structure. Signed-off-by: Leela Krishna Amudala l.kris...@samsung.com --- Note: This patch is rebased on kgene's for-next branch and tested

RE: [PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Inki Dae
-Original Message- From: Antonios Motakis [mailto:a.mota...@virtualopensystems.com] Sent: Tuesday, July 23, 2013 8:00 PM To: Inki Dae Cc: Linux ARM Kernel; Linux IOMMU; Linux Samsung SOC; kvm-arm; Cho KyongHo; Joerg Roedel; Sachin Kamat; Jiri Kosina; Wei Yongjun; open list

Re: [PATCH v2 1/8] clk: mux: Add support for read-only muxes.

2013-07-23 Thread Sergei Shtylyov
Hello. On 23-07-2013 3:49, Tomasz Figa wrote: Some platforms have read-only clock muxes that are preconfigured at reset and cannot be changed at runtime. This patch extends mux clock driver to allow handling such read-only muxes by adding new CLK_MUX_READ_ONLY mux flag. Signed-off-by:

Re: [PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Antonios Motakis
On Tue, Jul 23, 2013 at 1:21 PM, Inki Dae inki@samsung.com wrote: -Original Message- From: Antonios Motakis [mailto:a.mota...@virtualopensystems.com] Sent: Tuesday, July 23, 2013 8:00 PM To: Inki Dae Cc: Linux ARM Kernel; Linux IOMMU; Linux Samsung SOC; kvm-arm; Cho KyongHo;

RE: [PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Cho KyongHo
-Original Message- From: Inki Dae [mailto:inki@samsung.com] Sent: Tuesday, July 23, 2013 8:21 PM -Original Message- From: Antonios Motakis [mailto:a.mota...@virtualopensystems.com] Sent: Tuesday, July 23, 2013 8:00 PM To: Inki Dae Cc: Linux ARM Kernel; Linux

Re: [PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Antonios Motakis
On Tue, Jul 23, 2013 at 2:13 PM, Cho KyongHo pullip@samsung.com wrote: -Original Message- From: Inki Dae [mailto:inki@samsung.com] Sent: Tuesday, July 23, 2013 8:21 PM -Original Message- From: Antonios Motakis [mailto:a.mota...@virtualopensystems.com] Sent:

RE: [PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Cho KyongHo
-Original Message- From: Antonios Motakis [mailto:a.mota...@virtualopensystems.com] Sent: Tuesday, July 23, 2013 9:23 PM On Tue, Jul 23, 2013 at 2:13 PM, Cho KyongHo pullip@samsung.com wrote: -Original Message- From: Inki Dae [mailto:inki@samsung.com] Sent:

RE: [PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Sethi Varun-B16395
-Original Message- From: iommu-boun...@lists.linux-foundation.org [mailto:iommu- boun...@lists.linux-foundation.org] On Behalf Of Antonios Motakis Sent: Tuesday, July 23, 2013 3:32 PM To: linux-arm-ker...@lists.infradead.org; iommu@lists.linux- foundation.org;

[v2 PATCH 0/2] EXYNOS: Fix low level debug support

2013-07-23 Thread Yadwinder Singh Brar
Presently, using exynos_defconfig with CONFIG_DEBUG_LL and CONFIG_EARLY_PRINTK on, kernel is not booting, we are getting following: [0.00] [ cut here ] [0.00] kernel BUG at mm/vmalloc.c:1134! [0.00] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM

[PATCH 2/2] ARM: EXYNOS: Fix low level debug support

2013-07-23 Thread Yadwinder Singh Brar
Presently, using exynos_defconfig with CONFIG_DEBUG_LL and CONFIG_EARLY_PRIN on, kernel is not booting, we are getting following: [0.00] [ cut here ] [0.00] kernel BUG at mm/vmalloc.c:1134! [0.00] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM [

[PATCH 1/2] ARM: SAMSUNG: pm: Save/restore only selected uart's registers

2013-07-23 Thread Yadwinder Singh Brar
Basically this code gets executed only during debugging i.e when DEBUG_LL SAMSUNG_PM_DEBUG is on, so required only for UART used for debugging. Since we are removing static iodesc entries for UARTs, so now only the selected (CONFIG_DEBUG_S3C_UART) UART will be ioremapped by the debug_ll_io_init()

RE: [PATCH] iommu/exynos: add devices attached to the System MMU to an IOMMU group

2013-07-23 Thread Inki Dae
-Original Message- From: Antonios Motakis [mailto:a.mota...@virtualopensystems.com] Sent: Tuesday, July 23, 2013 9:05 PM To: Inki Dae Cc: Linux ARM Kernel; Linux IOMMU; Linux Samsung SOC; kvm-arm; Cho KyongHo; Joerg Roedel; Sachin Kamat; Jiri Kosina; Wei Yongjun; open list; Alex

Re: [PATCH v2] spi: s3c64xx: fix casting warning

2013-07-23 Thread Mark Brown
On Mon, Jul 22, 2013 at 07:09:27PM +0200, Tomasz Figa wrote: On Wednesday 17 of July 2013 11:08:16 Mark Brown wrote: Applied, though only the cast to unsigned long should actually be needed - casting to void * should be good for any pointer so changing to the specific struct shouldn't be

Re: [PATCH v2] spi: s3c64xx: fix casting warning

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 14:27:53 Mark Brown wrote: On Mon, Jul 22, 2013 at 07:09:27PM +0200, Tomasz Figa wrote: On Wednesday 17 of July 2013 11:08:16 Mark Brown wrote: Applied, though only the cast to unsigned long should actually be needed - casting to void * should be good for any

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here. Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any other device types as well. In those other cases, presumably

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 10:37:05 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here. Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Kishon Vijay Abraham I
Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here. Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any other

Re: [PATCH v4 00/20] Samsung PWM support cleanup

2013-07-23 Thread Thierry Reding
On Mon, Jul 22, 2013 at 09:49:49AM +0200, Tomasz Figa wrote: On Monday 22 of July 2013 11:01:32 Kukjin Kim wrote: Kukjin Kim wrote: Tomasz Figa wrote: On Monday 22 of July 2013 00:22:16 Sylwester Nawrocki wrote: On 07/20/2013 02:04 AM, Tomasz Figa wrote: Since we now have a

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here.

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Kishon Vijay Abraham I
Hi Greg, On Tuesday 23 July 2013 09:48 PM, Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 09:58:34PM +0530, Kishon Vijay Abraham I wrote: Hi Greg, On Tuesday 23 July 2013 09:48 PM, Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 09:18:46 Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi

[PATCH] ARM: dts: Add USBPHY nodes to Exynos4x12

2013-07-23 Thread Dongjin Kim
This patch adds device nodes for USBPHY to Exynos4x12. Signed-off-by: Dongjin Kim tobet...@gmail.com --- arch/arm/boot/dts/exynos4x12.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi index

[PATCH] ARM: dts: Add USB host node for Exynos4

2013-07-23 Thread Dongjin Kim
This patch adds EHCI and OHCI host device nodes for Exynos4. Signed-off-by: Dongjin Kim tobet...@gmail.com --- arch/arm/boot/dts/exynos4.dtsi | 20 1 file changed, 20 insertions(+) diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi index

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer in the first place, right? IMHO it would be better if you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 10:37:05AM -0400, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any other device types as well. In those other cases, presumably there is no platform data associated with the PHY

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 10:37:11AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: I fully agree that a simple, single string will not scale even in some, not so uncommon cases, but there is already a lot of existing lookup solutions over the kernel and

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer in

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote: On Tue, Jul 23, 2013 at 10:37:11AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: I fully agree that a simple, single string will not scale even in some, not so uncommon cases, but there

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from,

[REVIEW PATCH 0/6] exynos4-is: Asynchronous subdev registration support

2013-07-23 Thread Sylwester Nawrocki
This patch series is a refactoring of the exynos4-is driver to get rid of the common fimc-is-sensor driver and to adapt it to use standard sensor subdev drivers, one per each image sensor type. Then a clock provider is added to the exynos4-is driver and the s5k6a3 subdev is modified to use one of

[REVIEW PATCH 2/6] V4L: s5k6a3: Add support for asynchronous subdev registration

2013-07-23 Thread Sylwester Nawrocki
This patch converts the driver to use v4l2 asynchronous subdev registration API an the common clock API. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/i2c/s5k6a3.c | 63

[REVIEW PATCH 1/6] V4L: Add driver for s5k6a3 image sensor

2013-07-23 Thread Sylwester Nawrocki
This patch adds subdev driver for Samsung S5K6A3 raw image sensor. As it is intended at the moment to be used only with the Exynos FIMC-IS (camera ISP) subsystem it is pretty minimal subdev driver. It doesn't do any I2C communication since the sensor is controlled by the ISP and its own firmware.

[REVIEW PATCH 4/6] exynos4-is: Add clock provider for the external clocks

2013-07-23 Thread Sylwester Nawrocki
This patch adds clock provider to expose the sclk_cam0/1 clocks for image sensor subdevs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/samsung-fimc.txt | 17 +++-

[REVIEW PATCH 3/6] exynos4-is: Simplify sclk_cam clocks handling

2013-07-23 Thread Sylwester Nawrocki
Use clk_prepare_enable()/clk_disable_unprepare() instead of separately prearing/unparing the clk_cam clocks. This simplifies the code that is now mostly not going to be used, function __fimc_md_set_camclk() is only left for S5PV210 platform which is not yet converted to Device Tree.

[REVIEW PATCH 6/6] exynos4-is: Add support for asynchronous sensor subddevs registration

2013-07-23 Thread Sylwester Nawrocki
Add support registering external sensor subdevs using the v4l2-async API. The async API is used only for sensor subdevs and only for platforms instatiated from Device Tree. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[REVIEW PATCH 5/6] exynos4-is: Use external s5k6a3 sensor driver

2013-07-23 Thread Sylwester Nawrocki
This patch removes the common fimc-is-sensor driver for image sensors that are normally controlled by the FIMC-IS firmware. The FIMC-IS driver now contains only a table of properties specific to each sensor. The sensor properties required for the ISP's firmware are parsed from device tree and

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 11:01:10AM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 06:44:56PM +0100, Mark Brown wrote: What are the problems you are seeing with doing things with lookups? You don't know the id of the device you are looking up, due to multiple devices being in the system

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Tomasz Figa wrote: IMHO it would be better if you provided some code example, but let's try to check if I understood you correctly. 8 [Board file] static struct phy my_phy; static struct

Re: [PATCH] ASoC: Samsung: Modify the I2S driver to support I2S on Exynos5420

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 09:38:00AM +0530, Padma Venkat wrote: On Fri, Jul 12, 2013 at 2:19 PM, Mark Brown broo...@kernel.org wrote: Yes, this is good but the quirk should just be found by software based on the compatible string rather than in the DT. You mean I just need to initialize the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.) I got copied in very late so don't have most of the

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.)

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 15:36:00 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: IMHO it would be better if you provided some code example, but let's try to check if I understood you correctly. 8--- -

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 11:04:14 Greg KH wrote: On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids,

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Tomasz Figa wrote: That's what I was going to suggest too. The struct phy is defined in the board file, which already knows about all the PHYs that exist in the system. (Or perhaps it is allocated dynamically, so that when many board files are present in the same

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 16:53:55 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: That's what I was going to suggest too. The struct phy is defined in the board file, which already knows about all the PHYs that exist in the system. (Or perhaps it is allocated

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 13:50:07 Greg KH wrote: On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Alan Stern
On Tue, 23 Jul 2013, Tomasz Figa wrote: If you want to keep the phy struct completely separate from the board file, there's an easy way to do it. Let's say the board file knows about N different PHYs in the system. Then you define an array of N pointers to phys: struct phy

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Greg KH
On Tue, Jul 23, 2013 at 11:05:48PM +0200, Tomasz Figa wrote: That's not so bad, as long as you let the phy core use whatever name it wants for the device when it registers it with sysfs. Yes, in regulator core consumer names are completely separated from this. Regulator core simply

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: If you want to keep the phy struct completely separate from the board file, there's an easy way to do it. Let's say the board file knows about N different PHYs in the system. Then you

[PATCH v6 02/20] clocksource: samsung_pwm_timer: Correct definition of AUTORELOAD bit

2013-07-23 Thread Tomasz Figa
PWM channel 4 has its autoreload bit located at different position. This patch fixes the driver to account for that. This fixes a problem with the clocksource hanging after it overflows because it is not reloaded any more. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Reviewed-by: Sylwester

[PATCH v6 13/20] pwm: Add new pwm-samsung driver

2013-07-23 Thread Tomasz Figa
This patch introduces new Samsung PWM driver, which is completely rewritten to be multiplatform- and DeviceTree-aware. In addition, remaining problems of old driver are fixed, such as: - proper handling of hardware variants, - synchronization on SMP systems, - handling of boundary parameter

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Mark Brown
On Tue, Jul 23, 2013 at 12:44:23PM -0700, Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: statement. In any case this is why the APIs doing lookups do the lookups in the context of the requesting device - devices ask for whatever name they use locally. What do

[PATCH v3 2/8] clk: samsung: pll: Add support for PLL6552 and PLL6553

2013-07-23 Thread Tomasz Figa
This patch adds support for PLL6552 and PLL6553 PLLs present on Samsung S3C64xx SoCs. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Acked-by: Mike Turquette mturque...@linaro.org --- drivers/clk/samsung/clk-pll.c | 77 +++ drivers/clk/samsung/clk-pll.h

[PATCH v3 3/8] clk: samsung: Add clock driver for S3C64xx SoCs

2013-07-23 Thread Tomasz Figa
This patch adds new, Common Clock Framework-based clock driver for Samsung S3C64xx SoCs. The driver is just added, without actually letting the platforms use it yet, since this requires more intermediate steps. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com Acked-by: Mike Turquette

RE: [PATCH 3/3] ARM: dts: Add WM1811A audio CODEC to Arndale bindings

2013-07-23 Thread Kukjin Kim
Mark Brown wrote: On Tue, Jul 02, 2013 at 10:51:36AM +0530, Tushar Behera wrote: Arndale board also comes with two other audio codec boards - ALC5631Q and AK4678. Different audio codec boards came with different shipments. This is the default though and since they didn't bother

RE: [PATCH 1/4] ARM: dts: Hook up IRQ for PMIC on Arndale

2013-07-23 Thread Kukjin Kim
Mark Brown wrote: From: Mark Brown broo...@linaro.org The out of tree code configures a pullup on the line indicating that it is an active low interrupt. Signed-off-by: Mark Brown broo...@linaro.org --- arch/arm/boot/dts/exynos5250-arndale.dts | 3 +++ 1 file changed, 3 insertions(+)

RE: [PATCH 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

2013-07-23 Thread Kukjin Kim
Sachin Kamat wrote: [...] Hmm, BTW, I'm wondering why it is 288 not 285 or other specific number... I wasn't really sure if we can have any number there. I chose the closest one (288) which was already used by other platform. If there is no problem to use 285 itself then I can

RE: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file

2013-07-23 Thread Kukjin Kim
Sachin Kamat wrote: Remove unused declarations that got left behind subsequent to making Exynos a DT-only platform. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/common.h | 41 - 1 file changed, 41 deletions(-)

RE: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file

2013-07-23 Thread Kukjin Kim
Kukjin Kim wrote: Sachin Kamat wrote: Remove unused declarations that got left behind subsequent to making Exynos a DT-only platform. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/common.h | 41 --- -- 1

Re: [PATCH 1/1] ARM: EXYNOS: Cleanup common.h file

2013-07-23 Thread Sachin Kamat
On 24 July 2013 08:43, Kukjin Kim kg...@kernel.org wrote: Kukjin Kim wrote: Sachin Kamat wrote: Remove unused declarations that got left behind subsequent to making Exynos a DT-only platform. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org --- arch/arm/mach-exynos/common.h |

Re: [PATCH] ARM: dts: Add USB host node for Exynos4

2013-07-23 Thread Sachin Kamat
On 23 July 2013 23:02, Dongjin Kim tobet...@gmail.com wrote: This patch adds EHCI and OHCI host device nodes for Exynos4. Signed-off-by: Dongjin Kim tobet...@gmail.com --- arch/arm/boot/dts/exynos4.dtsi | 20 1 file changed, 20 insertions(+) diff --git

[PATCH v3 1/1] ARM: EXYNOS: Update CONFIG_ARCH_NR_GPIO for Exynos

2013-07-23 Thread Sachin Kamat
With the recent cleanup in Exynos platform code notably commits 17859bec (ARM: EXYNOS: Do not select legacy Kconfig symbols any more) and b910 (ARM: EXYNOS: Remove mach/gpio.h), the definition of ARCH_NR_GPIOS got removed. This started causing problems on SoCs like Exynos4412 which have more

[PATCH] ARM: dts: re-ordering exynos dtbs in Makefile

2013-07-23 Thread Kukjin Kim
Re-ordering in alphabetical. Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/boot/dts/Makefile |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index 641b3c9..ad340e4 100644 ---

RE: [PATCH] ARM: dts: Add basic dts for Exynos4412-based Trats 2 board

2013-07-23 Thread Kukjin Kim
Tomasz Figa wrote: This patch introduces device tree sources for Samsung Trats 2 board based on Exynos4412 SoC. Currently support includes: - eMMC, - main PMIC (max77686), - serial ports, - GPIO keys, - touchscreen. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by:

RE: [PATCH V2 1/2] ARM: SAMSUNG: Add SAMSUNG_PM config option to select pm

2013-07-23 Thread Kukjin Kim
Amit Daniel Kachhap wrote: This patch enables the selection of samsung pm related stuffs when SAMSUNG_PM config is enabled and not just when generic PM config is enabled. Power management for s3c64XX and s3c24XX is enabled by default and for other platform depends on S5P_PM. This patch also

Re: [PATCH] ARM: dts: Add USBPHY nodes to Exynos4x12

2013-07-23 Thread Sachin Kamat
Hi Dongjin, On 23 July 2013 23:01, Dongjin Kim tobet...@gmail.com wrote: This patch adds device nodes for USBPHY to Exynos4x12. Signed-off-by: Dongjin Kim tobet...@gmail.com --- arch/arm/boot/dts/exynos4x12.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git

RE: [PATCH V2 2/2] ARM: EXYNOS: cpuidle: Allow C1 state only in supported SOC's.

2013-07-23 Thread Kukjin Kim
Amit Daniel Kachhap wrote: This patch registers the basic C0 state for all exynos SOC's but limits the C1(AFTR -Arm off top running) state in only the supported SOC's(ie. EXYNOS 4210, 4212, 4412 and 5250). Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com ---

Re: [PATCH V2 1/2] ARM: SAMSUNG: Add SAMSUNG_PM config option to select pm

2013-07-23 Thread amit daniel kachhap
On Wed, Jul 24, 2013 at 10:24 AM, Kukjin Kim kg...@kernel.org wrote: Amit Daniel Kachhap wrote: This patch enables the selection of samsung pm related stuffs when SAMSUNG_PM config is enabled and not just when generic PM config is enabled. Power management for s3c64XX and s3c24XX is enabled