Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver

2013-10-24 Thread Olof Johansson
Hi Kishon, On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I kis...@ti.com wrote: diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c index 32e5406..00b3a52 100644 --- a/drivers/video/exynos/exynos_mipi_dsi.c +++

Re: [PATCH 5/7] phy: Add driver for Exynos DP PHY

2013-10-24 Thread Tomasz Stanislawski
Hi Kishon, Recently, I posted 'simple-phy' driver. It is a part of patchset for HDMI enabling on Exynos4 using Device Tree. http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg23655.html The simple-phy was dedicated for single register PHYs like HDMI or DP. Using such a generic phy

[PATCH] drivers: video: exynos: Fix compiler Warning

2013-10-24 Thread Kishon Vijay Abraham I
Fixed the following compilation warning: ../../drivers/video/exynos/exynos_mipi_dsi.c: In function 'exynos_mipi_dsi_blank_mode': ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused variable 'pdev' [-Wunused-variable] struct platform_device *pdev = to_platform_device(dsim-dev);

Re: [PATCH] drivers: video: exynos: Fix compiler Warning

2013-10-24 Thread Felipe Balbi
On Thu, Oct 24, 2013 at 08:57:34PM +0530, Kishon Vijay Abraham I wrote: Fixed the following compilation warning: ../../drivers/video/exynos/exynos_mipi_dsi.c: In function 'exynos_mipi_dsi_blank_mode': ../../drivers/video/exynos/exynos_mipi_dsi.c:144:26: warning: unused variable 'pdev'

Re: [RFC 05/12] phy: use of_phy_simple_xlate for NULL xlate function

2013-10-24 Thread Kishon Vijay Abraham I
Hi, On Monday 21 October 2013 07:48 PM, Tomasz Stanislawski wrote: Use default handler of_phy_simple_xlate() when NULL is passed as argument to of_phy_provider_register(). Signed-off-by: Tomasz Stanislawski t.stanisl...@samsung.com --- drivers/phy/phy-core.c |2 +- 1 file changed, 1

Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver

2013-10-24 Thread Sachin Kamat
Hi Olof, On 24 October 2013 20:00, Olof Johansson o...@lixom.net wrote: Hi Kishon, On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I kis...@ti.com wrote: diff --git a/drivers/video/exynos/exynos_mipi_dsi.c b/drivers/video/exynos/exynos_mipi_dsi.c index 32e5406..00b3a52 100644 ---

Re: [RFC 04/12] phy: Add simple-phy driver

2013-10-24 Thread Kishon Vijay Abraham I
Hi, On Monday 21 October 2013 07:48 PM, Tomasz Stanislawski wrote: Add simple-phy driver to support a single register PHY interfaces present on Exynos4 SoC. How are these PHY interfaces modelled in the SoC? Where does the register actually reside? Signed-off-by: Tomasz Stanislawski

Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver

2013-10-24 Thread Kishon Vijay Abraham I
Hi, On Thursday 24 October 2013 09:12 PM, Sachin Kamat wrote: Hi Olof, On 24 October 2013 20:00, Olof Johansson o...@lixom.net wrote: Hi Kishon, On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I kis...@ti.com wrote: diff --git a/drivers/video/exynos/exynos_mipi_dsi.c

Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver

2013-10-24 Thread Olof Johansson
On Thu, Oct 24, 2013 at 8:42 AM, Sachin Kamat sachin.ka...@linaro.org wrote: Hi Olof, On 24 October 2013 20:00, Olof Johansson o...@lixom.net wrote: Hi Kishon, On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I kis...@ti.com wrote: diff --git a/drivers/video/exynos/exynos_mipi_dsi.c

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. [...] Signed-off-by: Joe Perches j...@perches.com diff --git a/drivers/input/joystick/as5011.c

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Dmitry Torokhov
Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. No, please don't. The kzalloc may get changed in the future to not dump stack (that was added

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote: Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. [...] Signed-off-by: Joe

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and a dump_stack already done. No, please don't. The kzalloc may

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote: Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote: On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: [] Any k.alloc without __GFP_NOWARN does a generic OOM message and a dump_stack() so there could already be 2 messages anyway. Then mention that in the commit log if you

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Dmitry Torokhov
On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM and

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:48:48AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote: On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: [] Any k.alloc without __GFP_NOWARN does a generic OOM message and a dump_stack() so there could already be

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Joe Perches
On Thu, 2013-10-24 at 12:10 -0700, Dmitry Torokhov wrote: On Thu, Oct 24, 2013 at 11:45:39AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 11:37 -0700, Dmitry Torokhov wrote: Hi Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't

Re: [PATCH 3/7] video: exynos_mipi_dsim: Use the generic PHY driver

2013-10-24 Thread Sylwester Nawrocki
On 10/24/2013 05:57 PM, Kishon Vijay Abraham I wrote: On Thursday 24 October 2013 09:12 PM, Sachin Kamat wrote: On 24 October 2013 20:00, Olof Johanssono...@lixom.net wrote: On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham Ikis...@ti.com wrote: diff --git