Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-26 Thread Russell King - ARM Linux
On Tue, Jan 21, 2014 at 12:45:05AM +, Alan Cox wrote: Peter handed it on. Try using git log on Documentation/devices.txt. It still gets updates. Perhaps you'd care to stick to reality and fix the tree instead of trying to excuse the mess ? Perhaps returning to reality might be

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Tomasz Figa
Hi Manish, On 26.01.2014 08:15, Manish Badarkhe wrote: Instead of #if define CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- :100644 100644 b4513f2... d353fbc... M drivers/power/max8925_power.c

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Manish Badarkhe
Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Manish, On 26.01.2014 08:15, Manish Badarkhe wrote: Instead of #if define CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code.

[PATCH V2] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Manish Badarkhe
Instead of #ifdef CONFIG_OF use IS_ENABLED(CONFIG_OF) option for DT code to avoid if-deffery in code. Signed-off-by: Manish Badarkhe badarkhe.man...@gmail.com --- Changes since V1: 1. update code to retrieve platform/dt data in same function :100644 100644 b4513f2... 20a7100... M

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-26 Thread Pavel Machek
On Thu 2014-01-23 19:36:33, Mark Brown wrote: On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: On 23.01.2014 19:40, Mark Brown wrote: We'd need to leave it user selectable rather than enabling it for ARM, the whole reason this got noticed is that people are trying to build

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Dmitry Torokhov
Hi Manish, On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code. ... and also breaks the driver: now you are freeing desc-name and desc-supply_name while regulator structures are still alive and can

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Dmitry Torokhov
On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Manish, On 26.01.2014 08:15, Manish Badarkhe wrote: Instead of #if define CONFIG_OF use

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Tomasz Figa
On 26.01.2014 22:45, Dmitry Torokhov wrote: On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Manish, On 26.01.2014 08:15, Manish Badarkhe wrote:

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Dmitry Eremin-Solenikov
On Mon, Jan 27, 2014 at 1:49 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 26.01.2014 22:45, Dmitry Torokhov wrote: On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: Hi Tomasz, Thank you for your review comments. On Sun, Jan 26, 2014 at 6:52 PM, Tomasz Figa

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Dmitry Torokhov
On Mon, Jan 27, 2014 at 02:31:59AM +0400, Dmitry Eremin-Solenikov wrote: On Mon, Jan 27, 2014 at 1:49 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 26.01.2014 22:45, Dmitry Torokhov wrote: On Sun, Jan 26, 2014 at 07:31:50PM +0530, Manish Badarkhe wrote: Hi Tomasz, Thank you for

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Dmitry Eremin-Solenikov
On Mon, Jan 27, 2014 at 3:14 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Mon, Jan 27, 2014 at 02:31:59AM +0400, Dmitry Eremin-Solenikov wrote: On Mon, Jan 27, 2014 at 1:49 AM, Tomasz Figa tomasz.f...@gmail.com wrote: On 26.01.2014 22:45, Dmitry Torokhov wrote: On Sun, Jan 26,

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Mark Brown
On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code. ... and also breaks the driver: now you are freeing desc-name and

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-26 Thread Alan Cox
On Sun, 26 Jan 2014 22:09:07 +0100 Pavel Machek pa...@ucw.cz wrote: On Thu 2014-01-23 19:36:33, Mark Brown wrote: On Thu, Jan 23, 2014 at 07:47:56PM +0100, Tomasz Figa wrote: On 23.01.2014 19:40, Mark Brown wrote: We'd need to leave it user selectable rather than enabling it for ARM,

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-26 Thread Mark Brown
On Fri, Jan 24, 2014 at 02:38:59PM +, Alan Cox wrote: Mark Brown broo...@kernel.org wrote: I don't see how that follows? For the most part architecture maintainers aren't going to be able to say too much about which userspaces are being run on their platforms if the architecture has

Re: [PATCH] regulator: fixed: Use devm_regulator_register

2014-01-26 Thread Manish Badarkhe
Hi On Mon, Jan 27, 2014 at 5:33 AM, Mark Brown broo...@kernel.org wrote: On Sun, Jan 26, 2014 at 01:36:53PM -0800, Dmitry Torokhov wrote: On Sat, Jan 25, 2014 at 11:35:54PM +0530, Manish Badarkhe wrote: Use devm_regulator_register instead of regulator_register which simplifies the code.

Re: [PATCH 1/2] serial: samsung: Move uart_register_driver call to device probe

2014-01-26 Thread Nicolas Pitre
On Sun, 26 Jan 2014, Russell King - ARM Linux wrote: On Tue, Jan 21, 2014 at 12:45:05AM +, Alan Cox wrote: Peter handed it on. Try using git log on Documentation/devices.txt. It still gets updates. Perhaps you'd care to stick to reality and fix the tree instead of trying to excuse

Re: [PATCH] max8925_power: Use IS_ENABLED(CONFIG_OF) for DT code.

2014-01-26 Thread Manish Badarkhe
Hi Thank you for review. On Mon, Jan 27, 2014 at 5:16 AM, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: On Mon, Jan 27, 2014 at 3:14 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Mon, Jan 27, 2014 at 02:31:59AM +0400, Dmitry Eremin-Solenikov wrote: On Mon, Jan 27, 2014 at