Re: [RFC 3/4] drm: exynos: add IELCD post processor

2014-03-21 Thread Sachin Kamat
On 19 March 2014 19:52, Ajay Kumar ajaykumar...@samsung.com wrote: Add post processor ops for IELCD and their support functions. Expose an interface for the FIMD to register IELCD PP. [snip] + +#define exynos_ielcd_readl(addr) readl(ielcd-exynos_ielcd_base + addr) +#define

Re: [PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-21 Thread Mark Rutland
On Wed, Mar 19, 2014 at 10:32:48PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : On Tue, Mar 18, 2014 at 04:27:46PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : Hi, As a general note it's helpful for devicetree to be Cc'd on the entire series

Re: [PATCH v11 20/27] iommu/exynos: allow having multiple System MMUs for a master H/W

2014-03-21 Thread Tomasz Figa
On 21.03.2014 06:21, Cho KyongHo wrote: On Thu, 20 Mar 2014 11:54:58 +0100, Tomasz Figa wrote: On 20.03.2014 11:22, Cho KyongHo wrote: On Wed, 19 Mar 2014 16:14:57 +0100, Tomasz Figa wrote: On 19.03.2014 14:20, Tomasz Figa wrote: On 19.03.2014 01:39, Cho KyongHo wrote: On Tue, 18 Mar 2014

Re: [PATCH V8 1/7] sxgbe: Add device-tree binding support document

2014-03-21 Thread Mark Rutland
+Example: + + aliases { + ethernet0 = sxgbe0; + }; + + sxgbe0: ethernet@1a04 { + compatible = samsung,sxgbe-v2.0a; + reg = 0 0x1a04 0 0x1; + interrupt-parent = gic; + interrupts = 0 209 4, 0 185 4, 0 186

Re: [PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-21 Thread Mark Rutland
On Thu, Mar 20, 2014 at 05:26:06PM +, Byungho An wrote: From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An

Re: [PATCH v3 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-21 Thread Mark Rutland
Hi, On Mon, Mar 17, 2014 at 10:14:35PM +, Kukjin Kim wrote: Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Catalin Marinas catalin.mari...@arm.com --- arch/arm64/boot/dts/samsung-gh7.dtsi | 134 +++

[PATCH] mmc: dw_mmc: Support setting the ciu-div on exynos

2014-03-21 Thread Yuvaraj Kumar C D
From: Doug Anderson diand...@chromium.org The existing dw_mmc code for exynos5250/exynos5420 read the ciu-div property from the device tree and used it in calculations, but didn't actually ever set it in hardware. That means that if the hardware value set by the firmware didn't match what was in

[PATCH 1/2] clk: s2mps11: Fix possible NULL pointer dereference

2014-03-21 Thread Krzysztof Kozlowski
If parent device does not have of_node set the s2mps11_clk_parse_dt() returned NULL. This NULL was later passed to of_clk_add_provider() which dereferenced it in pr_debug() call. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Cc: sta...@vger.kernel.org --- drivers/clk/clk-s2mps11.c |

[PATCH 2/2] clk: s2mps11: Use of_get_child_by_name

2014-03-21 Thread Krzysztof Kozlowski
of_find_node_by_name() walks over all nodes and can thus walk outside of the parent node. Use of_get_child_by_name() instead. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-s2mps11.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH-next 2/2] clk: s2mps11: Remove useless check for clk_table

2014-03-21 Thread Krzysztof Kozlowski
There is no need for checking if 'clk_table' is not NULL twice (first after allocation and second at the end of probe()). Also move allocation of this 'clk_table' to probe from s2mps11_clk_parse_dt as this is logical place for it. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com ---

[PATCH-next 1/2] clk: s2mps11: Add missing of_node_put and of_clk_del_provider

2014-03-21 Thread Krzysztof Kozlowski
Add of_clk_del_provider to remove previously registered clock provider. Add of_node_put to decrement the ref count of clock nodes. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- drivers/clk/clk-s2mps11.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-)

RE: [PATCH v3 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-21 Thread Kukjin Kim
Mark Rutland wrote: Hi, Hi Mark, [...] +/memreserve/ 0xFEC0 0x140; /* EL3 monitor, secure intepreter */ As I've mentioned, I'm concerned that this is even in the non-secure address space that the kernel can access. Why is this not hidden from the kernel entirely? Why is it

[PATCH v4 1/3] arm64: dts: add initial dts for Samsung GH7 SoC and SSDK-GH7 board

2014-03-21 Thread Kukjin Kim
Signed-off-by: Kukjin Kim kgene@samsung.com Reviewed-by: Thomas Abraham thomas...@samsung.com Cc: Mark Rutland mark.rutl...@arm.com Cc: Catalin Marinas catalin.mari...@arm.com --- Changes since v3: - addressed comments from Mark : updated reserved memory : fixed interrupt trigger for pmu

[PATCH 0/7] mmc: dw_mmc: update host driver including HS400 support

2014-03-21 Thread Seungwon Jeon
This patch-set includes several driver's updates. Specially, HS400 mode is enabled for eMMC5.0 spec. Seungwon Jeon (7): mmc: dw_mmc: fix the max_blk_count in IDMAC mmc: dw_mmc: exynos: don't use if clock isn't available mmc: dw_mmc: exynos: move definitions to header file mmc: dw_mmc:

[PATCH 1/7] mmc: dw_mmc: fix the max_blk_count in IDMAC

2014-03-21 Thread Seungwon Jeon
Even though 1MB is reserved for descriptor table in IDMAC, the dw_mmc host driver is allowed to receive only maximum 128KB block length in one request. This is caused by setting improper max_blk_count. It needs to be e adjusted so that descriptor table is used fully. It is found that the

[PATCH 2/7] mmc: dw_mmc: exynos: don't use if clock isn't available

2014-03-21 Thread Seungwon Jeon
Adds checking whether the clock is valid. Signed-off-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc-exynos.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/dw_mmc-exynos.c b/drivers/mmc/host/dw_mmc-exynos.c index

[PATCH 7/7] ARM: dts: add HS400 support for Exynos5420

2014-03-21 Thread Seungwon Jeon
HS400 timing value set is added for SMDK5420. And GPIO line for RCLK should be pull-down state. Signed-off-by: Seungwon Jeon tgih@samsung.com --- .../devicetree/bindings/mmc/exynos-dw-mshc.txt |6 ++ arch/arm/boot/dts/exynos5420-pinctrl.dtsi |7 +++

[PATCH 5/7] mmc: dw_mmc: exynos: support eMMC's HS400 mode

2014-03-21 Thread Seungwon Jeon
Implements HS400 support for Exynos's host driver. And this patch includes some updates as new mode is added. Signed-off-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc-exynos.c | 140 +++--- drivers/mmc/host/dw_mmc-exynos.h | 14

[PATCH 6/7] ARM: dts: drop dw-mshc-ciu-div property from Exynos

2014-03-21 Thread Seungwon Jeon
As dw-mshc-ciu-div is strongly close to timing property, it is merged with each timing property. Signed-off-by: Seungwon Jeon tgih@samsung.com --- .../devicetree/bindings/mmc/exynos-dw-mshc.txt | 12 +--- arch/arm/boot/dts/exynos4412-odroidx.dts |5 ++---

[PATCH 4/7] mmc: dw_mmc: exynos: incorporate ciu_div into timing property

2014-03-21 Thread Seungwon Jeon
ciu_div may not be common value for all speed mode. So, it needs to be attached to CLKSEL timing. Signed-off-by: Seungwon Jeon tgih@samsung.com --- drivers/mmc/host/dw_mmc-exynos.c | 75 ++ drivers/mmc/host/dw_mmc-exynos.h |1 + 2 files changed, 53

RE: [PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-21 Thread Byungho An
Mark Rutland mark.rutl...@arm.com wrote: On Thu, Mar 20, 2014 at 05:26:06PM +, Byungho An wrote: From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe

Re: [PATCH V7 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-21 Thread Vince Bridgers
On Wed, Mar 19, 2014 at 9:26 PM, Byungho An bh74...@samsung.com wrote: From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An

RE: [PATCH V8 1/7] sxgbe: Add device-tree binding support document

2014-03-21 Thread Byungho An
Mark Rutland mark.rutl...@arm.com wrote: +Example: + + aliases { + ethernet0 = sxgbe0; + }; + + sxgbe0: ethernet@1a04 { + compatible = samsung,sxgbe-v2.0a; + reg = 0 0x1a04 0 0x1; + interrupt-parent = gic; +

RE: [PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-21 Thread Byungho An
Mark Rutland mark.rutl...@arm.com wrote : On Wed, Mar 19, 2014 at 10:32:48PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : On Tue, Mar 18, 2014 at 04:27:46PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : Hi, As a general note it's helpful for

RE: [PATCH V7 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-21 Thread Byungho An
Vince Bridgers vbridgers2...@gmail.com wrote : On Wed, Mar 19, 2014 at 9:26 PM, Byungho An bh74...@samsung.com wrote: From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches

[PATCH 0/4] devfreq: exynos: generalize PPMU code

2014-03-21 Thread Bartlomiej Zolnierkiewicz
Hi, This patch series generalizes PPMU support for Exynos devfreq drivers. It is based on top of devfreq: exynos: Fix minor issue and code clean to remove legacy method patch series from Chanwoo Choi (https://lkml.org/lkml/2014/3/19/713). Please note that the patches were only compile tested

[PATCH 2/4] devfreq: exynos4: introduce struct busfreq_ppmu_data

2014-03-21 Thread Bartlomiej Zolnierkiewicz
This is a preparation for making more PPMU code common for EXYNOS devfreq drivers. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/devfreq/exynos/exynos4_bus.c | 74 ++-- 1

[PATCH 3/4] devfreq: exynos5: introduce struct busfreq_ppmu_data

2014-03-21 Thread Bartlomiej Zolnierkiewicz
This is a preparation for making more PPMU code common for EXYNOS devfreq drivers. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/devfreq/exynos/exynos5_bus.c | 72 ++-- 1

[PATCH 1/4] devfreq: exynos4: use common PPMU code

2014-03-21 Thread Bartlomiej Zolnierkiewicz
From: Chanwoo Choi cw00.c...@samsung.com This patch converts exynos4_bus driver to use common PPMU code (exynos_ppmu.c) instead of individual functions related to PPC because PPMU is integrated module with both PPC and Bus event generator. When using PPMU to get bus performance read/write event

[PATCH 4/4] devfreq: exynos: make more PPMU code common

2014-03-21 Thread Bartlomiej Zolnierkiewicz
Move common PPMU code from exynos[45]_bus.c to exynos_ppmu.c. There should be no functional changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com --- drivers/devfreq/exynos/exynos4_bus.c | 70 ++--

[PATCH V10 0/7] add new Samsung SXGBE driver

2014-03-21 Thread Byungho An
Hi all, This is 10th posting for SAMSUNG SXGBE driver. Changes since v1: - changed name of driver to SXGbE as per Ben's comment - squashed Joe's neatening for many stuff in original patches Changes since v2: - updated and split binding document as per Mark's comment - clean up codes as per

[PATCH V10 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-21 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V10 1/7] sxgbe: Add device-tree binding support document

2014-03-21 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 52

[PATCH V10 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-21 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h |

[PATCH V10 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-21 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com ---

[PATCH V10 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-21 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

Re: [PATCH V10 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-21 Thread Francois Romieu
Byungho An bh74...@samsung.com : [...] +static int sxgbe_hw_init(struct sxgbe_priv_data * const priv) +{ struct sxgbe_ops *hw = priv-hw; + u32 ctrl_ids; [...] +struct sxgbe_priv_data *sxgbe_dvr_probe(struct device *device, nit: s/dvr/drv/ ? (several occurences in the driver)

RE: [PATCH V10 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-21 Thread Byungho An
Francois Romieu rom...@fr.zoreil.com : Byungho An bh74...@samsung.com : [...] +static int sxgbe_hw_init(struct sxgbe_priv_data * const priv) { struct sxgbe_ops *hw = priv-hw; + u32 ctrl_ids; [...] +struct sxgbe_priv_data *sxgbe_dvr_probe(struct device *device, nit: