Re: [PATCH v3 0/4] ARM: dts: enable display for peach-pit and snow boards

2014-05-20 Thread Rahul Sharma
On 20 May 2014 10:41, Rahul Sharma rahul.sha...@samsung.com wrote: Thanks Kukjin, I have changed it in my environment now. Kukjin, dp_hpd_gpio got accidentally merged to pinctrl_3 in your for-next branch. It should be in pinctrl_0. /*/ }; dp_hpd_gpio:

Re: [PATCH v3 1/7] mfd: cros_ec: spi: calculate delay between transfers correctly

2014-05-20 Thread Lee Jones
From: David Hendricks dhend...@chromium.org To avoid spamming the EC we calculate the time between the previous transfer and the current transfer and force a delay if the time delta is too small. However, a small miscalculation causes the delay period to be far too short. Most noticably

Re: [PATCH v3 6/7] i2c: ChromeOS EC tunnel driver

2014-05-20 Thread Lee Jones
Code looks good, so Reviewed-by: Wolfram Sang w...@the-dreams.de I don't mind how it gets upstream. I can take it, but you can also keep it in this series. Let's keep the series together. Are you happy with me just merging it through MFD, or would you like a

Re: [PATCH v3 2/7] mfd: cros_ec: spi: Add mutex to cros_ec_spi

2014-05-20 Thread Lee Jones
On Wed, 30 Apr 2014, Doug Anderson wrote: The main transfer function for cros_ec_spi can be called by more than one client at a time. Make sure that those clients don't stomp on each other by locking the bus for the duration of the transfer function. Signed-off-by: Doug Anderson

Re: [PATCH v3 3/7] mfd: cros_ec: spi: Make the cros_ec_spi timeout more reliable

2014-05-20 Thread Lee Jones
On Wed, 30 Apr 2014, Doug Anderson wrote: The cros_ec_spi transfer had two problems with its timeout code: 1. It looked at the timeout even in the case that it found valid data. 2. If the cros_ec_spi code got switched out for a while, it's possible it could get a timeout after a single

Re: [PATCH v3 4/7] mfd: cros_ec: spi: Increase cros_ec_spi deadline from 5ms to 100ms

2014-05-20 Thread Lee Jones
On Wed, 30 Apr 2014, Doug Anderson wrote: We're adding i2c tunneling to the list of things that goes over cros_ec. i2c tunneling can be slooow, so increase our deadline to 100ms to account for that. Signed-off-by: Doug Anderson diand...@chromium.org Acked-by: Lee Jones

Re: [PATCH v3 5/7] mfd: cros_ec: Sync to the latest cros_ec_commands.h from EC sources

2014-05-20 Thread Lee Jones
On Wed, 30 Apr 2014, Doug Anderson wrote: From: Bill Richardson wfric...@chromium.org This just updates include/linux/mfd/cros_ec_commands.h to match the latest EC version (which is the One True Source for such things). See https://chromium.googlesource.com/chromiumos/platform/ec

Re: [PATCH v3 6/7] i2c: ChromeOS EC tunnel driver

2014-05-20 Thread Lee Jones
On Wed, 30 Apr 2014, Doug Anderson wrote: On ARM Chromebooks we have a few devices that are accessed by both the AP (the main Application Processor) and the EC (the Embedded Controller). These are: * The battery (sbs-battery). * The power management unit tps65090. On the original Samsung

Re: [PATCH v3 7/7] ARM: tegra: Add the EC i2c tunnel to tegra124-venice2

2014-05-20 Thread Lee Jones
This adds the EC i2c tunnel (and devices under it) to the tegra124-venice2 device tree. I'll happily take this into the Tegra tree once the patch containing the binding it uses is applied. All other patches applied. Take this when ready. -- Lee Jones Linaro STMicroelectronics Landing

Re: [PATCH] ASoC: samsung: Allow setting OP_CLK of the IIS Multi Audio Interface

2014-05-20 Thread Sylwester Nawrocki
On 20/05/14 07:14, Tushar Behera wrote: On 05/19/2014 11:00 PM, Sylwester Nawrocki wrote: This patch adds support for setting source clock of the Core CLK of the IIS Multi Audio Interface. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- sound/soc/samsung/i2s.c |4

Re: [PATCH 01/18] drm/exynos: dsi: move the EoT packets configuration point

2014-05-20 Thread Andrzej Hajda
On 05/14/2014 08:26 AM, YoungJun Cho wrote: This configuration could be used in MIPI DSI command mode also. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Reviewed-by: Andrzej Hajda

Re: [PATCH 02/18] drm/exynos: use wait_event_timeout() for safety usage

2014-05-20 Thread Andrzej Hajda
On 05/14/2014 08:26 AM, YoungJun Cho wrote: There could be the case that the page flip operation isn't finished correctly with some abnormal condition such as panel reset. So this patch replaces wait_event() with wait_event_timeout() to avoid waiting for page flip completion infinitely.

Re: [PATCH] ASoC: samsung: Allow setting OP_CLK of the IIS Multi Audio Interface

2014-05-20 Thread Tushar Behera
On 05/20/2014 02:40 PM, Sylwester Nawrocki wrote: On 20/05/14 07:14, Tushar Behera wrote: On 05/19/2014 11:00 PM, Sylwester Nawrocki wrote: This patch adds support for setting source clock of the Core CLK of the IIS Multi Audio Interface. Signed-off-by: Sylwester Nawrocki

Re: [PATCH 02/18] drm/exynos: use wait_event_timeout() for safety usage

2014-05-20 Thread Daniel Kurtz
On Wed, May 14, 2014 at 2:26 PM, YoungJun Cho yj44@samsung.com wrote: There could be the case that the page flip operation isn't finished correctly with some abnormal condition such as panel reset. So this patch replaces wait_event() with wait_event_timeout() to avoid waiting for page flip

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Arnd Bergmann
On Monday 19 May 2014 22:32:33 Thierry Reding wrote: On Mon, May 19, 2014 at 06:22:31PM +0100, Dave Martin wrote: On Mon, May 19, 2014 at 01:53:37PM +0100, Thierry Reding wrote: [...] My understanding here is mostly based on the OpenFirmware working group proposal for the dma-ranges

Re: [PATCH] ASoC: samsung: Allow setting OP_CLK of the IIS Multi Audio Interface

2014-05-20 Thread Mark Brown
On Tue, May 20, 2014 at 11:10:08AM +0200, Sylwester Nawrocki wrote: So how do you think this should be addressed ? Isn't it better to give options to the machine drivers to alter these clock settings, rather than hard coding it in the I2S driver ? Let's not forget it covers multiple Samsung

[PATCH 0/3] Support for multiple MFC FW sub-versions

2014-05-20 Thread Arun Kumar K
This patchset is for supporting multple firmware sub-versions for MFC. Newer firmwares come with changed interfaces and fixes without any change in the fw version number. So this implementation is as per Tomasz Figa's suggestion [1]. [1]

[PATCH 1/3] [media] s5p-mfc: Remove duplicate function s5p_mfc_reload_firmware

2014-05-20 Thread Arun Kumar K
The function s5p_mfc_reload_firmware is exactly same as s5p_mfc_load_firmware. So removing the duplicate function. Signed-off-by: Arun Kumar K arun...@samsung.com --- drivers/media/platform/s5p-mfc/s5p_mfc.c |2 +- drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 33

[PATCH 2/3] [media] s5p-mfc: Support multiple firmware sub-versions

2014-05-20 Thread Arun Kumar K
For MFC firmwares, improved versions with bug fixes and feature additions are released keeping the firmware version including major and minor number same. The issue came with the release of a new MFCv6 firmware with an interface change. This patch adds the support of accepting multiple firmware

[PATCH 3/3] [media] s5p-mfc: Add init buffer cmd to MFCV6

2014-05-20 Thread Arun Kumar K
Latest MFC v6 firmware requires tile mode and loop filter setting to be done as part of Init buffer command, in sync with v7. This patch adds this support for new v6 firmware. Signed-off-by: Arun Kumar K arun...@samsung.com Signed-off-by: Kiran AVND avnd.ki...@samsung.com ---

Re: [PATCH 14/18] drm/panel: add S6E3FA0 driver

2014-05-20 Thread Andrzej Hajda
On 05/14/2014 08:27 AM, YoungJun Cho wrote: This patch adds MIPI-DSI command mode based S6E3FA0 AMOLED LCD Panel driver. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com Few nitpicks, beside them.

[PATCH v3 2/2] ARM: dts: fixed gpio key node for exynos4412

2014-05-20 Thread Beomho Seo
This patch fixed gpio key device node. First, fix incorrect gpio property. And then, add ok-key node where locate bottom center. I have tested on exynos4412-trats2 board. Signed-off-by: Beomho Seo beomho@samsung.com Signed-off-by: MyungJoo Ham myungjoo@samsung.com --- Changes in v3: -

[PATCH v3 1/2] ARM: dts: add cm36651 light/proximity sensor node

2014-05-20 Thread Beomho Seo
Exynos4412-trats2 board have light/proximity sensor. This patch add cm36651 light/ proximity sensor node for exynos4412. cm36651 is required properties as below. - Use i2c-gpio for cm36651 sensor. - Use fixed regulator for the IR LED. It is a part of the cm36651 for proximity detection. -

[PATCH v3 0/2] ARM: dts: add device data for exynos4412-trats2

2014-05-20 Thread Beomho Seo
This patchset add some device node for exynos4412-trats2. It is based on v3.15-next/dt-samsung-2 branch. exynos4412-trats2.dts - Fix incorrect compatible. Compatible of AK8975 are ak8975 or asahi-kasei,ak8975. - Add cm36651 light/proximity sensor device node. - Change gpio-key device node. fix

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Thierry Reding
On Tue, May 20, 2014 at 12:04:54PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 22:59:46 Thierry Reding wrote: On Mon, May 19, 2014 at 08:34:07PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 14:53:37 Thierry Reding wrote: On Mon, May 19, 2014 at 12:26:35PM +0200, Arnd Bergmann

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 13:05:37 Thierry Reding wrote: On Tue, May 20, 2014 at 12:04:54PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 22:59:46 Thierry Reding wrote: On Mon, May 19, 2014 at 08:34:07PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 14:53:37 Thierry Reding wrote:

Re: [PATCH] ASoC: samsung: Add 'mclk' handling for Snow sound-card driver

2014-05-20 Thread Mark Brown
On Tue, May 20, 2014 at 09:55:42AM +0530, Tushar Behera wrote: For audio to work on Snow board, we need the codec master clock 'mclk' to be properly configured. Currently XCLKOUT is configured as 'mclk' for codec chip and it is required to be clocked at 24MHz for the codec to work properly.

Re: [PATCH 2/3] [media] s5p-mfc: Support multiple firmware sub-versions

2014-05-20 Thread Sachin Kamat
Hi Arun, On 20 May 2014 15:47, Arun Kumar K arun...@samsung.com wrote: For MFC firmwares, improved versions with bug fixes and feature additions are released keeping the firmware version including major and minor number same. The issue came with the release of a new MFCv6 firmware with an

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Thierry Reding
On Tue, May 20, 2014 at 01:15:48PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 13:05:37 Thierry Reding wrote: On Tue, May 20, 2014 at 12:04:54PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 22:59:46 Thierry Reding wrote: On Mon, May 19, 2014 at 08:34:07PM +0200, Arnd Bergmann

[PATCH] drivers: phy: exynos4x12-phy: fix HSIC1 power on/off sequence

2014-05-20 Thread Marek Szyprowski
From experiments with real hardware, it seems that URSTCON bits for HSIC0 and HSIC1 seems to be swapped, so updated macro definitions for them. HSIC1 also requires enabling power to device phy to get properly enabled (similar hack is already implemented for HSIC0). Signed-off-by: Marek Szyprowski

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: On Tue, May 20, 2014 at 01:15:48PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 13:05:37 Thierry Reding wrote: On Tue, May 20, 2014 at 12:04:54PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 22:59:46 Thierry Reding wrote:

[PATCH 0/4] Add more supported blocks to UniversalC210 and Trats

2014-05-20 Thread Marek Szyprowski
Hello, This is a small update for Exynos4210 based UniversalC210 and Trats boards. Full USB support requires merging '[PATCHv5 0/4] Enable usbphy and hsotg for exynos4' series recently posted by Chanho Park. Best regards Marek Szyprowski Samsung RD Institute Poland Marek Szyprowski (3): ARM:

[PATCH 4/4] ARM: dts: exynos4210-universal_c210: add external sd card node

2014-05-20 Thread Marek Szyprowski
This patch enables support external SD card slot. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- arch/arm/boot/dts/exynos4210-universal_c210.dts | 10 ++ 1 file changed, 10 insertions(+) diff --git a/arch/arm/boot/dts/exynos4210-universal_c210.dts

[PATCH 1/4] ARM: dts: exynos4210-trats: Enable USB gadget functionality

2014-05-20 Thread Marek Szyprowski
From: Tomasz Figa t.f...@samsung.com This patch adds device tree nodes necessary to enable USB gadget functionality on Exynos4210-based Trats board. Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- arch/arm/boot/dts/exynos4210-trats.dts

[PATCH 3/4] ARM: dts: exynos4210-universal_c210: add multimedia nodes

2014-05-20 Thread Marek Szyprowski
This patch enables support for multimedia blocks - fimc in mem2mem mode, no camera sensors support yet. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- arch/arm/boot/dts/exynos4210-universal_c210.dts | 23 +++ 1 file changed, 23 insertions(+) diff --git

[PATCH 2/4] ARM: dts: exynos4210-universal_c210: enable USB functionality

2014-05-20 Thread Marek Szyprowski
This patch adds device tree nodes necessary to enable USB support on universalc210 board, this includes UDC controller (USB gadget) as well as EHCI and OHCI host ports. LDO3 and LDO8 regulators are switched to always on mode until EHCI and OHCI drivers will support them correctly. Signed-off-by:

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Dave Martin
On Tue, May 20, 2014 at 12:08:44PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 22:32:33 Thierry Reding wrote: On Mon, May 19, 2014 at 06:22:31PM +0100, Dave Martin wrote: On Mon, May 19, 2014 at 01:53:37PM +0100, Thierry Reding wrote: [...] My understanding here is mostly based

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Thierry Reding
On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: [...] Couldn't a single-master IOMMU be windowed? Ah, yes. That would actually be like an IBM pSeries, which has a windowed IOMMU but uses one window per virtual machine. In

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 14:07:09 Dave Martin wrote: On Tue, May 20, 2014 at 12:08:44PM +0200, Arnd Bergmann wrote: On Monday 19 May 2014 22:32:33 Thierry Reding wrote: On Mon, May 19, 2014 at 06:22:31PM +0100, Dave Martin wrote: On Mon, May 19, 2014 at 01:53:37PM +0100, Thierry Reding

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 15:17:43 Thierry Reding wrote: On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: [...] Couldn't a single-master IOMMU be windowed? Ah, yes. That would actually be like an IBM pSeries, which has a

[PATCH 0/2] ARM: dts: add pmu syscon handle to exynos hdmi nodes

2014-05-20 Thread Rahul Sharma
Add PMU syscon handle to HDMI dt node for controlling PHY Enable/Disable bit. Patch is dependent for following patch for approval on DT Bindings: http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg31106.html It is based on Kukjin's for-next branch. Rahul Sharma (2): ARM: dts:

[PATCH 2/2] ARM: dts: add pmu syscon handle to exynos5420 hdmi

2014-05-20 Thread Rahul Sharma
Add PMU syscon handle to HDMI dt node for controlling PHY Enable/Disable bit. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi

[PATCH 1/2] ARM: dts: add pmu syscon handle to exynos5250 hdmi

2014-05-20 Thread Rahul Sharma
Add PMU syscon handle to HDMI dt node for controlling PHY Enable/Disable bit. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi |1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Thierry Reding
On Tue, May 20, 2014 at 03:34:46PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 15:17:43 Thierry Reding wrote: On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: [...] Couldn't a single-master IOMMU be windowed?

[PATCH] clk: exynos4: Register custom fixed rate clocks conditionally

2014-05-20 Thread Sylwester Nawrocki
Use the Exynos custom fixed rate clocks registration (for oscillators connected to the XXTI or XUSBXTI pins) only if fixed-rate-clocks node is found in device tree. This allows to handle new dtbs with those clocks described in a generic way and having the fixed-rate-clocks node removed.

[PATCH] ARM: dts: exynos4: Remove custom fixed rate clock nodes

2014-05-20 Thread Sylwester Nawrocki
This patch specifies the XXTI and XUSBXTI clock sources as standard fixed rate clocks and removes the related Exynos custom clock nodes. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 14 +-

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Dave Martin
On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: On Tue, May 20, 2014 at 01:15:48PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 13:05:37 Thierry Reding wrote: On Tue, May 20, 2014 at 12:04:54PM +0200, Arnd

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Will Deacon
On Tue, May 20, 2014 at 02:23:47PM +0100, Arnd Bergmann wrote: Bit# 3322 1100 10987654 32109876 54321098 76543210 phys.hi cell: npt000ss dfff phys.mid cell: phys.lo cell:

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Dave Martin
On Tue, May 20, 2014 at 04:26:59PM +0100, Will Deacon wrote: On Tue, May 20, 2014 at 02:23:47PM +0100, Arnd Bergmann wrote: Bit# 3322 1100 10987654 32109876 54321098 76543210 phys.hi cell: npt000ss dfff phys.mid cell:

[PATCH 3/4] clk: samsung: Add driver to control CLKOUT line on Exynos SoCs

2014-05-20 Thread Tomasz Figa
This patch introduces a driver that handles configuration of CLKOUT pin of Exynos SoCs that can be used to output certain clocks from inside of the SoC to a dedicated output pin. Signed-off-by: Tomasz Figa t.f...@samsung.com --- .../devicetree/bindings/arm/samsung/pmu.txt| 30

[PATCH 4/4] ARM: dts: exynos: Update PMU node with CLKOUT related data

2014-05-20 Thread Tomasz Figa
This patch extends nodes of PMU system controller on Exynos4210, 4x12, 5250 and 5420 SoCs with newly defined properties used by Exynos CLKOUT driver. Signed-off-by: Tomasz Figa t.f...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi| 1 + arch/arm/boot/dts/exynos4210.dtsi | 9 +

[PATCH 1/4] clk: samsung: exynos4: Add missing CPU/DMC clock hierarchy

2014-05-20 Thread Tomasz Figa
This patch adds missing definitions of clocks from CPU and DMC clock domains, which are necessary to properly represent CLKOUT clock hierarchy added in further patch. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/clk/samsung/clk-exynos4.c | 50 +++

[PATCH 0/4] Add support for Exynos clock output configuration

2014-05-20 Thread Tomasz Figa
On all Exynos SoCs there is a dedicated CLKOUT pin that allows many of internal SoC clocks to be output from the SoC. The hardware structure of CLKOUT related clocks looks as follows: CMU |--- clock0 - | PMU | | | |

[PATCH 2/4] clk: samsung: exynos4: Add CLKOUT clock hierarchy

2014-05-20 Thread Tomasz Figa
This patch adds definitions of clocks that are used to drive clock output signals of particular CMU sub-blocks that are then fed to PMU and handled by Exynos CLKOUT driver added in further patch. Signed-off-by: Tomasz Figa t.f...@samsung.com --- drivers/clk/samsung/clk-exynos4.c | 123

[RESEND PATCH v3] charger: tps65090: Allow charger module to be used when no irq

2014-05-20 Thread Doug Anderson
On the ARM Chromebook tps65090 has two masters: the AP (the main processor running linux) and the EC (the embedded controller). The AP is allowed to mess with FETs but the EC is in charge of charge control. The tps65090 interupt line is routed to both the AP and the EC, which can cause quite a

Re: [PATCH 0/3] Support for multiple MFC FW sub-versions

2014-05-20 Thread Tomasz Figa
Hi Arun, On 20.05.2014 12:17, Arun Kumar K wrote: This patchset is for supporting multple firmware sub-versions for MFC. Newer firmwares come with changed interfaces and fixes without any change in the fw version number. So this implementation is as per Tomasz Figa's suggestion [1]. [1]

Re: [PATCH] Fix for possible null pointer dereference in dma.c

2014-05-20 Thread Rickard Strandqvist
Hi Tomasz What I based my patch on is really because of this line: if (substream) snd_pcm_period_elapsed(substream); Boojin Kim thought that this was needed, if this is true anymore..? I have not been able to immerse myself so much in all patches. I'm working on about 100 similar

Re: [alsa-devel] [PATCH] Fix for possible null pointer dereference in dma.c

2014-05-20 Thread Tomasz Figa
On 20.05.2014 21:29, Andrew Eikum wrote: On Tue, May 20, 2014 at 09:16:59PM +0200, Tomasz Figa wrote: To me having NULL as either data argument of buffer done callback or private_data would be a serious driver bug and IMHO it's better to let it crash with a NULL pointer dereference to let

Re: [alsa-devel] [PATCH] Fix for possible null pointer dereference in dma.c

2014-05-20 Thread Andrew Eikum
On Tue, May 20, 2014 at 09:16:59PM +0200, Tomasz Figa wrote: To me having NULL as either data argument of buffer done callback or private_data would be a serious driver bug and IMHO it's better to let it crash with a NULL pointer dereference to let someone notice than mask it by adding a

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 16:24:59 Dave Martin wrote: On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote: On Tue, May 20, 2014 at 01:15:48PM +0200, Arnd Bergmann wrote: Typical values for the above include: - #address-cells

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 16:00:02 Thierry Reding wrote: On Tue, May 20, 2014 at 03:34:46PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 15:17:43 Thierry Reding wrote: On Tue, May 20, 2014 at 02:41:18PM +0200, Arnd Bergmann wrote: On Tuesday 20 May 2014 14:02:43 Thierry Reding wrote:

Re: [PATCH] devicetree: Add generic IOMMU device tree bindings

2014-05-20 Thread Arnd Bergmann
On Tuesday 20 May 2014 17:39:12 Dave Martin wrote: On Tue, May 20, 2014 at 04:26:59PM +0100, Will Deacon wrote: On Tue, May 20, 2014 at 02:23:47PM +0100, Arnd Bergmann wrote: Bit# 3322 1100 10987654 32109876 54321098 76543210 phys.hi cell:

Re: [alsa-devel] [PATCH] Fix for possible null pointer dereference in dma.c

2014-05-20 Thread Lars-Peter Clausen
On 05/20/2014 09:16 PM, Tomasz Figa wrote: Hi Rickard, On 20.05.2014 21:12, Rickard Strandqvist wrote: Hi Tomasz What I based my patch on is really because of this line: if (substream) snd_pcm_period_elapsed(substream); Boojin Kim thought that this was needed, if this is true

Re: [PATCH] clk: exynos5250: Add missing sysmmu clocks for DISP and ISP blocks

2014-05-20 Thread Tomasz Figa
Hi Shaik, On 20.05.2014 06:08, Shaik Ameer Basha wrote: Hi Tomasz, Any comments on this patch ? Looks good. Kukjin, if you still can pick this up to your tree for 3.16, since all the dependencies are already there, then Acked-by: Tomasz Figa t.f...@samsung.com If not, I will pick it up to

Re: [alsa-devel] [PATCH] Fix for possible null pointer dereference in dma.c

2014-05-20 Thread Mark Brown
On Tue, May 20, 2014 at 11:21:08PM +0200, Lars-Peter Clausen wrote: On 05/20/2014 09:16 PM, Tomasz Figa wrote: Still, I'm not too experienced with ALSA and ASoC, so I might be wrong. Mark, what do you think about this? Given that there is a patch[1] which removes the whole file I think we

Re: [PATCH] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-20 Thread Doug Anderson
Seungwon, On Mon, May 19, 2014 at 6:51 PM, Seungwon Jeon tgih@samsung.com wrote: + } else { + /* +* If we don't have a command complete now we'll +* never

[PATCH v2] mmc: dw_mmc: Make sure we don't get stuck when we get an error

2014-05-20 Thread Doug Anderson
If we happened to get a data error at just the wrong time the dw_mmc driver could get into a state where it would never complete its request. That would leave the caller just hanging there. We fix this two ways and both of the two fixes on their own appear to fix the problems we've seen: 1. Fix

Re: [PATCH] ASoC: samsung: Allow setting OP_CLK of the IIS Multi Audio Interface

2014-05-20 Thread Mark Brown
On Mon, May 19, 2014 at 07:30:38PM +0200, Sylwester Nawrocki wrote: This patch adds support for setting source clock of the Core CLK of the IIS Multi Audio Interface. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH v3 0/2] ARM: dts: add device data for exynos4412-trats2

2014-05-20 Thread Tomasz Figa
On 20.05.2014 12:48, Beomho Seo wrote: This patchset add some device node for exynos4412-trats2. It is based on v3.15-next/dt-samsung-2 branch. exynos4412-trats2.dts - Fix incorrect compatible. Compatible of AK8975 are ak8975 or asahi-kasei,ak8975. - Add cm36651 light/proximity sensor

Re: [PATCH 2/4] ARM: dts: exynos4210-universal_c210: enable USB functionality

2014-05-20 Thread Tomasz Figa
Hi Marek, On 20.05.2014 14:46, Marek Szyprowski wrote: This patch adds device tree nodes necessary to enable USB support on universalc210 board, this includes UDC controller (USB gadget) as well as EHCI and OHCI host ports. LDO3 and LDO8 regulators are switched to always on mode until EHCI

Re: [PATCH 0/4] Add more supported blocks to UniversalC210 and Trats

2014-05-20 Thread Tomasz Figa
On 20.05.2014 14:46, Marek Szyprowski wrote: Hello, This is a small update for Exynos4210 based UniversalC210 and Trats boards. Full USB support requires merging '[PATCHv5 0/4] Enable usbphy and hsotg for exynos4' series recently posted by Chanho Park. Best regards Marek Szyprowski

Re: [PATCH 02/18] drm/exynos: use wait_event_timeout() for safety usage

2014-05-20 Thread YoungJun Cho
Hi Daniel Thank you for comments. On 05/20/2014 07:02 PM, Daniel Kurtz wrote: On Wed, May 14, 2014 at 2:26 PM, YoungJun Cho yj44@samsung.com wrote: There could be the case that the page flip operation isn't finished correctly with some abnormal condition such as panel reset. So this

[PATCH 0/4] ASoC: samsung: Add devres APIs

2014-05-20 Thread Tushar Behera
Adding devres APIs to various files in sound/soc/samsung saves us close to 150 lines of code. The patches are based on next-20140519 and have been build tested. Tushar Behera (4): ASoC: samsung: Use devm_snd_soc_register_card ASoC: samsung: Use devm_snd_soc_register_platform ASoC: samsung:

[PATCH 2/4] ASoC: samsung: Use devm_snd_soc_register_platform

2014-05-20 Thread Tushar Behera
Replaced snd_soc_register_platform with devm_snd_soc_register_platform in samsung_asoc_dma_platform_register(). This makes the function samsung_asoc_dma_platform_unregister() redundant. This is removed and all its users are updated. Signed-off-by: Tushar Behera tushar.beh...@linaro.org ---

[PATCH 4/4] ASoC: samsung: Add devm_clk_get to pcm.c

2014-05-20 Thread Tushar Behera
clk_get in probe function can be safely replaced with devm_clk_get. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/samsung/pcm.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/sound/soc/samsung/pcm.c b/sound/soc/samsung/pcm.c index

[PATCH 1/4] ASoC: samsung: Use devm_snd_soc_register_card

2014-05-20 Thread Tushar Behera
Replace snd_soc_register_card with devm_snd_soc_register_card. With this change, we can delete the empty remove functions. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/samsung/bells.c | 16 +++- sound/soc/samsung/littlemill.c | 18

[PATCH 3/4] ASoC: samsung: Use devm_snd_soc_register_component

2014-05-20 Thread Tushar Behera
Replaced snd_soc_register_component with its devres equivalent, devm_snd_soc_register_component. Signed-off-by: Tushar Behera tushar.beh...@linaro.org --- sound/soc/samsung/ac97.c|8 ++-- sound/soc/samsung/goni_wm8994.c |9 +++-- sound/soc/samsung/pcm.c |8

[PATCH v2 11/18] ARM: dts: exynos_dsim: add exynos5420 compatible to DT bindings

2014-05-20 Thread YoungJun Cho
This patch adds relevant to exynos5420 compatible for exynos5420 SoC support. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/video/exynos_dsim.txt |4 +++- 1 file

[PATCH v2 03/18] ARM: dts: video: add command mode display timing DT bindings

2014-05-20 Thread YoungJun Cho
This patch adds DT bindings for command mode display timing. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- .../bindings/video/cmdmode-display-timing.txt | 64 1 file

[PATCH v2 01/18] drm/exynos: dsi: move the EoT packets configuration point

2014-05-20 Thread YoungJun Cho
This configuration could be used in MIPI DSI command mode also. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/exynos/exynos_drm_dsi.c |5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v2 12/18] drm/exynos: dsi: add driver data to support Exynos5420

2014-05-20 Thread YoungJun Cho
The offset of register DSIM_PLLTMR_REG in Exynos5420 is different from the one in Exynos4 SoC. In case of Exynos5420 SoC, there is no frequency band bit in DSIM_PLLCTRL_REG, and it uses DSIM_PHYCTRL_REG and DSIM_PHYTIMING*_REG instead. So this patch adds driver data to distinguish it.

[PATCH v2 18/18] ARM: dts: exynos5420: add dsi node

2014-05-20 Thread YoungJun Cho
This patch adds common part of dsi node. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH v2 15/18] ARM: dts: exynos4: add system register node

2014-05-20 Thread YoungJun Cho
This patch adds sysreg property to fimd device node which is required to use I80 interface. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi |1 + 1 file changed, 1

[PATCH v2 14/18] drm/panel: add S6E3FA0 driver

2014-05-20 Thread YoungJun Cho
This patch adds MIPI-DSI command mode based S6E3FA0 AMOLED LCD Panel driver. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/panel/Kconfig |7 +

[PATCH v2 10/18] drm/exynos: fimd: support I80 interface

2014-05-20 Thread YoungJun Cho
To support MIPI DSI command mode interface, FIMD should do followings: - Sets LCD block configuration for I80 interface. - Uses lcd_sys as an IRQ resource and sets relevant IRQ configuration. - Implements trigger feature which transfers image date if there is page flip request, and implements TE

[PATCH v2 00/18] drm/exynos: support MIPI DSI command mode display

2014-05-20 Thread YoungJun Cho
Hi, This series is for the Exynos DRM driver to support MIPI DSI command mode display and based on exynos-drm-next branch. The previous patches, RFC: http://www.spinics.net/lists/dri-devel/msg58898.html V1: http://www.spinics.net/lists/dri-devel/msg59291.html Changelog v2: - Rebases for latest

[PATCH v2 04/18] video: add command mode and command mode display timing

2014-05-20 Thread YoungJun Cho
This patch is based on videomode and display_timing relevant codes. To support command mode panel, it does not need to guide its timing information to the display controller like video mode panel, but it requires signal timings to transfer video data. So this patch adds cmdmode struct,

[PATCH v2 16/18] ARM: dts: exynos5: add system register support

2014-05-20 Thread YoungJun Cho
This patch adds sysreg device node, and sysreg property to fimd device node which is required to use I80 interface. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos5.dtsi |6

[PATCH v2 05/18] drm_modes: add command mode helpers

2014-05-20 Thread YoungJun Cho
This patch adds helper functions to convert cmdmode to drm_display_mode Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/gpu/drm/drm_modes.c | 59 +++

[PATCH v2 17/18] ARM: dts: exynos5420: add mipi-phy node

2014-05-20 Thread YoungJun Cho
This patch adds mipi-phy node for MIPI-DSI device. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos5420.dtsi |6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH v2 13/18] ARM: dts: s6e3fa0: add DT bindings

2014-05-20 Thread YoungJun Cho
This patch adds DT bindings for s6e3fa0 panel. The bindings describes panel resources, display timings and cpu mode timings. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v2 09/18] drm/exynos: dsi: add TE handler to support command mode interface

2014-05-20 Thread YoungJun Cho
To support command mode interface, the DSI host calls this handler to notify the panel tearing effect synchronization signal to the CRTC device manager to trigger to transfer video image. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin

[PATCH v2 07/18] ARM: dts: samsung-fimd: add I80 specific properties

2014-05-20 Thread YoungJun Cho
In case of using MIPI command mode interface panel, the relevant registers should be set. So this patch adds relevant DT bindings. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v2 06/18] ARM: dts: sysreg: add exynos5 compatible to DT bindings

2014-05-20 Thread YoungJun Cho
This patch adds relevant to exynos5 compatible for exynos5 SoCs. Signed-off-by: YoungJun Cho yj44@samsung.com Acked-by: Inki Dae inki@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/arm/samsung/sysreg.txt |1 + 1 file changed, 1

[PATCH v2 08/18] drm/exynos: add TE handler to support MIPI DSI command mode interface

2014-05-20 Thread YoungJun Cho
To support MIPI DSI command mode interface, the panel should generates Tearing Effect synchronization signal between MCU and FB to display video images. And the display controller should trigger to transfer video image at this signal. So the panel receives the TE IRQ, then calls this handler

[PATCH v2 02/18] drm/exynos: use wait_event_timeout() for safety usage

2014-05-20 Thread YoungJun Cho
There could be the case that the page flip operation isn't finished correctly with some abnormal condition such as panel reset. So this patch replaces wait_event() with wait_event_timeout() to avoid waiting for page flip completion infinitely. And clears exynos_crtc-pending_flip in

Re: [PATCH] ASoC: samsung: Add 'mclk' handling for Snow sound-card driver

2014-05-20 Thread Tushar Behera
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/20/2014 04:46 PM, Mark Brown wrote: On Tue, May 20, 2014 at 09:55:42AM +0530, Tushar Behera wrote: For audio to work on Snow board, we need the codec master clock 'mclk' to be properly configured. Currently XCLKOUT is configured as 'mclk'