RE: [GIT PULL 2/2] Samsung defconfig updates for v3.18

2014-10-16 Thread Kukjin Kim
Javier Martinez Canillas wrote: Hello Kukjin, Hi, On Thu, Oct 16, 2014 at 3:01 AM, Kukjin Kim kg...@kernel.org wrote: Sjoerd Simons wrote: On Tue, 2014-10-14 at 23:32 -0700, Olof Johansson wrote: On Tue, Oct 14, 2014 at 4:27 PM, Kukjin Kim kgene@samsung.com wrote:

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-16 Thread Ajay kumar
ping! On Fri, Oct 10, 2014 at 6:33 PM, Ajay kumar ajayn...@gmail.com wrote: On Wed, Oct 8, 2014 at 12:39 PM, Thierry Reding thierry.red...@gmail.com wrote: On Tue, Oct 07, 2014 at 05:49:24PM +0300, Laurent Pinchart wrote: Hi Ajay, On Tuesday 07 October 2014 16:06:55 Ajay kumar wrote: On

Re: [PATCH 2/9] regulator: max77802: Add .{get,set}_mode callbacks

2014-10-16 Thread Mark Brown
On Wed, Oct 15, 2014 at 06:20:32PM +0200, Javier Martinez Canillas wrote: +#define MAX77802_MODE(pval) ((pval == MAX77802_OPMODE_NORMAL) ? \ + REGULATOR_MODE_NORMAL : REGULATOR_MODE_STANDBY) + Make this a static inline function if there's any need for it, this is

Re: [PATCH 1/9] regulator: max77802: Add .set_suspend_{enable,disable} callbacks

2014-10-16 Thread Mark Brown
On Wed, Oct 15, 2014 at 06:20:31PM +0200, Javier Martinez Canillas wrote: The max77802 PMIC has an enable pin (PWRREQ) that can be used to switch regulators ON and OFF automatically by the Application Processor when the system is leaving and entering sleep mode. Applied, thanks.

Re: [PATCH 3/9] regulator: max77802: Split regulator operations for BUCKs

2014-10-16 Thread Mark Brown
On Wed, Oct 15, 2014 at 06:20:33PM +0200, Javier Martinez Canillas wrote: Not all the max77802 BUCKs regulators have the same functionality, for example BUCKs 2-4 support the output to be configured as normal or Low Power Mode by the PWRREQ enable pin while the other BUCKs only support their

Re: [PATCH V7 11/12] Documentation: bridge: Add documentation for ps8622 DT properties

2014-10-16 Thread Laurent Pinchart
Hi Ajay, On Friday 10 October 2014 18:33:05 Ajay kumar wrote: On Wed, Oct 8, 2014 at 12:39 PM, Thierry Reding wrote: On Tue, Oct 07, 2014 at 05:49:24PM +0300, Laurent Pinchart wrote: On Tuesday 07 October 2014 16:06:55 Ajay kumar wrote: On Tue, Oct 7, 2014 at 4:00 PM, Tomi Valkeinen

[PATCH v2 1/2] Revert mfd: sec-core: Prepare regulators for suspend state to reduce power-consumption

2014-10-16 Thread Javier Martinez Canillas
This reverts commit b7cde7078d2344073c310aa65fc2b0a845d2cb5b (mfd: sec-core: Prepare regulators for suspend state to reduce power-consumption) Commit b7cde7078d23 called regulator_suspend_prepare() to prepare the regulators for a suspend state. But did it from the device pm suspend handler but

[PATCH v2 0/2] ARM: EXYNOS: Call regulator suspend prepare/finish

2014-10-16 Thread Javier Martinez Canillas
Hello, This series add support for Exynos platforms to prepare regulators for system suspend. The regulator core has a set of helpers functions to be used when the system is entering and leaving from a suspend state but currently there is only one user in mainline. This user is

[PATCH v2 2/2] ARM: EXYNOS: Call regulator core suspend prepare and finish functions

2014-10-16 Thread Javier Martinez Canillas
The regulator framework has a set of helpers functions to be used when the system is entering and leaving from suspend but these are not called on Exynos platforms. This means that the .set_suspend_* function handlers defined by regulator drivers are not called when the system is suspended.

Re: [PATCH 2/9] regulator: max77802: Add .{get,set}_mode callbacks

2014-10-16 Thread Javier Martinez Canillas
Hello Mark, Thanks a lot for your feedback. On 10/16/2014 10:36 AM, Mark Brown wrote: On Wed, Oct 15, 2014 at 06:20:32PM +0200, Javier Martinez Canillas wrote: +#define MAX77802_MODE(pval) ((pval == MAX77802_OPMODE_NORMAL) ? \ + REGULATOR_MODE_NORMAL :

[PATCH 8/9] usb: dwc2/gadget: fix calls to phy control functions in suspend/resume code

2014-10-16 Thread Marek Szyprowski
This patch moves calls to phy enable/disable out of spinlock protected blocks in device suspend/resume to fix incorrect caller context. Phy related functions must not be called from atomic context. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/usb/dwc2/gadget.c | 9

[PATCH 7/9] usb: dwc2/gadget: use soft disconnect mode for implementing pullup control

2014-10-16 Thread Marek Szyprowski
This patch moves PHY enable and disable calls from pullup method to udc_start/stop functions and adds calls to recently introduces soft disconnect mode in pullup method. This improves dwc2 gadget driver compatibility with gadget API requirements (now pullup method really forces soft disconnect

[PATCH 1/9] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-10-16 Thread Marek Szyprowski
This patch adds a call to s3c_hsotg_disconnect() from 'end session' interrupt to correctly notify gadget subsystem about unplugged usb cable. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/usb/dwc2/gadget.c | 6 ++ 1 file changed, 6 insertions(+) diff --git

[PATCH 6/9] usb: dwc2/gadget: decouple setting soft disconnect from s3c_hsotg_core_init

2014-10-16 Thread Marek Szyprowski
This patch changes s3c_hsotg_core_init function to leave hardware in soft disconnect mode, so the actual moment of coupling the hardware to the usb bus can be later controlled by the driver in the more accurate way. For this purpose, separate functions for enabling and disabling soft disconnect

[PATCH 4/9] usb: dwc2/gadget: disable phy before turning off power regulators

2014-10-16 Thread Marek Szyprowski
This patch fixes probe function to match the pattern used elsewhere in the driver, where power regulators are turned off as the last element in the device shutdown procedure. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/usb/dwc2/gadget.c | 3 +-- 1 file changed, 1

[PATCH 2/9] usb: dwc2/gadget: fix enumeration issues

2014-10-16 Thread Marek Szyprowski
Excessive debug messages might cause timing issues that prevent correct usb enumeration. This patch hides information about USB bus reset to let driver enumerate fast enough to avoid making host angry. This fixes endless enumeration and usb reset loop observed with some Linux hosts.

[PATCH 5/9] usb: dwc2/gadget: move setting last reset time to s3c_hsotg_core_init

2014-10-16 Thread Marek Szyprowski
This patch removes duplicated code and sets last_rst variable in the function which does the hardware reset. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com --- drivers/usb/dwc2/gadget.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/usb/dwc2/gadget.c

[PATCH 9/9] usb: dwc2/gadget: rework suspend/resume code to correctly restore gadget state

2014-10-16 Thread Marek Szyprowski
Suspend/resume code assumed that the gadget was always enabled and connected to usb bus. This means that the actual state of the gadget (soft-enabled/disabled or connected/disconnected) was not correctly preserved on suspend/resume cycle. This patch fixes this issue. Signed-off-by: Marek

[PATCH 3/9] usb: dwc2/gadget: fix support for soft_connect udc framework feature

2014-10-16 Thread Marek Szyprowski
Enabling and disabling usb gadget by writing to /sys/class/udc/*hsotg/soft_connect results in calling udc_start/udc_stop functions with the same usb gadget driver, so the driver should not WARN about such case. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com ---

Re: [PATCH 1/9] usb: dwc2/gadget: report disconnect event from 'end session' irq

2014-10-16 Thread Felipe Balbi
On Thu, Oct 16, 2014 at 02:57:57PM +0200, Marek Szyprowski wrote: This patch adds a call to s3c_hsotg_disconnect() from 'end session' interrupt to correctly notify gadget subsystem about unplugged usb cable. Signed-off-by: Marek Szyprowski m.szyprow...@samsung.com ---

Re: [PATCH 3/9] usb: dwc2/gadget: fix support for soft_connect udc framework feature

2014-10-16 Thread Felipe Balbi
Hi, On Thu, Oct 16, 2014 at 02:57:59PM +0200, Marek Szyprowski wrote: Enabling and disabling usb gadget by writing to /sys/class/udc/*hsotg/soft_connect results in calling udc_start/udc_stop functions with the same usb gadget driver, so the driver should not WARN about such case.

Re: [PATCH 6/9] usb: dwc2/gadget: decouple setting soft disconnect from s3c_hsotg_core_init

2014-10-16 Thread Felipe Balbi
On Thu, Oct 16, 2014 at 02:58:02PM +0200, Marek Szyprowski wrote: This patch changes s3c_hsotg_core_init function to leave hardware in soft disconnect mode, so the actual moment of coupling the hardware to the usb bus can be later controlled by the driver in the more accurate what is this more

Re: [PATCH 7/9] usb: dwc2/gadget: use soft disconnect mode for implementing pullup control

2014-10-16 Thread Felipe Balbi
Hi, your subject line is wrong. -pullup() is already implemented, you're moving unnecessary code from -pullup() to other places. On Thu, Oct 16, 2014 at 02:58:03PM +0200, Marek Szyprowski wrote: This patch moves PHY enable and disable calls from pullup method to udc_start/stop functions and

Re: [PATCH 2/9] usb: dwc2/gadget: fix enumeration issues

2014-10-16 Thread Felipe Balbi
On Thu, Oct 16, 2014 at 02:57:58PM +0200, Marek Szyprowski wrote: Excessive debug messages might cause timing issues that prevent correct usb enumeration. This patch hides information about USB bus reset to let driver enumerate fast enough to avoid making host angry. This fixes endless

Re: [PATCH 8/9] usb: dwc2/gadget: fix calls to phy control functions in suspend/resume code

2014-10-16 Thread Felipe Balbi
Hi, On Thu, Oct 16, 2014 at 02:58:04PM +0200, Marek Szyprowski wrote: This patch moves calls to phy enable/disable out of spinlock protected blocks in device suspend/resume to fix incorrect caller context. Phy related functions must not be called from atomic context. Signed-off-by: Marek

[PATCH v2 0/7] Add max77802 regulator operating mode support

2014-10-16 Thread Javier Martinez Canillas
Hello Mark, This is the second version of the series that adds operating modes support for the regulators in the max77802 PMIC. It address issues pointed out in regulator: max77802: Add .{get,set}_mode callbacks and also removes the patches you already picked on the topic branch. The first

[PATCH v2 6/7] regulator: max77802: Parse regulator operating mode properties

2014-10-16 Thread Javier Martinez Canillas
The max77802 PMIC regulators output can be configured in one of two modes: Output ON (normal) and Output ON in Low Power Mode. Some of the regulators support their operating mode to be changed on startup or by consumers when the system is running while others only support their operating mode to

[PATCH v2 7/7] ARM: dts: Configure regulators for suspend on exynos Peach boards

2014-10-16 Thread Javier Martinez Canillas
The regulator core now has support to choose if a regulator has to be enabled or disabled during system suspend and also the max77802 driver supports changing the regulator operating mode during runtime and when the system enters into sleep mode. To lower power during suspend, configure the

[PATCH v2 4/7] regulator: max77802: Add header for operating modes

2014-10-16 Thread Javier Martinez Canillas
Add a header file for the max77802 constants that could be shared between the regulator driver and Device Tree source files. Also, remove standby and off opmodes since only normal and low power are valid operating modes. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk ---

[PATCH v2 5/7] regulator: max77802: Document regulator opmode DT properties

2014-10-16 Thread Javier Martinez Canillas
Some regulators from the max77802 PMIC support to be configured in one of two operating mode: Output ON (normal) and Output On Low Power Mode. Not all regulators support these two modes and for some of them, the mode can be changed while the system is running in normal operation while others only

[PATCH v2 1/7] regulator: max77802: Add .{get,set}_mode callbacks

2014-10-16 Thread Javier Martinez Canillas
Some max77802 LDOs (1, 3, 20 and 21) support to be configured in Low Power Mode during system normal operation. Add function handlers for the .get_mode and .set_mode operations to set the mode on these LDOs. Signed-off-by: Javier Martinez Canillas javier.marti...@collabora.co.uk --- Changes

[GIT PULL 2nd] Samsung fixes 2nd for v3.18

2014-10-16 Thread Kukjin Kim
Hi, This is required for previous exynos_defconfig updates including USB gadget. Please pull. Note, this branch is based on previous tags/samsung-defconfig. Thanks, Kukjin --- The following changes since commit 508423bebcda29eb0ba7c627f895387dad7cdcd6: ARM: exynos_defconfig: enable USB

Re: [GIT PULL 2/2] Samsung defconfig updates for v3.18

2014-10-16 Thread Chanwoo Choi
Dear Kukjin, On 10/17/2014 08:00 AM, Kukjin Kim wrote: On 10/16/14 16:59, Kukjin Kim wrote: Javier Martinez Canillas wrote: Hello Kukjin, Hi, On Thu, Oct 16, 2014 at 3:01 AM, Kukjin Kimkg...@kernel.org wrote: Sjoerd Simons wrote: On Tue, 2014-10-14 at 23:32 -0700, Olof Johansson wrote: