Re: Enable runtime PM automatically?

2014-12-19 Thread Geert Uytterhoeven
Hi Kevin, Thanks for your comments! On Thu, Dec 18, 2014 at 10:29 PM, Kevin Hilman khil...@kernel.org wrote: However, if PM domains are active, drivers must be runtime PM-aware for the gpd_dev_ops.start() method to be called in the first place (perhaps this is just one bug that's easy to

Re: [PATCH 4/4] PM: Eliminate CONFIG_PM_RUNTIME

2014-12-19 Thread Geert Uytterhoeven
On Fri, Dec 19, 2014 at 3:03 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: --- linux-pm.orig/arch/mips/configs/lemote2f_defconfig +++ linux-pm/arch/mips/configs/lemote2f_defconfig @@ -37,7 +37,7 @@ CONFIG_MIPS32_N32=y CONFIG_PM=y ^^^ CONFIG_HIBERNATION=y

[PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys

2014-12-19 Thread Beomho Seo
This patch replace number by macro in gpio keys for exynos 3250 boards. Cc: Youngjun Cho yj44@samsung.com Cc: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Beomho Seo beomho@samsung.com --- arch/arm/boot/dts/exynos3250-monk.dts |3 ++- arch/arm/boot/dts/exynos3250-rinato.dts |

[PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node

2014-12-19 Thread Beomho Seo
This patch remove unecessary property of gpio-keys node. gpio-keys driver do not uses interrupts and interrupt-parent. Cc: Youngjun Cho yj44@samsung.com Cc: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Beomho Seo beomho@samsung.com --- arch/arm/boot/dts/exynos3250-monk.dts |2

Re: [PATCH 2/2] ARM: dts: exynos3250: replace number by macro in gpio keys

2014-12-19 Thread Chanwoo Choi
Hi Beomho, On 12/19/2014 05:39 PM, Beomho Seo wrote: This patch replace number by macro in gpio keys for exynos 3250 boards. Cc: Youngjun Cho yj44@samsung.com Cc: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Beomho Seo beomho@samsung.com Reviewed-by: Chanwoo Choi

Re: [PATCH 1/2] ARM: dts: exynos3250: remove unecessary property of gpio-keys node

2014-12-19 Thread Chanwoo Choi
Hi Beomho, On 12/19/2014 05:39 PM, Beomho Seo wrote: This patch remove unecessary property of gpio-keys node. gpio-keys driver do not uses interrupts and interrupt-parent. Cc: Youngjun Cho yj44@samsung.com Cc: Chanwoo Choi cw00.c...@samsung.com Signed-off-by: Beomho Seo

[PATCH 0/2] Add pinctrl support for audio IPs on exynos7

2014-12-19 Thread Padmavathi Venna
Audio interface IPs I2S, PCM and SPDIF on Exynos7 requires GPIOs available on AUD and BUS0 pin controller blocks. So add support for all. This patchset is dependent on BUS1 pin control support from Vivek in the below link https://patchwork.kernel.org/patch/5467321/ Padmavathi Venna (2):

[PATCH 2/2] arm64: dts: Add pinctrl support for audio IPs on exynos7

2014-12-19 Thread Padmavathi Venna
Add pinctrl support for I2S,PCM,SPDIF Signed-off-by: Padmavathi Venna padm...@samsung.com --- arch/arm64/boot/dts/exynos/exynos7-pinctrl.dtsi | 56 +++ arch/arm64/boot/dts/exynos/exynos7.dtsi |7 +++ 2 files changed, 63 insertions(+), 0 deletions(-) diff --git

[PATCH 1/2] pinctrl: exynos: Add AUDIO pin controller for exynos7

2014-12-19 Thread Padmavathi Venna
Audio IPs on Exynos7 require gpios available in AUDIO pin controller block. So adding the AUDIO pinctrl support. Signed-off-by: Padmavathi Venna padm...@samsung.com --- .../bindings/pinctrl/samsung-pinctrl.txt |1 + drivers/pinctrl/samsung/pinctrl-exynos.c | 10

[PATCH 0/4] Add clk and dt support for PDMA and SPI on Exynos7

2014-12-19 Thread Padmavathi Venna
Add PDMA0,PDMA1 gate clock and required clks for 5 SPI channels. Also enable the support for PDMA and 5 SPI channels in DT. This patchset is dependent on usb clk support from Vivek in below link. http://www.spinics.net/lists/linux-samsung-soc/msg39342.html Padmavathi Venna (4): clk: samsung:

[PATCH 2/4] clk: samsung: exynos7: add clocks for SPI block

2014-12-19 Thread Padmavathi Venna
Add clock support for 5 SPI channels. Signed-off-by: Padmavathi Venna padm...@samsung.com --- drivers/clk/samsung/clk-exynos7.c | 73 +++ include/dt-bindings/clock/exynos7-clk.h | 22 - 2 files changed, 93 insertions(+), 2 deletions(-) diff --git

[PATCH 3/4] clk: samsung: exynos7: add clocks for audio block

2014-12-19 Thread Padmavathi Venna
Add required clk support for I2S,PCM amd SPDIF Signed-off-by: Padmavathi Venna padm...@samsung.com --- .../devicetree/bindings/clock/exynos7-clock.txt|6 + drivers/clk/samsung/clk-exynos7.c | 144 +++- include/dt-bindings/clock/exynos7-clk.h|

[PATCH 4/4] arm64: dts: Add PDMA and SPI device tree node for exynos7

2014-12-19 Thread Padmavathi Venna
Add PDMA0,PDMA1 and 5 SPI dt nodes for Exynos7. Signed-off-by: Padmavathi Venna padm...@samsung.com --- arch/arm64/boot/dts/exynos/exynos7.dtsi | 113 +++ 1 files changed, 113 insertions(+), 0 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi

[PATCH] clk: samsung: exynos7: Fix fsys NR_CLK

2014-12-19 Thread Padmavathi Venna
Fix typo in fsys0 and fsys1 NR_CLK assignment Signed-off-by: Padmavathi Venna padm...@samsung.com --- drivers/clk/samsung/clk-exynos7.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos7.c b/drivers/clk/samsung/clk-exynos7.c index

[PATCH] arm64: dts: exynos7: Fix wrong base address of i2c7 bus

2014-12-19 Thread Padmavathi Venna
I2C7 base address corrected. Signed-off-by: Padmavathi Venna padm...@samsung.com --- arch/arm64/boot/dts/exynos/exynos7.dtsi |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index

Re: [alsa-devel] [PATCH/RFC 00/14] ASoC: samsung: Add clk provider for I2S internal clocks

2014-12-19 Thread Sylwester Nawrocki
Hi Padma, On 16/12/14 04:16, Padma Venkat wrote: Hi Sylwester, I need some more thought about interaction between the clk API calls on the clocks being exposed and the ASoC calls into sound/soc/samsung/i2s.c. I'm sending teh patches for review though to avoid any waste of time should it

[PATCH v2 00/16] ASoC: samsung: Add clk provider for I2S internal clocks

2014-12-19 Thread Sylwester Nawrocki
This series is an attempt to resolve the CDCLK clock gating issue on Odroid X2/U3 as reported by Daniel Drake [1], by exposing the CDCLK gate clock (and the two other clocks) through clk API. Changes since previous version: - removed check for the i2s_opclk1 mux input clock while creating the

[PATCH v2 02/16] ASoC: samsung: i2s: samsung_i2s_get_driver_data() cleanup

2014-12-19 Thread Sylwester Nawrocki
Tidy up the samsung_i2s_get_driver_data() function by using IS_ENABLE() instead of #ifdef and add missing braces for the 'else' part. Also ensure we are not dereferencing NULL 'match' pointer. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- sound/soc/samsung/i2s.c |9 -

[PATCH v2 03/16] ASoC: samsung: i2s: Add return value checks in probe()

2014-12-19 Thread Sylwester Nawrocki
These functions may fail so let's properly report any errors. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- sound/soc/samsung/i2s.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c index

[PATCH v2 04/16] ASoC: samsung: i2s: Request memory region in driver probe()

2014-12-19 Thread Sylwester Nawrocki
The memory mapped registers region is common for both DAIs so request it in the I2S platform device driver's probe for the platform device corresponding to the primary DAI, rather than in the ASoC DAI's probe callback. While at it switch to devm_ioremap_resource(). This also drops the hard coded

[PATCH v2 01/16] ASoC: samsung: i2s: Remove unused gpios field from struct i2s

2014-12-19 Thread Sylwester Nawrocki
The 'gpios' field in 'struct i2s' is now unused, this change seems to be missing in commit 0429ffeff460c4302bd1520e6 (ASoC: samsung: Remove obsolete GPIO based DT pinmuxing). Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- sound/soc/samsung/i2s.c |1 - 1 file changed, 1

[PATCH v2 05/16] ASoC: samsung: i2s: Move clk_get() to platform driver probe()

2014-12-19 Thread Sylwester Nawrocki
Acquire the I2S interface clock in driver probe() callback as it's a per-device not a per-DAI clock. While at it switch to the resource managed clk_get(). Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- sound/soc/samsung/i2s.c | 19 +++ 1 file changed, 7

[PATCH v2 06/16] ASoC: samsung: i2s: Move clk enable to the platform driver probe()

2014-12-19 Thread Sylwester Nawrocki
Gating the I2S bus clock in the driver's runtime PM callbacks has currently really no effect since the clock is being enabled in the DAI's probe() and thus is permanently turned on. Now we just move the enable to the platform driver's probe(), which doesn't change the situation much. It will allow

[PATCH v2 07/16] ASoC: samsung: i2s: Add get_other_dai helper function

2014-12-19 Thread Sylwester Nawrocki
The code to get pointer to the other DAI is repeated multiple times. Add a helper function and use it instead. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- sound/soc/samsung/i2s.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git

[PATCH v2 08/16] ASoC: samsung: i2s: Remove an unneeded goto usage

2014-12-19 Thread Sylwester Nawrocki
The usage of this goto seems unjustified, use if/else statement instead. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- sound/soc/samsung/i2s.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/sound/soc/samsung/i2s.c b/sound/soc/samsung/i2s.c

[PATCH v2 10/16] ASoC: samsung: i2s: Protect more registers with a spinlock

2014-12-19 Thread Sylwester Nawrocki
Ensure the I2SMOD, I2SPSR registers, which are also exposed through clk API are only accessed with the i2s-spinlock spinlock held. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- sound/soc/samsung/i2s.c | 81 +-- 1 file changed, 51

[PATCH v2 12/16] ASoC: samsung: i2s: Add clk provider DT binding documentation

2014-12-19 Thread Sylwester Nawrocki
The new DT properties required for the I2S device node to be referred as a clock provider and corresponding clock indices definition is added. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- .../devicetree/bindings/sound/samsung-i2s.txt | 22

[PATCH v2 11/16] ASoC: samsung: odroidx2: Handle I2S CDCLK clock conditionally

2014-12-19 Thread Sylwester Nawrocki
In order to support old DTs we check the codec device node if it contains clocks property and only if it doesn't (which indicates an old DT) we proceed with enabling the CDCLK clock by means of the set_sysclk() callback. For new DTs which use the common clock bindings for CDCLK that clock is

[PATCH v2 09/16] ASoC: samsung: i2s: Add spinlock in place of local_irq_* calls

2014-12-19 Thread Sylwester Nawrocki
It seems this driver hasn't been updated for SMP, as local_irq_save/ local_irq_restore don't provide proper protection of read/modify/write of the device's registers on such systems. Introduce a spinlock serializing access to the register region, it will be helpful later when I2SMOD, I2SPSR

[PATCH v2 13/16] ASoC: samsung: i2s: Add clock provider for the I2S internal clocks

2014-12-19 Thread Sylwester Nawrocki
This patch adds a clock provider (currently only for DT platforms) for the CODECLKO (CDCLK) gate, RCLKSRC mux and RCLK pre-scaler divider clock. All these tree clocks are only available in the IIS Multi Audio Interface (I2S0), the regular IIS Bus Interface has only CDCLK gate clock. With that in

[PATCH v2 14/16] ARM: dts: Exynos4 and Odroid X2/U3 sound device nodes update

2014-12-19 Thread Sylwester Nawrocki
Clock related properties are added to the Exynos4 I2S device nodes so they can be referred to as clock providers. Missing i2s_opclk1 clock is added to the I2S0 node and clock properties are added to the MAX98090 codec node to allow it to control/read frequency of the MCLK clock directly.

[PATCH v2 15/16] ARM: dts: Switch Odroid X2/U2 to simple-audio-card

2014-12-19 Thread Sylwester Nawrocki
Now when the CDCLK I2S output clock can be handled through the clock API the Odroid X2/U3 can be switched to the simple-audio-card DT binding. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi |3 +++

[PATCH v2 16/16] ARM: dts: Fix I2S1, I2S2 compatible for exynos4 SoCs

2014-12-19 Thread Sylwester Nawrocki
I2S1, I2S2 on Exynos4 SoC series have limited functionality compared to I2S0, samsung,s3c6410-i2s compatible should be used for them. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH] ARM: SAMSUNG: remove dead #elif CONFIG_S3C24XX_DMAC

2014-12-19 Thread Stefan Hengelein
From what i can see, the block was already dead when it was introduced. d2193ce2 changed the if ARCH_S3C64XX into the Kconfig file itself, before it was around the source statement in arch/arm/Kconfig if there are really just downstream users that explicitly have to add a statement to select

Re: [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device

2014-12-19 Thread Lukasz Majewski
Hi Sjoerd, Thanks for your feedback and sorry for a late reply. On Thu, 2014-12-18 at 11:13 +0100, Lukasz Majewski wrote: Several new properties to allow PWM fan working as a cooling device have been combined into this single commit. Signed-off-by: Lukasz Majewski

Re: [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device

2014-12-19 Thread Guenter Roeck
On Fri, Dec 19, 2014 at 04:32:24PM +0100, Lukasz Majewski wrote: Hi Sjoerd, Thanks for your feedback and sorry for a late reply. On Thu, 2014-12-18 at 11:13 +0100, Lukasz Majewski wrote: Several new properties to allow PWM fan working as a cooling device have been combined into this

Re: [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device

2014-12-19 Thread Lukasz Majewski
Hi Guenter, On Fri, Dec 19, 2014 at 04:32:24PM +0100, Lukasz Majewski wrote: Hi Sjoerd, Thanks for your feedback and sorry for a late reply. On Thu, 2014-12-18 at 11:13 +0100, Lukasz Majewski wrote: Several new properties to allow PWM fan working as a cooling device have

Re: [PATCH] clk: samsung: exynos7: Add clocks for MSCL block

2014-12-19 Thread Sylwester Nawrocki
Hi, On 17/12/14 08:33, Tony K Nadackal wrote: Add clock support for the MSCL block for Exynos7. Signed-off-by: Tony K Nadackal tony...@samsung.com --- .../devicetree/bindings/clock/exynos7-clock.txt| 1 + drivers/clk/samsung/clk-exynos7.c | 124

Re: [PATCH 2/9] hwmon: dts: Doc: Add DTS doc to explain how to use PWM FAN as a cooling device

2014-12-19 Thread Lukasz Majewski
Hi Guenter, On 12/18/2014 02:13 AM, Lukasz Majewski wrote: Several new properties to allow PWM fan working as a cooling device have been combined into this single commit. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- .../devicetree/bindings/hwmon/pwm-fan.txt |

Re: [PATCH 4/4] PM: Eliminate CONFIG_PM_RUNTIME

2014-12-19 Thread Rafael J. Wysocki
On Friday, December 19, 2014 09:13:29 AM Geert Uytterhoeven wrote: On Fri, Dec 19, 2014 at 3:03 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: --- linux-pm.orig/arch/mips/configs/lemote2f_defconfig +++ linux-pm/arch/mips/configs/lemote2f_defconfig @@ -37,7 +37,7 @@ CONFIG_MIPS32_N32=y

Re: [PATCH 4/4] PM: Eliminate CONFIG_PM_RUNTIME

2014-12-19 Thread Kevin Hilman
Rafael J. Wysocki r...@rjwysocki.net writes: [...] Fixed up patch is appended, thanks! --- From: Rafael J. Wysocki rafael.j.wyso...@intel.com Subject: PM: Eliminate CONFIG_PM_RUNTIME Having switched over all of the users of CONFIG_PM_RUNTIME to use CONFIG_PM directly, turn the latter

Re: Enable runtime PM automatically?

2014-12-19 Thread Kevin Hilman
Geert Uytterhoeven ge...@linux-m68k.org writes: [...] On Thu, Dec 18, 2014 at 10:29 PM, Kevin Hilman khil...@kernel.org wrote: However, if PM domains are active, drivers must be runtime PM-aware for the gpd_dev_ops.start() method to be called in the first place (perhaps this is just one

Re: [PATCH 4/4] PM: Eliminate CONFIG_PM_RUNTIME

2014-12-19 Thread Rafael J. Wysocki
On Friday, December 19, 2014 01:49:34 PM Kevin Hilman wrote: Rafael J. Wysocki r...@rjwysocki.net writes: [...] Fixed up patch is appended, thanks! --- From: Rafael J. Wysocki rafael.j.wyso...@intel.com Subject: PM: Eliminate CONFIG_PM_RUNTIME Having switched over all of the