Re: [PATCH v2 7/8] hwmon: thermal: Read PWM FAN configuration from device tree

2014-12-29 Thread Guenter Roeck
On Mon, Dec 22, 2014 at 05:27:47PM +0100, Lukasz Majewski wrote: Code for reading PWM FAN configuration data via device tree. Signed-off-by: Lukasz Majewski l.majew...@samsung.com --- The headline is quite misleading. Please provide the affected subsystem (hwmon) and the affected driver

Re: [PATCH v2 6/8] hwmon: thermal: Extract __set_pwm() function to only modify PWM duty cycle

2014-12-29 Thread Guenter Roeck
On Mon, Dec 22, 2014 at 05:27:46PM +0100, Lukasz Majewski wrote: It was necessary to decouple code handling writing to sysfs from the one responsible for setting PWM of the fan. Due to that, new __set_pwm() method was extracted, which is responsible for only setting new PWM duty cycle.

Re: [PATCH v10 2/8] ARM: l2c: Refactor the driver to use commit-like interface

2014-12-29 Thread Nishanth Menon
On 20:34-20141228, Tomasz Figa wrote: May I ask you (or anyone else working on OMAP) to try to figure out what the issue is? It is stopping L2 cache support for Exynos4 being http://slexy.org/view/s2BnzxVglj Took a register dump and compared - Got the same dump http://slexy.org/view/s21YRHpzeW

Re: [PATCH v10 2/8] ARM: l2c: Refactor the driver to use commit-like interface

2014-12-29 Thread Nishanth Menon
On 12/23/2014 04:48 AM, Marek Szyprowski wrote: -static void l2c310_resume(void) +static void l2c310_configure(void __iomem *base) { - void __iomem *base = l2x0_base; + unsigned revision; - if (!(readl_relaxed(base + L2X0_CTRL) L2X0_CTRL_EN)) { - unsigned