Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode

2015-08-07 Thread Yakir Yang
Daniel, 在 2015/8/7 19:25, Daniel Vetter 写道: On Thu, Aug 06, 2015 at 10:29:29PM +0800, Yakir Yang wrote: Hi Jingoo, 在 2015/8/6 22:19, Jingoo Han 写道: On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote: In order to move exynos dp code to bridge directory, we need to convert driver drm

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-07 Thread Inki Dae
Hi Daniel, On 2015년 08월 07일 21:28, Daniel Vetter wrote: On Fri, Aug 7, 2015 at 1:50 PM, Inki Dae inki@samsung.com wrote: Booting is locked up here. This patch looks good to me so I tried to find why locked up and I found the booting is locked up as soon as console_lock function is

Re: [RFC PATCH v4 1/9] mmc: dw_mmc: Add external dma interface support

2015-08-07 Thread Joachim Eastwood
Hi Shawn, On 6 August 2015 at 08:44, Shawn Lin shawn@rock-chips.com wrote: DesignWare MMC Controller can supports two types of DMA mode: external dma and internal dma. We get a RK312x platform integrated dw_mmc and ARM pl330 dma controller. This patch add edmac ops to support these

Re: [RFC PATCH v4 7/9] arm: lpc18xx_defconfig: remove CONFIG_MMC_DW_IDMAC

2015-08-07 Thread Joachim Eastwood
On 6 August 2015 at 08:46, Shawn Lin shawn@rock-chips.com wrote: DesignWare MMC Controller's transfer mode should be decided at runtime instead of compile-time. So we remove this config option and read dw_mmc's register to select DMA master. Signed-off-by: Shawn Lin

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-07 Thread Rafael J. Wysocki
On Friday, August 07, 2015 05:26:27 PM Viresh Kumar wrote: On 07-08-15, 13:47, Bartlomiej Zolnierkiewicz wrote: Hmm, wait. Patch 6/6 depends on earlier changes. I cannot remove the config option in question now as it is currently used by exynos-cpufreq specific boost support. Patch 1/6

Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Rafael J. Wysocki
On Friday, August 07, 2015 05:07:39 PM Viresh Kumar wrote: On 07-08-15, 13:12, Bartlomiej Zolnierkiewicz wrote: From 993ebb6fc632ec7b61654c9610c90ff4dca4be34 Mon Sep 17 00:00:00 2001 From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Date: Fri, 7 Aug 2015 13:07:51 +0200 Subject:

Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday, August 07, 2015 09:11:28 AM Viresh Kumar wrote: Hi, I would suggest you sending such patches as reply to the earlier threads only, instead of a new chain. This will save your time. Please explain it more. This patch needs to be first for cpufreq-dt switch to be complete.

[PATCH v2 0/8] Add Analogix Core Display Port Driver

2015-08-07 Thread Yakir Yang
Hi all, The Samsung Exynos eDP controller and Rockchip RK3288 eDP controller share the same IP, so a lot of parts can be re-used. I split the common code into bridge directory, then rk3288 and exynos only need to keep some platform code. Cause I can't find the exact IP name of exynos dp

[PATCH v2 1/8] drm: exynos/dp: fix code style

2015-08-07 Thread Yakir Yang
After run checkpatch.pl -f --subjective command, I see there are lots of alignment problem in exynos_dp driver, so let just fix them. Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v2: - Take Joe Preches advise, improved commit message more readable, and avoid using some uncommon

[PATCH v2 8/8] drm: bridge/analogix_dp: expand the delay time for hpd detect

2015-08-07 Thread Yakir Yang
Some edp screen with no hpd signal would need some delay time to ensure that screen would be ready for work, so we can expand the delay time in hpd detect function, it works prefectly on my rk3288 sdk board. Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v2: None

[PATCH v2 2/8] drm: exynos/dp: convert to drm bridge mode

2015-08-07 Thread Yakir Yang
In order to move exynos dp code to bridge directory, we need to convert driver drm bridge mode first. As dp driver already have a ptn3460 bridge, so we need to move ptn bridge to the next bridge of dp bridge. Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v2: - Take Jingoo Han

Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Viresh Kumar
On 07-08-15, 12:34, Bartlomiej Zolnierkiewicz wrote: I would suggest you sending such patches as reply to the earlier threads only, instead of a new chain. This will save your time. Please explain it more. This patch needs to be first for cpufreq-dt switch to be complete.

[PATCH v2 7/8] drm: bridge: analogix_dp: try force hpd after plug in lookup failed

2015-08-07 Thread Yakir Yang
Some edp screen do not have hpd signal, so we can't just return failed when hpd plug in detect failed. Besides TRM indicate that if HPD_STATUS(RO) is 0, AUX CH will not work, so we need to give a force hpd action to set HPD_STATUS manually. Signed-off-by: Yakir Yang y...@rock-chips.com ---

Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Viresh Kumar
On 07-08-15, 13:12, Bartlomiej Zolnierkiewicz wrote: From 993ebb6fc632ec7b61654c9610c90ff4dca4be34 Mon Sep 17 00:00:00 2001 From: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Date: Fri, 7 Aug 2015 13:07:51 +0200 Subject: [PATCH] cpufreq-dt: make scaling_boost_freqs sysfs attr available

[PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-07 Thread Yakir Yang
Rockchip have three clocks for dp controller, we leave pclk_edp to analogix_dp driver control, and keep the sclk_edp_24m and sclk_edp in platform driver. Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v2: None drivers/gpu/drm/rockchip/Kconfig| 10 +

[PATCH v2 5/8] drm: bridge/analogix_dp: add platform device type support

2015-08-07 Thread Yakir Yang
Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v2: - Add GNU license v2 declared and samsung copyright drivers/gpu/drm/exynos/analogix_dp-exynos.c | 1 + drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 1 + include/drm/bridge/analogix_dp.h| 16

Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Bartlomiej Zolnierkiewicz
On Friday, August 07, 2015 04:11:56 PM Viresh Kumar wrote: On 07-08-15, 12:34, Bartlomiej Zolnierkiewicz wrote: I would suggest you sending such patches as reply to the earlier threads only, instead of a new chain. This will save your time. Please explain it more. This patch needs to

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-07 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday, August 07, 2015 10:48:26 AM Viresh Kumar wrote: On 07-08-15, 13:52, Krzysztof Kozlowski wrote: Thanks for explanation. As fair as I understand, Bartlomiej wanted to merge this in a way which would avoid loosing the boost mode. Kukjin prepared topic branches for previous

[PATCH v2 6/8] drm: bridge: analogix_dp: add some rk3288 special registers setting

2015-08-07 Thread Yakir Yang
RK3288 need some special registers setting, we can separate them out by the dev_type of plat_data. Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v2: - Fix compile failed dut to phy_pd_addr variable misspell error drivers/gpu/drm/bridge/analogix_dp_reg.c | 76

Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode

2015-08-07 Thread Daniel Vetter
On Thu, Aug 06, 2015 at 10:29:29PM +0800, Yakir Yang wrote: Hi Jingoo, 在 2015/8/6 22:19, Jingoo Han 写道: On Thursday, August 06, 2015 11:07 PM, Yakir Yang wrote: In order to move exynos dp code to bridge directory, we need to convert driver drm bridge mode first. As dp driver already have a

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-07 Thread Viresh Kumar
On 07-08-15, 13:31, Bartlomiej Zolnierkiewicz wrote: Users don't need to enable the config option to get boost functionality working. It is only needed to get scaling_boost_freqs sysfs attribute visible (which lists available boost freqs) when using cpufreq-dt driver. Also the config option

[PATCH 2/4] drm/bridge: Add vendor prefixes

2015-08-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Use vendor prefixes for Kconfig symbols and filenames. This should make it easier to identify the various bridge drivers and to organize the directory. While at it, rename dw_hdmi.[ch] to dw-hdmi.[ch] for consistency. Signed-off-by: Thierry Reding

[PATCH 1/4] ARM: exynos: Remove PTN3460 dependency

2015-08-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Now that the PTN3460 driver has been rewritten as a proper I2C driver and there is infrastructure to hook up the bridge with a DRM device, it is no longer necessary to have this dependency to ensure the correct build mode. Signed-off-by: Thierry Reding

[PATCH 4/4] drm/bridge: Put Kconfig entries in a separate menu

2015-08-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com Put the Kconfig entries for bridge drivers into a separate menu so that they are automatically grouped and don't clutter up the top-level menu. While at it, move the bridge menu towards the end of the top-level menu where the panel menu is already located.

[PATCH 3/4] drm/panel: Add Samsung prefix to panel drivers

2015-08-07 Thread Thierry Reding
From: Thierry Reding tred...@nvidia.com The likelihood of getting a large number of panel drivers from different vendors is quite high. Add a prefix to the two existing Samsung panel drivers to set a guideline for future patch submissions. Using vendor prefixes consistently should allow a cleaner

[PATCH RFC v2 07/16] media: get rid of unused extra_links param on media_entity_init()

2015-08-07 Thread Mauro Carvalho Chehab
Currently, media_entity_init() creates an array with the links, allocated at init time. It provides a parameter (extra_links) that would allocate more links than the current needs, but this is not used by any driver. As we want to be able to do dynamic link allocation/removal, we'll need to

Re: [PATCH] clk: s5pv210: add missing call to samsung_clk_of_add_provider()

2015-08-07 Thread Marek Szyprowski
Hello, On 2014-09-19 11:00, Marek Szyprowski wrote: Commit d5e136a21b2028fb1f45143ea7112d5869bfc6c7 (clk: samsung: Register clk provider only after registering its all clocks, merged to v3.17-rc1) modified a way that driver registers registers to core framework. This change has not been applied

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-07 Thread Bartlomiej Zolnierkiewicz
On Friday, August 07, 2015 05:09:50 PM Viresh Kumar wrote: On 07-08-15, 13:31, Bartlomiej Zolnierkiewicz wrote: Users don't need to enable the config option to get boost functionality working. It is only needed to get scaling_boost_freqs sysfs attribute visible (which lists available boost

[PATCH] cpufreq-dt: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Bartlomiej Zolnierkiewicz
Make scaling_boost_freqs sysfs attribute is available when cpufreq-dt driver is used and boost support is enabled. Cc: Thomas Abraham thomas...@samsung.com Cc: Javier Martinez Canillas jav...@osg.samsung.com Cc: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Viresh Kumar

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-07 Thread Inki Dae
Hi Gustavo, On 2015년 08월 06일 22:31, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had only a drm_encoder member and the internal exynos_drm_encoders ops that was directly mapped to the

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-07 Thread Viresh Kumar
On 07-08-15, 13:47, Bartlomiej Zolnierkiewicz wrote: Hmm, wait. Patch 6/6 depends on earlier changes. I cannot remove the config option in question now as it is currently used by exynos-cpufreq specific boost support. Patch 1/6 can be applied now but 6/6 needs to wait for patches 2-5 to be

[PATCH v2] cpufreq-dt: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Bartlomiej Zolnierkiewicz
Make scaling_boost_freqs sysfs attribute is available when cpufreq-dt driver is used and boost support is enabled. Cc: Thomas Abraham thomas...@samsung.com Cc: Javier Martinez Canillas jav...@osg.samsung.com Cc: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Viresh Kumar

[PATCH v3] cpufreq-dt: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Bartlomiej Zolnierkiewicz
Make scaling_boost_freqs sysfs attribute is available when cpufreq-dt driver is used and boost support is enabled. Cc: Thomas Abraham thomas...@samsung.com Cc: Javier Martinez Canillas jav...@osg.samsung.com Cc: Krzysztof Kozlowski k.kozlow...@samsung.com Suggested-by: Viresh Kumar

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-07 Thread Daniel Vetter
On Fri, Aug 7, 2015 at 1:50 PM, Inki Dae inki@samsung.com wrote: Booting is locked up here. This patch looks good to me so I tried to find why locked up and I found the booting is locked up as soon as console_lock function is called. Can you and other guys look into this issue? It's not

Re: [PATCH v2] cpufreq-dt: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Viresh Kumar
On 07-08-15, 13:56, Bartlomiej Zolnierkiewicz wrote: Make scaling_boost_freqs sysfs attribute is available when cpufreq-dt driver is used and boost support is enabled. Cc: Thomas Abraham thomas...@samsung.com Cc: Javier Martinez Canillas jav...@osg.samsung.com Cc: Krzysztof Kozlowski

Re: [PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-07 Thread Heiko Stübner
Hi Yakir, I think this Rockchip portion is missing a devicetree binding. You have the ability to power down the actual edp phy by using grf_edp_iddq_en from GRF_SOC_CON12. This is similar to how the rk3288 usb-phy gets put into a deeper state. So maybe you could provide a phy driver

Re: [PATCH v4 1/6] cpufreq: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Viresh Kumar
On 08-08-15, 00:21, Rafael J. Wysocki wrote: Acked-by: Viresh Kumar viresh.ku...@linaro.org And what exactly am I supposed to do with this? Have a robot that will pick up all patches ACKed by you magically or what? :) That's why I have asked Bartlomiej specifically to send it separately

Re: [PATCH v4 0/6] cpufreq: use generic cpufreq drivers for Exynos4x12 platform

2015-08-07 Thread Viresh Kumar
On 08-08-15, 00:24, Rafael J. Wysocki wrote: OK, so please let me know which patches you want me to pick up. Ideally, I'd prefer them to be resent in a separate series with ACKs and all with a cover letter clearly stating whose tree they are being targeted at. He already sent it separately,

Re: [PATCH v3] cpufreq-dt: make scaling_boost_freqs sysfs attr available when boost is enabled

2015-08-07 Thread Viresh Kumar
On 07-08-15, 13:59, Bartlomiej Zolnierkiewicz wrote: Make scaling_boost_freqs sysfs attribute is available when cpufreq-dt driver is used and boost support is enabled. Cc: Thomas Abraham thomas...@samsung.com Cc: Javier Martinez Canillas jav...@osg.samsung.com Cc: Krzysztof Kozlowski

Re: [PATCH v2 4/8] drm: rockchip/dp: add rockchip platform dp driver

2015-08-07 Thread Yakir Yang
Hi Hekio, 在 2015/8/8 6:46, Heiko Stübner 写道: Hi Yakir, I think this Rockchip portion is missing a devicetree binding. Oh, thanks, I would complete it in next ;) You have the ability to power down the actual edp phy by using grf_edp_iddq_en from GRF_SOC_CON12. This is similar to how the