Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-10-30 Thread Krzysztof Kozlowski
On 30.10.2015 15:25, Alim Akhtar wrote: > From: Thomas Abraham > > Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device > is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. > This also supports RTC and three 32.768KHz clock

Re: [PATCH 07/13] tests/exynos: use XRGB8888 for framebuffer

2015-10-30 Thread Hyungwon Hwang
On Tue, 22 Sep 2015 17:54:56 +0200 Tobias Jakobi wrote: > This matches the G2D color mode that is used in the entire code. > The previous (incorrect) RGBA would only work since the > Exynos mixer did its configuration based on the bpp, and not > based on the

RE: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-10-30 Thread Pavel Fedin
Hello! > -Original Message- > From: linux-samsung-soc-ow...@vger.kernel.org > [mailto:linux-samsung-soc-ow...@vger.kernel.org] > On Behalf Of Pankaj Dubey > Sent: Thursday, October 29, 2015 8:28 PM > To: Pavel Fedin > Cc: devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Krzysztof Kozlowski
On 30.10.2015 15:25, Alim Akhtar wrote: > RTC found in s2mps15 is almost same as one found on s2mps13 > with few differences in RTC_UPDATE register fields, like: > 1> Bit[4] and Bit[1] are reversed >- On s2mps13 > WUDR -> bit[4], AUDR -> bit[1] >- On s2mps15 > WUDR ->

Re: [PATCH v3 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Krzysztof Kozlowski
On 29.10.2015 20:43, Pavel Fedin wrote: > Hello! > Any vendor prefix here? How generic is this? >>> >>> I just don't know... Does *everything* really need a vendor prefix? How >>> readable would that >> be? "compatible" property already says >>> that it's samsung-exynos-specific. And IMHO

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Krzysztof Kozlowski
On 29.10.2015 21:42, Pavel Fedin wrote: > Add documentation for new subnode properties, allowing bank configuration. > Based on u-boot implementation, but heavily reworked. Please, carefully look at: Documentation/devicetree/bindings/net/gpmc-eth.txt

[PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-10-30 Thread Alim Akhtar
From: Thomas Abraham Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. This also supports RTC and three 32.768KHz clock outputs. Cc: devicet...@vger.kernel.org

[PATCH v5 3/4] regulator: s2mps11: add support for S2MPS15 regulators

2015-10-30 Thread Alim Akhtar
From: Thomas Abraham The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains 27 LDO and 10 Buck regulators and allows programming these regulators via a I2C interface. This patch adds initial support for LDO/Buck regulators of S2MPS15 PMIC.

[PATCH v5 2/4] mfd: sec: Add support for S2MPS15 PMIC

2015-10-30 Thread Alim Akhtar
From: Thomas Abraham Add support for S2MPS15 PMIC which is similar to S2MPS11 PMIC. The S2MPS15 PMIC supports 27 LDO regulators, 10 buck regulators, RTC, three 32.768KHz clock outputs and battery charger. This patch adds initial support for LDO and buck regulators of

[PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Alim Akhtar
RTC found in s2mps15 is almost same as one found on s2mps13 with few differences in RTC_UPDATE register fields, like: 1> Bit[4] and Bit[1] are reversed - On s2mps13 WUDR -> bit[4], AUDR -> bit[1] - On s2mps15 WUDR -> bit[1], AUDR -> bit[4] 2> In case of s2mps13, for alarm

Re: [PATCH 03/13] tests/exynos: add fimg2d performance analysis

2015-10-30 Thread Hyungwon Hwang
On Tue, 22 Sep 2015 17:54:52 +0200 Tobias Jakobi wrote: > Currently only fast solid color clear performance is measured. > A large buffer is allocated and solid color clear operations > are executed on it with randomly chosen properties (position > and size of the

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

2015-10-30 Thread Hyungwon Hwang
On Tue, 22 Sep 2015 17:54:55 +0200 Tobias Jakobi wrote: > This tests async processing of G2D jobs. A separate thread is spawned > to monitor the DRM fd for events and check whether a G2D job was > completed. > > v2: Add GPLv2 header, argument handling and

RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Pavel Fedin
Hello! > > Add documentation for new subnode properties, allowing bank configuration. > > Based on u-boot implementation, but heavily reworked. > > Please, carefully look at: > Documentation/devicetree/bindings/net/gpmc-eth.txt > Documentation/devicetree/bindings/bus/ti-gpmc.txt Thank you

Re: [PATCH 08/13] exynos: fimg2d: add g2d_set_direction

2015-10-30 Thread Hyungwon Hwang
On Tue, 22 Sep 2015 17:54:57 +0200 Tobias Jakobi wrote: > This allows setting the two direction registers, which specify how > the engine blits pixels. This can be used for overlapping blits, > which happen e.g. when 'moving' a rectangular region inside a > fixed

[PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children

2015-10-30 Thread Krzysztof Kozlowski
The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02 device") added new MFD child devices for S2MPU02: RTC and clock provider (the clock provider with new compatible). However support for these devices was not added to existing drivers (rtc-s5m, clk-s2mps11). New drivers were not

[PATCH v5 0/4] mfd: sec: add S2MPS15 PMIC support

2015-10-30 Thread Alim Akhtar
Samsung's S2MPS15 PMIC is targetted to be used with Samsung's Exynos7 SoC. The S2MPS15 PMIC is similar in functionality to S2MPS11/14 PMIC. It contains 27 LDO and 10 Buck regulators, RTC, three 32.768 KHz clock outputs and allows programming these blocks via a I2C interface. This patch series adds

RE: [PATCH v4 0/4] [PATCH v4 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-10-30 Thread Pavel Fedin
Hello! > > .../bindings/arm/samsung/exynos-srom.txt | 50 ++- > > arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++ > > arch/arm/boot/dts/exynos5410.dtsi | 15 ++ > > arch/arm/mach-exynos/Kconfig | 2 +-

Re: [PATCH 09/13] exynos/fimg2d: add g2d_move

2015-10-30 Thread Hyungwon Hwang
On Tue, 22 Sep 2015 17:54:58 +0200 Tobias Jakobi wrote: > We already have g2d_copy() which implements G2D copy > operations from one buffer to another. However we can't > do a overlapping copy operation in one buffer. > > Add g2d_move() which acts like the

Re: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Krzysztof Kozlowski
On 30.10.2015 15:58, Pavel Fedin wrote: > Hello! > >>> Add documentation for new subnode properties, allowing bank configuration. >>> Based on u-boot implementation, but heavily reworked. >> >> Please, carefully look at: >> Documentation/devicetree/bindings/net/gpmc-eth.txt >>

drm/exynos: when to call dma_map_sg() on a GEM object?

2015-10-30 Thread Tobias Jakobi
Hey there, this question arose during some discussion with someone concerning the Exynos mixer and G2D. The question is the following. Consider the Exynos mixer when run under the IOMMU (that's sysmmu_tv IIRC). What exactly does setup the IOMMU mapping so that the mixer can scanout the

Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children

2015-10-30 Thread Lee Jones
On Fri, 30 Oct 2015, Krzysztof Kozlowski wrote: > The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02 > device") added new MFD child devices for S2MPU02: RTC and clock > provider (the clock provider with new compatible). However support for > these devices was not added to existing

RE: [PATCH v4 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-10-30 Thread Pavel Fedin
Hello! > Please, carefully look at: > Documentation/devicetree/bindings/net/gpmc-eth.txt > Documentation/devicetree/bindings/bus/ti-gpmc.txt > > 1. Try to re-use existing bindings. Although I see existing bank-width > and gpmc,device-width but yours samsung,srom-data-width seems better. > Maybe

RE: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-10-30 Thread Pavel Fedin
Hello! > >>> + sromc: sromc@1225 { > >>> + #address-cells = <1>; > >>> + #size-cells = <1>; > >>> + ranges; > >>> + > >> > >> We do not need to specify these three properties as they are already > >> present in

[PATCH 2/2] regulator: s2mps11: Rename s2mpsxx regulator as *-regulator

2015-10-30 Thread Alim Akhtar
S2MPSXX regulators are probed with the same name as their parent MFD device, this is a bit confusing. As we discussed the same here[1], this patch rename the current regulator names from *-pmic to *-regulator. [1]-> https://lkml.org/lkml/2015/10/28/417 Suggested-by: Lee Jones

[PATCH 1/2] mfd: sec-core: Rename MFD and regulator names differently

2015-10-30 Thread Alim Akhtar
Currently S2MPSXX multifunction device is named as *-pmic, and this MFD also supports regulator as a one of its MFD cell which has the same name, which is a bit confusing. We did discussed different approaches about how the MFD and it cells need to be named here [1]. Based in the discussion this

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

2015-10-30 Thread Tobias Jakobi
Hello Hyungwon, first of all thanks for reviewing the series! Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:55 +0200 > Tobias Jakobi wrote: > >> This tests async processing of G2D jobs. A separate thread is spawned >> to monitor the DRM fd for events and

Re: [PATCH 07/13] tests/exynos: use XRGB8888 for framebuffer

2015-10-30 Thread Tobias Jakobi
Hello Hyungwon, Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:56 +0200 > Tobias Jakobi wrote: > >> This matches the G2D color mode that is used in the entire code. >> The previous (incorrect) RGBA would only work since the >> Exynos mixer did its

Re: [PATCH v4 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-10-30 Thread Pankaj Dubey
Hi Pavel, On Friday 30 October 2015 12:11 PM, Pavel Fedin wrote: Hello! -Original Message- From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung-soc-ow...@vger.kernel.org] On Behalf Of Pankaj Dubey Sent: Thursday, October 29, 2015 8:28 PM To: Pavel Fedin Cc:

Re: [PATCH 08/13] exynos: fimg2d: add g2d_set_direction

2015-10-30 Thread Tobias Jakobi
Hello Hyungwon, Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:57 +0200 > Tobias Jakobi wrote: > >> This allows setting the two direction registers, which specify how >> the engine blits pixels. This can be used for overlapping blits, >> which happen e.g. when

Re: [PATCH 03/13] tests/exynos: add fimg2d performance analysis

2015-10-30 Thread Tobias Jakobi
Hello Hyungwon, Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:52 +0200 > Tobias Jakobi wrote: > >> Currently only fast solid color clear performance is measured. >> A large buffer is allocated and solid color clear operations >> are executed on it with

Re: [PATCH 09/13] exynos/fimg2d: add g2d_move

2015-10-30 Thread Tobias Jakobi
Hello Hyungwon, Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:58 +0200 > Tobias Jakobi wrote: > >> We already have g2d_copy() which implements G2D copy >> operations from one buffer to another. However we can't >> do a overlapping copy operation in one

Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-10-30 Thread Alim Akhtar
On 10/30/2015 01:12 PM, Krzysztof Kozlowski wrote: On 30.10.2015 15:25, Alim Akhtar wrote: From: Thomas Abraham Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. This

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

2015-10-30 Thread Emil Velikov
On 30 October 2015 at 11:16, Tobias Jakobi wrote: > Hello Hyungwon, > > first of all thanks for reviewing the series! > > > > Hyungwon Hwang wrote: >> On Tue, 22 Sep 2015 17:54:55 +0200 >> Tobias Jakobi wrote: >> >>> +

Re: [GIT PULL 4/5] Late Samsung driver updates for v4.4

2015-10-30 Thread Olof Johansson
On Wed, Oct 28, 2015 at 04:37:23PM +0900, Krzysztof Kozlowski wrote: > On 24.10.2015 06:26, Kukjin Kim wrote: > > The following changes since commit 6ff33f3902c3b1c5d0db6b1e2c70b6d76fba357f: > > > > Linux 4.3-rc1 (2015-09-12 16:35:56 -0700) > > > > are available in the git repository at: > >

Re: [PATCH v8 11/17] dt-bindings: add document for rockchip dp phy

2015-10-30 Thread Yakir Yang
On 10/31/2015 12:42 AM, Rob Herring wrote: On Wed, Oct 28, 2015 at 3:31 AM, Yakir Yang wrote: Add dt binding documentation for rockchip display port PHY. Reviewed-by: Heiko Stuebner Signed-off-by: Yakir Yang Acked-by: Rob Herring

Re: [PATCH v8 09/17] dt-bindings: add document for rockchip variant of analogix_dp

2015-10-30 Thread Yakir Yang
Hi Rob, On 10/31/2015 12:46 AM, Rob Herring wrote: On Wed, Oct 28, 2015 at 3:28 AM, Yakir Yang wrote: Rockchip DP driver is a helper driver of analogix_dp coder driver, so most of the DT property should be descriped in analogix_dp document. Reviewed-by: Heiko Stuebner

Re: [PATCH 2/2] regulator: s2mps11: Rename s2mpsxx regulator as *-regulator

2015-10-30 Thread Lee Jones
On Fri, 30 Oct 2015, Alim Akhtar wrote: > S2MPSXX regulators are probed with the same name as their parent MFD > device, this is a bit confusing. > As we discussed the same here[1], this patch rename the current regulator > names from *-pmic to *-regulator. > > [1]->

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

2015-10-30 Thread Emil Velikov
On 30 October 2015 at 11:28, Tobias Jakobi wrote: > Hello Emil, > > > Emil Velikov wrote: >> On 30 October 2015 at 11:16, Tobias Jakobi >> wrote: >>> Hello Hyungwon, >>> >>> first of all thanks for reviewing the series! >>> >>> >>>

Re: [PATCH 1/2] mfd: sec-core: Rename MFD and regulator names differently

2015-10-30 Thread Lee Jones
On Fri, 30 Oct 2015, Alim Akhtar wrote: > Currently S2MPSXX multifunction device is named as *-pmic, > and this MFD also supports regulator as a one of its MFD cell which > has the same name, which is a bit confusing. > > We did discussed different approaches about how the MFD and it > cells

[PATCH] i2c: exynos5: register driver early in subsys initcall to avoid probe defer

2015-10-30 Thread Marek Szyprowski
i2c bus drivers should be registered earlier than typical drivers to let important i2c devices (like PMICs/regulators) get registered early enough to avoid probe defer of all devices in typical embedded system. Signed-off-by: Marek Szyprowski ---

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

2015-10-30 Thread Tobias Jakobi
Hey Emil, Emil Velikov wrote: > On 30 October 2015 at 11:28, Tobias Jakobi > wrote: >> Hello Emil, >> >> >> Emil Velikov wrote: >>> On 30 October 2015 at 11:16, Tobias Jakobi >>> wrote: Hello Hyungwon, first of all

Re: [PATCH v8 11/17] dt-bindings: add document for rockchip dp phy

2015-10-30 Thread Rob Herring
On Wed, Oct 28, 2015 at 3:31 AM, Yakir Yang wrote: > Add dt binding documentation for rockchip display port PHY. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Yakir Yang Acked-by: Rob Herring > --- > Changes in

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Lee Jones
On Fri, 30 Oct 2015, Alim Akhtar wrote: > RTC found in s2mps15 is almost same as one found on s2mps13 > with few differences in RTC_UPDATE register fields, like: > 1> Bit[4] and Bit[1] are reversed >- On s2mps13 > WUDR -> bit[4], AUDR -> bit[1] >- On s2mps15 > WUDR ->

Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-10-30 Thread Lee Jones
On Fri, 30 Oct 2015, Alim Akhtar wrote: > From: Thomas Abraham > > Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device > is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. > This also supports RTC and three 32.768KHz clock

Re: [PATCH 08/13] exynos: fimg2d: add g2d_set_direction

2015-10-30 Thread Tobias Jakobi
Tobias Jakobi wrote: > Hello Hyungwon, > > > Hyungwon Hwang wrote: >> On Tue, 22 Sep 2015 17:54:57 +0200 >> Tobias Jakobi wrote: >> >>> This allows setting the two direction registers, which specify how >>> the engine blits pixels. This can be used for overlapping

Re: [PATCH v8 09/17] dt-bindings: add document for rockchip variant of analogix_dp

2015-10-30 Thread Rob Herring
On Wed, Oct 28, 2015 at 3:28 AM, Yakir Yang wrote: > Rockchip DP driver is a helper driver of analogix_dp coder driver, > so most of the DT property should be descriped in analogix_dp document. > > Reviewed-by: Heiko Stuebner > Signed-off-by: Yakir Yang

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

2015-10-30 Thread Emil Velikov
On 30 October 2015 at 14:28, Tobias Jakobi wrote: > OK, I see what you mean. However this shouldn't happen as long as the > user properly zero initializes the event context structures, right? > It pains me to say it but in this day and age, not everyone zero

Re: [PATCH] mfd: sec-core: Remove unused s2mpu02-rtc and s2mpu02-clk children

2015-10-30 Thread Chanwoo Choi
Hi, On 2015년 10월 30일 16:51, Krzysztof Kozlowski wrote: > The commit 54e8827d5f0e ("mfd: sec-core: Add support for S2MPU02 > device") added new MFD child devices for S2MPU02: RTC and clock > provider (the clock provider with new compatible). However support for > these devices was not added to

Re: [PATCH v5 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-30 Thread Alim Akhtar
Hi Krzysztof, On 10/30/2015 02:08 PM, Krzysztof Kozlowski wrote: On 30.10.2015 15:25, Alim Akhtar wrote: RTC found in s2mps15 is almost same as one found on s2mps13 with few differences in RTC_UPDATE register fields, like: 1> Bit[4] and Bit[1] are reversed - On s2mps13 WUDR ->

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

2015-10-30 Thread Tobias Jakobi
Hello Emil, Emil Velikov wrote: > On 30 October 2015 at 11:16, Tobias Jakobi > wrote: >> Hello Hyungwon, >> >> first of all thanks for reviewing the series! >> >> >> >> Hyungwon Hwang wrote: >>> On Tue, 22 Sep 2015 17:54:55 +0200 >>> Tobias Jakobi