Re: [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-11-05 Thread Krzysztof Kozlowski
On 05.11.2015 16:59, Pavel Fedin wrote: > Hello! > >>> This patchset also depends on Exynos 5410 pinctrl support, introduced by >>> patches 0003 and 0004 from this set: >>> [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs >>>

Re: [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-11-05 Thread Krzysztof Kozlowski
On 05.11.2015 17:44, Pavel Fedin wrote: > Hello! > > This patchset also depends on Exynos 5410 pinctrl support, introduced by > patches 0003 and 0004 from this set: > [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs >

RE: [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-11-05 Thread Pavel Fedin
Hello! > > This patchset also depends on Exynos 5410 pinctrl support, introduced by > > patches 0003 and 0004 from this set: > > [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/330862.html > > Only

RE: [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-11-05 Thread Pavel Fedin
Hello! > >>> This patchset also depends on Exynos 5410 pinctrl support, introduced by > >>> patches 0003 and 0004 from this set: > >>> [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs > >>> http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/330862.html > >> > >> Only the first

RE: [PATCH v5 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-11-05 Thread Pavel Fedin
Hello! > > This patchset also depends on Exynos 5410 pinctrl support, introduced by > > patches 0003 and 0004 from this set: > > [PATCH v4 0/5] ARM: EXYNOS: ODROID-XU DT and LEDs > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-March/330862.html > > Only the first patch made up to

RE: [PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration

2015-11-05 Thread Pavel Fedin
Hello! > > +static int decode_sromc(struct exynos_srom *srom, struct device_node *np) > > I missed that one previously: add prefix and more descriptive name, like: > exynos_srom_parse_child() exynos_srom_configure_bank(), is this name OK? > > static int exynos_srom_probe(struct

RE: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410

2015-11-05 Thread Pavel Fedin
Hello! > > + ethernet@3 { > > + compatible = "smsc,lan9115"; > > + reg = <3 0 0x1>; > > + phy-mode = "mii"; > > + interrupt-parent = <>; > > + interrupts = <5 8>; > > s/8/IRQ_TYPE_LEVEL_LOW/ > (is this really level low interrupt?) Yes,

[PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node

2015-11-05 Thread Alim Akhtar
This patch add pmic (s2mps15) node of espresso board, which includes addition of regulators and pmic-clk sub-nodes. This patch also adds {vmmc,vqmmc}-supply properties for mmc2 node. Signed-off-by: Abhilash Kesavan Signed-off-by: Alim Akhtar

[PATCH v2 2/2] arm64: dts: exynos7: Enable HS200 mode operation

2015-11-05 Thread Alim Akhtar
This patch enables HS200 mode operation on exynos7 based espresso board. This also removes _broken-cd_ property as per mmc binding documentation which says one of the properties between broken-cd and non-removable should be used. And we already use _non-removable_ as emmc mounted on board which is

[PATCH v6 4/4] ARM: dts: Add Ethernet chip to SMDK5410

2015-11-05 Thread Pavel Fedin
The chip is smsc9115, connected via SROMc bank 3. Additionally, some GPIO initialization is required. Signed-off-by: Pavel Fedin --- arch/arm/boot/dts/exynos5410-smdk5410.dts | 41 +++ arch/arm/boot/dts/exynos5410.dtsi | 6 + 2 files

[PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-05 Thread Pavel Fedin
Add documentation for new subnode properties, allowing bank configuration. Based on u-boot implementation, but heavily reworked. Also, fix size of SROMc mapping in the example. Signed-off-by: Pavel Fedin --- .../bindings/arm/samsung/exynos-srom.txt | 71

Re: [PATCH v5 3/4] drivers: exynos-srom: Add support for bank configuration

2015-11-05 Thread Krzysztof Kozlowski
W dniu 05.11.2015 o 19:40, Pavel Fedin pisze: > Hello! > >>> +static int decode_sromc(struct exynos_srom *srom, struct device_node *np) >> >> I missed that one previously: add prefix and more descriptive name, like: >> exynos_srom_parse_child() > > exynos_srom_configure_bank(), is this name

Re: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410

2015-11-05 Thread Krzysztof Kozlowski
W dniu 05.11.2015 o 20:14, Pavel Fedin pisze: > Hello! > >>> + ethernet@3 { >>> + compatible = "smsc,lan9115"; >>> + reg = <3 0 0x1>; >>> + phy-mode = "mii"; >>> + interrupt-parent = <>; >>> + interrupts = <5 8>; >> >>

RE: [PATCH v5 4/4] ARM: dts: Add Ethernet chip to SMDK5410

2015-11-05 Thread Pavel Fedin
Hello! > >>> + ethernet@3 { > >>> + compatible = "smsc,lan9115"; > >>> + reg = <3 0 0x1>; > >>> + phy-mode = "mii"; > >>> + interrupt-parent = <>; > >>> + interrupts = <5 8>; > >> > >> s/8/IRQ_TYPE_LEVEL_LOW/ > >> (is this really level low interrupt?)

[PATCH v6 0/4] Exynos SROMc configuration and Ethernet support for SMDK5410

2015-11-05 Thread Pavel Fedin
This patch extends Exynos SROM controller driver with ability to configure controller outputs and enables SMSC9115 Ethernet chip on SMDK5410 board, which is connected via SROMc bank #3. With this patchset, support for the whole existing SMDK range can be added. Actually, only bank number is

[PATCH v6 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-11-05 Thread Pavel Fedin
This machine uses own SoC device tree file, add missing part. Signed-off-by: Pavel Fedin --- arch/arm/boot/dts/exynos5410.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/exynos5410.dtsi b/arch/arm/boot/dts/exynos5410.dtsi index

[PATCH v6 3/4] drivers: exynos-srom: Add support for bank configuration

2015-11-05 Thread Pavel Fedin
Implement handling properties in subnodes and adding child devices to the system. Child devices will not be added if configuration fails. Since the driver now does more than suspend-resume support, dependency on CONFIG_PM is removed. Signed-off-by: Pavel Fedin ---

Re: [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node

2015-11-05 Thread Krzysztof Kozlowski
On 05.11.2015 20:52, Alim Akhtar wrote: > This patch add pmic (s2mps15) node of espresso board, > which includes addition of regulators and pmic-clk sub-nodes. My comment for fixing capital letters was ignored. Do you disagree with it? > > This patch also adds {vmmc,vqmmc}-supply properties for

Re: [PATCH v9 10/17] phy: Add driver for rockchip Display Port PHY

2015-11-05 Thread Brian Norris
Hi, A few updates: On Tue, Nov 03, 2015 at 05:13:48PM -0800, Brian Norris wrote: > On Wed, Nov 04, 2015 at 08:48:38AM +0800, Yakir Yang wrote: > > On 11/03/2015 12:38 PM, Brian Norris wrote: > > >On Thu, Oct 29, 2015 at 09:58:38AM +0800, Yakir Yang wrote: > > >(FYI, I came across this by

Re: [PATCH v2 2/2] arm64: dts: exynos7: Enable HS200 mode operation

2015-11-05 Thread Krzysztof Kozlowski
On 05.11.2015 20:52, Alim Akhtar wrote: > This patch enables HS200 mode operation on exynos7 based > espresso board. > This also removes _broken-cd_ property as per mmc binding documentation > which says one of the properties between broken-cd and non-removable > should be used. And we already use

Re: [PATCH v6 1/4] Documentation: dt-bindings: Describe SROMc configuration

2015-11-05 Thread Krzysztof Kozlowski
On 05.11.2015 21:03, Pavel Fedin wrote: > Add documentation for new subnode properties, allowing bank configuration. > Based on u-boot implementation, but heavily reworked. > > Also, fix size of SROMc mapping in the example. > > Signed-off-by: Pavel Fedin > --- >

Re: [PATCH v2 1/2] arm64: dts: exynos7: Add pmic s2mps15 device tree node

2015-11-05 Thread Alim Akhtar
On Fri, Nov 6, 2015 at 5:25 AM, Krzysztof Kozlowski wrote: > On 05.11.2015 20:52, Alim Akhtar wrote: >> This patch add pmic (s2mps15) node of espresso board, >> which includes addition of regulators and pmic-clk sub-nodes. > > My comment for fixing capital letters was

Re: [PATCH v6 2/4] ARM: dts: Add SROMc to Exynos 5410

2015-11-05 Thread Krzysztof Kozlowski
On 05.11.2015 21:03, Pavel Fedin wrote: > This machine uses own SoC device tree file, add missing part. > > Signed-off-by: Pavel Fedin > --- > arch/arm/boot/dts/exynos5410.dtsi | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Krzysztof Kozlowski

Re: [PATCH v3 0/7] samsung: pmu: split up SoC specific PMU data

2015-11-05 Thread Krzysztof Kozlowski
On 05.11.2015 14:27, Pankaj Dubey wrote: > Hi Krzysztof, > > On Tuesday 03 November 2015 07:36 AM, Krzysztof Kozlowski wrote: >> On 26.10.2015 21:55, Pankaj Dubey wrote: >>> This patch series is a part of continuation work from following series >>> [1] and [2]. >>> >>> 1: exynos: Move pmu driver

Re: [PATCH v3 7/7] drivers: soc: Add support for Exynos PMU driver

2015-11-05 Thread Krzysztof Kozlowski
On 05.11.2015 14:31, Pankaj Dubey wrote: > Hi Krzysztof, > > On Tuesday 03 November 2015 07:52 AM, Krzysztof Kozlowski wrote: > >> >> 1. Please reorder the exynos_sys_powerdown_conf() to be after the >> statics. I am thinking also about adding EXPORT_SYMBOL... but maybe this >> would be

[PATCH v3 1/2] arm64: dts: exynos7: Add PMIC S2MPS15 device tree node

2015-11-05 Thread Alim Akhtar
This patch adds PMIC (S2MPS15) node of espresso board, which includes addition of regulators and pmic-clk sub-nodes. This patch also adds {vmmc,vqmmc}-supply properties for mmc2 node. Signed-off-by: Abhilash Kesavan Signed-off-by: Alim Akhtar

[PATCH v3 2/2] arm64: dts: exynos7: Enable HS200 mode operation

2015-11-05 Thread Alim Akhtar
This patch enables HS200 mode operation on exynos7 based espresso board. This also removes _broken-cd_ property as per mmc binding documentation which says one of the properties between broken-cd and non-removable should be used. And we already use _non-removable_ as emmc mounted on board which is