Re: [PATCH] MAINTAINERS: update email address and cleanup for exynos entry

2014-11-17 Thread Ben Dooks
On 14/11/14 07:54, Kukjin Kim wrote: Use kernel.org account instead of samsung.com and cleanup for Samsung s3c, s5p and exynos SoCs. Cc: Ben Dooks ben.do...@codethink.co.uk I do wish these would be sent to the mail address I use for Linux related issues. I only want to see work related Linux

Re: [PATCH] spi: s3c24xx: Convert to use devm_kzalloc

2014-04-03 Thread Ben Dooks
On Mon, Mar 31, 2014 at 11:37:29AM +0800, Axel Lin wrote: Simplify the cleanup code. Signed-off-by: Axel Lin axel@ingics.com Acked-by: Ben Dooks ben-li...@fluff.org --- drivers/spi/spi-s3c24xx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers

Re: [PATCH] watchdog: s3c2410_wdt: Only register for cpufreq on CPU_FREQ_S3C24XX

2013-11-25 Thread Ben Dooks
On Mon, Nov 25, 2013 at 02:55:37PM -0800, Doug Anderson wrote: On modern SoCs the watchdog timer is parented on a clock that doesn't change every time we have a cpufreq change. That means we don't need to constantly adjust the watchdog timer, so avoid registering for and dealing with cpufreq

Re: [PATCH] ARM: plat-samsung: using vsnprintf instead of vsprintf for the limit buffer length 256

2013-01-21 Thread Ben Dooks
); + vsnprintf(buff, 256, fmt, va); How about: vsnprintf(buff, sizeof(buff), fmt, va); It means we do not end up assuming the size of 'buff' and will be correct if the code is changed to declare 'buff' to be a different size. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada

Re: [PATCH] ARM: samsung: adc: fix race in s3c_adc_start

2012-07-12 Thread Ben Dooks
On Wed, Jul 11, 2012 at 07:12:11PM -0700, Todd Poynor wrote: Checking for adc-ts_pend already claimed should be done with the lock held. Change-Id: Ic9f15e26bd19934ab8c2885ce5df265933ac304a Signed-off-by: Todd Poynor toddpoy...@google.com Acked-by: Ben Dooks ben-li...@fluff.org

Re: [PATCH] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Ben Dooks
On Sun, Jan 22, 2012 at 09:39:53PM +, Mark Brown wrote: On Sun, Jan 22, 2012 at 06:48:36PM +0100, Sylwester Nawrocki wrote: On 01/22/2012 06:27 PM, Bill Gatliff wrote: I for one would rather see in-kernel drivers that require it, and then In fact we have to deal with the opposite

Re: [PATCH 1/2] i2c-s3c2410: Convert to devm_kzalloc()

2012-02-13 Thread Ben Dooks
On Sat, Jan 21, 2012 at 05:10:22PM +0100, Sylwester Nawrocki wrote: On 01/21/2012 02:28 PM, Mark Brown wrote: Saves remembering to call kfree(). There's some kfree()s used by the resource still, these will be removed in 3.3 using the newly added devm_request_and_ioremap().

Re: [PATCH 2/2] i2c-s3c2410: Add stub runtime power management

2012-02-13 Thread Ben Dooks
On Sat, Jan 21, 2012 at 01:28:47PM +, Mark Brown wrote: Add stub runtime_pm calls which go through the flow of enabling and disabling but don't actually do anything with the device itself as there's nothing useful we can do. This provides the core PM framework with information about when

Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume

2012-02-13 Thread Ben Dooks
On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: From: Kisoo Yu ksoo...@samsung.com need to set flag after finishing its work Signed-off-by: Kisoo Yu ksoo...@samsung.com Signed-off-by: Huisung Kang hs1218.k...@samsung.com --- drivers/i2c/busses/i2c-s3c2410.c |2 +- 1

Re: [PATCH] i2c-s3c2410: move resume state flag to end of resume

2012-02-13 Thread Ben Dooks
On Sun, Feb 12, 2012 at 01:12:31PM +, Mark Brown wrote: On Sat, Feb 11, 2012 at 12:22:21PM +0900, Huisung Kang wrote: From: Kisoo Yu ksoo...@samsung.com need to set flag after finishing its work - i2c-suspended = 0; clk_enable(i2c-clk); s3c24xx_i2c_init(i2c);

Re: [PATCH v3 0/2] Add device tree support for Samsung's I2C driver

2011-09-15 Thread Ben Dooks
On Tue, Sep 13, 2011 at 09:46:03AM +0530, Thomas Abraham wrote: This patchset adds device tree support for Samsung's I2C driver. I've applied these after a brief review. I'll give them a better review before the weekend. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/4] serial: s5pv210: Add device tree support

2011-08-03 Thread Ben Dooks
instance of port info is updated with the fifosize value and attached to the driver's private data. The default platform data is selected based on the compatible property. CC: Ben Dooks ben-li...@fluff.org Signed-off-by: Thomas Abraham thomas.abra...@linaro.org --- .../devicetree/bindings/serial

Re: [PATCH v2 0/3] Add device tree support for Samsung's I2C driver

2011-07-27 Thread Ben Dooks
/samsung-i2c.txt -- To unsubscribe from this list: send the line unsubscribe linux-i2c in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large

Re: [PATCH 2/2] arm: dt: Add device tree support for i2c instance 1 on exynos4 dt machine

2011-07-18 Thread Ben Dooks
part of the SoC, I don't really want to see n different .dts files hanging around with the same information in it. Maybe it is time for a standardised callback to allow devices to connect themselves to the pins they need, and have dt capability of over-riding the information if it needs it. -- Ben

Re: [PATCH] I2C: Samsung: Add support for PM_runtime in the I2C driver.

2011-03-27 Thread Ben Dooks
) -- 1.7.1 ___ linux-arm-kernel mailing list linux-arm-ker...@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada

Re: [PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C

2011-03-25 Thread Ben Dooks
On Fri, Mar 25, 2011 at 08:12:06AM +0530, Tushar Behera wrote: Hi Ben, On 24 March 2011 16:17, Ben Dooks ben-...@fluff.org wrote: On Thu, Mar 24, 2011 at 02:36:13PM +0530, Tushar Behera wrote: On Samsung Kconfig files, HAVE_S3C2410_I2C is selected if we want to enable support for I2C

Re: [PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C

2011-03-24 Thread Ben Dooks
. No. Do not do this, just having the device on the board does not mean you want it forced into the kernel. A user may want to build it as a module or not build it at-all. -- Ben Dooks, b...@fluff.org, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe

Re: [PATCH] mmc: mshci: Add support Mobile Storage Host Controller Interface

2011-01-07 Thread Ben Dooks
On Fri, Jan 07, 2011 at 12:51:23PM +0100, Wolfram Sang wrote: The 'mshci.c' is based on 'linux/drivers/mmc/host/sdhci.c' and the role is exactly same with that. Can you sum up the differences why you cannot sdhci.c directly, please? I second that. -- Ben Dooks, b...@fluff.org, http

Re: [PATCH 3/3] ARM: S3C64XX: Use chip_data to store the shift for EINTs

2010-12-07 Thread Ben Dooks
On 01/12/10 11:55, Mark Brown wrote: On Wed, Dec 01, 2010 at 08:44:25PM +0900, Kukjin Kim wrote: Mark Brown wrote: This makes all the functions that use the shift slightly smaller, one instruction in most cases but more for ack() and maskack(). Uhm...I'm not sure to use chip_data for the

Re: CpuFreq for mini2440

2010-12-07 Thread Ben Dooks
On 03/12/10 01:12, tarek attia wrote: Hi all, I tried many times to enable the Cpufreq for the mini2440 Friendly Arm board but each time I enable it in the kernel it ended up by a successful compilation ,but when I mount the kernel image on the board ,just I dun find it's folder nor it's

Re: [PATCH 2/2] h1940-leds: Fix compile issue introduced by latch-related changes

2010-11-16 Thread Ben Dooks
On 08/11/10 20:31, Vasily Khoruzhick wrote: Latch API was converted to gpiolib API as result we got this compile error: drivers/leds/leds-h1940.c: In function 'h1940_greenled_set': drivers/leds/leds-h1940.c:33: error: implicit declaration of function 'h1940_latch_control Adapt h1940-leds

Re: [PATCH] ARM: SAMSUNG: Add the missed s3c_gpio_getpull() API

2010-10-21 Thread Ben Dooks
: Ben Dooks ben-li...@fluff.org Signed-off-by: Kukjin Kim kgene@samsung.com --- NOTE: - already issued about this arch/arm/plat-samsung/gpio-config.c| 19 +++ .../plat-samsung/include/plat/gpio-cfg-helpers.h |6 ++ 2 files changed, 25

Re: [PATCH 1/5] ARM: S5P6442: Add DMA operation clock

2010-10-21 Thread Ben Dooks
On 21/10/10 01:58, Kukjin Kim wrote: From: Seungwhan Youn sw.y...@samsung.com This patch adds DMA operation clock which is disabled as default. Signed-off-by: Seungwhan Youn sw.y...@samsung.com Acked-by: Jassi Brar jassi.b...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com

Re: [PATCH 3/4] USB: Gadget: Add Samsung S3C24XX USB High-Speed controller driver

2010-10-21 Thread Ben Dooks
On 13/10/10 01:10, Sangbeom Kim wrote: From: Thomas Abraham thomas...@samsung.com The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed device controller module. This driver enables support for USB high-speed gadget functionality for the Samsung S3C24xx SoC's that include this

Re: [PATCH 0/4] USB: gadget: Add Samsung S3C24xx USB HS controller driver

2010-10-21 Thread Ben Dooks
On 13/10/10 01:10, Sangbeom Kim wrote: The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed device controller module. This driver enables support for USB high-speed gadget functionality for the Samsung S3C24xx SoC's that include this controller. The patch series contains:

Re: [PATCH 2/2] ARM: S5PV310: Add external interrupt support

2010-10-18 Thread Ben Dooks
On 18/10/10 06:06, Jongsun Han wrote: All external interrupts are transferred to GIC through interrupt combiner. Signed-off-by: Jongsun Han jongsun@samsung.com Signed-off-by: Jongpill Lee boyko@samsung.com --- arch/arm/mach-s5pv310/Makefile |2 +-

Re: [PATCH] ARM: SAMSUNG: Bug fix spin_lock recursion in clk_enable() and clk_disable()

2010-10-18 Thread Ben Dooks
On 12/10/10 01:39, Jaecheol Lee wrote: From: Minho Ban mh...@samsung.com The clk_enable() and clk_disable() can be used process and ISR either. So spin_lock_irqsave should be used instead. Signed-off-by: Minho Ban mh...@samsung.com Signed-off-by: Jaecheol Lee jc@samsung.com ---

Re: [PATCH 1/2] ARM: S3C64XX: Add suspend support

2010-10-06 Thread Ben Dooks
On 06/10/10 00:23, Kyungmin Park wrote: Hi, I agree your approach, put the common features in common place. but Samsung maintainers insist put these at each machine file at current time. This is just an init call, the actuall implementation is common to the core. We did it this was as it was

Re: [PATCH] ARM: S5PC100: Bug fix EPLL_CON MASK settings

2010-09-28 Thread Ben Dooks
On Tue, Sep 28, 2010 at 06:23:24PM +0900, Kukjin Kim wrote: From: Seungwhan Youn sw.y...@samsung.com This patch fixes EPLL_CON MASK settings which did not contain its shift values when set epll rate on S5PC100. Signed-off-by: Seungwhan Youn sw.y...@samsung.com Signed-off-by: Kukjin Kim

Re: [PATCH] ARM: s3c2442: gta02: Fix usage gpio bank j pin definitions

2010-09-26 Thread Ben Dooks
On 24/09/10 19:24, Lars-Peter Clausen wrote: The gta02 header file still uses the old S3C2410_GPJx defines instead of the S3C2410_GPJ(x) macro. Since the S3C2410_GPJx defines have already been removed this causes a build failure. This patches fixes the issue by doing a

Re: [PATCH] ARM: s3c2442: Setup gpio {set,get}_pull callbacks

2010-09-20 Thread Ben Dooks
On 20/09/10 23:00, Lars-Peter Clausen wrote: Currently the {set,get}_pull callbacks of the s3c24xx_gpiocfg_default structure are not initalized for the s3c2442 cpu type. This results in a NULL-pointer deref upon calling s3c_gpio_setpull. The s3c2442 has pulldowns instead of pullups

Re: [PATCH 0/3] rx1950: add rest of devices

2010-09-07 Thread Ben Dooks
On 07/09/10 15:32, Vasily Khoruzhick wrote: This series adds battery device, LEDs device and sound codec device to mach-rx1950.c the first one has a few issues, the others look fine. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to

Re: [PATCH 1/5] rtc: rtc-s3c: Fix access unit from byte to word on RTCCON

2010-09-07 Thread Ben Dooks
@samsung.com Cc: Ben Dooks ben-li...@fluff.org Anyone else tried this on s3c24xx? -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/5] rtc: rtc-s3c: Fix setting missing field of getalarm

2010-09-07 Thread Ben Dooks
. Signed-off-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org Acked-By: Ben Dooks ben-li...@fluff.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH 3/5] rtc: rtc-s3c: Fix on support RTC Alarm

2010-09-07 Thread Ben Dooks
kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org oops. wonder how long that's been broken for. Acked-by: Ben Dooks ben-li...@fluff.org -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 4/5] rtc: rtc-s3c: Fix on RTC initialization method

2010-09-07 Thread Ben Dooks
previous method cannot validate RTC BCD registers properly. Signed-off-by: Changhwan Youn chaos.y...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org Cc: Wan ZongShun mcuos@gmail.com --- drivers/rtc/rtc-s3c.c | 16 +++- 1 files

Re: [PATCH 5/5] rtc: rtc-s3c: Fix debug message format on RTC

2010-09-07 Thread Ben Dooks
On 07/09/10 06:29, Kukjin Kim wrote: This patch fixes debug message format on rtc-s3c. Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org --- drivers/rtc/rtc-s3c.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) how long has

Re: [PATCH 1/2] s3c24xx: DMA: don't use autoreload feature

2010-09-07 Thread Ben Dooks
On 08/09/10 00:23, Vasily Khoruzhick wrote: Some integrated DMA-capable hardware doesn't like autoreload feature of s3c24xx DMA-engine, that's why s3cmci driver didn't work with DMA transfers enabled. I rewrote DMA driver not to use autoreload feature and removed all pre-loading features.

Re: [PATCH 00/13] ARM: S5P64X0: Add new S5P6450 Support

2010-09-01 Thread Ben Dooks
On Wed, Sep 01, 2010 at 04:09:07PM +0900, Kukjin Kim wrote: This patches add basic support for Samsung S5P6450 SoC. Basically this patch moves mach-s5p6440 (ARCH_S5P6440) to mach-s5p64x0 (ARCH_S5P64X0) to support Samsung's new S5P6450 SoC. The ARCH_S5P64X0 can support S5P6440 and S5P6450

Re: [PATCH v3 3/3] ARM: SAMSUNG: i2c/busses: Add HAVE_S3C2410_I2C option to include I2C for Samsung SoCs

2010-08-04 Thread Ben Dooks
On 30/07/10 01:22, Kyungmin Park wrote: On Thu, Jul 29, 2010 at 6:42 PM, Kukjin Kim kgene@samsung.com wrote: From: Naveen Krishna Ch ch.nav...@samsung.com This patch adds HAVE_S3C2410_I2C to control inclusion of I2C bus driver on Samsung SoCs and makes I2C bus driver dependency SoC

Re: [PATCH RFC] h1940: use gpiolib for latch access

2010-08-04 Thread Ben Dooks
On 25/07/10 17:41, Vasily Khoruzhick wrote: This patch adds gpiolib support for h1940 latch. With this patch it's possible to use leds-gpio and uda1380 drivers (they require gpiolib support for appropriate pins). And now it's possible to drop leds-h1940 driver. I'm reasonably happy with this,

Re: not coming prompt in 2.6.33.6 kernel

2010-07-28 Thread Ben Dooks
On Wed, Jul 28, 2010 at 08:51:06AM +0530, nitin vishnoi wrote: Hi I am porting the 2.6.33.6 kernel,which i took from kernel.org.I am trying to port it on samsung-s3c2451 board. But i am not getting the shell prompt,due to getting the following error.Any body can tell due to what this error

Re: [PATCHv2 1/4] sdhci-s3c: add support for the non standard minimal clock value

2010-07-28 Thread Ben Dooks
On 28/07/10 15:19, Marek Szyprowski wrote: S3C SDHCI host controller can change the source for generating mmc clock. By default host bus clock is used, what causes some problems on machines with 133MHz bus, because the SDHCI divider cannot be as high get proper clock value for identification

Re: [PATCHv5 3/4] sdhci-s3c: add support for new card detection methods (driver part)

2010-07-28 Thread Ben Dooks
On 28/07/10 15:19, Marek Szyprowski wrote: On some Samsung SoCs not all SDHCI controllers have card detect (CD) line. For some embedded designs it is not even needed, because ususally the device (like SDIO flash memory or wifi controller) is permanently wired to the controller. There are also

Re: [PATCH v5 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT quirk for Samsung SoC

2010-07-28 Thread Ben Dooks
. Signed-off-by: Hyuk Lee hyuk1@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Ben Dooks ben-li...@fluff.org --- Changes since v4: - Address comments from Marek. Hi Andrew, If there are no problems, could you please apply this patch? rn gpio_get_value(ourhost-pdata

Re: [PATCH] ARM: Samsung SoC: clksrc-clk: wait for the stable SRC/DIV status.

2010-07-28 Thread Ben Dooks
On 28/07/10 04:17, MyungJoo Ham wrote: Many MUX and clock dividers have a status bit so that users can wait until the status is stable. When corresponding registers are accessed while a clock is not stable, we may suffer from unexpected errors. Therefore, we introduce a mechanism to let the

Re: [PATCH 3/5] ARM: S5P6440: Add RTC support for S5P6440

2010-07-28 Thread Ben Dooks
On 21/07/10 10:00, Kukjin Kim wrote: From: Atul Dahiya atul.dah...@samsung.com This patch adds support RTC driver for Samsung S5P6440. Signed-off-by: Atul Dahiya atul.dah...@samsung.com Signed-off-by: Kukjin Kim kgene@samsung.com --- arch/arm/mach-s5p6440/Kconfig|2

Re: [PATCH v3 1/7] ARM: S5PV210: Add a Kconfig entry S5PC110_EVT0_WORKAROUND

2010-07-21 Thread Ben Dooks
On 21/07/10 02:13, MyungJoo Ham wrote: On Wed, Jul 21, 2010 at 9:36 AM, Ben Dooks b...@simtec.co.uk wrote: On 07/19/10 06:31, MyungJoo Ham wrote: Early S5PC110 (EVT0) chip had some issues required workaround from a kernel. We can add such workaround codes with this Kconfig entry. Signed-off

[PATCH 03/11] USB: s3c-hsotg: Avoid overwriting contents of perodic in 'fifo'

2010-07-19 Thread Ben Dooks
are fixing the case that this may happen. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index 4a25145..354fd45

[PATCH 11/11] USB: s3c-hsotg: Add support for external USB clock

2010-07-19 Thread Ben Dooks
USB external clock definition Signed-off-by: Maurus Cuelenaere mcuelena...@gmail.com Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers

[PATCH 07/11] USB: s3c-hsotg: Check for new request before enqueing new setup

2010-07-19 Thread Ben Dooks
all the data as we start waiting for a new OUT transaction Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index df6a39d..10aeee1

[PATCH 08/11] USB: s3c-hsotg: Fix max EP0 IN request length

2010-07-19 Thread Ben Dooks
The maximum length for any EP0 IN request on EP0 is 127 bytes, not 128 as the driver currently has it. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b

[PATCH 01/11] USB: s3c-hsotg: Increase TX fifo limit

2010-07-19 Thread Ben Dooks
the max-packet size to TXFIFOSIZE, since the TXFIFOSIZE depends on how the TX FIFOs have been setup. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb

S3C HSOTG fixes

2010-07-19 Thread Ben Dooks
Repost of the series as requested by Greg. Fixes a number of problems with the hsotg block on Samsung devices, including FIFO reset issues, data sizes, dealing with core compilation options, et al. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a

[PATCH 01/11] USB: s3c-hsotg: Increase TX fifo limit

2010-07-07 Thread Ben Dooks
the max-packet size to TXFIFOSIZE, since the TXFIFOSIZE depends on how the TX FIFOs have been setup. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb

[PATCH 09/11] USB: s3c-hsotg: Fix the OUT EP0 limit

2010-07-07 Thread Ben Dooks
The EP0 out limit is the same as the IN limit, so make them the same. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index

[PATCH 07/11] USB: s3c-hsotg: Check for new request before enqueing new setup

2010-07-07 Thread Ben Dooks
all the data as we start waiting for a new OUT transaction Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers/usb/gadget/s3c-hsotg.c index df6a39d..10aeee1

[PATCH 10/11] USB: s3c-hsotg: Fix OUT packet request retry

2010-07-07 Thread Ben Dooks
of a transfer). Also, move the debug message about the current transfer state before the warning about a bad transfer. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c | 18 +++--- 1 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/usb

[PATCH 04/11] USB: s3c-hsotg: Re-initialise all FIFOs on USB bus reset

2010-07-07 Thread Ben Dooks
The USB documentation suggest that the FIFOs should be reset when a bus reset event happens. Use the s3c_hsotg_init_fifo() to ensure that the FIFO layout is correct and that the FIFOs are flushed before acknowledging the reset. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget

[PATCH 08/11] USB: s3c-hsotg: Fix max EP0 IN request length

2010-07-07 Thread Ben Dooks
The maximum length for any EP0 IN request on EP0 is 127 bytes, not 128 as the driver currently has it. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b

[PATCH 11/11] USB: s3c-hsotg: Add support for external USB clock

2010-07-07 Thread Ben Dooks
USB external clock definition Signed-off-by: Maurus Cuelenaere mcuelena...@gmail.com Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsotg.c b/drivers

[PATCH 05/11] USB: s3c-hsotg: Add initial detection and setup for dedicated FIFO mode

2010-07-07 Thread Ben Dooks
cannot re-allocate space to the individual IN FIFOs as they are already maxed out (to be confirmed). Signed-off-by: Ben Dooks ben-li...@fluff.org --- .../arm/plat-samsung/include/plat/regs-usb-hsotg.h |2 + drivers/usb/gadget/s3c-hsotg.c | 40 +++- 2 files

[PATCH 06/11] USB: s3c-hsotg: Only load packet per fifo write

2010-07-07 Thread Ben Dooks
Limit the IN FIFO write to a single packet per attempt at writing, as per the specifications and ensure that we don't return fifo-full so that we can continue writing packets if we have the space. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c | 11

[PATCH 02/11] USB: s3c-hsotg: The NPTX/PTX FIFO sizes are in words, not bytes

2010-07-07 Thread Ben Dooks
or start addresses available to userspace as we assume the user can multiply by four easily and is already knows these values are in words. Signed-off-by: Ben Dooks ben-li...@fluff.org --- drivers/usb/gadget/s3c-hsotg.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers

Re: [PATCH v3 01/12] s3c-fb: Fix various null references on framebuffer memory alloc failure

2010-07-02 Thread Ben Dooks
On 28/06/10 09:08, Pawel Osciak wrote: The following problems were found in the above situation: sfb-windows[win] was being assigned at the end of s3c_fb_probe_win only. This resulted in passing a NULL to s3c_fb_release_win if probe_win returned early and a memory leak.

Re: [PATCH v3 02/12] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register

2010-07-02 Thread Ben Dooks
On 28/06/10 09:08, Pawel Osciak wrote: FRAMESEL1 bitfield starts on 13th bit, not on 14th. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com Acked-by: Ben Dooks ben-li...@fluff.org -- To unsubscribe from this list: send the line

Re: [PATCH v3 03/12] s3c-fb: Separate S5PC100 and S5PV210 framebuffer driver data structures

2010-07-02 Thread Ben Dooks
On 28/06/10 09:08, Pawel Osciak wrote: S5PC100 and S5PV210 framebuffer devices differ slightly in terms of available registers and their driver data structures have to be separate. Would have been nice to note which ones changes, otherwise ok. -- To unsubscribe from this list: send the line

Re: [PATCH v3 04/12] s3c-fb: Add device name initialization

2010-07-02 Thread Ben Dooks
On 28/06/10 09:08, Pawel Osciak wrote: Add framebuffer device name initialization calls for S3C2443, S3C64xx and S5P machines. ok, if we don't sort out a better system before the next window then this should be ok. -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH v3 06/12] s3c-fb: Add wait for VSYNC ioctl

2010-07-02 Thread Ben Dooks
On 28/06/10 09:08, Pawel Osciak wrote: Add VSYNC interrupt support and an ioctl that allows waiting for it. Interrupts are turned on only when needed. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v3 09/12] s3c-fb: Correct window osd size and alpha register handling

2010-07-02 Thread Ben Dooks
On 28/06/10 09:08, Pawel Osciak wrote: S3C64xx and S5P OSD registers for OSD size and alpha are as follows: VIDOSDC: win 0 - size, win 1-4: alpha VIDOSDD: win 1-2 - size; not present for windows 0, 3 and 4 Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH 2/3] ARM: S5PV210: Add support SDMMC WP through EXT_INT on SMDKV210

2010-06-15 Thread Ben Dooks
On Tue, Jun 15, 2010 at 08:27:47PM +0900, Kukjin Kim wrote: From: Lee Hyuk hyuk1@samsung.com S5PV210 HSMMC host controller doesn't have the Write Protection pin which should be connnected with SDMMC card WP pin. So allocated a GPIO in order to get the data from SDMMC card WP pin with

Re: [PATCH 1/3] ARM: SAMSUNG: Add the member of platdata to implement SDMMC Write Protection

2010-06-15 Thread Ben Dooks
On Tue, Jun 15, 2010 at 08:27:46PM +0900, Kukjin Kim wrote: From: Lee Hyuk hyuk1@samsung.com This patch adds the members of platdata which are cfg_wp and get_ro. The cfg_wp is the function for setting the specific GPIO for WP pin and get_ro is the function for getting data from the

Re: [PATCH 3/3] sdhci-s3c: Add SDHCI_QUIRK_NO_WP_BIT for Samsung SoC

2010-06-15 Thread Ben Dooks
On Tue, Jun 15, 2010 at 08:27:48PM +0900, Kukjin Kim wrote: From: Lee Hyuk hyuk1@samsung.com S5PV210 HSMMC host controller doesn't have the WP pin which should be connnected with SDMMC card WP pin. So if there are the cfg_wp and get_ro in pdata, configure the WP pin and replace get_ro

Re: [PATCH v3] libata: pata_samsung_cf: Add Samsung PATA controller driver

2010-06-10 Thread Ben Dooks
On Thu, Jun 10, 2010 at 02:43:34PM +0400, Sergei Shtylyov wrote: Kukjin Kim wrote: From: Abhilash Kesavan a.kesa...@samsung.com Adds support for the Samsung PATA controller. This driver is based on the Libata subsystem and references the earlier patches sent for IDE subsystem.

Re: [PATCH v3] libata: pata_samsung_cf: Add Samsung PATA controller driver

2010-06-10 Thread Ben Dooks
On Thu, Jun 10, 2010 at 04:50:41PM +0900, Kukjin Kim wrote: From: Abhilash Kesavan a.kesa...@samsung.com Adds support for the Samsung PATA controller. This driver is based on the Libata subsystem and references the earlier patches sent for IDE subsystem. Signed-off-by: Abhilash Kesavan

Re: [PATCH 3/3] s5pv210: Aquila: add definitions for sdhci devices

2010-06-10 Thread Ben Dooks
On Wed, Jun 09, 2010 at 11:39:05AM +0200, Marek Szyprowski wrote: This patch add support for SDHCI blocks on Samsung Aquila board. The following host controllers are defined: 1. Internal MoviNAND device (permanently wired to the controller) 2. Internal WiFI SDIO device (card is activated by

Re: [PATCH 1/5] sdhci-s3c: depend on plat-samsung

2010-06-10 Thread Ben Dooks
On Fri, Jun 11, 2010 at 09:29:38AM +0900, Kukjin Kim wrote: Marek Szyprowski wrote: Most Samsung SoC have support for SDHCI block, so make the driver dependent on the Samsung platform instead on listing all SoCs in the Kconfig (and updating it again when support for the new SoC variant

Re: [PATCH 0/6] Various s3c-fb updates

2010-06-10 Thread Ben Dooks
On Mon, May 31, 2010 at 11:08:49AM +0200, Pawel Osciak wrote: Hello, This series is rebased onto Ben Dook's framebuffer branch available at: git://git.fluff.org/bjdooks/linux.git dev/s3c-fb I'll look at updating this series once I am back in the uk, it mostly looks good but I have yet to do

Re: ARM: SAMSUNG: question about cfg_eint field of struct s3c_gpio_cfg

2010-06-02 Thread Ben Dooks
On Mon, May 31, 2010 at 08:22:12PM +0900, Joonyoung Shim wrote: Hi, There is cfg_eint field in struct s3c_gpio_cfg at arch/arm/plat-samsung/include/plat/gpio-cfg.h. I don't know the usage of cfg_eint. It isn't used anywhere or just assigned. Does it need really? It was there for the

Re: [PATCH 6/6] s3c-fb: Add wait for VSYNC ioctl

2010-05-31 Thread Ben Dooks
On Mon, May 31, 2010 at 11:08:55AM +0200, Pawel Osciak wrote: Add VSYNC interrupt support and an ioctl that allows waiting for it. Interrupts are turned on only when needed. Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Ben Dooks
comments as per comments from Ben Dooks 2. Removed redunt #if defined(CONFIG_PM) 3. Removed redunt including header files 4. Removed mach/pm.h and plat/pm-s5p.h 5. Moved 's5pv210_core_save' into machine directory 6. Moved sleep.S into machine directory for S5P SoCs compatibility 7. Added CF

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Ben Dooks
On Tue, Jun 01, 2010 at 12:23:39PM +0900, Kyungmin Park wrote: On Tue, Jun 1, 2010 at 11:03 AM, Ben Dooks ben-li...@fluff.org wrote: On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: From: Jongpill Lee boyko@samsung.com This patch adds suspend-to-ram support for S5PV210

Re: [PATCH 2/6] s3c-fb: Correct FRAMESEL1 bitfield defines for VIDINTCON0 register

2010-05-31 Thread Ben Dooks
On Mon, May 31, 2010 at 11:08:51AM +0200, Pawel Osciak wrote: FRAMESEL1 bitfield starts on 13th bit, not on 14th. is this true for all variants that have FRAMESEL1? Signed-off-by: Pawel Osciak p.osc...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

Re: [PATCH v2] ARM: S5PV210: Add Power Management Support

2010-05-31 Thread Ben Dooks
On Tue, Jun 01, 2010 at 02:13:18PM +0900, MyungJoo Ham wrote: On Tue, Jun 1, 2010 at 11:03 AM, Ben Dooks ben-li...@fluff.org wrote: On Tue, Jun 01, 2010 at 10:36:04AM +0900, Kukjin Kim wrote: From: Jongpill Lee boyko@samsung.com This patch adds suspend-to-ram support for S5PV210

Re: [PATCH 4/4] usb: s3c-hsotg: Enable HCLK for the OTG module.

2010-05-30 Thread Ben Dooks
On Fri, May 28, 2010 at 02:48:25PM +0400, Sergei Shtylyov wrote: Hello. Ben Dooks wrote: From: Thomas Abraham thomas...@samsung.com This patch modifies the following in S3C hsotg driver. 1. Gets a reference to the USB OTG hclk clock and enables it. This is required for plaforms

Re: [PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-30 Thread Ben Dooks
On Fri, May 28, 2010 at 03:24:02PM +0900, Kyungmin Park wrote: Hi, Looks good but I'm afraid it's more difficult to find pin configuration from typo. Do you meant that there's now no explicit mention of all pins invovled? Note, may decided to drop or re-do this series. -- Ben Q:

Re: [PATCH v2 5/5] input: samsung-keypad - Add samsung keypad driver

2010-05-29 Thread Ben Dooks
On Sun, May 30, 2010 at 05:39:50AM +0200, Marek Vasut wrote: Dne Ne 30. kv??tna 2010 05:06:24 Joonyoung Shim napsal(a): This patch adds support for keypad driver running on Samsung cpus. This driver is tested on GONI and Aquila board using S5PC110 cpu. Signed-off-by: Joonyoung Shim

[PATCH 3/9] ARM: SAMSUNG: Default s3c_device_i2c2 to s3c2440-i2c

2010-05-28 Thread Ben Dooks
. Signed-off-by: Ben Dooks ben-li...@fluff.org --- arch/arm/mach-s5pv210/cpu.c |1 - arch/arm/plat-samsung/dev-i2c2.c |3 ++- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-s5pv210/cpu.c b/arch/arm/mach-s5pv210/cpu.c index 987fe1d..8a64ef3 100644 --- a/arch

[PATCH 8/9] ARM: S3C24XX: Use s3c_set_platdata() helper

2010-05-28 Thread Ben Dooks
Commit f8b5ea089d5a447a8933a6540ceeccbcb78f9e53 added a helper to copy and set platform data, so let's replace the various sites in the Samsung support where this is happening. Signed-off-by: Ben Dooks ben-li...@fluff.org --- arch/arm/plat-s3c24xx/devs.c | 23 --- 1 files

[PATCH 4/9] ARM: SAMSUNG: Default s3c_device_i2c0 to s3c2440-i2c

2010-05-28 Thread Ben Dooks
The bulk of the SoCs implement the s3c2440-i2c variant of this block, so change the default name to s3c2440-i2c and rename the cases where it is s3c2410. Signed-off-by: Ben Dooks ben-li...@fluff.org --- arch/arm/mach-s3c2410/s3c2410.c |3 +++ arch/arm/mach-s3c2412/s3c2412.c |3

[PATCH 7/9] ARM: SAMSUNG: Use s3c_set_platdata() helper

2010-05-28 Thread Ben Dooks
Commit f8b5ea089d5a447a8933a6540ceeccbcb78f9e53 added a helper to copy and set platform data, so let's replace the various sites in the Samsung support where this is happening. Signed-off-by: Ben Dooks ben-li...@fluff.org --- arch/arm/plat-samsung/dev-fb.c | 13 + arch/arm

[PATCH 5/9] ARM: SAMSUNG: Eliminate s3c2440-i2c renames

2010-05-28 Thread Ben Dooks
Commit 0445af6624016110d1b448e0089261548ba29ee3 set the default name to s3c2440-i2c, so we no longer need to do anything about renaming it. Remove all the call sites and the header that was included to get it. Signed-off-by: Ben Dooks ben-li...@fluff.org --- arch/arm/mach-s3c2412/s3c2412.c

[PATCH 6/9] ARM: SAMSUNG: Add helper to clone and set platform data

2010-05-28 Thread Ben Dooks
for replacements. Signed-off-by: Ben Dooks ben-li...@fluff.org --- arch/arm/plat-samsung/Makefile|2 + arch/arm/plat-samsung/include/plat/devs.h | 12 + arch/arm/plat-samsung/platformdata.c | 37 + 3 files changed, 51 insertions(+), 0 deletions

Re: [PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-28 Thread Ben Dooks
On Fri, May 28, 2010 at 03:24:02PM +0900, Kyungmin Park wrote: Hi, Looks good but I'm afraid it's more difficult to find pin configuration from typo. I'm not sure if that's really so much of a problem. On Fri, May 28, 2010 at 2:56 PM, Ben Dooks ben-li...@fluff.org wrote: Change the code

Re: [PATCH 4/4] usb: s3c-hsotg: Enable HCLK for the OTG module.

2010-05-28 Thread Ben Dooks
On Fri, May 28, 2010 at 11:41:17AM +0900, Kukjin Kim wrote: From: Thomas Abraham thomas...@samsung.com This patch modifies the following in S3C hsotg driver. 1. Gets a reference to the USB OTG hclk clock and enables it. This is required for plaforms on which the USB OTG hclk is disabled

Re: [PATCH 4/4] pata_samsung: Add Samsung PATA controller driver

2010-05-27 Thread Ben Dooks
On Thu, May 27, 2010 at 05:22:04PM +0900, Kukjin Kim wrote: From: Abhilash Kesavan a.kesa...@samsung.com Adds support for the Samsung PATA controller. This driver is based on the Libata subsystem and references the earlier patches sent for IDE subsystem. Signed-off-by: Abhilash Kesavan

Re: [PATCH 1/4] ARM: S3C64XX: Add support for Compact Flash driver on SMDK6410

2010-05-27 Thread Ben Dooks
On Thu, May 27, 2010 at 05:22:01PM +0900, Kukjin Kim wrote: From: Abhilash Kesavan a.kesa...@samsung.com Following is added for the CF-ATA driver: - Platform data strucure definition and instantiation - Platform device definition and enabling code - Platform-specific gpio

Re: [PATCH 4/4] pata_samsung: Add Samsung PATA controller driver

2010-05-27 Thread Ben Dooks
On Thu, May 27, 2010 at 05:43:47PM +0900, Jassi Brar wrote: On Thu, May 27, 2010 at 5:22 PM, Kukjin Kim kgene@samsung.com wrote: From: Abhilash Kesavan a.kesa...@samsung.com Adds support for the Samsung PATA controller. This driver is based on the Libata subsystem and references the

Re: [PATCH 4/4] usb: s3c-hsotg: Enable HCLK for the OTG module.

2010-05-27 Thread Ben Dooks
On Fri, May 28, 2010 at 11:41:17AM +0900, Kukjin Kim wrote: From: Thomas Abraham thomas...@samsung.com This patch modifies the following in S3C hsotg driver. 1. Gets a reference to the USB OTG hclk clock and enables it. This is required for plaforms on which the USB OTG hclk is disabled

[PATCH 05/15] ARM: S5P6442: Change to using s3c_gpio_cfgpin_range()

2010-05-27 Thread Ben Dooks
Change the code setting ranges of GPIO pins using s3c_gpio_cfgpin() to use the recently introduced s3c_gpio_cfgpin_range(). Signed-off-by: Ben Dooks ben-li...@fluff.org --- arch/arm/mach-s5p6442/dev-audio.c | 30 ++ arch/arm/mach-s5p6442/dev-spi.c |4 +--- 2

  1   2   3   4   >